Re: [PATCH] Bug 2178: Empty Layout

2008-02-09 Thread Jürgen Spitzmüller
Richard Heck wrote: > > I'd call it "Plain". > > > >   > > I was trying to choose something I knew wouldn't appear in any > layout---e.g., in user layouts. And "Plain" might. LyXDefault might as well, in some possible world. Can't you just give it some unique internal identifier? Also, the name o

Re: [PATCH] Bug 2178: Empty Layout

2008-02-06 Thread Richard Heck
Jürgen Spitzmüller wrote: rgheck wrote: The attached patch is now pretty much complete, I think, so I'm sending it again to the list. Excellent. Many thanks for looking at this. The basic idea has two parts. First, we hard code an "empty layout" (called LyXDefault, for want of a b

Re: [PATCH] Bug 2178: Empty Layout

2008-02-06 Thread Jürgen Spitzmüller
rgheck wrote: > The attached patch is now pretty much complete, I think, so I'm sending > it again to the list. Excellent. Many thanks for looking at this. > The basic idea has two parts. First, we hard code an "empty layout" > (called LyXDefault, for want of a better name) I'd call it "Plain".

Re: [PATCH] Bug 2178: Empty Layout

2008-02-06 Thread Abdelrazak Younes
Pavel Sanda wrote: remain active and full of entries instead of disabling it. i guess switching between tabs wouldnt update envi of the current environment too. Yes, I noticed that, though it's obviously a different bug. You just notice it here. It's worst with ERT, where the dropbox ought

Re: [PATCH] Bug 2178: Empty Layout

2008-02-06 Thread Pavel Sanda
>>> remain >>> active and full of entries instead of disabling it. i guess switching >>> between >>> tabs wouldnt update envi of the current environment too. >>> >>> >> Yes, I noticed that, though it's obviously a different bug. You just >> notice it here. It's worst with ERT, where the dropbo

Re: [PATCH] Bug 2178: Empty Layout

2008-02-06 Thread Abdelrazak Younes
rgheck wrote: there are still missing some toolbar updates. eg open the footnote inset and the LyXDefault appears AFTER you start typing not just after inserting the inset and puting cursor there. also try close document - envi toolbox remain active and full of entries instead of disabling it.

Re: [PATCH] Bug 2178: Empty Layout

2008-02-06 Thread Abdelrazak Younes
rgheck wrote: Pavel Sanda wrote: there are still missing some toolbar updates. eg open the footnote inset and the LyXDefault appears AFTER you start typing not just after inserting the inset and puting cursor there. also try close document - envi toolbox remain active and full of entries inste

Re: [PATCH] Bug 2178: Empty Layout

2008-02-05 Thread rgheck
Pavel Sanda wrote: The one remaining issue has to do with sorting, but I think there may be some issues with that code, anyway, since it seems to assume that the default layout will always appear first, and I'm not sure why that would have to be true. i remember that i assumed this first

Re: [PATCH] Bug 2178: Empty Layout

2008-02-05 Thread Pavel Sanda
> The one remaining issue has to do with sorting, but I think there may be > some issues with that code, anyway, since it seems to assume that the > default layout will always appear first, and I'm not sure why that would > have to be true. i remember that i assumed this first position by check

[PATCH] Bug 2178: Empty Layout

2008-02-05 Thread rgheck
The attached patch is now pretty much complete, I think, so I'm sending it again to the list. The basic idea has two parts. First, we hard code an "empty layout" (called LyXDefault, for want of a better name) in TextClass and read it before doing anything else. It can therefore be customized b

Re: [Partial PATCH] Bug 2178: Empty Layout

2008-02-04 Thread rgheck
Pavel Sanda wrote: The other big change is in GuiToolbar: We want to show LyXDefault and the "default" layout only when they're active. Pavel: This probably doesn't work right with your sort routine. That's one thing that needs to be finished. The other is that there's just a fix me in the LFUN

Re: [Partial PATCH] Bug 2178: Empty Layout

2008-02-04 Thread Pavel Sanda
> The other big change is in GuiToolbar: We want to show LyXDefault and the > "default" layout only when they're active. Pavel: This probably doesn't > work right with your sort routine. That's one thing that needs to be > finished. The other is that there's just a fix me in the LFUN_LAYOUT i

[Partial PATCH] Bug 2178: Empty Layout

2008-02-04 Thread rgheck
The attached patch isn't quite complete, but it mostly works, and I'm not sure exactly when I'll be able to work on it further, so I'm sending it to the list (a) for comment and (b) in case anyone else has time to finish it. The patch is against trunk at the moment. The basic idea has two pa