Re: [PATCH] And now for something completely different: Undo Groups

2008-08-18 Thread Helge Hafting
Jean-Marc Lasgouttes wrote: What is it good for? 1/ some operations (like inserting a float over a selection) generate several undo elements on the stack. This is now completely transparent to the user. Great, undo will be much more user friendly now. :-) Helge Hafting

Re: [PATCH] And now for something completely different: Undo Groups

2008-08-15 Thread Jean-Marc Lasgouttes
Le 15 août 08 à 19:18, José Matos a écrit : We don't want your summer of code to wait. You can commit. :-) OK, you asked for it, it is in now. I am back in vacations for two weeks starting tomorrow, so I hope you tested it before doing the José Nod. JMarc

Re: [PATCH] And now for something completely different: Undo Groups

2008-08-15 Thread José Matos
On Friday 15 August 2008 16:54:49 Jean-Marc Lasgouttes wrote: > Le 15 août 08 à 17:21, Jürgen Spitzmüller a écrit : > > Jean-Marc Lasgouttes wrote: > >> This patch implements an idea that has already been discussed before: > >> undo groups. > > > > Very good IMHO. > > It was my personal "summer of

Re: [PATCH] And now for something completely different: Undo Groups

2008-08-15 Thread Jean-Marc Lasgouttes
Undo groups is now the subject of bug 5173 http://bugzilla.lyx.org/show_bug.cgi?id=5173 JMarc

Re: [PATCH] And now for something completely different: Undo Groups

2008-08-15 Thread Jean-Marc Lasgouttes
Le 15 août 08 à 17:21, Jürgen Spitzmüller a écrit : Jean-Marc Lasgouttes wrote: This patch implements an idea that has already been discussed before: undo groups. Very good IMHO. It was my personal "summer of code" project. Turned out to be super easy. JMarc

Re: [PATCH] And now for something completely different: Undo Groups

2008-08-15 Thread Jürgen Spitzmüller
Jean-Marc Lasgouttes wrote: > This patch implements an idea that has already been discussed before:   > undo groups. Very good IMHO. Jürgen

Re: [PATCH] And now for something completely different: Undo Groups

2008-08-15 Thread Jean-Marc Lasgouttes
Le 15 août 08 à 02:05, Jean-Marc Lasgouttes a écrit : This patch implements an idea that has already been discussed before: undo groups. Here is a new iteration: - fix bug when using a function handled by BuffeView::dispatch, like LFUN_UNDO %-] I wonder why I did not see it earlier...

[PATCH] And now for something completely different: Undo Groups

2008-08-14 Thread Jean-Marc Lasgouttes
This patch implements an idea that has already been discussed before: undo groups. The idea is that several recordUndo operations that belong to the same group will be undone at the same time. For example, with a code like the following, beginUndoGroup() recordUndo()