[PATCH] And now for something completely different: Undo Groups

[Jean-Marc Lasgouttes]

This patch implements an idea that has already been discussed before: undo groups. The idea is that several recordUndo operations that belong to the same group will be undone at the same time. For example, with a code like

the following,
        beginUndoGroup()
        recordUndo()
        doaction1()
        recotdUndo()
        doaction2()
        endUndoGroup()

elements with same id in one operation.

What is it good for?




   to do many small operations instead.

The following patch does not implement part 2/ of the plan as it is. All

that it would be enough when editing BufferParams?).


I understand that not everybody would be thrilled by this idea :)

Comments and testers welcome.

textUndo() will undo both doaction2 and doaction1 (in this order). This is done by assigning a group_id to each UndoElement and handling consecutive 1/ some operations (like inserting a float over a selection) generate several undo elements on the stack. This is now completely transparent to the user. 2/ some operations (e.g. replace all) save the whole document in the undo stack. This can be a problem when working on a big document [1]. Undo groups allows recordUndoFullDocument uses should be audited and either replaced with individual recordUndo operations or by a new recordUndoDocumentParameters method (am I wrong The patch is actually simpler than it seems since I only introduce a new indirection between the kernel and the undo machinery. I'd be tempted to propose it for 1.6, but

undogroups.diff
Description: Binary data

JMarc

[1] reallife example: http://thread.gmane.org/ gmane.editors.lyx.general/48388