Re: [LyX/master] Fix backspace deletion of selected items with change tracking

Am Mon, 13 Jan 2020 14:27:53 +0100 schrieb Kornel Benko : > Am Mon, 13 Jan 2020 14:00:35 +0100 > schrieb Jürgen Spitzmüller : > > > Am Montag, den 13.01.2020, 13:54 +0100 schrieb Kornel Benko: > > > ! Package fontspec Error: The font "FreeSerif" cannot be found. > > > > Apparently you need

Re: [LyX/master] Fix backspace deletion of selected items with change tracking

Le 14/01/2020 à 09:30, Jürgen Spitzmüller a écrit : Am Montag, den 13.01.2020, 16:00 +0100 schrieb Jürgen Spitzmüller: Also, is there a reason why your change status does not have a author and time associated with it? The author and time should be recorded via the cells. It is now recorded i

Re: [LyX/master] Fix backspace deletion of selected items with change tracking

Am Montag, den 13.01.2020, 16:00 +0100 schrieb Jürgen Spitzmüller: > > Also, is there a reason why your change status does not have a > > author > > and time associated with it? > > The author and time should be recorded via the cells. It is now recorded in the row/column metadata itself. Jürge

Re: [LyX/master] Fix backspace deletion of selected items with change tracking

Am Montag, den 13.01.2020, 17:45 +0100 schrieb Jürgen Spitzmüller: > We could color the lines of the > added/removed columns/rows blue or red. Coloring now done. Ideally, deleted rows/columns should be struck-out as we do for deleted tables. But I don't know how to do that. Jürgen signature.asc

Re: [LyX/master] Fix backspace deletion of selected items with change tracking

Am Montag, den 13.01.2020, 17:49 +0100 schrieb Jean-Marc Lasgouttes: > To put things differently: what does the support for tracking > row/column > addition/removal that you added does in terms of functionality? It is actually tracked. Before (and still in stable) if you added a row/column in ct

Re: [LyX/master] Fix backspace deletion of selected items with change tracking

Le 13/01/2020 à 17:45, Jürgen Spitzmüller a écrit : Am Montag, den 13.01.2020, 16:14 +0100 schrieb Jean-Marc Lasgouttes: Yes, but you do not know what column was added. This is how it was before as well. We could color the lines of the added/removed columns/rows blue or red. To put things di

Re: [LyX/master] Fix backspace deletion of selected items with change tracking

Am Montag, den 13.01.2020, 16:14 +0100 schrieb Jean-Marc Lasgouttes: > Yes, but you do not know what column was added. This is how it was before as well. We could color the lines of the added/removed columns/rows blue or red. > BTW, the changebar in the margin has a height computed as > >

Re: [LyX/master] Fix backspace deletion of selected items with change tracking

Le 13/01/2020 à 16:00, Jürgen Spitzmüller a écrit : Am Montag, den 13.01.2020, 15:48 +0100 schrieb Jean-Marc Lasgouttes: If I switch on change tracking before inserting a column in a tabular, there is no way to know what column is new. I see a change bar in the margin. Yes, but you do not k

Re: [LyX/master] Fix backspace deletion of selected items with change tracking

Am Montag, den 13.01.2020, 15:48 +0100 schrieb Jean-Marc Lasgouttes: > If I switch on change tracking before inserting a column in a > tabular, > there is no way to know what column is new. I see a change bar in the margin. > Should the tabular itself be marked as changed in this case ? I see >

Re: [LyX/master] Fix backspace deletion of selected items with change tracking

Le 13/01/2020 à 15:18, Jürgen Spitzmüller a écrit : Am Montag, den 13.01.2020, 15:12 +0100 schrieb Jean-Marc Lasgouttes: OK, I guess the code is a bit better now. BTW, I see that you added support for tracking insertion/deletion of cells/columns in Tabular Inset. However, there is no way to gues

Re: [LyX/master] Fix backspace deletion of selected items with change tracking

Am Montag, den 13.01.2020, 15:12 +0100 schrieb Jean-Marc Lasgouttes: > OK, I guess the code is a bit better now. BTW, I see that you added > support for tracking insertion/deletion of cells/columns in Tabular > Inset. However, there is no way to guess what cell/column has been > affected... Cur

Re: [LyX/master] Fix backspace deletion of selected items with change tracking

Le 13/01/2020 à 14:27, Jürgen Spitzmüller a écrit : Am Montag, den 13.01.2020, 14:05 +0100 schrieb Jean-Marc Lasgouttes: I am a bit puzzled. parit points to a paragraph, but this paragraph is not in an InsetText? Where is it? In a table cell? InsetTableCell probably. OK, I guess the code is

Re: [LyX/master] Fix backspace deletion of selected items with change tracking

Am Mon, 13 Jan 2020 14:00:35 +0100 schrieb Jürgen Spitzmüller : > Am Montag, den 13.01.2020, 13:54 +0100 schrieb Kornel Benko: > > ! Package fontspec Error: The font "FreeSerif" cannot be found. > > Apparently you need to install this font. > > Jürgen No, I have this font. Both compilations d

Re: [LyX/master] Fix backspace deletion of selected items with change tracking

Am Montag, den 13.01.2020, 14:05 +0100 schrieb Jean-Marc Lasgouttes: > I am a bit puzzled. parit points to a paragraph, but this paragraph > is > not in an InsetText? Where is it? In a table cell? InsetTableCell probably. Jürgen signature.asc Description: This is a digitally signed message par

Re: [LyX/master] Fix backspace deletion of selected items with change tracking

Le 13/01/2020 à 13:04, Jürgen Spitzmüller a écrit : Am Montag, den 13.01.2020, 12:08 +0100 schrieb Jürgen Spitzmüller: Am Montag, den 13.01.2020, 11:32 +0100 schrieb Kornel Benko: For instance for export/tabletemplates/Grid_with_Head_1x2_dvi lyx: SIGSEGV signal caught! JMarc, this looks like

Re: [LyX/master] Fix backspace deletion of selected items with change tracking

Am Montag, den 13.01.2020, 13:54 +0100 schrieb Kornel Benko: > ! Package fontspec Error: The font "FreeSerif" cannot be found. Apparently you need to install this font. Jürgen signature.asc Description: This is a digitally signed message part -- lyx-devel mailing list lyx-devel@lists.lyx.org h

Re: [LyX/master] Fix backspace deletion of selected items with change tracking

Am Mon, 13 Jan 2020 13:04:55 +0100 schrieb Jürgen Spitzmüller : > Am Montag, den 13.01.2020, 12:08 +0100 schrieb Jürgen Spitzmüller: > > Am Montag, den 13.01.2020, 11:32 +0100 schrieb Kornel Benko: > > > For instance for export/tabletemplates/Grid_with_Head_1x2_dvi > > > > > > lyx: SIGSEGV sign

Re: [LyX/master] Fix backspace deletion of selected items with change tracking

Am Montag, den 13.01.2020, 12:08 +0100 schrieb Jürgen Spitzmüller: > Am Montag, den 13.01.2020, 11:32 +0100 schrieb Kornel Benko: > > For instance for export/tabletemplates/Grid_with_Head_1x2_dvi > > > > lyx: SIGSEGV signal caught! > > JMarc, this looks like yours: This should be fixed. JMarc, p

Re: [LyX/master] Fix backspace deletion of selected items with change tracking

Am Mon, 13 Jan 2020 12:37:00 +0100 schrieb Jürgen Spitzmüller : > Am Montag, den 13.01.2020, 12:34 +0100 schrieb Kornel Benko: > > No, of course not. As I wrote 'After the last commits'. > > Yes but if you quote my commit it looks like you are pointing fingers > directly at it. At least I am re

Re: [LyX/master] Fix backspace deletion of selected items with change tracking

Am Montag, den 13.01.2020, 12:34 +0100 schrieb Kornel Benko: > Looking at the backtrace, I think it has to do with change tracking. > ... > #0 0x007ed966 in lyx::InsetText::isChanged(bool) const As I said, it looks like 4a4ded2297e which introduced Inset::isChanged() Jürgen signature.a

Re: [LyX/master] Fix backspace deletion of selected items with change tracking

Am Montag, den 13.01.2020, 12:34 +0100 schrieb Kornel Benko: > No, of course not. As I wrote 'After the last commits'. Yes but if you quote my commit it looks like you are pointing fingers directly at it. At least I am reading it like that. Jürgen signature.asc Description: This is a digitally

Re: [LyX/master] Fix backspace deletion of selected items with change tracking

Am Mon, 13 Jan 2020 12:03:13 +0100 schrieb Jürgen Spitzmüller : > Am Montag, den 13.01.2020, 12:01 +0100 schrieb Jürgen Spitzmüller: > > Are you sure this is related to this commit? This is very unlikely. No, of course not. As I wrote 'After the last commits'. > (more likely would be dvipost r

Re: [LyX/master] Fix backspace deletion of selected items with change tracking

Am Montag, den 13.01.2020, 11:32 +0100 schrieb Kornel Benko: > For instance for export/tabletemplates/Grid_with_Head_1x2_dvi > > lyx: SIGSEGV signal caught! JMarc, this looks like yours: Thread 1 "lyx" received signal SIGSEGV, Segmentation fault. 0x007ed966 in lyx::InsetText::isChanged (

Re: [LyX/master] Fix backspace deletion of selected items with change tracking

Am Montag, den 13.01.2020, 12:01 +0100 schrieb Jürgen Spitzmüller: > Are you sure this is related to this commit? This is very unlikely. (more likely would be dvipost removal) Jürgen signature.asc Description: This is a digitally signed message part -- lyx-devel mailing list lyx-devel@lists.ly

Re: [LyX/master] Fix backspace deletion of selected items with change tracking

Am Montag, den 13.01.2020, 11:32 +0100 schrieb Kornel Benko: > After the last commits many of the dvi-tests are failing. > ctest -R dvi3 > 55% tests passed, 270 tests failed out of 605 > > ctest -R 'dvi$' > 55% tests passed, 143 tests failed out of 320 > > For instance for export/tabletemplates/G

Re: [LyX/master] Fix backspace deletion of selected items with change tracking

Am Mon, 13 Jan 2020 09:34:31 +0100 (CET) schrieb Juergen Spitzmueller : > commit adfd38e4efd1180df164fa2c75cf15210f366e94 > Author: Juergen Spitzmueller > Date: Mon Jan 13 09:48:56 2020 +0100 > > Fix backspace deletion of selected items with change tracking > > Move cursor at begi