Re: [LyX/master] Fix AboutLyX layout

2024-11-07 Thread Jürgen Spitzmüller
Am Donnerstag, dem 07.11.2024 um 12:05 +0100 schrieb Kornel Benko: > I see only 'Qt::TextFormat::PlainText' in > src/frontends/qt/ui/AboutUi.ui. Thanks, I'll fix those. (the others have been fixed earlier, but of course they might reappear). -- Jürgen signature.asc Description: This is a digi

Re: [LyX/master] Fix AboutLyX layout

2024-11-07 Thread Jürgen Spitzmüller
Am Donnerstag, dem 07.11.2024 um 14:20 +0100 schrieb Kornel Benko: > Added test "check_Qt_ui_Constants" at 695b2f48 to check for such > suspected values. Great, thanks. -- Jürgen signature.asc Description: This is a digitally signed message part -- lyx-devel mailing list lyx-devel@lists.lyx.o

Re: [LyX/master] Fix AboutLyX layout

2024-11-07 Thread Kornel Benko
Am Thu, 07 Nov 2024 12:36:35 +0100 schrieb "Jürgen Spitzmüller" : > Am Donnerstag, dem 07.11.2024 um 12:05 +0100 schrieb Kornel Benko: > > I see only 'Qt::TextFormat::PlainText' in > > src/frontends/qt/ui/AboutUi.ui. > > Thanks, I'll fix those. > > (the others have been fixed earlier, but of c

Re: [LyX/master] Fix AboutLyX layout

2024-11-07 Thread Kornel Benko
Am Mon, 04 Nov 2024 12:15:25 +0100 schrieb "Jürgen Spitzmüller" : > Am Montag, dem 04.11.2024 um 12:04 +0100 schrieb Pavel Sanda: > > We could easily automatize check for this in our tests. > > > > I can add it if you write some list of string we should > > grep for in .ui files... > > For now

Re: [LyX/master] Fix AboutLyX layout

2024-11-06 Thread kornel . benko
This fits perfectly for any script returning an exit value.    KornelAm 05.11.2024 16:12 schrieb Pavel Sanda :On Mon, Nov 04, 2024 at 12:15:25PM +0100, Jürgen Spitzmüller wrote: > Am Montag, dem 04.11.2024 um 12:04 +0100 schrieb Pavel Sanda: > > We could easily automatize check for this in our te

Re: [LyX/master] Fix AboutLyX layout

2024-11-05 Thread Pavel Sanda
On Mon, Nov 04, 2024 at 12:15:25PM +0100, Jürgen Spitzmüller wrote: > Am Montag, dem 04.11.2024 um 12:04 +0100 schrieb Pavel Sanda: > > We could easily automatize check for this in our tests. > > > > I can add it if you write some list of string we should > > grep for in .ui files... > > For now

Re: [LyX/master] Fix AboutLyX layout

2024-11-04 Thread Jürgen Spitzmüller
Am Montag, dem 04.11.2024 um 12:04 +0100 schrieb Pavel Sanda: > We could easily automatize check for this in our tests. > > I can add it if you write some list of string we should > grep for in .ui files... For now I saw: Qt::Orientation:: => Qt:: QSizePolicy::Policy:: => QSizePolicy:: QLayout::

Re: [LyX/master] Fix AboutLyX layout

2024-11-04 Thread Pavel Sanda
On Mon, Nov 04, 2024 at 07:54:50AM +0100, Jürgen Spitzmüller wrote: > Am Sonntag, dem 03.11.2024 um 20:03 +0100 schrieb Pavel Sanda: > > I see this, but it seems to compile just fine on old system (Qt > > 5.15.8). > > Yes it does, but it does not work (neither on old nor on new systems) > as it is

Re: [LyX/master] Fix AboutLyX layout

2024-11-03 Thread Jürgen Spitzmüller
Am Sonntag, dem 03.11.2024 um 20:03 +0100 schrieb Pavel Sanda: > I see this, but it seems to compile just fine on old system (Qt > 5.15.8). Yes it does, but it does not work (neither on old nor on new systems) as it is invalid. Spacers using this, for instance, are simply ignored. -- Jürgen --

Re: [LyX/master] Fix AboutLyX layout

2024-11-03 Thread Pavel Sanda
On Sun, Nov 03, 2024 at 05:48:12AM +0100, Jürgen Spitzmüller wrote: > You can see how it inserts wrong namespaces such as > Qt::Orientation::Vertical instead of Qt::Vertical (which is then not > recognized). I see this, but it seems to compile just fine on old system (Qt 5.15.8). Pavel -- lyx-de

Re: [LyX/master] Fix AboutLyX layout

2024-11-02 Thread Jürgen Spitzmüller
Am Sonntag, dem 03.11.2024 um 05:48 +0100 schrieb Jürgen Spitzmüller: > I currently correct the UI files manually in an editor after having > used designer. Strangely enough, I also did not find any report about > it. I grep'ed the remaining cases in master and stable and fixed them. -- Jürgen -

Re: [LyX/master] Fix AboutLyX layout

2024-11-02 Thread Jürgen Spitzmüller
Am Samstag, dem 02.11.2024 um 19:22 +0100 schrieb Pavel Sanda: > What versions are safe in this regard? I don't know when it started. It certainly is a problem in recent versions. You can see how it inserts wrong namespaces such as Qt::Orientation::Vertical instead of Qt::Vertical (which is then

Re: [LyX/master] Fix AboutLyX layout

2024-11-02 Thread Pavel Sanda
On Sat, Nov 02, 2024 at 02:44:55PM +0100, Jürgen Spitzmüller wrote: > Am Samstag, dem 02.11.2024 um 13:40 + schrieb Juergen Spitzmueller: > > commit 11cbc3c4a765f93268a662846d7082b089b3782b > > Author: Juergen Spitzmueller > > Date:   Sat Nov 2 14:33:28 2024 +0100 > > > >     Fix AboutLyX lay

Re: [LyX/master] Fix AboutLyX layout

2024-11-02 Thread Richard Kimberly Heck
On 11/2/24 9:44 AM, Jürgen Spitzmüller wrote: Am Samstag, dem 02.11.2024 um 13:40 + schrieb Juergen Spitzmueller: commit 11cbc3c4a765f93268a662846d7082b089b3782b Author: Juergen Spitzmueller Date:   Sat Nov 2 14:33:28 2024 +0100     Fix AboutLyX layout     * remove wrong (sub)names

Re: [LyX/master] Fix AboutLyX layout

2024-11-02 Thread Jürgen Spitzmüller
Am Samstag, dem 02.11.2024 um 13:40 + schrieb Juergen Spitzmueller: > commit 11cbc3c4a765f93268a662846d7082b089b3782b > Author: Juergen Spitzmueller > Date:   Sat Nov 2 14:33:28 2024 +0100 > >     Fix AboutLyX layout >     >     * remove wrong (sub)namespaces. This are inserted by newer > ve