Re: [LyX/master] Comment out unused functions to restore -Werror

2018-11-04 Thread Jean-Marc Lasgouttes
Le 28/10/2018 à 22:30, Kornel Benko a écrit : It is not a global function, it is in an anonymous namespace. Are you sure? lyxfind.cpp:60 namespace lyx { ... lyxfind.cpp:2763 } // namespace lyx Kornel Yes. lyxfind.cpp: namespace { lyxfind.cpp:2619 } // name

Re: [LyX/master] Comment out unused functions to restore -Werror

2018-10-28 Thread Kornel Benko
Am Sonntag, 28. Oktober 2018 21:55:20 CET schrieb Jean-Marc Lasgouttes : > Le 28/10/2018 à 10:19, Kornel Benko a écrit : > > Am Sonntag, 28. Oktober 2018 02:13:43 CET schrieb Scott Kostyshak > > : > > > >> +#if 0 > >> void setIgnoreFormat(string type, bool value) > >> { > >> IgnoreFormat

Re: [LyX/master] Comment out unused functions to restore -Werror

2018-10-28 Thread Jean-Marc Lasgouttes
Le 28/10/2018 à 10:19, Kornel Benko a écrit : Am Sonntag, 28. Oktober 2018 02:13:43 CET schrieb Scott Kostyshak : +#if 0 void setIgnoreFormat(string type, bool value) { IgnoreFormats().setIgnoreFormat(type, value); } +#endif How does the compiler know, that a global function is not

Re: [LyX/master] Comment out unused functions to restore -Werror

2018-10-28 Thread Scott Kostyshak
On Sun, Oct 28, 2018 at 07:31:07PM +0100, Kornel Benko wrote: > Am Sonntag, 28. Oktober 2018 11:58:04 CET schrieb Scott Kostyshak > : > > > How does the compiler know, that a global function is not used? > > > > I don't know. > > It was missing declaration in a header file. > > > Now compilatio

Re: [LyX/master] Comment out unused functions to restore -Werror

2018-10-28 Thread Kornel Benko
Am Sonntag, 28. Oktober 2018 11:58:04 CET schrieb Scott Kostyshak : > > How does the compiler know, that a global function is not used? > > I don't know. It was missing declaration in a header file. > Now compilation with -Werror is broken for GCC 7.3.0. I did not realize > this would be such a

Re: [LyX/master] Comment out unused functions to restore -Werror

2018-10-28 Thread Scott Kostyshak
On Sun, Oct 28, 2018 at 10:19:05AM +0100, Kornel Benko wrote: > Am Sonntag, 28. Oktober 2018 02:13:43 CET schrieb Scott Kostyshak > : > > > +#if 0 > > void setIgnoreFormat(string type, bool value) > > { > >IgnoreFormats().setIgnoreFormat(type, value); > > } > > +#endif > > How does the co

Re: [LyX/master] Comment out unused functions to restore -Werror

2018-10-28 Thread Kornel Benko
Am Sonntag, 28. Oktober 2018 02:13:43 CET schrieb Scott Kostyshak : > +#if 0 > void setIgnoreFormat(string type, bool value) > { >IgnoreFormats().setIgnoreFormat(type, value); > } > +#endif How does the compiler know, that a global function is not used? The commit is wrong IMHO.