On Sun, Oct 28, 2018 at 10:19:05AM +0100, Kornel Benko wrote:
> Am Sonntag, 28. Oktober 2018 02:13:43 CET schrieb Scott Kostyshak
> <skost...@lyx.org>:
>
> > +#if 0
> > void setIgnoreFormat(string type, bool value)
> > {
> > IgnoreFormats().setIgnoreFormat(type, value);
> > }
> > +#endif
>
> How does the compiler know, that a global function is not used?I don't know. > The commit is wrong IMHO. Reverted at 645d42f4. By the way, I did not check with you before committing just because I was hoping to save you time and not bother you further with the issue. I got a similar error and thought the same solution you proposed before would be reasonable. Now compilation with -Werror is broken for GCC 7.3.0. I did not realize this would be such a tricky issue. It seems that fixing compilation with -Werror and GCC 7.3.0 is causing more pain than it is solving. Let's think of a reasonable policy and put it in our Development.lyx manual. What do you think of the following policy? A developer should fix any issue that causes compilation with -Werror to fail on the GCC version that ships with the previous Ubuntu LTS. For example, if Ubuntu 18.10 is the most recent Ubuntu release, then Ubuntu 18.04 is the current LTS and Ubuntu 16.04 is the previous LTS. Thus, compilation with -Werror for the GCC version that ships with 16.04 should be preserved. Do you think the above policy is reasonable? According to that policy, we would not require fixes for the current issue until Ubuntu 20.04 is released. I'm not sure how LyX devs who don't use Ubuntu will feel about this policy. I would be fine with a proposed non-Ubuntu-centric policy as well. Scott
signature.asc
Description: PGP signature
