You are correct, thanks.
Jmarc
Le 3 décembre 2022 01:38:29 GMT+01:00, Scott Kostyshak a
écrit :
>JMarc, can you double check this fix was correct? I changed the literal
>logic, and I just guessed at what was intended.
>
>Scott
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.
On Sat, Dec 03, 2022 at 12:39:18AM +0100, Scott Kostyshak wrote:
> commit c7269ffa8639ad1c8dac01997bd2117e5cfde96c
> Author: Scott Kostyshak
> Date: Fri Dec 2 19:34:36 2022 -0500
>
> Comment
> ---
> src/frontends/qt/GuiFontMetrics.cpp |2 +-
> 1 files changed, 1 insertions(+), 1 deleti
Le 28/10/2018 à 22:30, Kornel Benko a écrit :
It is not a global function, it is in an anonymous namespace.
Are you sure?
lyxfind.cpp:60
namespace lyx {
...
lyxfind.cpp:2763
} // namespace lyx
Kornel
Yes.
lyxfind.cpp:
namespace {
lyxfind.cpp:2619
} // name
Am Sonntag, 28. Oktober 2018 21:55:20 CET schrieb Jean-Marc Lasgouttes
:
> Le 28/10/2018 à 10:19, Kornel Benko a écrit :
> > Am Sonntag, 28. Oktober 2018 02:13:43 CET schrieb Scott Kostyshak
> > :
> >
> >> +#if 0
> >> void setIgnoreFormat(string type, bool value)
> >> {
> >> IgnoreFormat
Le 28/10/2018 à 10:19, Kornel Benko a écrit :
Am Sonntag, 28. Oktober 2018 02:13:43 CET schrieb Scott Kostyshak
:
+#if 0
void setIgnoreFormat(string type, bool value)
{
IgnoreFormats().setIgnoreFormat(type, value);
}
+#endif
How does the compiler know, that a global function is not
On Sun, Oct 28, 2018 at 07:31:07PM +0100, Kornel Benko wrote:
> Am Sonntag, 28. Oktober 2018 11:58:04 CET schrieb Scott Kostyshak
> :
> > > How does the compiler know, that a global function is not used?
> >
> > I don't know.
>
> It was missing declaration in a header file.
>
> > Now compilatio
Am Sonntag, 28. Oktober 2018 11:58:04 CET schrieb Scott Kostyshak
:
> > How does the compiler know, that a global function is not used?
>
> I don't know.
It was missing declaration in a header file.
> Now compilation with -Werror is broken for GCC 7.3.0. I did not realize
> this would be such a
On Sun, Oct 28, 2018 at 10:19:05AM +0100, Kornel Benko wrote:
> Am Sonntag, 28. Oktober 2018 02:13:43 CET schrieb Scott Kostyshak
> :
>
> > +#if 0
> > void setIgnoreFormat(string type, bool value)
> > {
> >IgnoreFormats().setIgnoreFormat(type, value);
> > }
> > +#endif
>
> How does the co
Am Sonntag, 28. Oktober 2018 02:13:43 CET schrieb Scott Kostyshak
:
> +#if 0
> void setIgnoreFormat(string type, bool value)
> {
>IgnoreFormats().setIgnoreFormat(type, value);
> }
> +#endif
How does the compiler know, that a global function is not used?
The commit is wrong IMHO.
