Re: [LyX/master] Add 3rdparty to source package

2015-12-20 Thread Peter Kümmel
Am 20.12.2015 um 21:01 schrieb Pavel Sanda: Georg Baum wrote: Did you run configure after autogen.sh? I assume the error happens when calling make? Here 3rdparty/libiconv/Makefile.in is already generated by autogen.sh. Maybe some old files in the source tree? Yes, also there is error whe

Re: [LyX/master] Add 3rdparty to source package

2015-12-20 Thread Pavel Sanda
Georg Baum wrote: > Did you run configure after autogen.sh? I assume the error happens when > calling make? Yes, also there is error when calling configure I did not catch before. config.status: creating Makefile config.status: creating lyx.1 config.status: creating 3rdparty/Makefile config.statu

Re: [LyX/master] Add 3rdparty to source package

2015-12-20 Thread Peter Kümmel
Am 20.12.2015 um 12:31 schrieb Kornel Benko: Am Sonntag, 20. Dezember 2015 um 12:10:19, schrieb Peter Kümmel Am 20.12.2015 um 11:29 schrieb Georg Baum: Kornel Benko wrote: Setting SRC_LIBCHARSET in the patch might be guarded by: if(UNIX AND NOT MINGW) endif() But since I cannot test windows

Re: [LyX/master] Add 3rdparty to source package

2015-12-20 Thread Kornel Benko
Am Sonntag, 20. Dezember 2015 um 12:10:19, schrieb Peter Kümmel > Am 20.12.2015 um 11:29 schrieb Georg Baum: > > Kornel Benko wrote: > > > >> Setting SRC_LIBCHARSET in the patch might be guarded by: > >> if(UNIX AND NOT MINGW) > >> endif() > >> But since I cannot test windows or Mac I don't commi

Re: [LyX/master] Add 3rdparty to source package

2015-12-20 Thread Peter Kümmel
Am 20.12.2015 um 11:29 schrieb Georg Baum: Kornel Benko wrote: Setting SRC_LIBCHARSET in the patch might be guarded by: if(UNIX AND NOT MINGW) endif() But since I cannot test windows or Mac I don't commit. You will see here if it compiles here: https://travis-ci.org/syntheticpp/lyx I'd say

Re: [LyX/master] Add 3rdparty to source package

2015-12-20 Thread Kornel Benko
Am Sonntag, 20. Dezember 2015 um 11:29:59, schrieb Georg Baum > Kornel Benko wrote: > > > Setting SRC_LIBCHARSET in the patch might be guarded by: > > if(UNIX AND NOT MINGW) > > endif() > > But since I cannot test windows or Mac I don't commit. > > I'd say commit. If relocatable.c is not suppos

Re: [LyX/master] Add 3rdparty to source package

2015-12-20 Thread Georg Baum
Kornel Benko wrote: > Setting SRC_LIBCHARSET in the patch might be guarded by: > if(UNIX AND NOT MINGW) > endif() > But since I cannot test windows or Mac I don't commit. I'd say commit. If relocatable.c is not supposed to be compiled, then it should be removed from the sources, these are stripp

Re: [LyX/master] Add 3rdparty to source package

2015-12-20 Thread Georg Baum
Pavel Sanda wrote: > I guess this is related, after running autogen.sh: > > 3rdparty/libiconv/Makefile.am: error: object 'relocatable.$(OBJEXT)' > created by '1.14/libcharset/lib/relocatable.c' and > '1.14/lib/relocatable.c' Makefile:445: recipe for target 'Makefile.in' > failed make: *** [Makefi

Re: [LyX/master] Add 3rdparty to source package

2015-12-19 Thread Kornel Benko
Am Samstag, 19. Dezember 2015 um 11:09:25, schrieb Georg Baum > commit 5537d1a1f03bb969d22e0d42a81317735c41c233 > Author: Georg Baum > Date: Sat Dec 19 11:08:08 2015 +0100 > > Add 3rdparty to source package > Problem with cmake too. I get /usr/src/lyx/lyx-git/3rdparty/libiconv/1.14/libcha

Re: [LyX/master] Add 3rdparty to source package

2015-12-19 Thread Pavel Sanda
Georg Baum wrote: > commit 5537d1a1f03bb969d22e0d42a81317735c41c233 > Author: Georg Baum > Date: Sat Dec 19 11:08:08 2015 +0100 > > Add 3rdparty to source package > > The new 3rdparty libraries are not added to the autotools build system, so > that they appear in the source pac