Am Sonntag, 20. Dezember 2015 um 11:29:59, schrieb Georg Baum 
<georg.b...@post.rwth-aachen.de>
> Kornel Benko wrote:
> 
> > Setting SRC_LIBCHARSET in the patch might be guarded by:
> > if(UNIX AND NOT MINGW)
> > endif()
> > But since I cannot test windows or Mac I don't commit.
> 
> I'd say commit. If relocatable.c is not supposed to be compiled, then it 
> should be removed from the sources, these are stripped down anyway. If this 
> really results in an error on windows then somebody will notice.

OK

> These libs are only supposed to be built with mingw or MSVC, except 
> hunspell: On linux and OS X they are already provided by the OS. iconv is 
> even part of libc on linux. We should probably split the LYX_3RDPARTY_BUILD 
> switch so that the bundled hunspell can also be used independently from the 
> two other libs.
> 

So, if we disable iconv and zlib from building on UNIX we were don too.
I try it this way. This does not effect windows, so it should be safe.

> Georg

        Kornel

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply via email to