Re: [Cvslog] r28160 - in /lyx-devel/trunk/src/frontends/qt4: GuiGraphi...

2009-01-16 Thread Pavel Sanda
Jürgen Spitzmüller wrote: > Jürgen Spitzmüller wrote: > > > yes, quick test looks good. maybe i would kill the tooltip for > > > "assigned to group" label. you can put it in i think. > > > > I've removed that tooltip, and commit now. > > attached is the backport to branch. > > Pavel, OK? as you

Re: [Cvslog] r28160 - in /lyx-devel/trunk/src/frontends/qt4: GuiGraphi...

2009-01-16 Thread Jürgen Spitzmüller
Jürgen Spitzmüller wrote: > > yes, quick test looks good. maybe i would kill the tooltip for > > "assigned to group" label. you can put it in i think. > > I've removed that tooltip, and commit now. attached is the backport to branch. Pavel, OK? Jürgen Index: src/frontends/qt4/GuiGraphics.cpp ===

Re: [Cvslog] r28160 - in /lyx-devel/trunk/src/frontends/qt4: GuiGraphi...

2009-01-16 Thread Jürgen Spitzmüller
Pavel Sanda wrote: > yes, quick test looks good. maybe i would kill the tooltip for > "assigned to group" label. you can put it in i think. I've removed that tooltip, and commit now. BTW I think it would be a good idea to indicate in the dialog's header if a group is used, because then the dialo

Re: [Cvslog] r28160 - in /lyx-devel/trunk/src/frontends/qt4: GuiGraphi...

2009-01-16 Thread Pavel Sanda
Jürgen Spitzmüller wrote: > Pavel Sanda wrote: > > > I understand correctly, is wrong: in the current approach, the graphics > > > params are changed without the user pressing apply (simply if the group > > > widget's content is changes). > > > > no, they are not changed without apply. > > Yes, I

Re: [Cvslog] r28160 - in /lyx-devel/trunk/src/frontends/qt4: GuiGraphi...

2009-01-16 Thread Jürgen Spitzmüller
Pavel Sanda wrote: > > I understand correctly, is wrong: in the current approach, the graphics > > params are changed without the user pressing apply (simply if the group > > widget's content is changes). > > no, they are not changed without apply. Yes, I misunderstood why the reloading of the par

Re: [Cvslog] r28160 - in /lyx-devel/trunk/src/frontends/qt4: GuiGraphi...

2009-01-16 Thread Pavel Sanda
Jürgen Spitzmüller wrote: > I understand correctly, is wrong: in the current approach, the graphics > params > are changed without the user pressing apply (simply if the group widget's > content is changes). no, they are not changed without apply. pavel

Re: [Cvslog] r28160 - in /lyx-devel/trunk/src/frontends/qt4: GuiGraphi...

2009-01-16 Thread Jürgen Spitzmüller
Also sprach Jürgen Spitzmüller: > > there is one serious bug with your patch though - you need to load group > > settings into the dialog when selected in the combobox, otherwise you > > destroy group settings by the current one after apply. > > I don't understand. Can you provide a recipe? OK, I

Re: [Cvslog] r28160 - in /lyx-devel/trunk/src/frontends/qt4: GuiGraphi...

2009-01-16 Thread Jürgen Spitzmüller
Pavel Sanda wrote: > yes i understood your plan :) this way when you create new group and then > click on another image without applying the group is gone. but i dont care > much about it, if you like it this way, we can use it. Yes, I prefer it that way. On the contrary, I think the current behav

Re: [Cvslog] r28160 - in /lyx-devel/trunk/src/frontends/qt4: GuiGraphi...

2009-01-16 Thread Pavel Sanda
Jürgen Spitzmüller wrote: > Pavel Sanda wrote: > > because there is no list of groups themselves (all this info is always > > gathered from scanning all images in the document) and there is nothing > > reasonable to be done as an action after pushing this button. one has to > > apply settings of th

Re: [Cvslog] r28160 - in /lyx-devel/trunk/src/frontends/qt4:GuiGraphi...

2009-01-16 Thread Jürgen Spitzmüller
Vincent van Ravesteijn wrote: > Why not something like "" then ? > > If I don't get the intention immediately, it might not be clear to > everyone. FWIW, in my proposal, the combo has an item "None". Jürgen

Re: [Cvslog] r28160 - in /lyx-devel/trunk/src/frontends/qt4:GuiGraphi...

2009-01-16 Thread Vincent van Ravesteijn
Pavel Sanda schreef: Vincent van Ravesteijn - TNW wrote: > A. There is always an empty item at top of the list. intended for canceling the group Why not something like "" then ? If I don't get the intention immediately, it might not be clear to everyone. Vincent

Re: [Cvslog] r28160 - in /lyx-devel/trunk/src/frontends/qt4:GuiGraphi...

2009-01-16 Thread Pavel Sanda
Vincent van Ravesteijn - TNW wrote: > A. There is always an empty item at top of the list. intended for canceling the group > B. Why is the group name box disabled if 'Show in LyX' is unchecked ? independent bug > C. Do the following: > . Insert Graphics > . Select an image > . Enter some name

Re: [Cvslog] r28160 - in /lyx-devel/trunk/src/frontends/qt4: GuiGraphi...

2009-01-16 Thread Jürgen Spitzmüller
Pavel Sanda wrote: > because there is no list of groups themselves (all this info is always > gathered from scanning all images in the document) and there is nothing > reasonable to be done as an action after pushing this button. one has to > apply settings of the whole dialog. if you only add the

Re: [Cvslog] r28160 - in /lyx-devel/trunk/src/frontends/qt4: GuiGraphi...

2009-01-16 Thread Pavel Sanda
Jürgen Spitzmüller wrote: > Pavel Sanda wrote: > > > > Add editable combobox for groups in graphics dialogs as discussed in > > > > http://www.mail-archive.com/lyx-us...@lists.lyx.org/msg70194.html > > > > > > i have tested this myself > > > > Juergen? > > I have not tested it thouroughly, neither

RE: [Cvslog] r28160 - in /lyx-devel/trunk/src/frontends/qt4:GuiGraphi...

2009-01-16 Thread Vincent van Ravesteijn - TNW
> Author: sanda > Date: Wed Jan 14 16:10:15 2009 > New Revision: 28160 > > URL: http://www.lyx.org/trac/changeset/28160 > Log: > Add editable combobox for groups in graphics dialogs as discussed in > http://www.mail-archive.com/lyx-us...@lists.lyx.org/msg70194.html > >i have tested this myself,

Re: [Cvslog] r28160 - in /lyx-devel/trunk/src/frontends/qt4: GuiGraphi...

2009-01-16 Thread Jürgen Spitzmüller
Pavel Sanda wrote: > > > Add editable combobox for groups in graphics dialogs as discussed in > > > http://www.mail-archive.com/lyx-us...@lists.lyx.org/msg70194.html > > > > i have tested this myself > > Juergen? I have not tested it thouroughly, neither carefully read the patch, but from a quick

Re: [Cvslog] r28160 - in /lyx-devel/trunk/src/frontends/qt4: GuiGraphi...

2009-01-15 Thread Pavel Sanda
Pavel Sanda wrote: > sa...@lyx.org wrote: > > Author: sanda > > Date: Wed Jan 14 16:10:15 2009 > > New Revision: 28160 > > > > URL: http://www.lyx.org/trac/changeset/28160 > > Log: > > Add editable combobox for groups in graphics dialogs as discussed in > > http://www.mail-archive.com/lyx-us...@li

Re: [Cvslog] r28160 - in /lyx-devel/trunk/src/frontends/qt4: GuiGraphi...

2009-01-14 Thread Pavel Sanda
sa...@lyx.org wrote: > Author: sanda > Date: Wed Jan 14 16:10:15 2009 > New Revision: 28160 > > URL: http://www.lyx.org/trac/changeset/28160 > Log: > Add editable combobox for groups in graphics dialogs as discussed in > http://www.mail-archive.com/lyx-us...@lists.lyx.org/msg70194.html i have tes