Re: [Cvslog] r25768 - /lyx-devel/trunk/src/LyXAction.cpp

2008-07-22 Thread rgheck
Andre Poenitz wrote: On Mon, Jul 21, 2008 at 02:41:16PM -0400, rgheck wrote: Pavel Sanda wrote: Pavel Sanda wrote: but to add support for svn (on the level of cvs) seems to be easy bussines of copy and paste from cvs code (nearly:) without beeing invasive to other parts of co

Re: [Cvslog] r25768 - /lyx-devel/trunk/src/LyXAction.cpp

2008-07-22 Thread Andre Poenitz
On Mon, Jul 21, 2008 at 02:41:16PM -0400, rgheck wrote: > Pavel Sanda wrote: >> Pavel Sanda wrote: >> >>> but to add support for svn (on the level of cvs) seems to be easy bussines >>> of >>> copy and paste from cvs code (nearly:) without beeing invasive to other >>> parts >>> of code. >>>

Re: [Cvslog] r25768 - /lyx-devel/trunk/src/LyXAction.cpp

2008-07-22 Thread Pavel Sanda
José Matos wrote: > On Monday 21 July 2008 19:32:47 Pavel Sanda wrote: > > have checked that its functions are working... so Jose am i allowed to put > > this into trunk? its not bug per se, anyway it somehow address > > long-standing #2574 and its uninvasive, just touching VCS files, which were >

Re: [Cvslog] r25768 - /lyx-devel/trunk/src/LyXAction.cpp

2008-07-22 Thread José Matos
On Monday 21 July 2008 19:32:47 Pavel Sanda wrote: > have checked that its functions are working... so Jose am i allowed to put > this into trunk? its not bug per se, anyway it somehow address > long-standing #2574 and its uninvasive, just touching VCS files, which were > broken till yesterday afte

Re: [Cvslog] r25768 - /lyx-devel/trunk/src/LyXAction.cpp

2008-07-21 Thread Pavel Sanda
rgheck wrote: > Excellent! How are we choosing the VCS when we "register" the file? we check for .svn/entries, CVS/Entries and finally for file.lyx,v. that decides which VCS is to be used. > In SVN::checkOut(), could you just try to do it and check the return value? this is unfortunately proble

Re: [Cvslog] r25768 - /lyx-devel/trunk/src/LyXAction.cpp

2008-07-21 Thread rgheck
Pavel Sanda wrote: Pavel Sanda wrote: but to add support for svn (on the level of cvs) seems to be easy bussines of copy and paste from cvs code (nearly:) without beeing invasive to other parts of code. as simple as this Excellent! How are we choosing the VCS when we "register" th

Re: [Cvslog] r25768 - /lyx-devel/trunk/src/LyXAction.cpp

2008-07-21 Thread Pavel Sanda
Pavel Sanda wrote: > > but to add support for svn (on the level of cvs) seems to be easy bussines > > of > > copy and paste from cvs code (nearly:) without beeing invasive to other > > parts > > of code. > > as simple as this have checked that its functions are working... so Jose am i allowed t

Re: [Cvslog] r25768 - /lyx-devel/trunk/src/LyXAction.cpp

2008-07-21 Thread Pavel Sanda
Pavel Sanda wrote: > but to add support for svn (on the level of cvs) seems to be easy bussines of > copy and paste from cvs code (nearly:) without beeing invasive to other parts > of code. as simple as this pavel diff --git a/src/LyXVC.cpp b/src/LyXVC.cpp index e156396..63d2622 100644 --- a/src/L

Re: [Cvslog] r25768 - /lyx-devel/trunk/src/LyXAction.cpp

2008-07-21 Thread Pavel Sanda
rgheck wrote: > Good. I've been thinking about working on this for a while and just had too > many other things to do unfortunately this is not working, since statusbar is going to be rewriten at the end of each lfun by the lfun name itself (besides other messages which are rewritten). dont k

Re: [Cvslog] r25768 - /lyx-devel/trunk/src/LyXAction.cpp

2008-07-21 Thread rgheck
Pavel Sanda wrote: rgheck wrote: There is a long-standing enhancement request to expand the range of VCS available. Of course, we're supposed to be feature-frozen, but perhaps for 1.6.2? That said, getting this right will involve doing something besides hard-coding the VCS that are availabl

Re: [Cvslog] r25768 - /lyx-devel/trunk/src/LyXAction.cpp

2008-07-21 Thread Uwe Stöhr
Pavel Sanda schrieb: few mouse clicks less? :) Yes, to be exact, one click less ;-) regards Uwe

Re: [Cvslog] r25768 - /lyx-devel/trunk/src/LyXAction.cpp

2008-07-21 Thread Pavel Sanda
rgheck wrote: > There is a long-standing enhancement request to expand the range of VCS > available. Of course, we're supposed to be feature-frozen, but perhaps for > 1.6.2? That said, getting this right will involve doing something besides > hard-coding the VCS that are available. We'd need som

Re: [Cvslog] r25768 - /lyx-devel/trunk/src/LyXAction.cpp

2008-07-21 Thread rgheck
Pavel Sanda wrote: Uwe Stöhr wrote: Uwe, it would be dead easy to expand this lfun for svn usage, so you could push your documentation changes directly to our repository, just by pushing some button on the toolbar. i can do it if you are interested. I don't

Re: [Cvslog] r25768 - /lyx-devel/trunk/src/LyXAction.cpp

2008-07-21 Thread Pavel Sanda
Uwe Stöhr wrote: > TortoiseSVN has of course a plain svn binary to be used via the command > line, but what will be the advantage to what I do currently to commit to > SVN? few mouse clicks less? :) but ok, i let it sleep. pavel

Re: [Cvslog] r25768 - /lyx-devel/trunk/src/LyXAction.cpp

2008-07-21 Thread Uwe Stöhr
Pavel Sanda schrieb: no, i meant that by pushing button in lyx window, your changes in the document you are editing will be directly commited after asking for commit message. no opening of TortoiseSVN. (i suppose TortoiseSVN has plain 'svn' binary which would be used on the background.) Tort

Re: [Cvslog] r25768 - /lyx-devel/trunk/src/LyXAction.cpp

2008-07-21 Thread Pavel Sanda
Pavel Sanda wrote: > (i suppose TortoiseSVN has plain 'svn' binary which would be used > on the background.) or more probably tortoise just already use 'svn' under the hood. pavel

Re: [Cvslog] r25768 - /lyx-devel/trunk/src/LyXAction.cpp

2008-07-21 Thread Pavel Sanda
Uwe Stöhr wrote: > > Uwe, it would be dead easy to expand this lfun for svn usage, so you > could push > > your documentation changes directly to our repository, just by pushing > some button on > > the toolbar. i can do it if you are interested. > > I don't understand. By pushing the button, my

Re: [Cvslog] r25768 - /lyx-devel/trunk/src/LyXAction.cpp

2008-07-21 Thread Uwe Stöhr
> Uwe, it would be dead easy to expand this lfun for svn usage, so you could push > your documentation changes directly to our repository, just by pushing some button on > the toolbar. i can do it if you are interested. I don't understand. By pushing the button, my TortoiseSVN opens and checks

Re: [Cvslog] r25768 - /lyx-devel/trunk/src/LyXAction.cpp

2008-07-21 Thread Pavel Sanda
[EMAIL PROTECTED] wrote: > Author: sanda > Date: Mon Jul 21 15:00:00 2008 > New Revision: 25768 > > URL: http://www.lyx.org/trac/changeset/25768 > Log: > commiting stuff also works. > > +/*! > + * \var lyx::FuncCode lyx::LFUN_VC_CHECK_IN > + * \li Action: Checks-in/commits the changes of the regi