Re: [Cvslog] r24526 - in /lyx-devel/trunk/src: BufferView.cpp FuncCode...

2008-05-05 Thread Pavel Sanda
> Pavel Sanda wrote: > > as an argument can be put any InsetGraphicsParams, from which only filename > > would be used in editGraphics. the same is situation with insetexternal. > > yes. > > > so either the syntax would be "inset-edit []" or we should > > remove string2params(to_utf8(cmd.argument

Re: [Cvslog] r24526 - in /lyx-devel/trunk/src: BufferView.cpp FuncCode...

2008-05-05 Thread Jürgen Spitzmüller
Pavel Sanda wrote: > as an argument can be put any InsetGraphicsParams, from which only filename > would be used in editGraphics. the same is situation with insetexternal. yes. > so either the syntax would be "inset-edit []" or we should > remove string2params(to_utf8(cmd.argument()), buffer(), p

Re: [Cvslog] r24526 - in /lyx-devel/trunk/src: BufferView.cpp FuncCode...

2008-05-05 Thread Pavel Sanda
> Pavel Sanda wrote: > > Juergen, are you sure this is correct syntax, > > yes. > > > i see in the code below it > > touches cmd.argument() > > this is a leftover from the old graphics-edit and external-edit. I'm not sure > about its use. which means you can't be sure about correct syntax :)

Re: [Cvslog] r24526 - in /lyx-devel/trunk/src: BufferView.cpp FuncCode...

2008-05-04 Thread Jürgen Spitzmüller
Pavel Sanda wrote: > Juergen, are you sure this is correct syntax, yes. > i see in the code below it > touches cmd.argument() this is a leftover from the old graphics-edit and external-edit. I'm not sure about its use. Jürgen

Re: [Cvslog] r24526 - in /lyx-devel/trunk/src: BufferView.cpp FuncCode...

2008-05-04 Thread Pavel Sanda
> Author: spitz > Date: Sun Apr 27 18:20:12 2008 > New Revision: 24526 > > URL: http://www.lyx.org/trac/changeset/24526 > Log: > * merge LFUN_EDIT_EXTERNAL and LFUN_EDIT_GRAPHICS to one LFUN_EDIT_INSET (bug > 3975) ... > { LFUN_EXTERNAL_EDIT, "external-edit", Noop, Edit }, >