> Pavel Sanda wrote:
> > Juergen, are you sure this is correct syntax,
>
> yes.
>
> > i see in the code below it
> > touches cmd.argument()
>
> this is a leftover from the old graphics-edit and external-edit. I'm not sure
> about its use.
which means you can't be sure about correct syntax :)
lets take a look on :
case LFUN_INSET_EDIT: {
InsetGraphicsParams p = params();
if (!cmd.argument().empty())
string2params(to_utf8(cmd.argument()), buffer(), p);
editGraphics(p, buffer());
break;
}
as an argument can be put any InsetGraphicsParams, from which only filename
would be used
in editGraphics. the same is situation with insetexternal.
so either the syntax would be "inset-edit [<INSET_PARAMS>]" or we should remove
string2params(to_utf8(cmd.argument()), buffer(), p); code - because i can't
imagine
situation where could be this used.
what do you think?
pavel
