> ...it doesn't need to be redone there. It can get copied into the params
> and then just used.
>
No. Remember that we are passing biblio back, and we need to find
/path/to/biobio.bib to calculate inzipname. Anyway, you are right that
we should be cautious so I have reverted.
Bo
Bo Peng wrote:
OK. I will revert this bit. I did not like the idea of calculating
inzip name twice...
Wait:
- FileName bibfilepath =
InsetBibtex::getBibTeXPath(bibfile, buf);
- string inzipName =
-
EmbeddedFile::c
> Is getBibTexPath expensive??? That line was the reason why I made the
> changes. You know, all these will be redone in InsetBibtex, and it
> does not make sense to calculate inzipname here. Maybe I can add a
> comment here?
OK. That can not be too expensive. Let us just try to be safe here.
> OK. I will revert this bit. I did not like the idea of calculating
> inzip name twice...
Wait:
> - FileName bibfilepath =
> InsetBibtex::getBibTeXPath(bibfile, buf);
> - string inzipName =
> -
> EmbeddedFile::calcInzipName(
> I strongly encourage you to revert this patch, except for the crucial
> bit about copying the file if the embedding status has changed, which is
> my bad.
OK. I will revert this bit. I did not like the idea of calculating
inzip name twice...
Bo
[EMAIL PROTECTED] wrote:
Author: bpeng
Date: Sat Mar 29 21:24:49 2008
New Revision: 24047
URL: http://www.lyx.org/trac/changeset/24047
Log:
Revert the addition of a static calcInzipName function, polish createBibFiles
function
Modified: lyx-devel/trunk/src/frontends/qt4/GuiBibtex.cpp
URL:
htt
