Bo Peng wrote:
 OK. I will revert this bit. I did not like the idea of calculating
 inzip name twice...

Wait:

-                     FileName bibfilepath = 
InsetBibtex::getBibTeXPath(bibfile, buf);
-                     string inzipName =
-                             
EmbeddedFile::calcInzipName(bibfilepath.absFilename(), buf.filePath());

Is getBibTexPath expensive???
Yes, but it doesn't matter very much here in the GUI, and...

That line was the reason why I made the
changes. You know, all these will be redone in InsetBibtex, and it
does not make sense to calculate inzipname here.
...it doesn't need to be redone there. It can get copied into the params and then just used.

Richard

Reply via email to