Re: [Cvslog] r22081 - /lyx-devel/trunk/src/support/SystemcallPrivate.cpp

2007-12-13 Thread Peter Kümmel
Enrico Forestieri wrote: On Wed, Dec 12, 2007 at 02:51:01PM +0100, Jean-Marc Lasgouttes wrote: Enrico Forestieri <[EMAIL PROTECTED]> writes: However, I'd rather revert the changes because they don't solve any problem (or those problems can be solved in other non-disruptive ways), destabilize a

Re: [Cvslog] r22081 - /lyx-devel/trunk/src/support/SystemcallPrivate.cpp

2007-12-12 Thread Andre Poenitz
On Wed, Dec 12, 2007 at 10:05:45AM +0100, Juergen Spitzmueller wrote: > Enrico Forestieri wrote: > > > Secondly, cmd is a command whose arguments are > > quoted for being processed by a shell, but this is not so. Hence > > when calling > > > > latex 'newfile1.tex' > > > > latex is passed the fil

Re: [Cvslog] r22081 - /lyx-devel/trunk/src/support/SystemcallPrivate.cpp

2007-12-12 Thread Enrico Forestieri
On Wed, Dec 12, 2007 at 02:51:01PM +0100, Jean-Marc Lasgouttes wrote: > Enrico Forestieri <[EMAIL PROTECTED]> writes: > > > However, I'd rather revert the changes because they don't solve any > > problem (or those problems can be solved in other non-disruptive ways), > > destabilize an already wor

Re: [Cvslog] r22081 - /lyx-devel/trunk/src/support/SystemcallPrivate.cpp

2007-12-12 Thread Jean-Marc Lasgouttes
Enrico Forestieri <[EMAIL PROTECTED]> writes: > However, I'd rather revert the changes because they don't solve any > problem (or those problems can be solved in other non-disruptive ways), > destabilize an already working code base, put a burden that is best > avoided, and I don't like that lyx f

Re: [Cvslog] r22081 - /lyx-devel/trunk/src/support/SystemcallPrivate.cpp

2007-12-12 Thread Enrico Forestieri
On Tue, Dec 11, 2007 at 05:40:17PM -0800, Angus Leeming wrote: > Enrico Forestieri wrote: > >> configure_command_ = os::python() + ' ' + > >> quoteName(configure_script.toFilesystemEncoding()) + > >> with_version_suffix(); > > > > You are right. A parser would be needed, and it is go

Re: [Cvslog] r22081 - /lyx-devel/trunk/src/support/SystemcallPrivate.cpp

2007-12-12 Thread Enrico Forestieri
On Wed, Dec 12, 2007 at 10:05:45AM +0100, Juergen Spitzmueller wrote: > Enrico Forestieri wrote: > > > Secondly, cmd is a command whose arguments are > > quoted for being processed by a shell, but this is not so. Hence > > when calling > > > > latex 'newfile1.tex' > > > > latex is passed the fil

Re: [Cvslog] r22081 - /lyx-devel/trunk/src/support/SystemcallPrivate.cpp

2007-12-12 Thread Angus Leeming
Enrico Forestieri wrote: >> configure_command_ = os::python() + ' ' + >> quoteName(configure_script.toFilesystemEncoding()) + >> with_version_suffix(); > > You are right. A parser would be needed, and it is going to become > cumbersome and error prone. It just so happens that I wrot

Re: [Cvslog] r22081 - /lyx-devel/trunk/src/support/SystemcallPrivate.cpp

2007-12-12 Thread Juergen Spitzmueller
Enrico Forestieri wrote: > Secondly, cmd is a command whose arguments are > quoted for being processed by a shell, but this is not so. Hence > when calling > > latex 'newfile1.tex' > > latex is passed the filename 'newfile1.tex' *literally*, and of course > only newfile1.tex exists. On Windows i

Re: [Cvslog] r22081 - /lyx-devel/trunk/src/support/SystemcallPrivate.cpp

2007-12-11 Thread Enrico Forestieri
On Tue, Dec 11, 2007 at 09:32:59PM +0100, Andre Poenitz wrote: > On Tue, Dec 11, 2007 at 12:19:02PM +0100, Enrico Forestieri wrote: > > > > > > process.setReadChannel(QProcess::StandardOutput); > > > - process.start(cmd.c_str(), QStringList(), QIODevice::ReadOnly); > > > + process.start(toqstr

Re: [Cvslog] r22081 - /lyx-devel/trunk/src/support/SystemcallPrivate.cpp

2007-12-11 Thread Andre Poenitz
On Tue, Dec 11, 2007 at 12:19:02PM +0100, Enrico Forestieri wrote: > > > > process.setReadChannel(QProcess::StandardOutput); > > - process.start(cmd.c_str(), QStringList(), QIODevice::ReadOnly); > > + process.start(toqstr(cmd), QStringList(), QIODevice::ReadOnly); > > The problem is righ

Re: [Cvslog] r22081 - /lyx-devel/trunk/src/support/SystemcallPrivate.cpp

2007-12-11 Thread Enrico Forestieri
On Tue, Dec 11, 2007 at 10:48:49AM -, [EMAIL PROTECTED] wrote: > Author: spitz > Date: Tue Dec 11 11:48:48 2007 > New Revision: 22081 > > URL: http://www.lyx.org/trac/changeset/22081 > Log: > * src/support/SystemcallPrivate.cpp: > - QProcess::start and ProgressInterface::appendMessage t