Re: [LyX/master] lyx-tester: turn on more GCC warnings

2025-08-02 Thread Scott Kostyshak
On Sat, Aug 02, 2025 at 01:54:46PM +0200, Kornel Benko wrote: > Am Sat, 2 Aug 2025 13:31:41 +0200 > schrieb Kornel Benko : > > > Yes, your combination gives no warnings. I will check for the differences. > > > > OK, here your build is in ",x1", mine in ',x2'. > The lists are sorted, best to see

Re: [LyX/master] Add plimsoll symbol, for Bernt

2025-08-02 Thread Scott Kostyshak
On Sat, Aug 02, 2025 at 12:38:48PM +0200, Enrico Forestieri wrote: > > By the way, for the next development cycle (2.6) we might add a "Local > Symbols" panel (similar to the "Local Layout" panel) to the document > settings to add definitions that would otherwise be placed in the symbols > file. T

Re: [LyX/master] lyx-tester: turn on more GCC warnings

2025-08-02 Thread Scott Kostyshak
On Sat, Aug 02, 2025 at 11:35:10AM +0200, Kornel Benko wrote: > Am Sat, 2 Aug 2025 11:13:06 +0200 > schrieb Scott Kostyshak : > > > On Sat, Aug 02, 2025 at 11:00:48AM +0200, Kornel Benko wrote: > > > Am Fri, 01 Aug 2025 14:30:47 +0000 > > > schrieb Scott Ko

Re: [LyX/master] lyx-tester: turn on more GCC warnings

2025-08-02 Thread Scott Kostyshak
On Sat, Aug 02, 2025 at 11:00:48AM +0200, Kornel Benko wrote: > Am Fri, 01 Aug 2025 14:30:47 + > schrieb Scott Kostyshak : > > > commit 6ee67ae6823ded6e486fe9f8496e27e371308ac4 > > Author: Scott Kostyshak > > Date: Fri Aug 1 16:29:41 2025 +0200 > > >

Re: [automated testing] debian testing: compile failure with qt6

2025-07-31 Thread Scott Kostyshak
On Thu, Jul 31, 2025 at 11:44:16AM +0200, Pavel Sanda wrote: > On Thu, Jul 31, 2025 at 02:37:06AM +, test...@tester.lyx.org wrote: > > CXX Trans.o > > Trans.cpp: In member function 'const lyx::docstring > > lyx::Trans::process(lyx::char_type, lyx::TransManager&)': > > Trans.cpp:365:40:

Re: Failing ctests

2025-07-30 Thread Scott Kostyshak
On Fri, Jul 25, 2025 at 12:38:26PM +0200, Jürgen Spitzmüller wrote: > Am Freitag, dem 25.07.2025 um 12:26 +0200 schrieb Kornel Benko: > > Running exports, I got the attached errors. > > This is due to a change in recent babel-french (v. 4.0): > > "Options OldFigTabCaptions, ListOldLayout and Glob

Re: lyx2lyx tests are timing out now

2025-07-30 Thread Scott Kostyshak
On Tue, Jul 29, 2025 at 11:31:43PM -0400, Richard Kimberly Heck wrote: > On 7/29/25 6:53 PM, Scott Kostyshak wrote: > > Some lyx2lyx tests are timing out now, suggesting a possible infinite > > loop. For example, > > > >lyx -e lyx24x autotests/export/lyx2lyx/lyx_2_

lyx2lyx tests are timing out now

2025-07-29 Thread Scott Kostyshak
Some lyx2lyx tests are timing out now, suggesting a possible infinite loop. For example, lyx -e lyx24x autotests/export/lyx2lyx/lyx_2_3_test.lyx I think it's due to a commit in the last couple of days. Scott signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.

Re: LyX crashes when using Arabic versions 2.4.3+

2025-07-29 Thread Scott Kostyshak
On Mon, Jul 28, 2025 at 11:13:37PM +0100, daky dakyion wrote: > Dear LyX developers, > I am writing this mail to report a bug associated with the crash of the > application when using the Arabic language as the language of the document. > I have been using LyX for 4 years now,I haven't encountered

Re: Failing ctests

2025-07-25 Thread Scott Kostyshak
On Fri, Jul 25, 2025 at 12:26:12PM +0200, Kornel Benko wrote: > > Running exports, I got the attached errors. They all succeed here here (except for Springer_Nature because I don't have the dependency). I haven't updated tlmgr un a few weeks, so what Jürgen says makes sense. Scott signature.a

Re: The features/breakinsets branch

2025-07-23 Thread Scott Kostyshak
On Tue, Jul 22, 2025 at 11:52:52PM +0200, Jean-Marc Lasgouttes wrote: > Le 22/07/2025 à 23:41, Scott Kostyshak a écrit : > > On Tue, Jul 22, 2025 at 06:11:00PM +0200, Jean-Marc Lasgouttes wrote: > > > > > Comments welcome. Don't get your expectations too high, thi

Re: The features/breakinsets branch

2025-07-22 Thread Scott Kostyshak
On Tue, Jul 22, 2025 at 06:11:00PM +0200, Jean-Marc Lasgouttes wrote: > Comments welcome. Don't get your expectations too high, this is far from > usable in real life. Thanks for your work on this, JMarc! I pulled in the branch and compiled. Do you have a test document or something we can use to

Re: Python error in fen2ascii.py

2025-07-19 Thread Scott Kostyshak
On Sat, Jul 19, 2025 at 04:11:13PM +0200, Jürgen Spitzmüller wrote: > Am Samstag, dem 19.07.2025 um 10:16 +0200 schrieb Scott Kostyshak: > > Using a fresh user directory and a clean build, bisect leads to: > > > > commit fcc77d6b14c2b528b22510e53041f8e11db9a98b (HEAD

Re: Python error in fen2ascii.py

2025-07-19 Thread Scott Kostyshak
On Fri, Jul 18, 2025 at 10:59:34PM +0200, Scott Kostyshak wrote: > > Could that be due to your converters settings? > > Could be, I'll check. Using a fresh user directory and a clean build, bisect leads to: commit fcc77d6b14c2b528b22510e53041f8e11db9a98b (HEAD) Author: Jue

Re: Python error in fen2ascii.py

2025-07-18 Thread Scott Kostyshak
On Fri, Jul 18, 2025 at 01:40:14PM +0100, José Matos wrote: > On Fri, 2025-07-18 at 13:50 +0200, Scott Kostyshak wrote: > > An error occurred while running: > > python3 $$s/scripts/fen2ascii.py > > "Journal_of_the_Acoustical_Society

Re: Python error in fen2ascii.py

2025-07-18 Thread Scott Kostyshak
On Fri, Jul 18, 2025 at 12:45:02PM +0200, Scott Kostyshak wrote: > On Thu, Jul 17, 2025 at 10:25:00PM +0100, José Matos wrote: > > On Thu, 2025-07-17 at 10:36 +0200, Scott Kostyshak wrote: > > > With the following command: > > > > > > cd "lib/te

Re: Python error in fen2ascii.py

2025-07-18 Thread Scott Kostyshak
On Thu, Jul 17, 2025 at 10:25:00PM +0100, José Matos wrote: > On Thu, 2025-07-17 at 10:36 +0200, Scott Kostyshak wrote: > > With the following command: > > > > cd "lib/templates/Articles/" && > > lyx -e lyx21x Journal_of_the_Acoustical_Society

Re: Maybe dviluatex bug: huge RAM usage

2025-07-18 Thread Scott Kostyshak
On Thu, Jul 17, 2025 at 10:39:48AM +0200, Scott Kostyshak wrote: > On Thu, Jul 17, 2025 at 09:23:40AM +0200, Kornel Benko wrote: > > Am Thu, 17 Jul 2025 00:00:27 +0200 > > schrieb Scott Kostyshak : > > > > > On Wed, Jul 16, 2025 at 02:42:01PM +0200, Kornel Benko wrot

Re: docbook test failures

2025-07-18 Thread Scott Kostyshak
On Fri, Jul 18, 2025 at 06:52:59AM +0200, Thibaut Cuvelier wrote: > On Thu, 17 Jul 2025 at 22:56, Scott Kostyshak wrote: > > > On Thu, Jul 17, 2025 at 07:58:25PM +0200, Thibaut Cuvelier wrote: > > > On Thu, 17 Jul 2025 at 10:21, Scott Kostyshak wrote: > > > &

Re: docbook test failures

2025-07-17 Thread Scott Kostyshak
On Fri, Jul 18, 2025 at 06:52:59AM +0200, Thibaut Cuvelier wrote: > On Thu, 17 Jul 2025 at 22:56, Scott Kostyshak wrote: > > > On Thu, Jul 17, 2025 at 07:58:25PM +0200, Thibaut Cuvelier wrote: > > > On Thu, 17 Jul 2025 at 10:21, Scott Kostyshak wrote: > > > &

Re: docbook test failures

2025-07-17 Thread Scott Kostyshak
On Thu, Jul 17, 2025 at 07:58:25PM +0200, Thibaut Cuvelier wrote: > On Thu, 17 Jul 2025 at 10:21, Scott Kostyshak wrote: > > > The following tests are failing on current master: > > > > export/export/docbook/basic_docbook5 (Failed) > > export/doc/de/

Re: Maybe dviluatex bug: huge RAM usage

2025-07-17 Thread Scott Kostyshak
On Thu, Jul 17, 2025 at 09:23:40AM +0200, Kornel Benko wrote: > Am Thu, 17 Jul 2025 00:00:27 +0200 > schrieb Scott Kostyshak : > > > On Wed, Jul 16, 2025 at 02:42:01PM +0200, Kornel Benko wrote: > > > Am Wed, 16 Jul 2025 14:29:40 +0200 > > > schrieb Scott Kosty

Python error in fen2ascii.py

2025-07-17 Thread Scott Kostyshak
With the following command: cd "lib/templates/Articles/" && lyx -e lyx21x Journal_of_the_Acoustical_Society_of_America_%28JASA%29.lyx I get the following: Traceback (most recent call last): File "/home/scott/lyxbuilds/master-master/repo/lib/scripts/fen2ascii.py", line 23, in line=string.

docbook test failures

2025-07-17 Thread Scott Kostyshak
The following tests are failing on current master: export/export/docbook/basic_docbook5 (Failed) export/doc/de/Customization_docbook5 (Failed) export/doc/es/Tutorial_docbook5 (Failed) export/doc/fr/Intro_docbook5 (Failed) export/doc/he/Intro_docbook5 (Failed) export/doc/hu/Intro_docboo

Re: Maybe dviluatex bug: huge RAM usage

2025-07-16 Thread Scott Kostyshak
On Wed, Jul 16, 2025 at 02:42:01PM +0200, Kornel Benko wrote: > Am Wed, 16 Jul 2025 14:29:40 +0200 > schrieb Scott Kostyshak : > > > My system runs out of RAM when I do this: > > > > lyx -e dvi3 > > ./autotests/export/latex/languages/supported-languages_babel

Maybe dviluatex bug: huge RAM usage

2025-07-16 Thread Scott Kostyshak
My system runs out of RAM when I do this: lyx -e dvi3 ./autotests/export/latex/languages/supported-languages_babel_non-tex.lyx On a system with more RAM, it seems it uses about 9GB for me. Can anyone reproduce? If you don't have much RAM, be careful since it might cause problems with your sy

Re: 5 warnings from -Woverloaded-virtual (Koji?)

2025-07-16 Thread Scott Kostyshak
On Wed, Jul 16, 2025 at 12:21:20PM +0200, Kornel Benko wrote: > Am Wed, 16 Jul 2025 18:07:41 +0900 > schrieb "Yokota K." : > > > Thanks, I could somehow manage to test :) > > > > I think the attached patch resolves the warnings. Could you test it? > > > > Probably, the reason of warning was that

Re: 5 warnings from -Woverloaded-virtual (Koji?)

2025-07-15 Thread Scott Kostyshak
On Tue, Jul 15, 2025 at 08:14:38PM +0200, Kornel Benko wrote: > Am Wed, 16 Jul 2025 02:47:20 +0900 > schrieb Koji Yokota : > > > > It does not help, unfortunately. > > > > I see, I will check. > > > > I tested with LYX_CXX_FLAGS=-Woverloaded-virtual on Qt Creator’s CMake > > settings, but >

Re: 5 warnings from -Woverloaded-virtual (Koji?)

2025-07-14 Thread Scott Kostyshak
On Mon, Jul 14, 2025 at 03:51:03PM +0200, Jean-Marc Lasgouttes wrote: > Le 14/07/2025 à 14:41, Yokota K. a écrit : > > Along with the 3/ plan, I hope the attached patch suppresses the warnings, > > but I’m not sure how much of resemblance of functions leads to a warning > > (it still uses overloa

Re: [LyX/master] Avoid clang warning

2025-07-14 Thread Scott Kostyshak
On Mon, Jul 14, 2025 at 02:31:59PM +0200, Jean-Marc Lasgouttes wrote: > Le 14/07/2025 à 13:46, Kornel Benko a écrit : > > BTW, what about warnings we get when compiling with -fsanitize=address? > > > > Mainly -Wmaybe-uninitialized. > > I was planning to do useful summer work this week, but if you

Re: [LyX/master] Avoid clang warning

2025-07-14 Thread Scott Kostyshak
On Mon, Jul 14, 2025 at 01:46:59PM +0200, Kornel Benko wrote: > Am Mon, 14 Jul 2025 13:28:52 +0200 > schrieb Jean-Marc Lasgouttes : > > > Le 14/07/2025 à 13:27, Scott Kostyshak a écrit : > > > Current master compiles fine for me, which means you didn't introduce &

Re: [LyX/master] Avoid clang warning

2025-07-14 Thread Scott Kostyshak
On Mon, Jul 14, 2025 at 01:14:42PM +0200, Jean-Marc Lasgouttes wrote: > Le 14/07/2025 à 12:43, Kornel Benko a écrit : > > Am Mon, 14 Jul 2025 10:20:59 + > > schrieb Jean-Marc Lasgouttes : > > > > > commit c6aee1c65531578d6128e06839dde168ede1d988 > > > Author: Jean-Marc Lasgouttes > > > Date:

Re: Worth fixing warnings about deprecated copy constructors and copy assignment operators?

2025-07-14 Thread Scott Kostyshak
On Mon, Jul 14, 2025 at 08:59:32AM +0200, Kornel Benko wrote: > Am Mon, 14 Jul 2025 01:00:43 +0200 > schrieb Scott Kostyshak : > > > > /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/stl_construct.h:88:2: > > > error: destructor called

Re: Worth fixing warnings about deprecated copy constructors and copy assignment operators?

2025-07-13 Thread Scott Kostyshak
On Fri, Jul 11, 2025 at 11:57:46PM +0200, Scott Kostyshak wrote: > On Fri, Jul 11, 2025 at 05:48:09PM +0200, Jean-Marc Lasgouttes wrote: > > Le 11/07/2025 à 17:12, Scott Kostyshak a écrit : > > > > I did a few more. > > > > > > Not sure I see the

Re: [LyX/master] Fix preedit representation on Windows/Linux and optimize

2025-07-13 Thread Scott Kostyshak
On Mon, Jul 14, 2025 at 02:21:37AM +0900, Yokota K. wrote: > > > 2025/07/13 22:18、Scott Kostyshak のメール: > > Could you please double-check my commit (406a1357) looks OK to you? > > Dear Scott, > > Sorry that I missed your mail. I misunderstood the usage of the funct

Re: [LyX/master] Fix preedit representation on Windows/Linux and optimize

2025-07-13 Thread Scott Kostyshak
On Thu, Jul 03, 2025 at 05:04:47PM +0200, Scott Kostyshak wrote: > On Thu, Jul 03, 2025 at 03:38:35AM +, Koji Yokota wrote: > > commit 29d41c1e1bcde742a2a2e34c350aced78cb2df07 > > Author: Koji Yokota > > Date: Thu Jul 3 11:21:03 2025 +0900 > > > > Fix

Re: 5 warnings from -Woverloaded-virtual (Koji?)

2025-07-13 Thread Scott Kostyshak
On Thu, Jul 03, 2025 at 12:55:02AM +0200, Scott Kostyshak wrote: > On Thu, Jul 03, 2025 at 12:10:10AM +0200, Jean-Marc Lasgouttes wrote: > > Le 02/07/2025 à 18:16, Scott Kostyshak a écrit : > > > src/insets/Inset.h:217:22: warning: ‘virtual void > > > lyx::Inset::draw(

Re: Worth fixing warnings about deprecated copy constructors and copy assignment operators?

2025-07-11 Thread Scott Kostyshak
On Fri, Jul 11, 2025 at 05:48:09PM +0200, Jean-Marc Lasgouttes wrote: > Le 11/07/2025 à 17:12, Scott Kostyshak a écrit : > > > I did a few more. > > > > Not sure I see these. Did you push? > > I pushed now :) > > > > For InsetBibitem and InsetCitatio

Re: Worth fixing warnings about deprecated copy constructors and copy assignment operators?

2025-07-11 Thread Scott Kostyshak
On Fri, Jul 11, 2025 at 03:33:06PM +0200, Jean-Marc Lasgouttes wrote: > Le 11/07/2025 à 15:14, Jean-Marc Lasgouttes a écrit : > > Le 07/07/2025 à 13:11, Scott Kostyshak a écrit : > > > Thanks for taking a look Riki! I don't think I will address these myself > > > si

Re: Metrics Crash/Metrics Loop

2025-07-08 Thread Scott Kostyshak
On Tue, Jul 08, 2025 at 03:27:50PM +0200, Jürgen Spitzmüller wrote: > Am Dienstag, dem 08.07.2025 um 14:54 +0200 schrieb Jürgen Spitzmüller: > > There still is a false marker if you insert a 100% textwidth table > > with the cursor _not_ being placed after the table (in the same par). > > The reas

Re: Metrics Crash/Metrics Loop

2025-07-08 Thread Scott Kostyshak
On Tue, Jul 08, 2025 at 12:25:02PM +0200, Jürgen Spitzmüller wrote: > Am Dienstag, dem 08.07.2025 um 12:05 +0200 schrieb Scott Kostyshak: > > Looks good here. The only issue is that no matter what zoom I set I > > can't get rid of the vertical red dotted lines (indicating the &

Re: Metrics Crash/Metrics Loop

2025-07-08 Thread Scott Kostyshak
On Tue, Jul 08, 2025 at 11:36:07AM +0200, Jürgen Spitzmüller wrote: > Am Dienstag, dem 08.07.2025 um 09:01 +0200 schrieb Jürgen Spitzmüller: > > I'm having a look ... > > Should be fixed. Testing would be good. Looks good here. The only issue is that no matter what zoom I set I can't get rid of t

Re: Metrics Crash/Metrics Loop

2025-07-07 Thread Scott Kostyshak
On Mon, Jul 07, 2025 at 03:50:17PM -0400, Richard Kimberly Heck wrote: > Open the attached file (if you can). Then try to resize the window (widen or > lengthen it). Here, that leads to a crash. > > Backtrace with devel: > > 1  lyx::TextMetrics::tokenizeParagraph TextMetrics.cpp  954 0x6fd7ad > 2

Re: About Lyx

2025-07-07 Thread Scott Kostyshak
On Mon, Jul 07, 2025 at 04:24:25PM +0200, Pavel Sanda wrote: > On Mon, Jul 07, 2025 at 03:00:43PM +0100, José Matos wrote: > > On Mon, 2025-07-07 at 13:06 +0200, Scott Kostyshak wrote: > > > I do think this is a bug (whether LyX or Qt). The minimum vertical size > > >

Re: [LyX/master] Fix the last remaining -Wmissing-noreturn

2025-07-07 Thread Scott Kostyshak
On Sat, Jul 05, 2025 at 10:18:06PM +0200, Scott Kostyshak wrote: > On Sat, Jul 05, 2025 at 09:35:58PM +0200, Kornel Benko wrote: > > Am Sat, 5 Jul 2025 21:18:52 +0200 > > schrieb Kornel Benko : > > > > > Am Sat, 5 Jul 2025 20:59:42 +0200 > > > schrieb Scott

Re: About Lyx

2025-07-07 Thread Scott Kostyshak
On Mon, Jul 07, 2025 at 03:00:43PM +0100, José Matos wrote: > On Mon, 2025-07-07 at 13:06 +0200, Scott Kostyshak wrote: > > I do think this is a bug (whether LyX or Qt). The minimum vertical size > > should be set properly such that the window cannot be resized to be too > >

Re: Worth fixing warnings about deprecated copy constructors and copy assignment operators?

2025-07-07 Thread Scott Kostyshak
On Sat, Jul 05, 2025 at 11:45:22AM -0400, Richard Kimberly Heck wrote: > On 7/5/25 8:01 AM, Scott Kostyshak wrote: > > Here are the warnings: > > > >src/ConverterCache.cpp:65:2: warning: definition of implicit copy > > assignment operator for 'CacheItem

Re: [LyX/master] Fix the last remaining -Wmissing-noreturn

2025-07-05 Thread Scott Kostyshak
On Sat, Jul 05, 2025 at 09:35:58PM +0200, Kornel Benko wrote: > Am Sat, 5 Jul 2025 21:18:52 +0200 > schrieb Kornel Benko : > > > Am Sat, 5 Jul 2025 20:59:42 +0200 > > schrieb Scott Kostyshak : > > > > > On Sat, Jul 05, 2025 at 08:14:49PM +0200, Kornel Benko

Re: [LyX/master] Fix the last remaining -Wmissing-noreturn

2025-07-05 Thread Scott Kostyshak
On Sat, Jul 05, 2025 at 08:14:49PM +0200, Kornel Benko wrote: > Am Sat, 05 Jul 2025 18:05:27 + > schrieb Scott Kostyshak : > > > commit cd5fb84098f46738a45699aeb1491b52282e3c2d > > Author: Scott Kostyshak > > Date: Sat Jul 5 20:04:28 2025 +0200 > > > &g

Worth fixing warnings about deprecated copy constructors and copy assignment operators?

2025-07-05 Thread Scott Kostyshak
Here are the warnings: src/ConverterCache.cpp:65:2: warning: definition of implicit copy assignment operator for 'CacheItem' is deprecated because it has a user-provided destructor [-Wdeprecated-copy-with-user-provided-dtor] src/graphics/GraphicsImage.h:34:10: warning: definition of implicit

Re: I'm stuck on a warning: 'Transparent' was marked unused but was used [-Wused-but-marked-unused]

2025-07-05 Thread Scott Kostyshak
On Sat, Jul 05, 2025 at 01:28:57PM +0200, Jürgen Spitzmüller wrote: > Am Samstag, dem 05.07.2025 um 12:55 +0200 schrieb Scott Kostyshak: > > It tells me: > > > >   src/frontends/qt/GuiPrefs.h:56:10: fatal error: 'QColorConstants' > >

Re: I'm stuck on a warning: 'Transparent' was marked unused but was used [-Wused-but-marked-unused]

2025-07-05 Thread Scott Kostyshak
On Sat, Jul 05, 2025 at 12:36:12PM +0200, Jürgen Spitzmüller wrote: > Am Samstag, dem 05.07.2025 um 11:53 +0200 schrieb Scott Kostyshak: > > The relevant code was introduced at d3f2c017, but I don't see > > anything wrong with it. > > Does it help if you add to

I'm stuck on a warning: 'Transparent' was marked unused but was used [-Wused-but-marked-unused]

2025-07-05 Thread Scott Kostyshak
I get the following warning: src/frontends/qt/GuiPrefs.cpp:4584:33: warning: 'Transparent' was marked unused but was used [-Wused-but-marked-unused] 4584 | pixmap.fill(QColorConstants::Transparent); | ^ I'm

Re: Fixing the only two -Wdouble-promotion warnings

2025-07-04 Thread Scott Kostyshak
On Fri, Jul 04, 2025 at 05:59:00PM +0200, Jean-Marc Lasgouttes wrote: > Le 04/07/2025 à 17:48, Scott Kostyshak a écrit : > > The -Wdouble-promotion warning gives two warnings on Clang > > The two patches look good, Thanks, I pushed to master at 59aa3e04. > but I still do

Fixing the only two -Wdouble-promotion warnings

2025-07-04 Thread Scott Kostyshak
bove fixes. Is it OK? Scott From 3248f1b4cfe659af82438f9fc41781a5d4b7c4db Mon Sep 17 00:00:00 2001 From: Scott Kostyshak Date: Fri, 4 Jul 2025 17:23:02 +0200 Subject: [PATCH] Fix two instances of Clang's -Wdouble-promotion src/frontends/qt/GuiView.cpp:184:30: warning: implicit conversi

Re: Removing a duplicate declaration

2025-07-04 Thread Scott Kostyshak
On Fri, Jul 04, 2025 at 02:33:40PM +0200, Jürgen Spitzmüller wrote: > Am Freitag, dem 04.07.2025 um 12:56 +0200 schrieb Scott Kostyshak: > > Bump. I think this is the only instance of this warning, so it would > > be nice to knock this one out so we can flip on -Wredundant-dec

Re: Two macros undefined (-Wundef)

2025-07-03 Thread Scott Kostyshak
On Thu, Jul 03, 2025 at 03:13:44PM +0200, Jean-Marc Lasgouttes wrote: > Le 03/07/2025 à 13:17, Scott Kostyshak a écrit : > > > > > #if defined(USE__func__) && USE__func__ > > > > > > I removed the use of USE__func__. Nothing of value has been lost. &

Re: Two macros undefined (-Wundef)

2025-07-03 Thread Scott Kostyshak
On Thu, Jul 03, 2025 at 12:29:59PM +0200, Jean-Marc Lasgouttes wrote: > Le 03/07/2025 à 12:17, Kornel Benko a écrit : > > Am Thu, 3 Jul 2025 12:06:42 +0200 > > schrieb Scott Kostyshak : > > > > > I get multiple warnings (from GCC and Clang) when compiling with -Wund

Two macros undefined (-Wundef)

2025-07-03 Thread Scott Kostyshak
I get multiple warnings (from GCC and Clang) when compiling with -Wundef about two main issues: src/support/FileName.cpp:687:7: warning: 'MKDIR_TAKES_ONE_ARG' is not defined, evaluates to 0 [-Wundef] src/tests/../support/debug.h:221:5: warning: 'USE__func__' is not defined, evaluates to 0 [-

Re: 5 warnings from -Woverloaded-virtual (Koji?)

2025-07-02 Thread Scott Kostyshak
On Thu, Jul 03, 2025 at 12:10:10AM +0200, Jean-Marc Lasgouttes wrote: > Le 02/07/2025 à 18:16, Scott Kostyshak a écrit : > > Compiling with GCC and -Woverloaded-virtual gives 5 warnings. Are they > > worth addressing? > > > > From what I understand, the main way to a

5 warnings from -Woverloaded-virtual

2025-07-02 Thread Scott Kostyshak
Compiling with GCC and -Woverloaded-virtual gives 5 warnings. Are they worth addressing? From what I understand, the main way to address them is via a "using" statement (https://stackoverflow.com/questions/18515183/c-overloaded-virtual-function-warning-by-clang) src/insets/Inset.h:217:22: warning

Re: One last (I think) casting away of qualifiers

2025-07-02 Thread Scott Kostyshak
On Wed, Jul 02, 2025 at 01:02:52PM +0200, Jean-Marc Lasgouttes wrote: > Le 02/07/2025 à 11:17, Scott Kostyshak a écrit : > > The attached patch just initializes demangled without const to begin > > with. Is it OK? The side effect is of course that in the call to .arg(), > &

One last (I think) casting away of qualifiers

2025-07-02 Thread Scott Kostyshak
Here is the GCC warning: src/support/lassert.cpp:145:22: warning: cast from type ‘const char*’ to type ‘void*’ casts away qualifiers [-Wcast-qual] 145 | free((void*)demangled); | ^~~~ And here is the code: const char* dema

Re: [LyX/master] Add \cpageref to context menus

2025-07-01 Thread Scott Kostyshak
On Tue, Jul 01, 2025 at 01:56:25PM +0200, Jürgen Spitzmüller wrote: > Am Dienstag, dem 01.07.2025 um 00:19 +0200 schrieb Scott Kostyshak: > > The above code triggers a warning: > > > > src/frontends/qt/TocWidget.cpp:188:11: warning: 'return' will never > > b

Removing a duplicate declaration

2025-07-01 Thread Scott Kostyshak
src/support/docstring.h:120:6: warning: redundant redeclaration of ‘bool lyx::operator==(const docstring&, const char*)’ in same scope [-Wredundant-decls] 120 | bool operator==(docstring const &, char const *); | ^~~~ src/support/docstring.h:65:6: note: previous declaration of ‘b

Re: patch: make a const cast explicit

2025-07-01 Thread Scott Kostyshak
On Tue, Jul 01, 2025 at 10:37:02AM +0200, Jean-Marc Lasgouttes wrote: > Le 30/06/2025 à 23:40, Scott Kostyshak a écrit : > > Clang gives the following warning: > > > > src/frontends/qt/GuiAlert.cpp:55:33: warning: cast from 'const char *' to > > '

Re: patch: include the .h file, not the .cpp file

2025-07-01 Thread Scott Kostyshak
On Tue, Jul 01, 2025 at 02:39:47AM +0200, Pavel Sanda wrote: > On Tue, Jul 01, 2025 at 12:03:20AM +0200, Scott Kostyshak wrote: > > Is the attached patch OK? > > Looks ok to me. P Thanks, it's in master at 22b35872. Scott signature.asc Description: PGP signature -- lyx-de

Re: [LyX/master] Add \cpageref to context menus

2025-06-30 Thread Scott Kostyshak
On Mon, Apr 28, 2025 at 09:47:24AM +, Juergen Spitzmueller wrote: > commit 9f6c452a5b4e444ab24903ff7d7ba17c1ef74985 > Author: Juergen Spitzmueller > Date: Mon Apr 28 11:46:56 2025 +0200 > > Add \cpageref to context menus > --- ... > + case LFUN_REFERENCE_TO_PARAGRAPH: { > +

patch: include the .h file, not the .cpp file

2025-06-30 Thread Scott Kostyshak
From: Scott Kostyshak Date: Mon, 30 Jun 2025 23:54:53 +0200 Subject: [PATCH] Include the .h file, not the .cpp file --- src/factory.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/factory.cpp b/src/factory.cpp index 310fbb8b86..b72e24ec39 100644 --- a/src/factory.cpp +++

patch: make a const cast explicit

2025-06-30 Thread Scott Kostyshak
Sep 17 00:00:00 2001 From: Scott Kostyshak Date: Mon, 30 Jun 2025 23:19:47 +0200 Subject: [PATCH] Make a const cast explicit This addresses the following Clang warning: src/frontends/qt/GuiAlert.cpp:55:33: warning: cast from 'const char *' to 'char *' drops const qualifier [

Re: Float equality warnings

2025-06-30 Thread Scott Kostyshak
On Mon, Jun 30, 2025 at 02:58:43PM +0200, Jürgen Spitzmüller wrote: > Am Montag, dem 30.06.2025 um 14:28 +0200 schrieb Jean-Marc Lasgouttes: > > I agree that normally there is no problem. OTOH, Lentgth::operator= > > could allow for a 1% relative error, for example. > > Certainly. Thanks for the

Re: Float conversion warnings

2025-06-30 Thread Scott Kostyshak
On Sun, Jun 29, 2025 at 05:55:08PM +0100, José Matos wrote: > On Sun, 2025-06-29 at 15:28 +0200, Scott Kostyshak wrote: > > Are these worth looking into? > > AFAICS all of these seem harmless. Thanks for taking a look, Riki and José! José, your explanation is very helpful sin

Float equality warnings

2025-06-29 Thread Scott Kostyshak
Should we use some kind of tolerance value, e.g., based on std::numeric_limits::epsilon and std::numeric_limits::epsilon ? /home/scott/lyxbuilds/master-master/repo/src/support/Length.h:119:22: warning: comparing floating point with == or != is unsafe [-Wfloat-equal] 119 | { return l1.va

Float conversion warnings

2025-06-29 Thread Scott Kostyshak
Are these worth looking into? /home/scott/lyxbuilds/master-master/repo/src/mathed/InsetMathBig.cpp:85:17: warning: implicit conversion from 'size_type' (aka 'unsigned long') to 'double' may lose precision [-Wimplicit-int-float-conversion] 85 | return (size() + 1) * 0.3; |

Re: What do you think about shadow warnings for LyX code by compilers [-Wshadow] ?

2025-06-29 Thread Scott Kostyshak
On Sat, Jun 28, 2025 at 07:07:46PM +0200, Jean-Marc Lasgouttes wrote: > Le 28/06/2025 à 18:22, Richard Kimberly Heck a écrit : > > On 6/28/25 9:07 AM, Scott Kostyshak wrote: > > > I'm wondering if you think it would be a (even trivial) improvement to > > > fix warni

Re: patch: have configure.py print to STDOUT, not STDERR

2025-06-27 Thread Scott Kostyshak
On Fri, Jun 27, 2025 at 10:37:05AM +0200, Jean-Marc Lasgouttes wrote: > Le 27 juin 2025 10:26:32 GMT+02:00, Scott Kostyshak a > écrit : > >Thanks, José for your follow-up commit. These last days I've been > >focused mainly on compiler warnings. And also seeing if anyth

Re: patch: have configure.py print to STDOUT, not STDERR

2025-06-27 Thread Scott Kostyshak
On Fri, Jun 27, 2025 at 07:59:23AM +0100, José Matos wrote: > On Thu, 2025-06-26 at 22:17 +0200, Enrico Forestieri wrote: > > Because we love tradition and this is lost in the mists of time? ;-) > > > > https://www.mail-archive.com/lyx-devel@lists.lyx.org/msg96750.html > > Now is the time to star

Re: patch: have configure.py print to STDOUT, not STDERR

2025-06-26 Thread Scott Kostyshak
On Thu, Jun 26, 2025 at 05:28:19PM +0100, José Matos wrote: > On Thu, 2025-06-26 at 00:21 +0200, Scott Kostyshak wrote: > > Currently, configure.py prints output to STDERR, even though they are > > not necessarily warnings or errors. > > I can understand why the logg

Re: underbar

2025-06-26 Thread Scott Kostyshak
On Thu, Jun 26, 2025 at 09:50:09PM +0200, Enrico Forestieri wrote: > On Thu, Jun 26, 2025 at 10:42:56AM +0200, Scott Kostyshak wrote: > > On Wed, Jun 25, 2025 at 11:57:23PM +0200, Enrico Forestieri wrote: > > > On Sat, Jun 14, 2025 at 11:18:57PM +0200, Scott Kostyshak wrote: &g

Re: Thread sanitizer warnings

2025-06-26 Thread Scott Kostyshak
On Thu, Jun 26, 2025 at 10:33:28PM +0200, Scott Kostyshak wrote: > Can anyone make sense of the attached warnings about thread safety? > > I'd be particularly curious if you have any intuition to share for how > to figure out whether it's an issue due to Qt or LyX. > &

Thread sanitizer warnings

2025-06-26 Thread Scott Kostyshak
Can anyone make sense of the attached warnings about thread safety? I'd be particularly curious if you have any intuition to share for how to figure out whether it's an issue due to Qt or LyX. Scott == WARNING: ThreadSanitizer: data race (pid=397551) Read of size 8 at 0x720c

Re: \underbar

2025-06-26 Thread Scott Kostyshak
On Wed, Jun 25, 2025 at 11:57:23PM +0200, Enrico Forestieri wrote: > On Sat, Jun 14, 2025 at 11:18:57PM +0200, Scott Kostyshak wrote: > > When I enter math mode and type \underbar, the cursor is placed outside > > of the box. I expected for it to be placed inside. I'm guessing

patch: have configure.py print to STDOUT, not STDERR

2025-06-25 Thread Scott Kostyshak
r... +checking for "xfig"... no +checking for "jfig3-itext.jar"... no +checking for "jfig3.jar"... no checking for a Dia viewer and editor... +checking for "dia"... yes ... Is the patch OK? Scott From 38fc0c3ba5ab0cf82c2ae764e62b16c8dd9fb769 Mon Sep 1

Re: Can't compile math manual

2025-06-18 Thread Scott Kostyshak
On Wed, Jun 18, 2025 at 05:02:47PM +0200, Jürgen Spitzmüller wrote: > Am Dienstag, dem 17.06.2025 um 22:59 +0200 schrieb Scott Kostyshak: > > Works well. Committed at fa6fa1f6. > > Meanwhile I had a closer look. With LyX's native \cmidrule support, the > case of activ

Re: Give an error if missing cross-reference in final compilation

2025-06-18 Thread Scott Kostyshak
On Wed, Jun 18, 2025 at 09:13:13AM +0200, Pavel Sanda wrote: > On Tue, Jun 17, 2025 at 11:07:54PM +0200, Scott Kostyshak wrote: > > Now User Guide fails to compile. I imagine your fix now correctly flags > > warnings that were already there, which is a nice improvement.

Re: Give an error if missing cross-reference in final compilation

2025-06-17 Thread Scott Kostyshak
On Tue, Jun 17, 2025 at 06:38:30PM +0200, Scott Kostyshak wrote: > On Tue, Jun 17, 2025 at 06:19:38PM +0200, Jürgen Spitzmüller wrote: > > Am Dienstag, dem 17.06.2025 um 15:00 +0200 schrieb Scott Kostyshak: > > > Can anyone else test and see if LyX (correctly) giv

Re: Can't compile math manual

2025-06-17 Thread Scott Kostyshak
On Tue, Jun 17, 2025 at 06:50:59PM +0200, Scott Kostyshak wrote: > On Tue, Jun 17, 2025 at 06:48:01PM +0200, Jürgen Spitzmüller wrote: > > Am Dienstag, dem 17.06.2025 um 18:11 +0200 schrieb Scott Kostyshak: > > > > > Or rather > > > > > \AtBeginDocume

Re: Can't compile math manual

2025-06-17 Thread Scott Kostyshak
On Tue, Jun 17, 2025 at 06:48:01PM +0200, Jürgen Spitzmüller wrote: > Am Dienstag, dem 17.06.2025 um 18:11 +0200 schrieb Scott Kostyshak: > > > > Or rather > > > > \AtBeginDocument{\shorthandoff{-}} > > > > > > I committed this one. Thanks, > >

Re: Give an error if missing cross-reference in final compilation

2025-06-17 Thread Scott Kostyshak
On Tue, Jun 17, 2025 at 06:19:38PM +0200, Jürgen Spitzmüller wrote: > Am Dienstag, dem 17.06.2025 um 15:00 +0200 schrieb Scott Kostyshak: > > Can anyone else test and see if LyX (correctly) gives an error during > > compilation? > > Fixed. The problem was that your label con

Re: Can't compile math manual

2025-06-17 Thread Scott Kostyshak
On Mon, Jun 16, 2025 at 11:04:13PM +0200, Pavel Sanda wrote: > On Mon, Jun 16, 2025 at 08:08:57PM +0200, Jürgen Spitzmüller wrote: > > Am Montag, dem 16.06.2025 um 16:55 +0200 schrieb Pavel Sanda: > > > I do not see anything cz-related in our preamble but exported .tex > > > source on my machine ad

Re: Give an error if missing cross-reference in final compilation

2025-06-17 Thread Scott Kostyshak
On Tue, Jun 17, 2025 at 02:52:36PM +0200, Pavel Sanda wrote: > On Tue, Jun 17, 2025 at 10:50:59AM +0200, Scott Kostyshak wrote: > > On Tue, Jun 17, 2025 at 10:40:18AM +0200, Pavel Sanda wrote: > > > On Tue, Jun 17, 2025 at 09:56:47AM +0200, Scott Kostyshak wrote: > > &g

Re: Give an error if missing cross-reference in final compilation

2025-06-17 Thread Scott Kostyshak
On Tue, Jun 17, 2025 at 10:40:18AM +0200, Pavel Sanda wrote: > On Tue, Jun 17, 2025 at 09:56:47AM +0200, Scott Kostyshak wrote: > > I recently ran into an issue [1] where one of my labels did not get > > defined properly and so the reference did not work. But I didn't realize

Give an error if missing cross-reference in final compilation

2025-06-17 Thread Scott Kostyshak
I recently ran into an issue [1] where one of my labels did not get defined properly and so the reference did not work. But I didn't realize it because LaTeX cannot easily give an error in this case, I think because it doesn't know if it's the last compilation. Would this be a nice feature for LyX

\underbar

2025-06-14 Thread Scott Kostyshak
When I enter math mode and type \underbar, the cursor is placed outside of the box. I expected for it to be placed inside. I'm guessing it has something to do with \underbar being wrapped in \text{}. Interestingly, if I do alt+m,_ then I get $\underbar{}$ and the cursor has correct placement. S

Re: An instance of -Wnested-anon-types

2025-06-12 Thread Scott Kostyshak
On Thu, Jun 12, 2025 at 10:18:20AM +0200, Scott Kostyshak wrote: > On Thu, Jun 12, 2025 at 01:05:35AM +0200, Jean-Marc Lasgouttes wrote: > > Le 07/06/2025 à 01:14, Scott Kostyshak a écrit : > > > With Clang and -pedantic, I get the following: > > > > > > /hom

Re: An instance of -Wnested-anon-types

2025-06-12 Thread Scott Kostyshak
On Thu, Jun 12, 2025 at 01:05:35AM +0200, Jean-Marc Lasgouttes wrote: > Le 07/06/2025 à 01:14, Scott Kostyshak a écrit : > > With Clang and -pedantic, I get the following: > > > > /home/scott/lyxbuilds/master-master/repo/src/TexRow.h:73:4: warning: > > anonymous typ

Re: A few instances of -Wdeprecated-copy-with-user-provided-copy

2025-06-12 Thread Scott Kostyshak
On Thu, Jun 12, 2025 at 12:59:47AM +0200, Jean-Marc Lasgouttes wrote: > Le 07/06/2025 à 01:00, Scott Kostyshak a écrit : > > When I compile with -Wextra with Clang, I get the following: > > Actually, autotools already compiles with -Wextra, but -Wno-deprecated-copy > is use

Re: A few instances of -Wdeprecated-copy-with-user-provided-copy

2025-06-09 Thread Scott Kostyshak
On Mon, Jun 09, 2025 at 08:26:24PM +0200, Jean-Marc Lasgouttes wrote: > Le 07/06/2025 à 01:00, Scott Kostyshak a écrit : > > When I compile with -Wextra with Clang, I get the following: > > > > /home/scott/lyxbuilds/master-master/repo/src/Bullet.h:53:11: warning: > >

Re: [LyX/master] Introducing LaTeX support for \intertext and \shortintertext

2025-06-08 Thread Scott Kostyshak
On Sun, Jun 08, 2025 at 09:36:34AM +0200, Kornel Benko wrote: > Am Sun, 8 Jun 2025 10:57:05 +0900 > schrieb Koji Yokota : > > > > > > 2025/06/05 3:46、Scott Kostyshak のメール: > > > > > > This commit broke some ctests: > > > > >

Re: [LyX/master] Fix incorrect escape in a QString

2025-06-07 Thread Scott Kostyshak
On Sat, Jun 07, 2025 at 11:40:05AM +0200, Pavel Sanda wrote: > On Fri, Jun 06, 2025 at 11:32:53PM +0000, Scott Kostyshak wrote: > > commit 64789ba422bdec692288f9c2e48299d6708b3741 > > Author: Scott Kostyshak > > Date: Sat Jun 7 01:22:55 2025 +0200 > > > >

  1   2   3   4   5   6   7   8   9   10   >