Re: Deps for LyX 2.5: GCC 8.5, Qt 5.12, Python 3.8

2024-10-22 Thread Richard Kimberly Heck
On 10/22/24 12:04 PM, Jean-Marc Lasgouttes wrote: Le 22/10/2024 à 16:50, Pavel Sanda a écrit : On Tue, Oct 22, 2024 at 04:34:29PM +0200, Jean-Marc Lasgouttes wrote: What I meant was mainly that we could delete specific ifdefs for gcc < 8 if there any in the code. We have a test for C++14 I

Re: [LyX/master] Fix dark/light mode setting and run-time switch with Qt 6.8

2024-10-22 Thread Yu Jin
Am Di., 22. Okt. 2024 um 19:08 Uhr schrieb Yu Jin : > Am Di., 22. Okt. 2024 um 17:30 Uhr schrieb Jürgen Spitzmüller < > jspi...@gmail.com>: > >> Am Dienstag, dem 22.10.2024 um 17:12 +0200 schrieb Yu Jin: >> > A runtime switch? I don't see any switch, The only switch I get is >> > when using #12224

Re: [LyX/master] Fix dark/light mode setting and run-time switch with Qt 6.8

2024-10-22 Thread Yu Jin
Am Di., 22. Okt. 2024 um 17:30 Uhr schrieb Jürgen Spitzmüller < jspi...@gmail.com>: > Am Dienstag, dem 22.10.2024 um 17:12 +0200 schrieb Yu Jin: > > A runtime switch? I don't see any switch, The only switch I get is > > when using #12224 patch. > > On Linux and Mac, when switching the OS between d

Re: Deps for LyX 2.5: GCC 8.5, Qt 5.12, Python 3.8

2024-10-22 Thread Jean-Marc Lasgouttes
Le 22/10/2024 à 16:50, Pavel Sanda a écrit : On Tue, Oct 22, 2024 at 04:34:29PM +0200, Jean-Marc Lasgouttes wrote: What I meant was mainly that we could delete specific ifdefs for gcc < 8 if there any in the code. We have a test for C++14 IMHO we can drop C++14 test as it's default since GCC

Re: [LyX/master] Fix dark/light mode setting and run-time switch with Qt 6.8

2024-10-22 Thread Jürgen Spitzmüller
Am Dienstag, dem 22.10.2024 um 17:12 +0200 schrieb Yu Jin: > A runtime switch? I don't see any switch, The only switch I get is > when using #12224 patch. On Linux and Mac, when switching the OS between dark and light, an opened LyX instance inherits this switch automatically. AFAIK this didn't wo

Re: [LyX/master] Fix dark/light mode setting and run-time switch with Qt 6.8

2024-10-22 Thread Yu Jin
Am Di., 22. Okt. 2024 um 09:30 Uhr schrieb Jürgen Spitzmüller < jspi...@gmail.com>: > Am Montag, dem 21.10.2024 um 20:52 +0200 schrieb Yu Jin: > > Can you help me out? What exactly do I need to test here? > > A runtime switch of (dark/light) mode should work now. A runtime switch? I don't see an

Re: Deps for LyX 2.5: GCC 8.5, Qt 5.12, Python 3.8

2024-10-22 Thread Jean-Marc Lasgouttes
Le 22/10/2024 à 16:50, Pavel Sanda a écrit : On Tue, Oct 22, 2024 at 04:34:29PM +0200, Jean-Marc Lasgouttes wrote: What I meant was mainly that we could delete specific ifdefs for gcc < 8 if there any in the code. We have a test for C++14 IMHO we can drop C++14 test as it's default since GCC

Re: Deps for LyX 2.5: GCC 8.5, Qt 5.12, Python 3.8 (was: GCC >= 5?)

2024-10-22 Thread Pavel Sanda
On Tue, Oct 22, 2024 at 04:34:29PM +0200, Jean-Marc Lasgouttes wrote: > > What I meant was mainly that we could delete specific ifdefs for gcc < 8 if > > there any in the code. > > We have a test for C++14 IMHO we can drop C++14 test as it's default since GCC 6.1. > one for C++17 (any.h). We can

Re: Deps for LyX 2.5: GCC 8.5, Qt 5.12, Python 3.8 (was: GCC >= 5?)

2024-10-22 Thread Jean-Marc Lasgouttes
Le 22/10/2024 à 16:30, Pavel Sanda a écrit : On Tue, Oct 22, 2024 at 03:52:40PM +0200, Jean-Marc Lasgouttes wrote: Do you plan to do the clenaup wrt ifdefs? I can. Instead of compiler versions, we could check for the features we want (like we do now in LYX_CXX_CXX11_FLAGS (config/lyxinclude.m4

Re: Deps for LyX 2.5: GCC 8.5, Qt 5.12, Python 3.8 (was: GCC >= 5?)

2024-10-22 Thread Pavel Sanda
On Tue, Oct 22, 2024 at 03:52:40PM +0200, Jean-Marc Lasgouttes wrote: > > Do you plan to do the clenaup wrt ifdefs? > > I can. Instead of compiler versions, we could check for the features we want > (like we do now in LYX_CXX_CXX11_FLAGS (config/lyxinclude.m4)) from C++17. > Would you have a snipp

Re: Deps for LyX 2.5: GCC 8.5, Qt 5.12, Python 3.8 (was: GCC >= 5?)

2024-10-22 Thread Jean-Marc Lasgouttes
Le 22/10/2024 à 15:11, Pavel Sanda a écrit : On Tue, Oct 22, 2024 at 01:18:45PM +0200, Jean-Marc Lasgouttes wrote: Le 22/10/2024 ?? 11:35, Pavel Sanda a écrit : Yes, I think we can bump to GCC 8.5 and Qt 5.12. 8.5 or 8, I guess. They should be equivalent, except for bugs. Agreed. If someo

Re: Deps for LyX 2.5: GCC 8.5, Qt 5.12, Python 3.8 (was: GCC >= 5?)

2024-10-22 Thread Pavel Sanda
On Tue, Oct 22, 2024 at 01:18:45PM +0200, Jean-Marc Lasgouttes wrote: > Le 22/10/2024 ?? 11:35, Pavel Sanda a écrit : > > Yes, I think we can bump to GCC 8.5 and Qt 5.12. > > 8.5 or 8, I guess. They should be equivalent, except for bugs. Agreed. > > If someone wants to go through the sources and

endResetModel called without calling beginResetModel first

2024-10-22 Thread Jürgen Spitzmüller
When launching master built against Qt 6.8, I am getting this warning (repeatedly): endResetModel called on QSortFilterProxyModel(0x30f83400) without calling beginResetModel first I have inspected our uses of endResetModel, but I don't see that it is called without a previous beginResetModel. Do

Re: Noticing runtime error in socktools.cpp

2024-10-22 Thread Jean-Marc Lasgouttes
Le 22/10/2024 à 14:00, Kornel Benko a écrit : It is not compilation which gives the error output. Start the debug-version of lyx from the build directory: $ ./bin/lyx2.5 /usr2/src/lyx/lyx-git/src/support/socktools.cpp:121:56: runtime error: member access within null pointer of type 'struct so

Re: Noticing runtime error in socktools.cpp

2024-10-22 Thread Scott Kostyshak
On Tue, Oct 22, 2024 at 02:00:28PM GMT, Kornel Benko wrote: > Am Tue, 22 Oct 2024 13:20:01 +0200 > schrieb Jean-Marc Lasgouttes : > > > Le 22/10/2024 à 12:27, Scott Kostyshak a écrit : > > > On Wed, Sep 18, 2024 at 10:06:58AM GMT, Kornel Benko wrote: > > >> Lyx compiled with -fsanitize=undefined

Re: Noticing runtime error in socktools.cpp

2024-10-22 Thread Kornel Benko
Am Tue, 22 Oct 2024 13:20:01 +0200 schrieb Jean-Marc Lasgouttes : > Le 22/10/2024 à 12:27, Scott Kostyshak a écrit : > > On Wed, Sep 18, 2024 at 10:06:58AM GMT, Kornel Benko wrote: > >> Lyx compiled with -fsanitize=undefined gives this at start: > >> > >> /usr2/src/lyx/lyx-git/src/support/sockto

Re: Noticing runtime error in socktools.cpp

2024-10-22 Thread Jean-Marc Lasgouttes
Le 22/10/2024 à 12:27, Scott Kostyshak a écrit : On Wed, Sep 18, 2024 at 10:06:58AM GMT, Kornel Benko wrote: Lyx compiled with -fsanitize=undefined gives this at start: /usr2/src/lyx/lyx-git/src/support/socktools.cpp:121:56: runtime error: member access within null pointer of type 'struct sock

Re: Deps for LyX 2.5: GCC 8.5, Qt 5.12, Python 3.8 (was: GCC >= 5?)

2024-10-22 Thread Jean-Marc Lasgouttes
Le 22/10/2024 à 11:35, Pavel Sanda a écrit : Yes, I think we can bump to GCC 8.5 and Qt 5.12. 8.5 or 8, I guess. They should be equivalent, except for bugs. If someone wants to go through the sources and cleanup ifdefs we can switch anytime. By doing this we should get access to C++17, so m

Re: Noticing runtime error in socktools.cpp

2024-10-22 Thread Scott Kostyshak
On Wed, Sep 18, 2024 at 10:06:58AM GMT, Kornel Benko wrote: > Lyx compiled with -fsanitize=undefined gives this at start: > > /usr2/src/lyx/lyx-git/src/support/socktools.cpp:121:56: runtime error: member > access > within null pointer of type 'struct sockaddr_un' #0 0x5570c33ba6c8 in > lyx::suppo

Re: GCC >= 5?

2024-10-22 Thread Pavel Sanda
On Mon, Oct 21, 2024 at 06:04:23PM +0100, José Matos wrote: > https://devguide.python.org/versions/ > > So you need to trust an external entity to rely on its maintenance. Which is exactly what you do when using linux distribution. > Are you telling me that a version released more than 5 years a

Deps for LyX 2.5: GCC 8.5, Qt 5.12, Python 3.8 (was: GCC >= 5?)

2024-10-22 Thread Pavel Sanda
On Mon, Oct 21, 2024 at 04:29:19PM +0200, Jean-Marc Lasgouttes wrote: > My conclusion is that it would only be nice to use with C++20 where one can > use constinit to force a function to be computed at compilation time. Then > we would be able to have: > docstring const var = "sôme ascii text"_asc

Re: Removal of functional.h

2024-10-22 Thread Jean-Marc Lasgouttes
Le 21/10/2024 à 21:46, Pavel Sanda a écrit : Hi, after requiring C+11 & purging boost includes from functional.h, the leftover stub is IMHO ready to go, see attached. Go for it. JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org https://lists.lyx.org/mailman/listinfo/lyx-devel

Re: [LyX/master] Fix dark/light mode setting and run-time switch with Qt 6.8

2024-10-22 Thread Jürgen Spitzmüller
Am Montag, dem 21.10.2024 um 19:12 +0200 schrieb Stephan Witt: > In general Qt6.8 is announced to support macOS 12, 13, 14, 15. So we > will loose many elder target platforms we currently support. I'm not proposing that we generally switch to 6.8., I just want to make sure it works on Mac, and the

Re: [LyX/master] Fix dark/light mode setting and run-time switch with Qt 6.8

2024-10-22 Thread Jürgen Spitzmüller
Am Montag, dem 21.10.2024 um 20:52 +0200 schrieb Yu Jin: > Can you help me out? What exactly do I need to test here?  A runtime switch of (dark/light) mode should work now. At least there should be no drawbacks as far as dark/light mode setting on Windows are concerned. > Does it correlate with #