On 11/6/20 7:37 PM, Jean-Marc Lasgouttes wrote:
> Le 06/11/2020 à 17:29, Richard Kimberly Heck a écrit :
>> This method is commented out ostensibly because the current
>> implementation
>>
>> bool operator==(ParConstIterator const & iter1, ParConstIterator
>> const & iter2)
>> {
>> // FIXME: t
On 11/6/20 7:37 PM, Jean-Marc Lasgouttes wrote:
> Le 06/11/2020 à 17:29, Richard Kimberly Heck a écrit :
>> This method is commented out ostensibly because the current
>> implementation
>>
>> bool operator==(ParConstIterator const & iter1, ParConstIterator
>> const & iter2)
>> {
>> // FIXME: t
Hi
The 2.4.0 release mostly seems to work fine on Catalina so far.
But the default settings don't work well in dark mode (screenshot attached).
Also, the color dialog can get hidden behind the main window, which causes
confusion when trying to reset the colors.
And I would suggest that it would
Le 06/11/2020 à 17:29, Richard Kimberly Heck a écrit :
This method is commented out ostensibly because the current implementation
bool operator==(ParConstIterator const & iter1, ParConstIterator const &
iter2)
{
// FIXME: this makes two full copies!
return DocIterator(iter1) == DocIt
Le 06/11/2020 à 23:53, Yuriy Skalko a écrit :
Yes, RefChanger is an interesting approach, it will be better than stack.
This NewOutputParams class looks like variation of the RefChanger. Right?
I understand how RefChanger works, but Changer is a strange thing. How
can it work with empty funct
On Sat, Nov 07, 2020 at 12:53:33AM +0200, Yuriy Skalko wrote:
> P.S. I've tried to search for some docs on Changers in LyX repository and
> found this useful document: development/coding/CodingRulesAndAdvice.lyx.
> Maybe it will be reasonable to merge it into lib/doc/Development.lyx so that
> deve
I started a patch some time ago trying something like that method for
OutputParams generally. The destuctor for the new instance copied relevant
changes back to the one one. Basically something like:
class NewOutputParams : public OutputParams {
explicit NewOutputParams(OutputParams & oldo
On 11/6/20 11:13 AM, Richard Kimberly Heck wrote:
On 11/5/20 5:43 AM, Yuriy Skalko wrote:
Yes, updateMacros is a pain, it is actually a O(n^2) algorithm which
kills performance for big documents. But it is a bit scary and I
never dared changing it :)
JMarc
Yes, macros implementation is real
This method is commented out ostensibly because the current implementation
bool operator==(ParConstIterator const & iter1, ParConstIterator const &
iter2)
{
// FIXME: this makes two full copies!
return DocIterator(iter1) == DocIterator(iter2);
}
made two copies, so was expensive. But w
On 11/5/20 5:43 AM, Yuriy Skalko wrote:
Yes, updateMacros is a pain, it is actually a O(n^2) algorithm which
kills performance for big documents. But it is a bit scary and I
never dared changing it :)
JMarc
Yes, macros implementation is really tangled. Maybe at first we can
try to minimize
On 11/6/20 5:26 AM, Jean-Marc Lasgouttes wrote:
Le 06/11/2020 à 10:57, Yuriy Skalko a écrit :
And to implement for OutputContext the push/pop operations (with
internal stack) to save/restore parent context (when needed to do
local changes) or directly modify parent context if changes should be
Le 06/11/2020 à 10:57, Yuriy Skalko a écrit :
And to implement for OutputContext the push/pop operations (with
internal stack) to save/restore parent context (when needed to do local
changes) or directly modify parent context if changes should be
propagated on the higher level.
Or use Changer
Yes, I looked at it but didn't have time then to comment.
It's fine as far as it goes, but I was thinking something somewhat different.
Others can chime in, perhaps, but I think there's a reason that OutputParams
was always supposed to be passed as const. At least, it began life as precisely
w
13 matches
Mail list logo
