Am Samstag, den 03.10.2020, 08:18 +0200 schrieb Jürgen Spitzmüller:
> > > We can probably omit the mark if the ref is in the same non-
> > > outputting
> > > context (or generally if it is in a non-outputting context
> itself).
> >
> > This indeed corresponds to the behavior I was expecting.
>
>
Am Freitag, den 02.10.2020, 16:09 -0400 schrieb Scott Kostyshak:
> On Fri, Oct 02, 2020 at 08:35:16AM +0200, Jürgen Spitzmüller wrote:
> > Am Donnerstag, den 01.10.2020, 17:21 -0400 schrieb Scott Kostyshak:
> > > Starting with this commit, if a deactivated branch has a
> > > reference to
> > > a la
On Fri, Oct 02, 2020 at 09:05:13PM +0300, Yuriy Skalko wrote:
> I've done some refactorings based on suggestions from cppcheck analyzer.
Looks good. Pavel
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel
On Fri, Oct 02, 2020 at 04:08:48PM -0400, Scott Kostyshak wrote:
> On Fri, Oct 02, 2020 at 01:43:00PM +0200, Jean-Marc Lasgouttes wrote:
> > Le 02/10/2020 à 01:25, Scott Kostyshak a écrit :
> > > I was not following my recipe carefully enough. I indeed cannot reproduce.
> > >
> > > Here is a diffe
> Actually, boost 1.74 only uses override in a handful of cases. Not worth
> updating now.
>
> Therefore, it does not seem doable to use -Wsuggest-override with gcc.
>
> JMarc
This should be useful to disable such warnings from boost:
https://stackoverflow.com/questions/3308523/how-to-eliminate
On 10/2/20 2:05 PM, Yuriy Skalko wrote:
> I've done some refactorings based on suggestions from cppcheck analyzer.
> diff --git a/src/lyxfind.cpp b/src/lyxfind.cpp
> index c3b59bb302..5f9e2d3093 100644
> --- a/src/lyxfind.cpp
> +++ b/src/lyxfind.cpp
> @@ -357,11 +357,10 @@ pair replaceOne(BufferVie
On 10/2/20 11:10 AM, Jean-Marc Lasgouttes wrote:
> Le 02/10/2020 à 15:46, Richard Kimberly Heck a écrit :
>>> @@ -972,7 +972,7 @@ MathClass MathData::lastMathClass() const
>>> for (MathAtom const & at : *this) {
>>> MathClass mc = at->mathClass();
>>> if (mc != MC_UNKNOWN)
On Fri, Oct 02, 2020 at 08:35:16AM +0200, Jürgen Spitzmüller wrote:
> Am Donnerstag, den 01.10.2020, 17:21 -0400 schrieb Scott Kostyshak:
> > Starting with this commit, if a deactivated branch has a reference to
> > a label that's in the same branch,
> > the reference is marked as "BROKEN". See att
On Fri, Oct 02, 2020 at 12:20:34PM +0200, Jean-Marc Lasgouttes wrote:
> Le 02/10/2020 à 02:15, Scott Kostyshak a écrit :
> > Sure, bisect leads to f96b99dc.
>
> Thanks a lot. Should be fixed now (and a bonus fix that will probably have
> some use).
Thanks, works well.
Scott
signature.asc
Descr
On Fri, Oct 02, 2020 at 01:43:00PM +0200, Jean-Marc Lasgouttes wrote:
> Le 02/10/2020 à 01:25, Scott Kostyshak a écrit :
> > I was not following my recipe carefully enough. I indeed cannot reproduce.
> >
> > Here is a different recipe that shows a similar issue:
> >
> > 1. Open the attached .lyx
I've done some refactorings based on suggestions from cppcheck analyzer.
Yuriy
From ac663a3837b7ef425c852aedf2731ec5aa3079c2 Mon Sep 17 00:00:00 2001
From: Yuriy Skalko
Date: Thu, 1 Oct 2020 13:34:15 +0300
Subject: [PATCH] Refactoring based on cppcheck suggestions
---
src/Author.cpp
> I just did that and see that many files have now been handled, probably
> because cppcheck did not warn about Qt headers: GuiView.h, GuiWorkArea.h...
>
>
> Here is a log file for your enjoyment.
>
> I'll try to handle the boost part by updating our local copy to the latest
> version 1.74 (wh
Le 02/10/2020 à 19:11, Richard Kimberly Heck a écrit :
On 10/2/20 12:29 PM, Jean-Marc Lasgouttes wrote:
/// Does an optional argument follow after the current token?
- bool hasOpt(std::string const l = "[");
+ bool hasOpt(std::string const & l = "[");
I am a bit surprised t
On 10/2/20 12:29 PM, Jean-Marc Lasgouttes wrote:
> /// Does an optional argument follow after the current token?
> - bool hasOpt(std::string const l = "[");
> + bool hasOpt(std::string const & l = "[");
I am a bit surprised that this is allowed---it looks like a reference to
a tempor
Le 02/10/2020 à 15:39, Jean-Marc Lasgouttes a écrit :
Le 02/10/2020 à 15:08, Jean-Marc Lasgouttes a écrit :
A few remarks
* there are places with a double space before 'override'
* it does not make sense to keep 'virtual' when overriding.
Could you fix these issues and make the commit message a
On Friday, October 2, 2020 2:46:30 PM WEST Richard Kimberly Heck wrote:
> This is actually fine. Assignment returns a reference to the thing on
> the left, at least by default. That is why
>
> a = b =c
>
> does what you expect.
>
> See
> https://stackoverflow.com/questions/15292892/what-is-r
Le 02/10/2020 à 15:46, Richard Kimberly Heck a écrit :
@@ -972,7 +972,7 @@ MathClass MathData::lastMathClass() const
for (MathAtom const & at : *this) {
MathClass mc = at->mathClass();
if (mc != MC_UNKNOWN)
- return res = mc;
+
On 10/2/20 5:41 AM, Jean-Marc Lasgouttes wrote:
> commit a97b384b07d81ee33815fd4f0e8a19c8ab2f66ed
> Author: Jean-Marc Lasgouttes
> Date: Fri Oct 2 12:06:32 2020 +0200
>
> Fixup f96b99dc: thinko
>
> Setting the res value and returning from the function at the same time
> does not
Le 02/10/2020 à 15:08, Jean-Marc Lasgouttes a écrit :
A few remarks
* there are places with a double space before 'override'
* it does not make sense to keep 'virtual' when overriding.
Could you fix these issues and make the commit message a bit more
consistent about why we do that?
On my sid
Le 01/10/2020 à 20:40, Yuriy Skalko a écrit :
Hello,
I've added `override` specifiers into the LyX codebase. This will
improve code maintainability in future. To find overridden methods I've
used the Cppcheck static analyzer. Probably some are missed and should
be marked later.
Jean-Marc alread
Le 02/10/2020 à 01:25, Scott Kostyshak a écrit :
I was not following my recipe carefully enough. I indeed cannot reproduce.
Here is a different recipe that shows a similar issue:
1. Open the attached .lyx file.
2. Select all.
3. Type "a".
Cursor is shorter than expected. If you do
4. Backspac
Le 02/10/2020 à 02:15, Scott Kostyshak a écrit :
Sure, bisect leads to f96b99dc.
Thanks a lot. Should be fixed now (and a bonus fix that will probably
have some use).
JMarc
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel
22 matches
Mail list logo
