Re: [PATCH] Fix uninitialized variable with wrong type

2020-09-09 Thread Kornel Benko
Am Wed, 9 Sep 2020 22:14:40 +0200 schrieb Kornel Benko : > Am Wed, 9 Sep 2020 22:42:59 +0300 > schrieb Yuriy Skalko : > > > > I meant, > > > if what you done is correct, then also the call in ForkedCalls.cpp should > > > be > > > corrected. > > > > > > Both places refer to WIN32 anyway. > > >

Re: [PATCH] Fix uninitialized variable with wrong type

2020-09-09 Thread Kornel Benko
Am Wed, 9 Sep 2020 22:42:59 +0300 schrieb Yuriy Skalko : > > I meant, > > if what you done is correct, then also the call in ForkedCalls.cpp should > > be > > corrected. > > > > Both places refer to WIN32 anyway. > > > > Kornel > > > Since pclose (Unix) returns signed int and GetEx

Re: [PATCH] Fix uninitialized variable with wrong type

2020-09-09 Thread Yuriy Skalko
> I meant, > if what you done is correct, then also the call in ForkedCalls.cpp should be > corrected. > > Both places refer to WIN32 anyway. > > Kornel Since pclose (Unix) returns signed int and GetExitCodeProcess (Windows) returns unsigned DWORD, and then result is compared with -1 i

Re: Size of space insets seem way too small in master

2020-09-09 Thread Jean-Marc Lasgouttes
Le 09/09/2020 à 13:33, Pavel Sanda a écrit : It's definitely big improvement. I would say that 2.3 version was still better, but I can live with the current version. Let's keep it like that for now then. JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listi

Re: [LyX/master] Implement properly \limits and \nolimits

2020-09-09 Thread Enrico Forestieri
On Wed, Sep 09, 2020 at 12:01:32PM +0200, Jean-Marc Lasgouttes wrote: > Le 09/09/2020 à 11:00, Enrico Forestieri a écrit : > > > Do you have a concrete case in mind where deriving requirements from the > > > contents of the macro goes wrong? Note that in this case, we could decide > > > that the re

Re: Size of space insets seem way too small in master

2020-09-09 Thread Pavel Sanda
On Wed, Sep 09, 2020 at 11:30:25AM +0200, Jean-Marc Lasgouttes wrote: > Le 25/08/2020 ?? 16:24, Pavel Sanda a écrit : > >On Tue, Aug 25, 2020 at 04:23:01PM +0200, Pavel Sanda wrote: > >>>No. Note however that is is a 1 pixel difference. > >> > >>On the screenshot I sent it was 3 pixels for protecte

Re: [LyX/master] Implement properly \limits and \nolimits

2020-09-09 Thread Jean-Marc Lasgouttes
Le 09/09/2020 à 11:00, Enrico Forestieri a écrit : Do you have a concrete case in mind where deriving requirements from the contents of the macro goes wrong? Note that in this case, we could decide that the requirements given to the macro override whatever is decided from its contents. The poin

Re: Size of space insets seem way too small in master

2020-09-09 Thread Jean-Marc Lasgouttes
Le 25/08/2020 à 16:24, Pavel Sanda a écrit : On Tue, Aug 25, 2020 at 04:23:01PM +0200, Pavel Sanda wrote: No. Note however that is is a 1 pixel difference. On the screenshot I sent it was 3 pixels for protected and 1 for thin. 3 pixels *difference* Indeed, I decided at the time hat having

Re: [LyX/master] Implement properly \limits and \nolimits

2020-09-09 Thread Enrico Forestieri
On Wed, Sep 09, 2020 at 10:33:44AM +0200, Jean-Marc Lasgouttes wrote: > Le 09/09/2020 à 01:41, Enrico Forestieri a écrit : > > > No, you did it right. My point was that the other patch was only hiding > > > the problem. > > > > In the absence of comments from JMarc, I committed the patch at fcd14d

Re: Possible regression on master regarding integral limit

2020-09-09 Thread Jean-Marc Lasgouttes
Le 07/09/2020 à 19:10, Scott Kostyshak a écrit : Looks good, thanks for the fix. There is a small difference in exported LaTeX, which is that 2.3.x produces "\int\limits _{" and master does not output a space after limits: "\int\limits_{". I'm guessing this is expected, and the output from master

Re: [LyX/master] Implement properly \limits and \nolimits

2020-09-09 Thread Jean-Marc Lasgouttes
Le 09/09/2020 à 01:41, Enrico Forestieri a écrit : No, you did it right. My point was that the other patch was only hiding the problem. In the absence of comments from JMarc, I committed the patch at fcd14df2. Sorry for not responding earlier. For me the fact that macros take their dependenc