Re: [PATCH] lyxpreview_tools.py: fix a regular expression

2020-02-15 Thread Scott Kostyshak
On Sat, Feb 15, 2020 at 10:26:15PM -0500, Richard Kimberly Heck wrote: > On 2/15/20 10:07 PM, Scott Kostyshak wrote: > > > >> I'm curious, why is it necessary to support Python 2? > > I forget what the discussion is regarding why we chose those versions. > > From what I understand, requiring 2.7 (a

Re: [PATCH] lyxpreview_tools.py: fix a regular expression

2020-02-15 Thread Richard Kimberly Heck
On 2/15/20 10:07 PM, Scott Kostyshak wrote: > >> I'm curious, why is it necessary to support Python 2? > I forget what the discussion is regarding why we chose those versions. > From what I understand, requiring 2.7 (as opposed to some earlier 2.x) > makes things easier. Probably we will not allow

Re: Valgrind "definitely lost" backtrace

2020-02-15 Thread Scott Kostyshak
On Sat, Feb 15, 2020 at 09:42:52PM +0100, Pavel Sanda wrote: > On Fri, Feb 14, 2020 at 08:09:09PM -0500, Scott Kostyshak wrote: > > Thanks to both of you for taking a look. I was hoping to investigate > > this memory leak but it seems to be beyond my knowledge. > > Do you have recipy to reproduce

Re: [PATCH] lyxpreview_tools.py: fix a regular expression

2020-02-15 Thread Scott Kostyshak
On Sat, Feb 15, 2020 at 09:25:40PM +0100, Kornel Benko wrote: > Am Sat, 15 Feb 2020 21:15:17 +0100 > schrieb Kornel Benko : > > > Am Sat, 15 Feb 2020 14:03:43 -0500 > > schrieb Scott Kostyshak : > > > > > Attached is a patch for lyxpreview_tools.py, but I don't know Python > > > well and I don't

Re: [PATCH] lyxpreview_tools.py: fix a regular expression

2020-02-15 Thread Scott Kostyshak
On Sat, Feb 15, 2020 at 07:46:56PM +, Neven Sajko wrote: > Hmm, after looking at the last few commits, it seems this may be a > more involved issue > than I first thought. On the one hand one has to take care to use the > proper choice > between "Unicode" and "byte" strings, Thanks for the sug

Re: [PATCH] lyxpreview_tools.py: fix a regular expression

2020-02-15 Thread Scott Kostyshak
On Sun, Feb 16, 2020 at 01:37:34AM +0100, Enrico Forestieri wrote: > On Sat, Feb 15, 2020 at 02:03:43PM -0500, Scott Kostyshak wrote: > > > Attached is a patch for lyxpreview_tools.py, but I don't know Python > > well and I don't know how to test whether this code works as intended > > now or not.

Re: [RFC][PATCH] Change to GuiView::goToFileRow

2020-02-15 Thread Stephan Witt
Am 16.02.2020 um 01:25 schrieb Enrico Forestieri : > > On Sat, Feb 15, 2020 at 04:09:14PM +0100, Stephan Witt wrote: >> Am 15.02.2020 um 15:31 schrieb Enrico Forestieri : >>> >>> On Sat, Feb 15, 2020 at 02:41:19PM +0100, Stephan Witt wrote: I came up with another path. IMHO easier to u

Re: [PATCH] lyxpreview_tools.py: fix a regular expression

2020-02-15 Thread Enrico Forestieri
On Sat, Feb 15, 2020 at 02:03:43PM -0500, Scott Kostyshak wrote: > Attached is a patch for lyxpreview_tools.py, but I don't know Python > well and I don't know how to test whether this code works as intended > now or not. All I know is it gets rid of the error. > > I originally saw that error on

Re: [RFC][PATCH] Change to GuiView::goToFileRow

2020-02-15 Thread Enrico Forestieri
On Sat, Feb 15, 2020 at 04:09:14PM +0100, Stephan Witt wrote: > Am 15.02.2020 um 15:31 schrieb Enrico Forestieri : > > > > On Sat, Feb 15, 2020 at 02:41:19PM +0100, Stephan Witt wrote: > >> > >> I came up with another path. IMHO easier to understand. > >> And it works with all variants of Qt and

Re: Valgrind "definitely lost" backtrace

2020-02-15 Thread Pavel Sanda
On Fri, Feb 14, 2020 at 08:09:09PM -0500, Scott Kostyshak wrote: > Thanks to both of you for taking a look. I was hoping to investigate > this memory leak but it seems to be beyond my knowledge. Do you have recipy to reproduce valgrind's warning? Pavel -- lyx-devel mailing list lyx-devel@lists.l

Re: [PATCH] lyxpreview_tools.py: fix a regular expression

2020-02-15 Thread Kornel Benko
Am Sat, 15 Feb 2020 21:15:17 +0100 schrieb Kornel Benko : > Am Sat, 15 Feb 2020 14:03:43 -0500 > schrieb Scott Kostyshak : > > > Attached is a patch for lyxpreview_tools.py, but I don't know Python > > well and I don't know how to test whether this code works as intended > > now or not. All I kno

Re: Questions regarding compiler warnings

2020-02-15 Thread Pavel Sanda
On Thu, Feb 13, 2020 at 06:28:05PM +0100, Jean-Marc Lasgouttes wrote: > >I can replace asserts with explicit checks if you agree. > >Or completely delete those checks because for most of them getStatus won't > >let > >you in without buffer anyway. > > Either solution will be OK. And do not forget

Re: [PATCH] lyxpreview_tools.py: fix a regular expression

2020-02-15 Thread Kornel Benko
Am Sat, 15 Feb 2020 14:03:43 -0500 schrieb Scott Kostyshak : > Attached is a patch for lyxpreview_tools.py, but I don't know Python > well and I don't know how to test whether this code works as intended > now or not. All I know is it gets rid of the error. > > I originally saw that error on mast

Re: [PATCH] lyxpreview_tools.py: fix a regular expression

2020-02-15 Thread Neven Sajko
Hmm, after looking at the last few commits, it seems this may be a more involved issue than I first thought. On the one hand one has to take care to use the proper choice between "Unicode" and "byte" strings, on the other hand it seems like the Lyx guys want the script to work for both Python 2 and

Re: [PATCH] lyxpreview_tools.py: fix a regular expression

2020-02-15 Thread Neven Sajko
Actually, do something like this (no "using distributivity" like in my first message, to get a minimal git diff) def_re = re.compile(r"(\newcommandx|\renewcommandx|\global\long\def)(\[a-zA-Z]+)(.+)") Regards, Neven Sajko -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mai

Re: [PATCH] lyxpreview_tools.py: fix a regular expression

2020-02-15 Thread Neven Sajko
Two notes: it would be better to use raw strings (r"string") and to maybe do r"\(a|b|c|d)" instead of r"(\a|\b|\c|\d)" (use distributivity, in other words). So, I think you want this: def_re = re.compile(r"\(newcommandx|renewcommandx|global\long\def)(\[a-zA-Z]+)(.+)") Regards, Neven Sajko -- l

Jenkins build is back to normal : Build branch "master" » ubuntu-xenial-qt4-autotools-extended #1826

2020-02-15 Thread ci-lyx
https://ci.inria.fr/lyx/job/build-master-head/job/ubuntu-xenial-qt4-autotools-extended/1826/ -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

[PATCH] lyxpreview_tools.py: fix a regular expression

2020-02-15 Thread Scott Kostyshak
Attached is a patch for lyxpreview_tools.py, but I don't know Python well and I don't know how to test whether this code works as intended now or not. All I know is it gets rid of the error. I originally saw that error on master when opening the User Guide with Preview enabled. Can someone give t

Re: Building windows installer questions

2020-02-15 Thread Richard Kimberly Heck
On 2/15/20 6:26 AM, Yu Jin wrote: > Looks like I got it working now. Here few more questions: > 1. How to do the GPG signature? Only a few of us can do that, because only a few of us have the key, for obvious reasons. If you want to send yours to me---just put it somewhere I can download it---then

Re: [RFC][PATCH] Change to GuiView::goToFileRow

2020-02-15 Thread Stephan Witt
Am 15.02.2020 um 15:31 schrieb Enrico Forestieri : > > On Sat, Feb 15, 2020 at 02:41:19PM +0100, Stephan Witt wrote: >> >> I came up with another path. IMHO easier to understand. >> And it works with all variants of Qt and input. > > Unfortunately, it confuses me more than the previous one. > P

Re: [RFC][PATCH] Change to GuiView::goToFileRow

2020-02-15 Thread Enrico Forestieri
On Sat, Feb 15, 2020 at 02:41:19PM +0100, Stephan Witt wrote: > > I came up with another path. IMHO easier to understand. > And it works with all variants of Qt and input. Unfortunately, it confuses me more than the previous one. Please, can you apply the attached debug patch and report the resu

Re: [RFC][PATCH] Change to GuiView::goToFileRow

2020-02-15 Thread Stephan Witt
Am 15.02.2020 um 13:12 schrieb Enrico Forestieri : > > On Fri, Feb 14, 2020 at 10:10:06PM +0100, Stephan Witt wrote: >> Am 14.02.2020 um 21:00 schrieb Stephan Witt : >>> >>> Hi all, >>> >>> I’ve a problem in LyX master with reverse search I don’t have in 2.3.x. >>> Unfortunately I cannot see the

Re: [RFC][PATCH] Change to GuiView::goToFileRow

2020-02-15 Thread Enrico Forestieri
On Fri, Feb 14, 2020 at 10:10:06PM +0100, Stephan Witt wrote: > Am 14.02.2020 um 21:00 schrieb Stephan Witt : > > > > Hi all, > > > > I’ve a problem in LyX master with reverse search I don’t have in 2.3.x. > > Unfortunately I cannot see the difference in LyX code causing it. > > > > The situatio

Re: [RFC][PATCH] Change to GuiView::goToFileRow

2020-02-15 Thread Enrico Forestieri
On Fri, Feb 14, 2020 at 09:00:48PM +0100, Stephan Witt wrote: > Hi all, > > I’ve a problem in LyX master with reverse search I don’t have in 2.3.x. > Unfortunately I cannot see the difference in LyX code causing it. > > The situation is: on Mac the directory /var is an symlink to private/var. > S

Re: Building windows installer questions

2020-02-15 Thread Yu Jin
Looks like I got it working now. Here few more questions: 1. How to do the GPG signature? 2. Are we bothering with the 64 bit version? Eugene -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Build failed in Jenkins: Build branch "master" » ubuntu-xenial-qt4-autotools-extended #1825

2020-02-15 Thread ci-lyx
https://ci.inria.fr/lyx/job/build-master-head/job/ubuntu-xenial-qt4-autotools-extended/1825/-- [...truncated 1221 lines...] Making check in autotests make[1]: Entering directory '/build/workspace/autotests' make[1]: Nothing to be done for 'check'. make[1]: Le

Re: [LyX/2.3.x] Cmake build: Remove cmake warnings about mismatched values of FindPackageHandleStandardArgs()

2020-02-15 Thread Stephan Witt
Am 15.02.2020 um 09:28 schrieb Kornel Benko : > > Am Sat, 15 Feb 2020 09:17:53 +0100 > schrieb Kornel Benko : > >> Am Sat, 15 Feb 2020 09:02:45 +0100 >> schrieb Stephan Witt : >> >>> Am 15.02.2020 um 08:32 schrieb Kornel Benko : Am Fri, 14 Feb 2020 17:37:28 +0100 schrieb Steph

Re: [LyX/2.3.x] Cmake build: Remove cmake warnings about mismatched values of FindPackageHandleStandardArgs()

2020-02-15 Thread Kornel Benko
Am Sat, 15 Feb 2020 09:17:53 +0100 schrieb Kornel Benko : > Am Sat, 15 Feb 2020 09:02:45 +0100 > schrieb Stephan Witt : > > > Am 15.02.2020 um 08:32 schrieb Kornel Benko : > > > > > > Am Fri, 14 Feb 2020 17:37:28 +0100 > > > schrieb Stephan Witt : > > > > > >> Changes not staged for comm

Re: [LyX/2.3.x] Cmake build: Remove cmake warnings about mismatched values of FindPackageHandleStandardArgs()

2020-02-15 Thread Kornel Benko
Am Sat, 15 Feb 2020 09:02:45 +0100 schrieb Stephan Witt : > Am 15.02.2020 um 08:32 schrieb Kornel Benko : > > > > Am Fri, 14 Feb 2020 17:37:28 +0100 > > schrieb Stephan Witt : > > > >> Changes not staged for commit: > >> (use "git add ..." to update what will be committed) > >> (use "git ch

Re: [LyX/2.3.x] Cmake build: Remove cmake warnings about mismatched values of FindPackageHandleStandardArgs()

2020-02-15 Thread Stephan Witt
Am 15.02.2020 um 08:32 schrieb Kornel Benko : > > Am Fri, 14 Feb 2020 17:37:28 +0100 > schrieb Stephan Witt : > >> Changes not staged for commit: >> (use "git add ..." to update what will be committed) >> (use "git checkout -- ..." to discard changes in working directory) >> >>modified: