Re: Build failed in Jenkins: Build branch "master" ?? ubuntu-xenial-qt4-autotools-extended #1487

2019-03-21 Thread Guenter Milde
On 2019-03-21, Jürgen Spitzmüller wrote: > [-- Type: text/plain, Encoding: quoted-printable --] > Am Donnerstag, den 21.03.2019, 16:13 +0100 schrieb Pavel Sanda: >> & is active shell character so even if we fix distcheck all sorts >> of commandline operations on lyx tree will suddenly become erro

Re: [PATCH] New Templates/Examples dialog

2019-03-21 Thread Daniel
On 2019-03-21 11:04, Daniel wrote: On 21/03/2019 10:49, Jean-Marc Lasgouttes wrote: Le 21/03/2019 à 10:39, Jürgen Spitzmüller a écrit : Am Do., 21. März 2019 um 10:35 Uhr schrieb Jean-Marc Lasgouttes mailto:lasgout...@lyx.org>>:     It looks good. A few additional remarks:     * the Type sele

Build failed in Jenkins: Build branch "master" » ubuntu-latest-qt5-cmake #1542

2019-03-21 Thread ci-lyx
https://ci.inria.fr/lyx/job/build-master-head/job/ubuntu-latest-qt5-cmake/1542/-- Started by an SCM change Building remotely on lyx-linux6 (linux) in workspace [WS-CLEANUP] Delet

Build failed in Jenkins: Build branch "master" » ubuntu-xenial-qt4-autotools #1271

2019-03-21 Thread ci-lyx
https://ci.inria.fr/lyx/job/build-master-head/job/ubuntu-xenial-qt4-autotools/1271/-- Started by an SCM change Building remotely on lyx-linux6 (linux) in workspace [WS-CLEANU

Re: convertDefault.py is broken under python 3

2019-03-21 Thread José Abílio Matos
On Monday, 11 February 2019 00.25.41 WET Uwe Stöhr wrote: > Attached is the diff to get it at least to work. > José, could you please have a look? I am sorry for not replying before. It is in my todo list as soon as I have some free time (from tasks that are urgent and important). I will take a

Build failed in Jenkins: Build branch "master" » ubuntu-xenial-qt4-autotools-extended #1490

2019-03-21 Thread ci-lyx
https://ci.inria.fr/lyx/job/build-master-head/job/ubuntu-xenial-qt4-autotools-extended/1490/-- [...truncated 1863 lines...] checking whether Qt uses the X Window system... yes checking for qtchooser... /usr/bin/qtchooser checking for moc... /usr/bin/moc check

Re: [PATCH] New Templates/Examples dialog

2019-03-21 Thread Jürgen Spitzmüller
Am Donnerstag, den 21.03.2019, 12:52 +0100 schrieb Jürgen Spitzmüller: > Am Do., 21. März 2019 um 10:49 Uhr schrieb Jean-Marc Lasgouttes < > lasgout...@lyx.org>: > > > I thought it would make sense to be able to open an example file > > as > > > template and vice versa. > > > > I would say that i

Re: [PATCH] New Templates/Examples dialog

2019-03-21 Thread Jürgen Spitzmüller
Am Donnerstag, den 21.03.2019, 09:11 +0100 schrieb Daniel: > But I'd be happy about an options to show only user, only system, or > both templates the last state of which is saved and restored upon > re-opening the dialog. Use case: apart from my very beginnings with > LyX, > I never used any sy

Re: Build failed in Jenkins: Build branch "master" ?? ubuntu-xenial-qt4-autotools-extended #1487

2019-03-21 Thread Jürgen Spitzmüller
Am Donnerstag, den 21.03.2019, 16:13 +0100 schrieb Pavel Sanda: > & is active shell character so even if we fix distcheck all sorts > of commandline operations on lyx tree will suddenly become errorneous > without proper quotation. It does not seem worth it... Alas, changing '&' alone does not see

Re: [LyX/master] Cache the value of GuiFontMetrics::lbearing().

2019-03-21 Thread Jean-Marc Lasgouttes
Le 21/03/2019 à 16:44, Richard Kimberly Heck a écrit : I I did not mistype something, the danger is null: we already cache rbearing (and width, ascent and descent) for the same reason. I only added caching of lbearing. The only use of lbearing has been added in the 2.3 development cycle, whence t

Re: Build failed in Jenkins: Build branch "master" ?? ubuntu-xenial-qt4-autotools-extended #1487

2019-03-21 Thread Pavel Sanda
On Thu, Mar 21, 2019 at 01:54:53PM +0100, Jürgen Spitzmüller wrote: > Am Do., 21. März 2019 um 13:52 Uhr schrieb Jean-Marc Lasgouttes < > lasgout...@lyx.org>: > > > Use normal characters instead? > > > > If possible, I want the filenames to match the GUI name of the layouts. What not use 'and' i

Re: [LyX/master] Use HAVE_LONG_LONG_INT instead of LYX_USE_LONG_LONG

2019-03-21 Thread Jean-Marc Lasgouttes
Le 21/03/2019 à 15:16, Stephan Witt a écrit : Am 21.03.2019 um 14:24 schrieb Jean-Marc Lasgouttes : If this turns out to compile on our usual targets (windows, macos and linux), we could consider to backport this to 2.3.x. git commit 4b2cce9e0f compiles on Mac. This includes your change. Th

Re: [LyX/master] Use HAVE_LONG_LONG_INT instead of LYX_USE_LONG_LONG

2019-03-21 Thread Kornel Benko
Am Donnerstag, 21. März 2019 15:13:21 CET schrieb Jean-Marc Lasgouttes : > Le 21/03/2019 à 14:59, Kornel Benko a écrit : > > Hm, it compiles OK also without modifications. > > Yes, it depends on architecture. > > > Where do you define HAVE_LONG_LONG_INT? > > Instead of defining LYX_USE_LONG_LON

Re: [LyX/master] Use HAVE_LONG_LONG_INT instead of LYX_USE_LONG_LONG

2019-03-21 Thread Stephan Witt
Am 21.03.2019 um 14:24 schrieb Jean-Marc Lasgouttes : > > Le 21/03/2019 à 14:12, Jean-Marc Lasgouttes a écrit : >> commit 601244ba92c3975f6915455943d49c621d9487fb >> Author: Jean-Marc Lasgouttes >> Date: Thu Mar 21 14:05:50 2019 +0100 >> Use HAVE_LONG_LONG_INT instead of LYX_USE_LONG_LONG >

Re: [PATCH] New Templates/Examples dialog

2019-03-21 Thread Kornel Benko
Am Donnerstag, 21. März 2019 14:41:04 CET schrieb Jürgen Spitzmüller : > Am Do., 21. März 2019 um 14:38 Uhr schrieb Kornel Benko : > > > But there are some files which are _not_ in translations (but in system > > dir) which nonetheless are displayed. > > > > See Letters->Serial_Letter_?.lyx > > B

Re: [LyX/master] Use HAVE_LONG_LONG_INT instead of LYX_USE_LONG_LONG

2019-03-21 Thread Jean-Marc Lasgouttes
Le 21/03/2019 à 14:59, Kornel Benko a écrit : Hm, it compiles OK also without modifications. Yes, it depends on architecture. Where do you define HAVE_LONG_LONG_INT? Instead of defining LYX_USE_LONG_LONG. JMarc

Re: [LyX/master] Use HAVE_LONG_LONG_INT instead of LYX_USE_LONG_LONG

2019-03-21 Thread Kornel Benko
Am Donnerstag, 21. März 2019 14:24:11 CET schrieb Jean-Marc Lasgouttes : > Le 21/03/2019 à 14:12, Jean-Marc Lasgouttes a écrit : > > commit 601244ba92c3975f6915455943d49c621d9487fb > > Author: Jean-Marc Lasgouttes > > Date: Thu Mar 21 14:05:50 2019 +0100 > > > > Use HAVE_LONG_LONG_INT ins

Re: [PATCH] New Templates/Examples dialog

2019-03-21 Thread Jürgen Spitzmüller
Am Do., 21. März 2019 um 14:38 Uhr schrieb Kornel Benko : > But there are some files which are _not_ in translations (but in system > dir) which nonetheless are displayed. > > See Letters->Serial_Letter_?.lyx > But I see, what you mean, the language dir part is missing. > Should be fixed. Jürgen

Re: [PATCH] New Templates/Examples dialog

2019-03-21 Thread Kornel Benko
Am Donnerstag, 21. März 2019 14:23:33 CET schrieb Jürgen Spitzmüller : > Am Do., 21. März 2019 um 14:02 Uhr schrieb Kornel Benko : > > > For instance a file in ~/.lyx/examples/de/Curricula_Vitae/xyzzy.lyx > > is not visible. > > > > The language subtrees are only used for translations to real fi

Re: [LyX/master] Use HAVE_LONG_LONG_INT instead of LYX_USE_LONG_LONG

2019-03-21 Thread Jean-Marc Lasgouttes
Le 21/03/2019 à 14:12, Jean-Marc Lasgouttes a écrit : commit 601244ba92c3975f6915455943d49c621d9487fb Author: Jean-Marc Lasgouttes Date: Thu Mar 21 14:05:50 2019 +0100 Use HAVE_LONG_LONG_INT instead of LYX_USE_LONG_LONG It seems that the extra complication hurts more than it h

Re: [PATCH] New Templates/Examples dialog

2019-03-21 Thread Jürgen Spitzmüller
Am Do., 21. März 2019 um 14:02 Uhr schrieb Kornel Benko : > For instance a file in ~/.lyx/examples/de/Curricula_Vitae/xyzzy.lyx > is not visible. > The language subtrees are only used for translations to real files. So ~/.lyx/examples/de/Curricula_Vitae/xyzzy.lyx will be displayed only if there

Re: [PATCH] New Templates/Examples dialog

2019-03-21 Thread Jürgen Spitzmüller
Am Do., 21. März 2019 um 10:39 Uhr schrieb Jürgen Spitzmüller : > * can the tooltip be used to convey explicitly whether the file is from >> user or system dir ? I am not sure that people will understand >> immediately what the icons mean. >> > > Yes, it should do this, but this is currently broke

Re: Toward LyX 2.3.3

2019-03-21 Thread Jürgen Womser-Schütz
Am 20.03.2019 um 02:21 schrieb Richard Kimberly Heck: > On 3/19/19 4:32 PM, Jürgen Womser-Schütz wrote: >> Am 19.03.2019 um 20:05 schrieb Scott Kostyshak: >>> On Tue, Mar 19, 2019 at 01:57:03PM -0400, Richard Kimberly Heck wrote: We're about three months past 2.3.2, so time to start thinkin

Re: [PATCH] New Templates/Examples dialog

2019-03-21 Thread Jürgen Spitzmüller
Am Do., 21. März 2019 um 12:56 Uhr schrieb Jürgen Spitzmüller : > I can just fill the combo with all available languages if no item is > selected. This will not be of (much) use, but maybe it is less confusing. > Done. Jürgen

Re: [PATCH] New Templates/Examples dialog

2019-03-21 Thread Kornel Benko
Am Mittwoch, 20. März 2019 12:40:39 CET schrieb Jürgen Spitzmüller : > Am Mi., 20. März 2019 um 10:46 Uhr schrieb Daniel : > > > I think own templates (from the user directory) should appear in their > > own category, maybe called "User templates", and right at the top of the > > list. (If it app

Re: Build failed in Jenkins: Build branch "master" » ubuntu-xenial-qt4-autotools-extended #1487

2019-03-21 Thread Jürgen Spitzmüller
Am Do., 21. März 2019 um 13:52 Uhr schrieb Jean-Marc Lasgouttes < lasgout...@lyx.org>: > Use normal characters instead? > If possible, I want the filenames to match the GUI name of the layouts. Jürgen > > JMarc >

Re: Build failed in Jenkins: Build branch "master" » ubuntu-xenial-qt4-autotools-extended #1487

2019-03-21 Thread Jean-Marc Lasgouttes
Le 21/03/2019 à 12:50, Jürgen Spitzmüller a écrit : Am Do., 21. März 2019 um 12:08 Uhr schrieb Jean-Marc Lasgouttes mailto:lasgout...@lyx.org>>: I don't know. All I found is: https://www.gnu.org/software/automake/manual/html_node/Limitations-on-File-Names.html which implies that we

Re: [PATCH] New Templates/Examples dialog

2019-03-21 Thread Jürgen Spitzmüller
Am Do., 21. März 2019 um 12:52 Uhr schrieb Jürgen Spitzmüller : > Well, it cannot be a global selector, since we do not have translations > for all files. But in a way it is a global selector, since the selected > value is preferred to other selections as well, if it is available. > I can just fi

Re: [PATCH] New Templates/Examples dialog

2019-03-21 Thread Jürgen Spitzmüller
Am Do., 21. März 2019 um 10:49 Uhr schrieb Jean-Marc Lasgouttes < lasgout...@lyx.org>: > > I thought it would make sense to be able to open an example file as > > template and vice versa. > > I would say that it is more confusing than helpful, but it is only me. > MAybe I remove it again. > > >

Re: Build failed in Jenkins: Build branch "master" » ubuntu-xenial-qt4-autotools-extended #1487

2019-03-21 Thread Jürgen Spitzmüller
Am Do., 21. März 2019 um 12:08 Uhr schrieb Jean-Marc Lasgouttes < lasgout...@lyx.org>: > I don't know. All I found is: > > https://www.gnu.org/software/automake/manual/html_node/Limitations-on-File-Names.html > which implies that we should not have issues. > I don't know either. But I had to use

Build failed in Jenkins: Build branch "master" » ubuntu-xenial-qt4-autotools-extended #1489

2019-03-21 Thread ci-lyx
https://ci.inria.fr/lyx/job/build-master-head/job/ubuntu-xenial-qt4-autotools-extended/1489/-- [...truncated 3311 lines...] /bin/mkdir -p '/build/workspace/lyx-2.4.0dev/_inst/share/lyx/examples/de/Curricula_Vitae' /usr/bin/install -c -m 644 ../../../lib/ex

Re: Build failed in Jenkins: Build branch "master" » ubuntu-xenial-qt4-autotools-extended #1487

2019-03-21 Thread Jean-Marc Lasgouttes
Le 21/03/2019 à 07:47, Jürgen Spitzmüller a écrit : Am Mittwoch, den 20.03.2019, 22:11 +0100 schrieb Jean-Marc Lasgouttes: Le 20/03/2019 à 20:30, ci-...@inria.fr a écrit : https://ci.inria.fr/lyx/job/build-master-head/job/ubuntu-xenial-qt4-autotools-extended Jürgen, this is related to the & i

Re: Testing 2.3 devel on Windows 10

2019-03-21 Thread Jean-Marc Lasgouttes
Le 16/02/2019 à 09:22, Daniel a écrit : On 2019-02-15 22:26, Jean-Marc Lasgouttes wrote: Le 13/02/2019 à 10:48, Jean-Marc Lasgouttes a écrit : Le 13/02/2019 à 07:44, Daniel a écrit : Even though I can compile LyX on Windows 10 now, I ended up not testing 2.3 devel in detail because it is too s

Re: [PATCH] New Templates/Examples dialog

2019-03-21 Thread Kornel Benko
Am Donnerstag, 21. März 2019 10:55:57 CET schrieb Daniel : > On 21/03/2019 09:47, Jürgen Spitzmüller wrote: > > Am Donnerstag, den 21.03.2019, 09:18 +0100 schrieb Daniel: > >> I find the default state of the Language drop down a bit confusing. > >> It > >> seems to always show its first entry (Afri

Re: [LyX/master] Cache the value of GuiFontMetrics::lbearing().

2019-03-21 Thread Jean-Marc Lasgouttes
Le 21/03/2019 à 00:08, Richard Kimberly Heck a écrit : I can confirm this this helps a lot on windows, at least with the test case that we received. Riki, OK to backport? Yes, thank you. Is there any danger to this, do you think? If so, I could try to produce a 'testing' binary before we move

Re: Track changes added paragraph breaks broken in master

2019-03-21 Thread Jean-Marc Lasgouttes
Le 21/03/2019 à 10:52, Daniel a écrit : In current master, added paragraph breaks are marked at the beginning of the line rather than the end. I guess that is not intentional. It was indeed not intentional. I fixed it by... removing the code! I used the pilcrow sign instead, it sound like a mu

Re: [PATCH] New Templates/Examples dialog

2019-03-21 Thread Daniel
On 21/03/2019 10:49, Jean-Marc Lasgouttes wrote: Le 21/03/2019 à 10:39, Jürgen Spitzmüller a écrit : Am Do., 21. März 2019 um 10:35 Uhr schrieb Jean-Marc Lasgouttes mailto:lasgout...@lyx.org>>:     It looks good. A few additional remarks:     * the Type selector is a bit confusing, since the t

Re: [PATCH] New Templates/Examples dialog

2019-03-21 Thread Daniel
On 21/03/2019 09:47, Jürgen Spitzmüller wrote: Am Donnerstag, den 21.03.2019, 09:18 +0100 schrieb Daniel: I find the default state of the Language drop down a bit confusing. It seems to always show its first entry (Afrikaans) when opening (after a restart). What does this mean? Do I have to cha

Track changes added paragraph breaks broken in master

2019-03-21 Thread Daniel
In current master, added paragraph breaks are marked at the beginning of the line rather than the end. I guess that is not intentional. Daniel

Re: [PATCH] New Templates/Examples dialog

2019-03-21 Thread Jean-Marc Lasgouttes
Le 21/03/2019 à 10:39, Jürgen Spitzmüller a écrit : Am Do., 21. März 2019 um 10:35 Uhr schrieb Jean-Marc Lasgouttes mailto:lasgout...@lyx.org>>: It looks good. A few additional remarks: * the Type selector is a bit confusing, since the two types are open from a different menu entry.

Re: [PATCH] New Templates/Examples dialog

2019-03-21 Thread Jürgen Spitzmüller
Am Do., 21. März 2019 um 10:35 Uhr schrieb Jean-Marc Lasgouttes < lasgout...@lyx.org>: > It looks good. A few additional remarks: > * the Type selector is a bit confusing, since the two types are open > from a different menu entry. What is the use case? I would get rid of it. > I thought it would

Re: [PATCH] New Templates/Examples dialog

2019-03-21 Thread Jean-Marc Lasgouttes
Le 20/03/2019 à 18:40, Jürgen Spitzmüller a écrit : I tried it, and it does not look bad IMHO. Please try it out. I also added the icons to the subcategories, so this should also cure JMarc's woes with the alignment. It looks good. A few additional remarks: * the Type selector is a bit confusin

Re: [PATCH] New Templates/Examples dialog

2019-03-21 Thread Jürgen Spitzmüller
Am Donnerstag, den 21.03.2019, 09:18 +0100 schrieb Daniel: > I find the default state of the Language drop down a bit confusing. > It > seems to always show its first entry (Afrikaans) when opening (after > a > restart). What does this mean? > > Do I have to change it every time to the language

Re: [PATCH] New Templates/Examples dialog

2019-03-21 Thread Daniel
On 19/03/2019 16:46, Jürgen Spitzmüller wrote: Am Di., 19. März 2019 um 16:43 Uhr schrieb Kornel Benko >: The problem starts with multi-language. Imagine following: 1.) The GUI is German 2.) We want write a French presentation 3.) Load a template (e.g.

Re: [LyX/master] Compilation fix for Qt < 5.2.

2019-03-21 Thread Jürgen Spitzmüller
Am Mittwoch, den 20.03.2019, 12:30 +0100 schrieb Jürgen Spitzmüller: > > While I am at it, I have remarks: > > 1/ on my machine, the language menu shows "Français", but I see no > > french examples. How does it work? > > It is just a very rough version with a fixed language list. I will > impleme

Re: [PATCH] New Templates/Examples dialog

2019-03-21 Thread Daniel
On 20/03/2019 18:40, Jürgen Spitzmüller wrote: Am Mittwoch, den 20.03.2019, 18:03 +0100 schrieb Jürgen Spitzmüller: Am Mittwoch, den 20.03.2019, 14:02 +0100 schrieb Jean-Marc Lasgouttes: The icons (that I personally find useless right now) could be used to convey (1) the system/user status and