Re: [patch] My first LFUN

2015-12-20 Thread Richard Heck
On 12/20/2015 06:12 PM, Guillaume Munch wrote: > Le 20/12/2015 22:42, Jean-Marc Lasgouttes a écrit : >> Le 17/12/2015 01:36, Guillaume Munch a écrit : >>> Here's a version with tabular-feature instead of table-modify (and no >>> change to Shortcuts.lyx given that the docs are now frozen). >> >> A f

Re: [patch] My first LFUN

2015-12-20 Thread Guillaume Munch
Le 20/12/2015 22:42, Jean-Marc Lasgouttes a écrit : Le 17/12/2015 01:36, Guillaume Munch a écrit : Here's a version with tabular-feature instead of table-modify (and no change to Shortcuts.lyx given that the docs are now frozen). A few comments on patches (not all of them for you): * you still

[PATCH] Bug 9907: Master-Child Closing Crash

2015-12-20 Thread Richard Heck
See http://www.lyx.org/trac/ticket/9907. Here's a proper patch intended to fix this bug. It actually does a lot less than it appears to do. The old BufferList::releaseChild(parent, child) routine did a few different things: First, it checked whether the child in question was open as a child of so

Re: [patch] My first LFUN

2015-12-20 Thread Jean-Marc Lasgouttes
Le 17/12/2015 01:36, Guillaume Munch a écrit : Here's a version with tabular-feature instead of table-modify (and no change to Shortcuts.lyx given that the docs are now frozen). A few comments on patches (not all of them for you): * you still handle inset-modify tabular for documents and of bin

Re: make distcheck: cannot remove '../../po/lyx.pot'

2015-12-20 Thread Jean-Marc Lasgouttes
Le 19/12/2015 12:17, Georg Baum a écrit : This code is executed in build-dir/po, so ../../po/lyx.pot points to the file in the source tree. lyx.pot exists and is writable, so the only thing I can imagine is some trickery that tries to forbid writing into the source tree by faking permissions, but

Re: What is our goal for 2.2 regarding the export tests?

2015-12-20 Thread Scott Kostyshak
On Sat, Dec 19, 2015 at 04:33:42AM -0500, Scott Kostyshak wrote: > On Sat, Dec 19, 2015 at 10:08:29AM +0100, Kornel Benko wrote: > > > This is meant if we are checking for regression. Yes. > > But it is better to also check for load, to catch also layout errors. > > ctest -L 'export|load' > >

Re: make distcheck: cannot remove '../../po/lyx.pot'

2015-12-20 Thread Scott Kostyshak
On Sat, Dec 19, 2015 at 11:41:02AM +0100, Kornel Benko wrote: > Am Samstag, 19. Dezember 2015 um 05:24:48, schrieb Scott Kostyshak > > > On Tue, Dec 15, 2015 at 12:28:32PM -0500, Scott Kostyshak wrote: > > > On Tue, Dec 15, 2015 at 02:20:50PM +0100, Jean-Marc Lasgouttes wrote: > > > > > > > > I

Re: make distcheck: cannot remove '../../po/lyx.pot'

2015-12-20 Thread Scott Kostyshak
On Sat, Dec 19, 2015 at 10:19:59AM -0800, Pavel Sanda wrote: > Scott Kostyshak wrote: > > It would be nice to fix this so that we can run all of the compilation > > tests before releasing beta. > > Did you try to bisect? Pavel Yes I did this for a previous instance of the error. I bisected on two

Re: [patch] My first LFUN

2015-12-20 Thread Guillaume Munch
Le 20/12/2015 19:28, Jean-Marc Lasgouttes a écrit : Le 20/12/15 19:49, Guillaume Munch a écrit : Here's a version with tabular-feature instead of table-modify (and no change to Shortcuts.lyx given that the docs are now frozen). It would be nice if somebody could review this before the feature

Re: [patch] Display the correct horizontal alignment in AMS environments

2015-12-20 Thread Guillaume Munch
Le 17/12/2015 16:50, Guillaume Munch a écrit : Le 14/12/2015 12:27, Jean-Marc Lasgouttes a écrit : Le 14/12/2015 12:05, Guillaume Munch a écrit : You're right, see now second patch attached. It's a fairly simple change, only adding some information to Georg's displayColAlign(), in addition to

Re: [LyX/master] Add 3rdparty to source package

2015-12-20 Thread Peter Kümmel
Am 20.12.2015 um 21:01 schrieb Pavel Sanda: Georg Baum wrote: Did you run configure after autogen.sh? I assume the error happens when calling make? Here 3rdparty/libiconv/Makefile.in is already generated by autogen.sh. Maybe some old files in the source tree? Yes, also there is error whe

Re: [LyX/master] Add 3rdparty to source package

2015-12-20 Thread Pavel Sanda
Georg Baum wrote: > Did you run configure after autogen.sh? I assume the error happens when > calling make? Yes, also there is error when calling configure I did not catch before. config.status: creating Makefile config.status: creating lyx.1 config.status: creating 3rdparty/Makefile config.statu

Re: [patch] My first LFUN

2015-12-20 Thread Jean-Marc Lasgouttes
Le 20/12/15 19:49, Guillaume Munch a écrit : Here's a version with tabular-feature instead of table-modify (and no change to Shortcuts.lyx given that the docs are now frozen). It would be nice if somebody could review this before the feature freeze. I'll try to have a go tomorrow. I've been b

Re: [patch] My first LFUN

2015-12-20 Thread Richard Heck
On 12/16/2015 07:36 PM, Guillaume Munch wrote: > Le 16/12/2015 13:30, Jean-Marc Lasgouttes a écrit : >> Le 11/12/2015 23:36, Guillaume Munch a écrit : >>> Dear list, >>> >>> >>> Following the discussions in , >>> here >>> are a series of patches meant to address

Re: [LyX/master] Work around bug #9841

2015-12-20 Thread Richard Heck
On 12/20/2015 01:45 PM, Guillaume Munch wrote: > > If what we need is a format change, then it is better to implement the > solution n°3 (attached) described at > . > On the one hand, the format change is very simple. On the other

Re: [patch] My first LFUN

2015-12-20 Thread Guillaume Munch
Le 17/12/2015 00:36, Guillaume Munch a écrit : Le 16/12/2015 13:30, Jean-Marc Lasgouttes a écrit : Le 11/12/2015 23:36, Guillaume Munch a écrit : Dear list, Following the discussions in , here are a series of patches meant to address #9794 (inset-modify ta

Re: [LyX/master] Work around bug #9841

2015-12-20 Thread Guillaume Munch
Le 20/12/2015 10:16, Georg Baum a écrit : I assume that the cited message was supposed to go to the list, so I cite it completely. Am 20.12.2015 um 05:20 schrieb Richard Heck: On 12/19/2015 05:55 PM, Guillaume Munch wrote: Le 19/12/2015 10:17, Georg Baum a écrit : Unfortunately we have a regr

Re: "Splitting of consecutive environments has been reworked and enhanced"

2015-12-20 Thread Enrico Forestieri
On Thu, Dec 17, 2015 at 06:57:23PM +, Guillaume Munch wrote: > Le 12/12/2015 09:47, Enrico Forestieri a écrit : > >On Sat, Dec 12, 2015 at 12:34:47AM +, Guillaume Munch wrote: > >>Le 11/12/2015 22:47, Enrico Forestieri a écrit : > >>>On Fri, Dec 11, 2015 at 06:52:19PM +, Guillaume Munc

[PATCH] Re: [CRASH] Master-Child Closing Crash in Master

2015-12-20 Thread Richard Heck
On 12/20/2015 11:48 AM, Richard Heck wrote: > On 12/20/2015 09:51 AM, Richard Heck wrote: >> On 12/20/2015 09:42 AM, Guillaume Munch wrote: >>> Yes, all this parent/child relationship seems quite complicated and ad >>> hoc. While testing what would happen when a document has two parents, I >>> foun

[CRASH] Master-Child Closing Crash in Master

2015-12-20 Thread Richard Heck
On 12/20/2015 09:51 AM, Richard Heck wrote: > On 12/20/2015 09:42 AM, Guillaume Munch wrote: >> Yes, all this parent/child relationship seems quite complicated and ad >> hoc. While testing what would happen when a document has two parents, I >> found the following crash:

Re: [PATCH] three bugfixes

2015-12-20 Thread Richard Heck
On 12/20/2015 09:42 AM, Guillaume Munch wrote: > Le 20/12/2015 04:43, Richard Heck a écrit : >> On 12/19/2015 06:35 PM, Guillaume Munch wrote: >>> >>> Let me ask naively, what is the expected difference with unchecking >>> "Select master document"? >> >> I assume you mean "Select default master doc

Re: change loading of packages to address #9884 or revert or nothing?

2015-12-20 Thread Jürgen Lange
I prefer: 1. revert 0bf8b8a1. The reason is, that most of my documents are otherwise not compatible with 2.2.0 anymore. So I will be stuck to 2.1.4 forever.

Re: [PATCH] three bugfixes

2015-12-20 Thread Guillaume Munch
Le 20/12/2015 04:43, Richard Heck a écrit : On 12/19/2015 06:35 PM, Guillaume Munch wrote: Let me ask naively, what is the expected difference with unchecking "Select master document"? I assume you mean "Select default master document"? (apart from the fact that we need to close the master

Re: [PATCH] three bugfixes

2015-12-20 Thread Guillaume Munch
Le 20/12/2015 11:28, Jürgen Spitzmüller a écrit : Am Samstag 19 Dezember 2015, 23:35:15 schrieb Guillaume Munch: I tested the patch and it does not solve the reported problem. As I understand it, it only loads the user preamble from the parent document. In my test document, \upharpoonright is st

Raspberry Pi 2 scroll speed

2015-12-20 Thread Peter Kümmel
Recently I gave away the computer which I've used when I was very busy on LyX. It was an Athlon XP 2GHz singlecore. I was interested how the hardware progress looks like from the LyX perspective, means the time needed to scroll to the end of the reference manual: Athlon XP 2GHz: 19s (< full HD)

Script to cross-compile for Linux

2015-12-20 Thread Peter Kümmel
I added a script for cross-compiling for Windows. development/cmake/scripts/xmingw 'xmingw' Must be called from a build directory with the path to the LyX code. Mingw needs to be installed. On Ubuntu I assume the package gcc-mingw-w64-i686 is enough. The script download a pre-compiled Qt 5

Re: [LyX/master] Add 3rdparty to source package

2015-12-20 Thread Peter Kümmel
Am 20.12.2015 um 12:31 schrieb Kornel Benko: Am Sonntag, 20. Dezember 2015 um 12:10:19, schrieb Peter Kümmel Am 20.12.2015 um 11:29 schrieb Georg Baum: Kornel Benko wrote: Setting SRC_LIBCHARSET in the patch might be guarded by: if(UNIX AND NOT MINGW) endif() But since I cannot test windows

Re: origin again

2015-12-20 Thread Jean-Marc Lasgouttes
Le 14/12/2015 22:04, Georg Baum a écrit : Jean-Marc Lasgouttes wrote: Would it make sens to add a parametr \is_lyx_doc to our fileformat? We could decide to do lots of interesting things (like have all relative paths be relative to lib/doc) to files declared this way. I am not sure. The whole

Re: [LyX/master] Amend f441590c

2015-12-20 Thread Jürgen Spitzmüller
Am Sonntag 20 Dezember 2015, 00:55:39 schrieb Guillaume Munch: > +/* > void GuiLog::on_copyPB_clicked() > { > theClipboard().put(fromqstr(logTB->toPlainText())); > } > +*/ > > > Dialog * createGuiLog(GuiView & lv) { return new GuiLog(lv); } > diff --git a/src/frontends/qt4/GuiLog.h

Re: [LyX/master] Add 3rdparty to source package

2015-12-20 Thread Kornel Benko
Am Sonntag, 20. Dezember 2015 um 12:10:19, schrieb Peter Kümmel > Am 20.12.2015 um 11:29 schrieb Georg Baum: > > Kornel Benko wrote: > > > >> Setting SRC_LIBCHARSET in the patch might be guarded by: > >> if(UNIX AND NOT MINGW) > >> endif() > >> But since I cannot test windows or Mac I don't commi

Re: [PATCH] three bugfixes

2015-12-20 Thread Jürgen Spitzmüller
Am Samstag 19 Dezember 2015, 23:35:15 schrieb Guillaume Munch: > I tested the patch and it does not solve the reported problem. As I > understand it, it only loads the user preamble from the parent document. > In my test document, \upharpoonright is still not defined because the > macros are still

Re: [LyX/master] Add 3rdparty to source package

2015-12-20 Thread Peter Kümmel
Am 20.12.2015 um 11:29 schrieb Georg Baum: Kornel Benko wrote: Setting SRC_LIBCHARSET in the patch might be guarded by: if(UNIX AND NOT MINGW) endif() But since I cannot test windows or Mac I don't commit. You will see here if it compiles here: https://travis-ci.org/syntheticpp/lyx I'd say

Re: why Babel with dvi3 (LuTeX)?

2015-12-20 Thread Guenter Milde
On 2015-12-19, Jürgen Spitzmüller wrote: > Am Mittwoch 16 Dezember 2015, 20:35:27 schrieb Guenter Milde: >> This should be the same for any export using Unicode fonts, however a look >> in the source pane shows, that with DVI (LuaTeX), the export still uses >> Babel, not Polyglossia. > Probably an

Re: [LyX/master] Add 3rdparty to source package

2015-12-20 Thread Kornel Benko
Am Sonntag, 20. Dezember 2015 um 11:29:59, schrieb Georg Baum > Kornel Benko wrote: > > > Setting SRC_LIBCHARSET in the patch might be guarded by: > > if(UNIX AND NOT MINGW) > > endif() > > But since I cannot test windows or Mac I don't commit. > > I'd say commit. If relocatable.c is not suppos

Re: [LyX/master] Add 3rdparty to source package

2015-12-20 Thread Georg Baum
Kornel Benko wrote: > Setting SRC_LIBCHARSET in the patch might be guarded by: > if(UNIX AND NOT MINGW) > endif() > But since I cannot test windows or Mac I don't commit. I'd say commit. If relocatable.c is not supposed to be compiled, then it should be removed from the sources, these are stripp

Re: [LyX/master] Add 3rdparty to source package

2015-12-20 Thread Georg Baum
Pavel Sanda wrote: > I guess this is related, after running autogen.sh: > > 3rdparty/libiconv/Makefile.am: error: object 'relocatable.$(OBJEXT)' > created by '1.14/libcharset/lib/relocatable.c' and > '1.14/lib/relocatable.c' Makefile:445: recipe for target 'Makefile.in' > failed make: *** [Makefi

Re: [LyX/master] Work around bug #9841

2015-12-20 Thread Georg Baum
I assume that the cited message was supposed to go to the list, so I cite it completely. Am 20.12.2015 um 05:20 schrieb Richard Heck: On 12/19/2015 05:55 PM, Guillaume Munch wrote: Le 19/12/2015 10:17, Georg Baum a écrit : Unfortunately we have a regression now: Both tex2lyx and lyx2lyx outpu