Re: Call for testers: features/str-metrics, take 2

2014-07-01 Thread Scott Kostyshak
On Tue, Jul 1, 2014 at 5:57 PM, Jean-Marc Lasgouttes wrote: > Le 01/07/2014 16:41, Scott Kostyshak a écrit : > >> error: ‘UniteClip’ is not a member of ‘Qt’ >> Qt::UniteClip); >> ^ >> >> It looks like this change was intended: >> "This is one of the few source breakages we will do

Re: Call for testers: features/str-metrics, take 2

2014-07-01 Thread Jean-Marc Lasgouttes
Le 01/07/2014 16:41, Scott Kostyshak a écrit : error: ‘UniteClip’ is not a member of ‘Qt’ Qt::UniteClip); ^ It looks like this change was intended: "This is one of the few source breakages we will do for Qt 5. The unite clip complicates and slows down some rendering paths and it

Re: Debug information for lyx crash with data loss

2014-07-01 Thread Georg Baum
Richard Heck wrote: > That was what I was thinking, too. Just guessing at this point. Another wild guess: Since the backtrace shows autoSave(), and autoSave() runs in a separate thread and operates on the cloned buffer: Could the non- thread-safety of the cloning business be the real problem? At

Re: Debug information for lyx crash with data loss

2014-07-01 Thread Georg Baum
Richard Heck wrote: > That was what I was thinking, too. Just guessing at this point. Yes. It would be really nice if we had a more reliable way to reproduce the crash. OTOH it is good that it does not occur very often;-) I went over the code again and found and fixed a memory leak (and missing

Re: Debug information for lyx crash with data loss

2014-07-01 Thread Richard Heck
On 07/01/2014 02:38 PM, Georg Baum wrote: Richard Heck wrote: On 06/30/2014 06:54 PM, Pavel Sanda wrote: Richard Heck wrote: Paragraph::write, so the crashing call to to_utf8 could come in any of them. The crashing call certainly isn't the first one, since "\begin_inset smells little bit lik

Re: Debug information for lyx crash with data loss

2014-07-01 Thread Georg Baum
Richard Heck wrote: > On 06/30/2014 06:54 PM, Pavel Sanda wrote: >> Richard Heck wrote: >>> Paragraph::write, so the crashing call to to_utf8 could come in any of >>> them. The crashing call certainly isn't the first one, since >>> "\begin_inset >> smells little bit like concurrency problem inside

Re: Debug information for lyx crash with data loss

2014-07-01 Thread Richard Heck
On 06/30/2014 06:54 PM, Pavel Sanda wrote: Richard Heck wrote: Paragraph::write, so the crashing call to to_utf8 could come in any of them. The crashing call certainly isn't the first one, since "\begin_inset smells little bit like concurrency problem inside to_utf8. we might try doing autosave

Re: Call for testers: features/str-metrics, take 2

2014-07-01 Thread Kornel Benko
Am Dienstag, 1. Juli 2014 um 16:55:39, schrieb Jean-Marc Lasgouttes > 01/07/2014 13:59, Kornel Benko: > > I tried. Editing seemed to work fine. Then I tried to compile a changed > > lyx-file, but somehow > > I managed to have made it invalid. > > Thanks for the report. Are you a Linux user? I

Re: Call for testers: features/str-metrics, take 2

2014-07-01 Thread Scott Kostyshak
On Tue, Jul 1, 2014 at 10:54 AM, Jean-Marc Lasgouttes wrote: > 01/07/2014 16:41, Scott Kostyshak: > >> error: ‘UniteClip’ is not a member of ‘Qt’ >> Qt::UniteClip); >> ^ >> >> It looks like this change was intended: >> "This is one of the few source breakages we will do for Qt 5. T

Re: Call for testers: features/str-metrics, take 2

2014-07-01 Thread Jean-Marc Lasgouttes
01/07/2014 13:59, Kornel Benko: I tried. Editing seemed to work fine. Then I tried to compile a changed lyx-file, but somehow I managed to have made it invalid. Thanks for the report. Are you a Linux user? I admit I do not recall that. JMarc

Re: Call for testers: features/str-metrics, take 2

2014-07-01 Thread Jean-Marc Lasgouttes
01/07/2014 16:41, Scott Kostyshak: error: ‘UniteClip’ is not a member of ‘Qt’ Qt::UniteClip); ^ It looks like this change was intended: "This is one of the few source breakages we will do for Qt 5. The unite clip complicates and slows down some rendering paths and it is not very

Re: Call for testers: features/str-metrics, take 2

2014-07-01 Thread Scott Kostyshak
On Tue, Jul 1, 2014 at 5:21 AM, Jean-Marc Lasgouttes wrote: > Hello, > > The features/str-metrics branch is now to a point where I think it is ready > to land on master, where further fixing can take place. Before I do that, I > would be grateful if some of you could try it out and report their fi

Re: Empty selection issues

2014-07-01 Thread Scott Kostyshak
On Tue, Jul 1, 2014 at 5:24 AM, Jean-Marc Lasgouttes wrote: > 25/06/2014 22:53, Scott Kostyshak: > >> It works for most of the issues. Attached is a patch. >> As for the empty selection issues it doesn't fix, perhaps it's because of >> the >> FIXME: let GuiView take care of those. >> in GuiWorkAre

Re: Debug information for lyx crash with data loss

2014-07-01 Thread Richard Heck
On 06/30/2014 06:54 PM, Pavel Sanda wrote: Richard Heck wrote: Paragraph::write, so the crashing call to to_utf8 could come in any of them. The crashing call certainly isn't the first one, since "\begin_inset smells little bit like concurrency problem inside to_utf8. we might try doing autosave

Re: Call for testers: features/str-metrics, take 2

2014-07-01 Thread Kornel Benko
Am Dienstag, 1. Juli 2014 um 13:59:18, schrieb Kornel Benko > Am Dienstag, 1. Juli 2014 um 11:21:02, schrieb Jean-Marc Lasgouttes > > > Hello, > > > > The features/str-metrics branch is now to a point where I think it is > > ready to land on master, where further fixing can take place. Before

Re: Call for testers: features/str-metrics, take 2

2014-07-01 Thread Kornel Benko
Am Dienstag, 1. Juli 2014 um 11:21:02, schrieb Jean-Marc Lasgouttes > Hello, > > The features/str-metrics branch is now to a point where I think it is > ready to land on master, where further fixing can take place. Before I > do that, I would be grateful if some of you could try it out and rep

Re: Empty selection issues

2014-07-01 Thread Jean-Marc Lasgouttes
25/06/2014 22:53, Scott Kostyshak: It works for most of the issues. Attached is a patch. As for the empty selection issues it doesn't fix, perhaps it's because of the FIXME: let GuiView take care of those. in GuiWorkArea The patch looks good. What are the remaining problems? JMarc

Call for testers: features/str-metrics, take 2

2014-07-01 Thread Jean-Marc Lasgouttes
Hello, The features/str-metrics branch is now to a point where I think it is ready to land on master, where further fixing can take place. Before I do that, I would be grateful if some of you could try it out and report their findings. I hope that all problems related to Arabic of Hebrew scr