Re: [DECISION] final layout patches for branch

2012-12-10 Thread Jürgen Spitzmüller
Georg Baum wrote: > > Is it a consensus if one developer is not fine with that? What about the > > users? Have you ever thought about them and/or asked them? (Se my first > > mail from today.) If you want to kick me out of the development please > > tell me but this is not fair! > > Nobody wants t

Re: Undo crash in InsetTabular with "spellcheck continuously" enabled

2012-12-10 Thread Stephan Witt
Am 11.12.2012 um 02:12 schrieb Pavel Sanda : > Jean-Marc Lasgouttes wrote: >> This last undo step can be replaced by anything here (clicking anywhere, >> inserting text...). >> >> Unfortunately, when I run LyX under gdb (or valgrind), I cannot reproduce >> anymore :( > > Backtrace: > #0 0x08c

Re: Undo crash in InsetTabular with "spellcheck continuously" enabled

2012-12-10 Thread Pavel Sanda
Jean-Marc Lasgouttes wrote: > This last undo step can be replaced by anything here (clicking anywhere, > inserting text...). > > Unfortunately, when I run LyX under gdb (or valgrind), I cannot reproduce > anymore :( Backtrace: #0 0x08c9d30b in typeinfo for QMimeData () #1 0x0810a9ba in lyx::Do

Re: Export-to fails for xhtml

2012-12-10 Thread Pavel Sanda
Tommaso Cucinotta wrote: > Don't know why I had to add "QtGui/" in a couple of includes in ColorCache.h. > Different CPPFLAGS are provided for the objects in graphics/ and What Qt version do you use, what build system (autotools/cmake, merged build?) There is couple of other files using the same

Re: [PATCH] move row for tabular

2012-12-10 Thread Pavel Sanda
Richard Heck wrote: >> In particular: >> (1) What if the current row contains a cell that is part of a multirow? >> (2) What if not (1) but the row beneath it has a cell that is part of >> a multirow? >> >> I see two solutions: >> (a) In cases (1) and (2) disable the LFUN. I would favor (a). >> I

Re: Export-to fails for xhtml

2012-12-10 Thread Tommaso Cucinotta
On 10/12/12 22:25, Richard Heck wrote: > On 12/10/2012 05:16 PM, Tommaso Cucinotta wrote: >> On 10/12/12 21:46, Tommaso Cucinotta wrote: >>> when exporting from the command-line, theApp() doesn't exist. Any >>> possible/meaningful replacement for these hexName() call ? >> Just came across the atta

Re: Export-to fails for xhtml

2012-12-10 Thread Richard Heck
On 12/10/2012 05:16 PM, Tommaso Cucinotta wrote: On 10/12/12 21:46, Tommaso Cucinotta wrote: when exporting from the command-line, theApp() doesn't exist. Any possible/meaningful replacement for these hexName() call ? Just came across the attached solution that seems better. Any comment ? Obj

Re: Export-to fails for xhtml

2012-12-10 Thread Tommaso Cucinotta
On 10/12/12 21:46, Tommaso Cucinotta wrote: > when exporting from the command-line, theApp() doesn't exist. Any > possible/meaningful replacement for these hexName() call ? Just came across the attached solution that seems better. Any comment ? Objections to commit ? Don't know why I had to add

Re: [DECISION] final layout patches for branch

2012-12-10 Thread Georg Baum
Uwe Stöhr wrote: > Is it a consensus if one developer is not fine with that? What about the > users? Have you ever thought about them and/or asked them? (Se my first > mail from today.) If you want to kick me out of the development please > tell me but this is not fair! Nobody wants that. I very

Re: Export-to fails for xhtml

2012-12-10 Thread Tommaso Cucinotta
On 10/12/12 21:11, Tommaso Cucinotta wrote: > On 10/12/12 15:16, Kornel Benko wrote: >> triggers a crash. > > Confirmed. Let me have a look. The problem is that it crashes here: ColorCode const bg = buffer_.isExporting() ? Color_white : PreviewLoader::backgroundCol

Re: Export-to fails for xhtml

2012-12-10 Thread Tommaso Cucinotta
On 10/12/12 15:16, Kornel Benko wrote: > triggers a crash. Confirmed. Let me have a look. T.

Re: [patch] final layout patches for branch

2012-12-10 Thread Richard Heck
On 12/10/2012 12:15 PM, José Matos wrote: On 12/10/2012 04:59 PM, Richard Heck wrote: - From my point as the author of a layout I cannot know what a version of the document class a user might have installed. So what should I do, if the layout works only with modernCV 1.0, but fails with 0.9 and

Re: [DECISION] final layout patches for branch

2012-12-10 Thread Richard Heck
On 12/09/2012 08:21 PM, Uwe Stöhr wrote: Am 07.12.2012 17:00, schrieb Richard Heck: After all of this discussion, Sorry, but why do you decide before I could comment? Please read my comments from today. I judged that further discussion was not going to change people's minds, as indeed it

Re: [patch] final layout patches for branch

2012-12-10 Thread José Matos
On 12/10/2012 04:59 PM, Richard Heck wrote: >> - From my point as the author of a layout I cannot know what a >> version of the document class a user might have installed. So what >> should I do, if the layout works only with modernCV 1.0, but fails >> with 0.9 and the recent version 1.2? - I have

Re: Undo crash in InsetTabular with "spellcheck continuously" enabled

2012-12-10 Thread Richard Heck
On 12/10/2012 06:49 AM, Jean-Marc Lasgouttes wrote: Le 08/12/2012 08:08, Scott Kostyshak a écrit : I'm hoping others can reproduce this. I can reproduce in current trunk with Ubuntu 12.04 as follows: - Enable "spellcheck continuously" - Insert a table, say 4x4. - Click on the upper-left cell. -

Re: [patch] final layout patches for branch

2012-12-10 Thread Richard Heck
On 12/09/2012 08:09 PM, Uwe Stöhr wrote: Am 07.12.2012 10:09, schrieb Jean-Marc Lasgouttes: OK. Let's face it: everything does not work like you are used to. It is not good or bad, it is a fact. And you cannot force everybody to do what you think is good. I don't want to force anybody to do

Re: [PATCH] fix three selection bugs in tabular

2012-12-10 Thread Richard Heck
On 12/10/2012 06:17 AM, Jean-Marc Lasgouttes wrote: Le 08/12/2012 08:10, Scott Kostyshak a écrit : Attached are three patches which fix selection bugs in tabular. I have a feeling that I am cheating by throwing in "cur.screenUpdateFlags(Update::Force | Update::FitCursor);" in a few places. Doing

Re: [PATCH] move row for tabular

2012-12-10 Thread Richard Heck
On 12/08/2012 02:11 AM, Scott Kostyshak wrote: This patch implements a "move row" feature for tabular. The purpose is to provide a useful behavior in tabular that is consistent with PARAGRAPH_MOVE_UP and PARAGRAPH_MOVE_DOWN so that the user can do, for example, alt- to move a row up. I don't use

Re: [PATCH] Remove a FIXME in InsetTabular

2012-12-10 Thread Richard Heck
On 12/08/2012 02:09 AM, Scott Kostyshak wrote: From my interpretation, the FIXME in the attached patch (added in 2009 by Vincent) is now satisfied and we can remove the !empty_cell from the condition. Is that correct or did I misunderstand something? I'm not sure what the issue was before, as I

Pipe in FlexInset Names

2012-12-10 Thread Richard Heck
On 12/08/2012 04:17 AM, Andrew Parsloe wrote: (1) If an inset name contains a vertical bar, |, the part after the bar is not shown in the Insert > Custom Insets list, but is retained in LyX format. Using the schema, inset definition => Custom Insets list => LyX file format, InsetLayout Flex:f

[BUG] Custom insets 1: ResetsFont

2012-12-10 Thread Richard Heck
On 12/08/2012 04:16 AM, Andrew Parsloe wrote: I'm trying to clarify some issues about custom insets. (I have a project that makes heavy use of them.) The Customization manual says (Sect. 5.3.9 on flex insets): ResetsFont [0,1] Whether this inset should use the font of its surrounding environm

Export-to fails for xhtml

2012-12-10 Thread Kornel Benko
Hi, exporting of MergedManuals.lyx Math.lyx EmbeddedObjects.lyx UserGuide.lyx Shortcuts.lyx Additional.lyx triggers a crash. To reproduce: #mkdir tmp #cd tmp #lyx -E xhtml bla.xhtml /lib/doc/MergedManuals.lyx ... Running: convert "70_usr_src

Re: [patch] final layout patches for branch

2012-12-10 Thread Pavel Sanda
Jürgen Spitzmüller wrote: > Uwe Stöhr wrote: > > What is if we add a layout that did not exist before? Of course this breaks > > the backward compatibility. > > Yes, that's tolerated. Although it is an edge case (there are some good > arguments to limit the inclusion of new layouts to major rele

Re: Undo crash in InsetTabular with "spellcheck continuously" enabled

2012-12-10 Thread Jean-Marc Lasgouttes
Le 08/12/2012 08:08, Scott Kostyshak a écrit : I'm hoping others can reproduce this. I can reproduce in current trunk with Ubuntu 12.04 as follows: - Enable "spellcheck continuously" - Insert a table, say 4x4. - Click on the upper-left cell. - Enter "a". - Undo twice, then redo twice, then undo

Re: [PATCH] fix three selection bugs in tabular

2012-12-10 Thread Jean-Marc Lasgouttes
Le 08/12/2012 08:10, Scott Kostyshak a écrit : Attached are three patches which fix selection bugs in tabular. I have a feeling that I am cheating by throwing in "cur.screenUpdateFlags(Update::Force | Update::FitCursor);" in a few places. Doing so does fix the bugs but I'm thinking I'm being wast

Re: [PATCH] delete row/column patch

2012-12-10 Thread Jean-Marc Lasgouttes
Le 08/12/2012 08:09, Scott Kostyshak a écrit : The attached patch is based on a patch sent by Zahari Dimitrov in this email: http://www.mail-archive.com/lyx-devel@lists.lyx.org/msg172590.html I have tested it. Can it go in to trunk? Yes, it looks fine. Should he send a GPL statement? I am

Re: [PATCH] InsetTabular code cleanup

2012-12-10 Thread Jean-Marc Lasgouttes
Le 08/12/2012 08:09, Scott Kostyshak a écrit : While studying InsetTabular{.cpp,.h}, I have some suggestions and questions. In the 0001 patch attached, am I missing something or can we remove cur.selection in the conditions? Yes, but then it would be clearer to rename selIsMultiCell to multiC

Re: [patch] final layout patches for branch

2012-12-10 Thread Jean-Marc Lasgouttes
Le 10/12/2012 02:09, Uwe Stöhr a écrit : - What do you expect as LyX developer, that people are not bothering you with complaints about things you already fixed years ago investing your spare time. So please be that fair and allow also the modernCV developer to act like you. Of course he has the