Re: [PATCH] src/*.cpp: reformatting to increase consistency

2012-10-27 Thread Abdelrazak Younes
Hi Stephan, On 27/10/2012 20:56, Stephan Witt wrote: This invalidates all patches hanging around for cosmetic reasons. Is this really necessary? Stephan Coding style and consistency is always worth it IMO. Solving merge issues because of those are often easy. But this was a very valid questi

Re: [PATCH] src/*.cpp: reformatting to increase consistency

2012-10-27 Thread Abdelrazak Younes
Hi Lars, I didn't read in detail but I think this patch is good. Thanks, Abdel

Re: Compile problem with latest pull

2012-10-27 Thread Kayvan Sylvan
Yes. This fixes it. Thanks. diff --git a/src/insets/InsetLine.cpp b/src/insets/InsetLine.cpp index f72fe64..d933382 100644 --- a/src/insets/InsetLine.cpp +++ b/src/insets/InsetLine.cpp @@ -34,6 +34,7 @@ #include "support/docstream.h" #include "support/gettext.h" #include "support/lstrings.h" +#

Re: Bug in "article (paper)" document class

2012-10-27 Thread Richard Heck
On 10/27/2012 03:02 PM, Hendrik Weisser wrote: Dear LyX developers, I've happened across a bug in LyX 2.0.0 on Ubuntu 11.04. If the "article (paper)" document class is used with the "titlepage" class option, there's an interaction between the "author" and "institution" environments. "author"

Re: [PATCH] src/*.cpp: reformatting to increase consistency

2012-10-27 Thread Lars Gullik Bjønnes
On 27 October 2012 21:31, Stephan Witt wrote: > Am 27.10.2012 um 21:12 schrieb Lars Gullik Bjønnes : > >>> This invalidates all patches hanging around for cosmetic reasons. >>> Is this really necessary? >> >> Why do you have patches hanging around? > > Because I didn't apply them? Commit them to

Re: [PATCH] src/*.cpp: reformatting to increase consistency

2012-10-27 Thread Stephan Witt
Am 27.10.2012 um 21:12 schrieb Lars Gullik Bjønnes : >> This invalidates all patches hanging around for cosmetic reasons. >> Is this really necessary? > > Why do you have patches hanging around? Because I didn't apply them? > Are you saying that changes are hostage to undisclosed patches that >

Re: [PATCH] src/*.cpp: reformatting to increase consistency

2012-10-27 Thread Lars Gullik Bjønnes
Stephan Witt writes: | Am 27.10.2012 um 15:46 schrieb Lars Gullik Bjønnes : > >> --- >> src/AppleSpellChecker.cpp | 6 +- >> src/AspellChecker.cpp | 32 +++-- >> src/Author.cpp| 13 +- >> src/BiblioInfo.cpp| 233 +- >> src/Bidi.cpp

Re: Compile problem with latest pull

2012-10-27 Thread Lars Gullik Bjønnes
Kayvan Sylvan writes: | On Fedora 16: > | CXXInsetListings.o | insets/InsetLine.cpp: In member function 'virtual void | lyx::InsetLine::metrics(lyx::MetricsInfo&, lyx::Dimension&) const': | insets/InsetLine.cpp:121:33: error: 'abs' was not declared in this scope On F16, that is actually surp

Bug in "article (paper)" document class

2012-10-27 Thread Hendrik Weisser
Dear LyX developers, I've happened across a bug in LyX 2.0.0 on Ubuntu 11.04. If the "article (paper)" document class is used with the "titlepage" class option, there's an interaction between the "author" and "institution" environments. "author" by itself will not be displayed in the document

Re: [PATCH] src/*.cpp: reformatting to increase consistency

2012-10-27 Thread Lars Gullik Bjønnes
> This invalidates all patches hanging around for cosmetic reasons. > Is this really necessary? Why do you have patches hanging around? Are you saying that changes are hostage to undisclosed patches that someone might have? And if it takes you more than 5 minutes to fix the conflicts that you ge

Re: [PATCH] src/*.cpp: reformatting to increase consistency

2012-10-27 Thread Stephan Witt
Am 27.10.2012 um 15:46 schrieb Lars Gullik Bjønnes : > --- > src/AppleSpellChecker.cpp | 6 +- > src/AspellChecker.cpp | 32 +++-- > src/Author.cpp| 13 +- > src/BiblioInfo.cpp| 233 +- > src/Bidi.cpp | 1 + > src/BranchList.cpp

Re: [PATCH 1/2] Author.cpp: Change to use Modified Bernstein's hash function

2012-10-27 Thread Lars Gullik Bjønnes
Pavel Sanda writes: | Lars Gullik Bj??nnes wrote: >>Change to use Modified Bernstein's hash function > | Doesn't this imply fileformat change/conversions so hashes generated | in 2.0 are correctly recognized in 2.1? Actually if I read the usage correctly we are free to change the hash function.

Re: [PATCH 1/2] Author.cpp: Change to use Modified Bernstein's hash function

2012-10-27 Thread Lars Gullik Bjønnes
Pavel Sanda writes: | Lars Gullik Bj??nnes wrote: >>Change to use Modified Bernstein's hash function > | Doesn't this imply fileformat change/conversions so hashes generated | in 2.0 are correctly recognized in 2.1? Right. The Author feature is really lacking in documentation. This really seem

Re: [PATCH 1/2] Author.cpp: Change to use Modified Bernstein's hash function

2012-10-27 Thread Pavel Sanda
Lars Gullik Bj??nnes wrote: >Change to use Modified Bernstein's hash function Doesn't this imply fileformat change/conversions so hashes generated in 2.0 are correctly recognized in 2.1? Pavel

[PATCH 2/2] Author.{h,cpp}: remove last_id

2012-10-27 Thread Lars Gullik Bjønnes
We can get the id from the size of the author container. --- src/Author.cpp | 3 +-- src/Author.h | 2 -- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/src/Author.cpp b/src/Author.cpp index b19e2be..5efa1fa 100644 --- a/src/Author.cpp +++ b/src/Author.cpp @@ -77,7 +77,6 @@ bool a

[PATCH 1/2] Author.cpp: Change to use Modified Bernstein's hash function

2012-10-27 Thread Lars Gullik Bjønnes
Also remove the manual "optimization": 33 * hash == (hash << 5) + hash, and just let the compiler handle that. The 33 really is important for the function so it is nicer to let it stand out more. --- src/Author.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Author.

Berntein's hash

2012-10-27 Thread Lars Gullik Bjønnes
static int computeHash(docstring const & name, docstring const & email) { string const full_author_string = to_utf8(name + email); // Bernstein's hash function unsigned int hash = 5381; for (unsigned int c: full_author_string) hash = ((hash <

Re: Compilers used for compiling LyX?

2012-10-27 Thread Pavel Sanda
André Pönitz wrote: > > The oldest gcc I'm still encountering on actively used boxes around > > is 4.2.1, but from my experiments with compiling/using LyX, the real > > stopper is Qt version, because while we (should) still compile with > > Qt 4.2.x > > This is, by the way, an absurd restriction.

Re: boost

2012-10-27 Thread André Pönitz
On Sat, Oct 27, 2012 at 11:23:48AM +0200, Lars Gullik Bjønnes wrote: > André Pönitz writes: > > | I thought I could simply shut up. Alas, it looks like I can't. > > > | On Sat, Oct 27, 2012 at 01:12:21AM +0200, Lars Gullik Bjønnes wrote: > >> lar...@gullik.org (Lars Gullik Bjønnes) writes: > >>

Re: Compilers used for compiling LyX?

2012-10-27 Thread André Pönitz
On Sat, Oct 27, 2012 at 02:00:42AM +0200, Pavel Sanda wrote: > Lars Gullik Bj?nnes wrote: > > Do any of you have feeling what compilers are use to compile LyX > > now-a-days, that at what version they are? > > The oldest gcc I'm still encountering on actively used boxes around > is 4.2.1, but from

Re: Compilers used for compiling LyX?

2012-10-27 Thread Lars Gullik Bjønnes
André Pönitz writes: | On Sat, Oct 27, 2012 at 01:35:26AM +0200, Lars Gullik Bjønnes wrote: >> >> Do any of you have feeling what compilers are use to compile LyX >> now-a-days, that at what version they are? >> >> Would be fun to see how far off we are from being able to use C++11. > | Might b

Re: boost

2012-10-27 Thread Lars Gullik Bjønnes
André Pönitz writes: | I thought I could simply shut up. Alas, it looks like I can't. > | On Sat, Oct 27, 2012 at 01:12:21AM +0200, Lars Gullik Bjønnes wrote: >> lar...@gullik.org (Lars Gullik Bjønnes) writes: >> >> | | BTW after some decade we still include boost in our tarballs and maintain >>

Re: boost

2012-10-27 Thread Lars Gullik Bjønnes
André Pönitz writes: | I thought I could simply shut up. Alas, it looks like I can't. > | On Sat, Oct 27, 2012 at 01:12:21AM +0200, Lars Gullik Bjønnes wrote: >> lar...@gullik.org (Lars Gullik Bjønnes) writes: >> >> | | BTW after some decade we still include boost in our tarballs and maintain >>

Re: Compilers used for compiling LyX?

2012-10-27 Thread André Pönitz
On Sat, Oct 27, 2012 at 01:35:26AM +0200, Lars Gullik Bjønnes wrote: > > Do any of you have feeling what compilers are use to compile LyX > now-a-days, that at what version they are? > > Would be fun to see how far off we are from being able to use C++11. Might be worth a look: http://blogs.msd

Re: boost

2012-10-27 Thread André Pönitz
I thought I could simply shut up. Alas, it looks like I can't. On Sat, Oct 27, 2012 at 01:12:21AM +0200, Lars Gullik Bjønnes wrote: > lar...@gullik.org (Lars Gullik Bjønnes) writes: > > | | BTW after some decade we still include boost in our tarballs and maintain > | | its updates. What was the