RE: [PATCH] LFUN_BUFFER_EXPORT_ALL & File menu reorganization

2012-07-15 Thread Scott Kostyshak
From: Pavel Sanda [sa...@lyx.org] Sent: Sunday, July 15, 2012 7:19 PM >While I think adding LFUNs you proposed makes sense, I don't think it's good >idea to add this new stuff into the File menu (at most poke them away to >some submenu). I would rather see the menu shrink than expand (e.g. Print).

RE: doxygen command for LyXAction.cpp --> LFUNs.lyx

2012-07-15 Thread Scott Kostyshak
From: Pavel Sanda [sa...@lyx.org] Sent: Sunday, July 15, 2012 6:34 PM >Doxygen generation is not related to LFUNs.lyx. > - doxygen: make doxydoc > - LFUNs.lyx: make lfundoc Thanks, Scott

RE: checking whether a buffer is hidden

2012-07-15 Thread Scott Kostyshak
From: Jean-Marc Lasgouttes [lasgout...@lyx.org] Sent: Sunday, July 15, 2012 4:54 PM >The problem is that it needs to be a member function of GuiApplication. >The buffer itself has no reason to know that it is hidden. >In what part of code do you need to know this information? I use this in LFUN_

RE: [PATCH] LFUN_BUFFER_FORALL

2012-07-15 Thread Scott Kostyshak
} >The lookup of commandToRun should be done at the place where the >arguments are parsed. Done. Please see the attached patch. Thank you for your help, Scottdiff --git a/src/FuncCode.h b/src/FuncCode.h index 9a7b06e..2c99432 100644 --- a/src/FuncCode.h +++ b/sr

Re: questions and proposal regarding enum FuncAttribs

2012-07-15 Thread Pavel Sanda
Jean-Marc Lasgouttes wrote: > Le 15/07/12 23:24, Pavel Sanda a écrit : >> Jean-Marc Lasgouttes wrote: >>> I think the best way would be to change LyXAction.cpp such that the >>> documentation is in string variables "action", "syntax" and "params" (added >>> to the struct). >> >> I'm not saying we c

Re: [LyX master] Fix bug #7741: incorrect locale when starting R from LyX?

2012-07-15 Thread Pavel Sanda
Jean-Marc Lasgouttes wrote: > I would appreciate feedback on how this work on linux, mac os and windows. I tested that setting LC_MESSAGES still works on Linux :) Pavel

Re: [PATCH] LFUN_BUFFER_EXPORT_ALL & File menu reorganization

2012-07-15 Thread Pavel Sanda
Scott Kostyshak wrote: > Any comments? While I think adding LFUNs you proposed makes sense, I don't think it's good idea to add this new stuff into the File menu (at most poke them away to some submenu). I would rather see the menu shrink than expand (e.g. Print). Regarding the fact how any menu

Re: doxygen command for LyXAction.cpp --> LFUNs.lyx

2012-07-15 Thread Pavel Sanda
Scott Kostyshak wrote: > How do I turn LyXAction.cpp into LFUNs.lyx? Doxygen generation is not related to LFUNs.lyx. - doxygen: make doxydoc - LFUNs.lyx: make lfundoc Pavel

Re: Bug: Too small list of paragraphs/environments when you filter with shortcuts

2012-07-15 Thread Pavel Sanda
Pavel Sanda wrote: > Richard Heck wrote: > > I see that. I'm not sure what causes it. > > This is old timer and IIRC there was even committed attempt to fix it from > Stefan long time ago. I think these are relevant: r23644,r23654 > Pavel

Re: Closing split views from the right click menu

2012-07-15 Thread Andrew Parsloe
On 15/07/2012 2:18 p.m., Richard Heck wrote: On 07/14/2012 07:08 PM, Andrew Parsloe wrote: I'm constantly working with a split window, generally left and right views. Closing one of these views to get a single main window again means going to the View menu and clicking on Close Current View, n

Re: Bug: Too small list of paragraphs/environments when you filter with shortcuts

2012-07-15 Thread Pavel Sanda
Richard Heck wrote: > I see that. I'm not sure what causes it. This is old timer and IIRC there was even committed attempt to fix it from Stefan long time ago. Pavel

Re: questions and proposal regarding enum FuncAttribs

2012-07-15 Thread Jean-Marc Lasgouttes
Le 15/07/12 23:24, Pavel Sanda a écrit : Jean-Marc Lasgouttes wrote: I think the best way would be to change LyXAction.cpp such that the documentation is in string variables "action", "syntax" and "params" (added to the struct). I'm not saying we can't go this route, just note that the current

Re: questions and proposal regarding enum FuncAttribs

2012-07-15 Thread Pavel Sanda
Scott Kostyshak wrote: > Why not? The attached patch checks whether the LFUN being called in > GuiView.cpp This works with VC_COMMAND. IIRC there are more possible entry points for LFUN execution, I'm not sure where all go through GuiView::getStatus, worth to check. > Is parsing LFUNs.lyx a bad

Re: [PATCH] LFUN_BUFFER_FORALL

2012-07-15 Thread Jean-Marc Lasgouttes
Le 15/07/12 22:35, Scott Kostyshak a écrit : Attached is a patch that implements LFUN_BUFFER_FORALL, which applies a passed LFUN command to all buffers. My motivation was that I sometimes need to do the same thing in all of the buffers that I have open. Another advantage of implementing this LFUN

Re: checking whether a buffer is hidden

2012-07-15 Thread Jean-Marc Lasgouttes
Le 15/07/12 22:37, Scott Kostyshak a écrit : From: Jean-Marc Lasgouttes [lasgout...@lyx.org] Sent: Sunday, July 15, 2012 9:34 AM Le 15/07/12 09:14, Scott Kostyshak a écrit : What is the correct way to check whether a buffer is hidden? I am currently doing the following bool const hidden = !(gu

Re: doxygen command for LyXAction.cpp --> LFUNs.lyx

2012-07-15 Thread Jean-Marc Lasgouttes
Le 15/07/12 21:07, Scott Kostyshak a écrit : How do I turn LyXAction.cpp into LFUNs.lyx? I think you need development/tools/gen_lfuns.py. JMarc

Re: questions and proposal regarding enum FuncAttribs

2012-07-15 Thread Jean-Marc Lasgouttes
Le 15/07/12 21:05, Scott Kostyshak a écrit : Ah, I see what you mean. Do you have an idea for the best way to parse LyXAction.cpp? Would any of the following strategies work well? I think the best way would be to change LyXAction.cpp such that the documentation is in string variables "action",

[PATCH] LFUN_BUFFER_EXPORT_ALL & File menu reorganization

2012-07-15 Thread Scott Kostyshak
ck here? break; + case LFUN_BUFFER_EXPORT_ALL: case LFUN_BUFFER_EXPORT: { docstring const arg = cmd.argument(); if (arg == "custom") { @@ -2247,6 +2248,12 @@ void Buffer::dispatch(FuncRequest const & func, DispatchResult & dr) break; } + case LFUN_BUFFER_EXPORT_ALL:

Re: [LyX master] Fix bug #7741: incorrect locale when starting R from LyX?

2012-07-15 Thread Jean-Marc Lasgouttes
Le 15/07/12 22:30, Jean-Marc Lasgouttes a écrit : commit 16fd47ad8f5d78a3b7266520b0868c1e2bd0dcac Author: Jean-Marc Lasgouttes Date: Sun Jul 15 22:22:10 2012 +0200 Fix bug #7741: incorrect locale when starting R from LyX? The goal here is to get rid of the old code that modified va

RE: checking whether a buffer is hidden

2012-07-15 Thread Scott Kostyshak
From: Jean-Marc Lasgouttes [lasgout...@lyx.org] Sent: Sunday, July 15, 2012 9:34 AM Le 15/07/12 09:14, Scott Kostyshak a écrit : >> What is the correct way to check whether a buffer is hidden? >> >> I am currently doing the following >> bool const hidden = !(guiApp->currentView() && >> guiApp->cur

[PATCH] LFUN_BUFFER_FORALL

2012-07-15 Thread Scott Kostyshak
FER_FORALL, // scottkostyshak, 20120715 LFUN_LASTACTION // end of the table }; diff --git a/src/LyXAction.cpp b/src/LyXAction.cpp index 39018ce..bed84c6 100644 --- a/src/LyXAction.cpp +++ b/src/LyXAction.cpp @@ -3127,6 +3139,27 @@ void LyXAction::init() */ { LFUN_BUFFER_WRITE_A

doxygen command for LyXAction.cpp --> LFUNs.lyx

2012-07-15 Thread Scott Kostyshak
How do I turn LyXAction.cpp into LFUNs.lyx? Thanks, Scott

RE: questions and proposal regarding enum FuncAttribs

2012-07-15 Thread Scott Kostyshak
From: Jean-Marc Lasgouttes [lasgout...@lyx.org] Sent: Sunday, July 15, 2012 9:41 AM Le 15/07/12 09:10, Scott Kostyshak a écrit : >>> I think theargument flag is not flexible enough to be useful. >> >> Why not? The attached patch checks whether the LFUN being called in >> GuiView.cpp has the Argume

Re: Bug: Too small list of paragraphs/environments when you filter with shortcuts

2012-07-15 Thread Richard Heck
On 07/15/2012 02:17 PM, Julian Parker wrote: When you have the pop-up list with paragraph-environments open and want to jump to certain styles by typing the first letters, the pop-up window shrinks smaller and there comes a scroll-bar when there are too many hits. It's annoying to not see the who

Re: GUI for headers and footers with fancy page-style

2012-07-15 Thread Julian Parker
2012/7/15 Richard Heck : > On 07/15/2012 10:55 AM, Julian Parker wrote: >> >> If you use fancy page-style you can use LaTeX-commands for what is >> displayed in header (left, center, right) and footer (left, center, >> right). And if a line is displayed or not. Because Lyx is for those >> people wh

Bug: Too small list of paragraphs/environments when you filter with shortcuts

2012-07-15 Thread Julian Parker
When you have the pop-up list with paragraph-environments open and want to jump to certain styles by typing the first letters, the pop-up window shrinks smaller and there comes a scroll-bar when there are too many hits. It's annoying to not see the whole list of hits, because the unfiltered complet

Re: GUI for headers and footers with fancy page-style

2012-07-15 Thread Richard Heck
On 07/15/2012 10:55 AM, Julian Parker wrote: If you use fancy page-style you can use LaTeX-commands for what is displayed in header (left, center, right) and footer (left, center, right). And if a line is displayed or not. Because Lyx is for those people who are no specialists for LaTeX it would

Bug: Zoom of editor doesn't zoom mathematical expression

2012-07-15 Thread Julian Parker
When you zoom in/out the editor (Alt+ / Alt-), everything is zoomed, but not the mathematical expressions. E.g. I have an x with a dash about it in the text (arithmetic mean) that is not zoomed in/out when I zoom in/out the editor. Lyx 2.0.4 on Windows 7

Re: Editing names for TOC, captions, ...

2012-07-15 Thread Richard Heck
On 07/15/2012 10:40 AM, Julian Parker wrote: It would be great, if the document-settings would also have a window, where you can change the fixed names that Lyx uses for some elements. E.g. "fig." instead of "figure", and the same for tables, TOC, etc. Because often users have to use special term

Re: Line-styles for tables

2012-07-15 Thread Richard Heck
On 07/15/2012 11:06 AM, Julian Parker wrote: 2012/7/15 Richard Heck : On 07/15/2012 10:37 AM, Julian Parker wrote: I think, it would be a great idea, if Lyx supports line-styles for tables. Not too much. But besides the normal line a thicker line, a dashed line and a dotted line, would be great

Re: Line-styles for tables

2012-07-15 Thread Julian Parker
2012/7/15 Richard Heck : > On 07/15/2012 10:37 AM, Julian Parker wrote: >> >> I think, it would be a great idea, if Lyx supports line-styles for >> tables. Not too much. But besides the normal line a thicker line, a >> dashed line and a dotted line, would be great. >> > Please file an enhancement r

GUI for headers and footers with fancy page-style

2012-07-15 Thread Julian Parker
If you use fancy page-style you can use LaTeX-commands for what is displayed in header (left, center, right) and footer (left, center, right). And if a line is displayed or not. Because Lyx is for those people who are no specialists for LaTeX it would be excellent, if after activation of fancy page

Re: Line-styles for tables

2012-07-15 Thread Richard Heck
On 07/15/2012 10:37 AM, Julian Parker wrote: I think, it would be a great idea, if Lyx supports line-styles for tables. Not too much. But besides the normal line a thicker line, a dashed line and a dotted line, would be great. Please file an enhancement request for this. rh

Editing names for TOC, captions, ...

2012-07-15 Thread Julian Parker
It would be great, if the document-settings would also have a window, where you can change the fixed names that Lyx uses for some elements. E.g. "fig." instead of "figure", and the same for tables, TOC, etc. Because often users have to use special terms that are given by the university, the magazin

Line-styles for tables

2012-07-15 Thread Julian Parker
I think, it would be a great idea, if Lyx supports line-styles for tables. Not too much. But besides the normal line a thicker line, a dashed line and a dotted line, would be great.

Re: questions and proposal regarding enum FuncAttribs

2012-07-15 Thread Jean-Marc Lasgouttes
Le 15/07/12 09:10, Scott Kostyshak a écrit : I think theargument flag is not flexible enough to be useful. Why not? The attached patch checks whether the LFUN being called in GuiView.cpp has the Argument flag and is trying to use an empty argument. If so, the command is disabled (from getStatus

Re: checking whether a buffer is hidden

2012-07-15 Thread Jean-Marc Lasgouttes
Le 15/07/12 09:14, Scott Kostyshak a écrit : What is the correct way to check whether a buffer is hidden? I am currently doing the following bool const hidden = !(guiApp->currentView() && guiApp->currentView()->workArea(*b)); which works fine but I'm not sure if it's the right way. This is th

checking whether a buffer is hidden

2012-07-15 Thread Scott Kostyshak
What is the correct way to check whether a buffer is hidden? I am currently doing the following bool const hidden = !(guiApp->currentView() && guiApp->currentView()->workArea(*b)); which works fine but I'm not sure if it's the right way. Thanks, Scott

RE: questions and proposal regarding enum FuncAttribs

2012-07-15 Thread Scott Kostyshak
From: Jean-Marc Lasgouttes [lasgout...@lyx.org] Sent: Thursday, July 12, 2012 5:20 AM Le 12/07/2012 09:44, Scott Kostyshak a écrit : >> It seems that there are many LFUNs that would fall under the description >> of the "Argument" flag (currently help-open is the only LFUN to specify >> it). If thi