Re: question regarding multicolumn table code

2010-01-16 Thread Vincent van Ravesteijn
The problem is that this routine fails for multirows: Assume this table a b c e f g i j k by setting cell "e" and "i" a a multirow, appendParagraphs leads to this cell content No this is not the fault of appendParagraphs. You shouldn't be looking into that function at all. "efgi" but I

Re: question regarding multicolumn table code

2010-01-16 Thread Uwe Stöhr
>> However, this doesn't work and I can't figure out why. > > at a minimum you will need to make sure that updateIndexes() takes multirows into account... This is already done. In the meantime I found now the main problem, see my last post in this thread. Thanks, for your help, I guess I need y

Re: question regarding multicolumn table code

2010-01-16 Thread Uwe Stöhr
Am 17.01.2010 01:31, schrieb Vincent van Ravesteijn: It should, but in the latex output routine, the recognition of the multirow part cells fail. How do you recognize them ? I just found a mistake in my routine where I ask if the cells are part of a multirow. I guess that if you select th

Re: question regarding multicolumn table code

2010-01-16 Thread Edwin Leuven
Uwe Stöhr wrote: However, this doesn't work and I can't figure out why. at a minimum you will need to make sure that updateIndexes() takes multirows into account...

Re: question regarding multicolumn table code

2010-01-16 Thread Vincent van Ravesteijn
Uwe Stöhr schreef: Am 17.01.2010 01:17, schrieb Vincent van Ravesteijn: Why not CELL_NORMAL, CELL_BEGIN_OF_MULTI, CELL_END_OF_MULTI.. these are exclusive anyway. It is unnecessary to determine also the end. Begin and part cells is enough information, no?. sorry I meant PART in stead of END

Re: question regarding multicolumn table code

2010-01-16 Thread Uwe Stöhr
Am 17.01.2010 01:17, schrieb Vincent van Ravesteijn: Why not CELL_NORMAL, CELL_BEGIN_OF_MULTI, CELL_END_OF_MULTI.. these are exclusive anyway. It is unnecessary to determine also the end. Begin and part cells is enough information, no?. What doesn't work ? You should at least have some code

Re: question regarding multicolumn table code

2010-01-16 Thread Vincent van Ravesteijn
But this doesn't work here: I have this enum enum { /// CELL_NORMAL = 0, /// CELL_BEGIN_OF_MULTICOLUMN, /// CELL_PART_OF_MULTICOLUMN, /// CELL_BEGIN_OF_MULTIROW, /// CELL_PART_OF_MULTIROW }; Why not CELL_NORMA

Re: question regarding multicolumn table code

2010-01-16 Thread Uwe Stöhr
Am 16.01.2010 00:19, schrieb Vincent van Ravesteijn: I think the cells aren't really merged. It is only that the "cellInfo(cell).multicolumn" is set to one of these values: /// enum { /// CELL_NORMAL = 0, /// CELL_BEGIN_OF_MULTICOLUMN, /// CELL_PART_OF_MULTICOLUMN }; So, If cell 1 and 2 are m

Re: depth and resetting itemize

2010-01-16 Thread Edwin Leuven
Jean-Marc Lasgouttes wrote: * it looks like the code should be put inside the code below (instead of the plain "return;"). i actually put it after recUndo to do this: * make sure that undo is correctly handled (I do not know whether changeDepth does it) ? Index: src/Text.cpp =

Re: Towards LyX 1.7 (2.0)

2010-01-16 Thread Vincent van Ravesteijn
we tend to write that lfun is selection-wise when it works on selected text. i can add it myself once its committed. I haven't seen that before. when editing i see on console: LayoutBox.cpp(551): Trying to select non existent layout type Plain Layout context menu missing (very usable for

Re: Towards LyX 1.7 (2.0)

2010-01-16 Thread Pavel Sanda
Vincent van Ravesteijn wrote: >>> + * \var lyx::FuncCode lyx::LFUN_PREVIEW_INSERT >>> + * \li Action: Inserts a new preview inset. >>> >> >> +(selection-wise) ? >> > ? we tend to write that lfun is selection-wise when it works on selected text. i can add it myself once its committed. >> than

Re: Towards LyX 1.7 (2.0)

2010-01-16 Thread Vincent van Ravesteijn
Pavel Sanda schreef: Vincent van Ravesteijn wrote: Here is the patch. thanks. the patch doesnt apply here because of wrong base dirs. No problem here (on linux). +#include "insets/InsetPreview.h" this file is missing in my tree I forgot to do "svn add". Anyway, the

Re: Towards LyX 1.7 (2.0)

2010-01-16 Thread Vincent van Ravesteijn
Pavel Sanda schreef: Vincent van Ravesteijn wrote: + * \var lyx::FuncCode lyx::LFUN_PREVIEW_INSERT + * \li Action: Inserts a new preview inset. +(selection-wise) ? pavel ? Vincent

Re: Towards LyX 1.7 (2.0)

2010-01-16 Thread Pavel Sanda
Vincent van Ravesteijn wrote: > + * \var lyx::FuncCode lyx::LFUN_PREVIEW_INSERT > + * \li Action: Inserts a new preview inset. +(selection-wise) ? pavel

Re: Towards LyX 1.7 (2.0)

2010-01-16 Thread Pavel Sanda
Vincent van Ravesteijn wrote: > Here is the patch. thanks. the patch doesnt apply here because of wrong base dirs. > +#include "insets/InsetPreview.h" this file is missing in my tree > + { Color_previewframe, N_("preview frame"), "previewframe", black, > "previewframe"}, "black" pavel

Re: Towards LyX 1.7 (2.0)

2010-01-16 Thread Vincent van Ravesteijn
Here is the patch. Objections ? Vincent Now the correct one. Vincent Index: src/Text3.cpp === --- src/Text3.cpp (revision 33051) +++ src/Text3.cpp (working copy) @@ -1569,6 +1569,7 @@ case LFUN_MARGINALNOTE_

Re: Towards LyX 1.7 (2.0)

2010-01-16 Thread Vincent van Ravesteijn
Pavel Sanda schreef: Pavel Sanda wrote: - Are there other missing features that you are working on and that you want to have in LyX 1.7 before a beta release? revision info under VCS is still in plan (fileformat change). but not necessarily before beta, shouldn't be big change...

Re: depth and resetting itemize

2010-01-16 Thread Jean-Marc Lasgouttes
Le 16/01/2010 10:52, Edwin Leuven a écrit : i remember a discussion a long time ago (i think it was jean-marc who then suggested behavior like this) Excellent idea :) However, about the implmentation: * it looks like the code should be put inside the code below (instead of the plain "return;")

depth and resetting itemize

2010-01-16 Thread Edwin Leuven
hi guys, at the moment it is a bit involved to snap out of an itemize or enumerate the attached a little patch allows the following when the cursor is in an empty indented item: 1. blah (a) | then decreases the depth: 1. blah 2. | and when at the 1st level in an empty itemize/enumerat