Re: [patch] fix bug 4128: branches cannot be renamed

2009-07-10 Thread Jürgen Spitzmüller
Uwe Stöhr wrote: > - when I press rename, the dialog should display me the current name > highlighted (The same way of the filename when you use Save As) because one > often only wants to add some characters or delete some. This also fixes the > case when you press rename, do nothing and press OK.

Re: [patch] branch paste check and LFUN_BRANCH_ADD

2009-07-10 Thread Jürgen Spitzmüller
Pavel Sanda wrote: > i missed that you actually added child/master distinction into the document > preferences. This commit was not intended. I'll revert it (the buttons do nothing yet). Jürgen

Re: [patch] fix longtable bug 6057

2009-07-10 Thread Jürgen Spitzmüller
Uwe Stöhr wrote: > > Why this? The first header is not empty. The first header is the caption. > > That's confusing: The table dialog states that the first header is not > empty, so the user might look for the row of the first header but cannot > find it. > When the first header is really the capti

Re: For branch ?

2009-07-10 Thread Jürgen Spitzmüller
Vincent van Ravesteijn wrote: > Can I start backporting the fixes for the following bugs: > > 5998, 2034, 2213, 3706, 3918, 4177, 4509, 4952, 5390, 5435, 5458, 5944, > 5948 ? Yes. Please post the patches subsequently. Jürgen

For branch ?

2009-07-10 Thread Vincent van Ravesteijn
Juergen, Can I start backporting the fixes for the following bugs: 5998, 2034, 2213, 3706, 3918, 4177, 4509, 4952, 5390, 5435, 5458, 5944, 5948 ? Vincent

Sweave string

2009-07-10 Thread Pavel Sanda
JMarc, would you oppposed to shortcut the string "Sweave - S/R literate programming". on the attached picture is a screenshot how modules list looks here - the bottom scrollbar is bit annoying. pavel <>

Re: [patch] branch paste check and LFUN_BRANCH_ADD

2009-07-10 Thread Pavel Sanda
Jürgen Spitzmüller wrote: > * in general, I'd like to have a toggle in children's document dialog where > the user can chose if he wants to edit the children's or the master's > properties. I started with this, but it entails all sorts of changes. i missed that you actually added child/master di

Re: Printing comments module

2009-07-10 Thread Pavel Sanda
Richard Heck wrote: > Pavel Sanda wrote: >> i see. as there was no feedback i suppose this module will stay locally on >> my box, so no additional tweaks needed... >> >> > Actually, I meant to be endorsing it. is this correct? pavel commit c5d65f6eb648e7c109530a18128ddc718503facf Author: Pavel

Re: [patch] branch paste check and LFUN_BRANCH_ADD

2009-07-10 Thread Pavel Sanda
Pavel Sanda wrote: > great , i'll prepare new patch once Juergen stuff is in. if there is no objection i'll commit this one soon. pavel diff --git a/lib/ui/stdmenus.inc b/lib/ui/stdmenus.inc index f0d8778..6758889 100644 --- a/lib/ui/stdmenus.inc +++ b/lib/ui/stdmenus.inc @@ -463,6 +463,8 @@ Menus

Re: What about LyX 1.7 instead of 2.0? LyX Meeting?

2009-07-10 Thread José Matos
On Friday 10 July 2009 07:08:25 Pavel Sanda wrote: > one more thing i wanted to add is - once Jose decides to choose our release > date we should be more strict for allowing branch enhacements. i'm very > grateful for Juergen's openness for new features in, but for the last few > versions we should

Re: What about LyX 1.7 instead of 2.0? LyX Meeting?

2009-07-10 Thread José Matos
On Thursday 09 July 2009 15:55:13 Abdelrazak Younes wrote: > Maybe it'd be good to have a list of feature that we (global we) have > still in the pipe. Personally I plan to add hunspell support and to help > Vincent with the soon to be disclosed "Compare" feature (Sorry Vincent > ;-). I would also

Re: What about LyX 1.7 instead of 2.0? LyX Meeting?

2009-07-10 Thread José Matos
On Thursday 09 July 2009 15:49:53 rgheck wrote: > > I've been having similar thoughts, but I don't know if September is > reasonable, at least if we want HTML output to be in a usable state. I'm > not sure how much time I'll have between now and then. Of course, it > could be disabled for 1.7.0 and

Re: [patch] fix longtable bug 6057

2009-07-10 Thread Uwe Stöhr
> Why this? The first header is not empty. The first header is the caption. That's confusing: The table dialog states that the first header is not empty, so the user might look for the row of the first header but cannot find it. When the first header is really the caption (probably the longtable

Re: Symlinks problem

2009-07-10 Thread rgheck
Pavel Sanda wrote: see why you might want to do what you describe. Perhaps in that case we should only allow these buffers to be opened read-only? very good idea. should i bugzilla it? Sure. rh

Re: trac account?

2009-07-10 Thread rgheck
Jean-Marc Lasgouttes wrote: rgheck writes: Do I have a trac account? If so, can someone tell me what my username and email address are so I can reset my password? You e-mail address is not set, which is a shame. Your login name is "rgheck" and your password is probably the same as fo

Re: [patch] fix longtable bug 6057

2009-07-10 Thread Jürgen Spitzmüller
Uwe Stöhr wrote: > > As far as I can see, the real fix would be to assure that the caption row > > > is terminated by an \endfirsthead, not by a \tabularnewline, if no first > > header is used. > > That is correct, but that is the same as if you set the first header to be > empty. With your patch

Re: Bug #5522

2009-07-10 Thread rgheck
Sergiu Carpov wrote: Should I send you a patch file? By the way about what patch you are speaking? The one with only string comparisons or with a new FileName? No, we figured it out. I'll just use the string comparison for now. It looks as if the whole DocFileName thing could use some work.

Re: [patch] fix bug 4128: branches cannot be renamed

2009-07-10 Thread Jürgen Spitzmüller
Uwe Stöhr wrote: > many thanks for implementing this! This should also go to branch if > possible. IMHO this is too complicated for branch. >- when I press rename, the dialog should display me the > current name highlighted (The same way of the filename when you use Save > As) because one often

Re: [patch] fix bug 4128: branches cannot be renamed

2009-07-10 Thread Jürgen Spitzmüller
Jean-Marc Lasgouttes wrote: > A single undo().recordUndo(it) at the right place in renameBranches > should suffice. OK, thanks. > A more annoying problem is that your existing code only iterates over > top-level insets. And this is at the price of code that is more > complicated than a forwardIns

Re: trac account?

2009-07-10 Thread Jean-Marc Lasgouttes
rgheck writes: > Do I have a trac account? If so, can someone tell me what my username > and email address are so I can reset my password? You e-mail address is not set, which is a shame. Your login name is "rgheck" and your password is probably the same as for svn. JMarc

Re: Keytest: Screenshots of Crashes, Samples and Patch.

2009-07-10 Thread Pavel Sanda
John McCabe-Dansted wrote: > I have made a new diff against the svn. > http://gmatht.homelinux.net/xp/svn.diff yep, i have commited it into trunk. keep the pacthes coming :) > > for bugs without this we should invent something another so we dont > > overpopulate bugzilla. maybe adding links int

trac account?

2009-07-10 Thread rgheck
Do I have a trac account? If so, can someone tell me what my username and email address are so I can reset my password? rh

Re: Bugs / Trac

2009-07-10 Thread Pavel Sanda
Pavel Sanda wrote: > of unfixed bugs to proper components, reseting old keywords should be ok now.) old "components" of course > it even seems that mails are not sent with this operation. so keep your hats i > plan to do the massive priorities movement soon ;) > > pavel

Re: Bugs / Trac

2009-07-10 Thread Pavel Sanda
Jean-Marc Lasgouttes wrote: > it actually works reliably enough. This is the problems with all these > plugins: they are not always actively maintained. i just tried small experiment to move residual guii bugs into frontend-qt4 and everything seem to work well. (this also should finish the movemen

Re: [patch] fix bug 4128: branches cannot be renamed

2009-07-10 Thread Jean-Marc Lasgouttes
Pavel Sanda writes: > it will be probably difficult to get consesus on this. > personally i would rather see the changes only buffer-related, > but i see the drawbacks too. This is why I proposed to have a general switch "see document as a whole". It could be buffer-local, but this creates intere

Re: Bugs / Trac

2009-07-10 Thread Jean-Marc Lasgouttes
Pavel Sanda writes: > Jean-Marc Lasgouttes wrote: >> I think I have something for you. Try a custom query and tell me what >> you think. > > bugza masta wow! For the entertainment of others, what he sees now (and juergen sees it too I think) is the batch ticket updater plugin. http://trac-ha

Re: What about LyX 1.7 instead of 2.0? LyX Meeting?

2009-07-10 Thread Abdelrazak Younes
Pavel Sanda wrote: the search and replace feature is imho in a very unfinished state. last tiutme i tried it was extremely slow for bigger documents, full of crashes and disabled 'features'. i even thought whether we disable it for a release since nobody seems to maintain it... I agree about t

Re: [patch] fix bug 4128: branches cannot be renamed

2009-07-10 Thread Pavel Sanda
Jean-Marc Lasgouttes wrote: > I should revive my inset-foreach patch. i was going to ask for this one day... >The question I am not sure about > is whether it should iterate into child documents. it will be probably difficult to get consesus on this. personally i would rather see the changes onl

Re: Bugs / Trac

2009-07-10 Thread Pavel Sanda
Jean-Marc Lasgouttes wrote: > I think I have something for you. Try a custom query and tell me what > you think. bugza masta wow! pavel

Re: Bugs / Trac

2009-07-10 Thread Pavel Sanda
Jean-Marc Lasgouttes wrote: > >> i would simply reset it to general. imho these are clearly for removal: > >> > >> frontend-* except qt4 > >> guii (move to frontend-qt4?) > > or keep separate frontend and frontend-qt4. if it was on me i would merge them. > >> lyxlex > > Why? (I just renamed it

backporting fixes for LyX 1.6.4

2009-07-10 Thread Uwe Stöhr
Looking at http://www.lyx.org/trac/wiki/BugTrackerHome one can see that there are 16! bugs marked as fixedintrunk and milestone 1.6.4. They should go in now to have time to test the fixes before LyX 1.6.4 is out. regards Uwe

Re: [patch] fix longtable bug 6057

2009-07-10 Thread Uwe Stöhr
> As far as I can see, the real fix would be to assure that the caption row > is terminated by an \endfirsthead, not by a \tabularnewline, if no first > header is used. That is correct, but that is the same as if you set the first header to be empty. With your patch the bug is also fixed, but th

Re: [patch] fix bug 4128: branches cannot be renamed

2009-07-10 Thread Uwe Stöhr
Uwe Stöhr schrieb: However there are two problems: - all branch insets appear now at the right side of the screen instead of on the left side This was only a leftover from my SVN tree. regards Uwe

Re: [patch] fix bug 4128: branches cannot be renamed

2009-07-10 Thread Uwe Stöhr
Hello Jürgen, many thanks for implementing this! This should also go to branch if possible. However there are two problems: - all branch insets appear now at the right side of the screen instead of on the left side - when I press rename, the dialog should display me the current name highlight

Re: hunspell or enchant support?

2009-07-10 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: Abdelrazak Younes writes: Jean-Marc Lasgouttes wrote: Abdelrazak Younes writes: I thought this was because some distribution likes and others like Yes it is. However... In any case, I think we should use and in the

Re: What about LyX 1.7 instead of 2.0? LyX Meeting?

2009-07-10 Thread José Matos
On Friday 10 July 2009 06:53:18 Pavel Sanda wrote: > Abdelrazak Younes wrote: > > What about LyX 1.7 instead of 2.0? > > i would rather have 1.7 instead of 2.0 actually. 2.0 for xml change > looks reasonable. I don't disagree (yeah I know about the problems with double negatives ;-) ). And yes, I

Re: Keytest: Screenshots of Crashes, Samples and Patch.

2009-07-10 Thread Jean-Marc Lasgouttes
Abdelrazak Younes writes: > Or course an 'lyx2lyx *' could be added to the begining of the > scripts. As an added bonus, this would then test lyx2lyx at the same > time :-) I think it is too strict. JMarc

Re: hunspell or enchant support?

2009-07-10 Thread Jean-Marc Lasgouttes
Abdelrazak Younes writes: > Jean-Marc Lasgouttes wrote: >> Abdelrazak Younes writes: >> >>> I thought this was because some distribution likes and >>> others like >>> >> >> Yes it is. However... >> >> >>> In any case, I think we should use and in >>> the code and adjust the includ

Re: Bugs / Trac

2009-07-10 Thread Jean-Marc Lasgouttes
Pavel Sanda writes: >> i would simply reset it to general. imho these are clearly for removal: >> >> frontend-* except qt4 >> guii (move to frontend-qt4?) or keep separate frontend and frontend-qt4. >> linuxdoc export ok >> lyxlex Why? (I just renamed it to lexer btw) >> relyx ok >> suppo

Re: [patch] fix bug 4128: branches cannot be renamed

2009-07-10 Thread Jean-Marc Lasgouttes
Jürgen Spitzmüller writes: > Jean-Marc Lasgouttes wrote: >> Doing a recordUndo for >> each inset (with cursor in the paragraph containing the inset) should >> just work (the undo group is created in the LyXFunc::dispatch >> machinery). > > How do I access the cursor from within Buffer::dispatch()

Re: [patch] fix bug 4128: branches cannot be renamed

2009-07-10 Thread Jean-Marc Lasgouttes
Pavel Sanda writes: > Jean-Marc Lasgouttes wrote: >> Please don't, this is very expensive in memory. Doing a recordUndo for >> each inset (with cursor in the paragraph containing the inset) should >> just work (the undo group is created in the LyXFunc::dispatch >> machinery). > > on the other han

Re: boost in trunk does not compile with gcc-4.4

2009-07-10 Thread Jean-Marc Lasgouttes
Helge Hafting writes: > Abdelrazak Younes wrote: >> rgheck wrote: >>> >>> I reported this a while back, and the advice was to use external boost. >> >> Well even if the advice is true this should be fixed. gcc-4.4 is out >> so we should support it. Maybe it is just a matter of upgrading our >> in

Re: Bugs / Trac

2009-07-10 Thread Jean-Marc Lasgouttes
Christian Ridderström writes: > I've never used 'website' myself, but I think it'd be good to have if > I ever do get around to using the issue tracking system for issues > related to the wiki/web site. Which I really should. In fact, given > that, I might even want two separate components (or cat

Re: Bugs / Trac

2009-07-10 Thread Jean-Marc Lasgouttes
Pavel Sanda writes: > hah we are in a deadlock ;) i moved some but have waited for your nod > which components to knock down. > > as for my coloring obsession i have though if there is possibility > to communicate by trac via sql would it be possible to run some > query which in the first run put

Re: Keytest: Screenshots of Crashes, Samples and Patch.

2009-07-10 Thread Abdelrazak Younes
Pavel Sanda wrote: Abdelrazak Younes wrote: For example we can test that a given sequence of LFUNs produces a lyx file that is identical to an archived lyx file on svn. So in my idea a test case would contain: * an optional lyx file input in case the test is about a mutating sequence (eg:

Re: Bugs / Trac

2009-07-10 Thread Pavel Sanda
Pavel Sanda wrote: > Pavel Sanda wrote: > > > Yes, I can do that. You should maybe first reset the bugs that use that > > > to "general" component (or a new "obsolete" component?) > > > > i would simply reset it to general. imho these are clearly for removal: > > > > frontend-* except qt4 > > gui

Re: hunspell or enchant support?

2009-07-10 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: Abdelrazak Younes writes: I thought this was because some distribution likes and others like Yes it is. However... In any case, I think we should use and in the code and adjust the include paths instead if need be. ... this is what the code

Re: boost in trunk does not compile with gcc-4.4

2009-07-10 Thread Abdelrazak Younes
Helge Hafting wrote: Abdelrazak Younes wrote: rgheck wrote: I reported this a while back, and the advice was to use external boost. Well even if the advice is true this should be fixed. gcc-4.4 is out so we should support it. Maybe it is just a matter of upgrading our internal boost? If

Re: [patch] fix bug 4128: branches cannot be renamed

2009-07-10 Thread Pavel Sanda
Jean-Marc Lasgouttes wrote: > Please don't, this is very expensive in memory. Doing a recordUndo for > each inset (with cursor in the paragraph containing the inset) should > just work (the undo group is created in the LyXFunc::dispatch > machinery). on the other hand this lfun would be called onc

Re: Bugs / Trac

2009-07-10 Thread Pavel Sanda
Jean-Marc Lasgouttes wrote: > Pavel Sanda writes: > > JMarc, do you plan to update the components list? > > I was waiting to see whether you would first reaffect all those bugs to > other components :) More seriously, I want to search a bit more whether > there is a trac-approved way of getting r

Re: [patch] fix longtable bug 6057

2009-07-10 Thread Jürgen Spitzmüller
Jürgen Spitzmüller wrote: > Jürgen Spitzmüller wrote: > > In any case, I'd like to understand the actual problem first. > > As far as I can see, the real fix would be to assure that the caption row > is terminated by an \endfirsthead, not by a \tabularnewline, if no first > header is used. The att

Re: boost in trunk does not compile with gcc-4.4

2009-07-10 Thread Helge Hafting
Abdelrazak Younes wrote: rgheck wrote: I reported this a while back, and the advice was to use external boost. Well even if the advice is true this should be fixed. gcc-4.4 is out so we should support it. Maybe it is just a matter of upgrading our internal boost? If external boost works s

Re: Bug #5522

2009-07-10 Thread Sergiu Carpov
Should I send you a patch file? By the way about what patch you are speaking? The one with only string comparisons or with a new FileName? 2009/7/9 rgheck > > OK, Sergiu, I think we'll go with your last patch, then. > > We don't have to have a GPL statement for little things like this, but if

Re: hunspell or enchant support?

2009-07-10 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: Abdelrazak Younes writes: And a patch that actually compiles... This looks reasonable (although the existing autotools code could use a cleanup). Do you have problems with it? Could you send a "diff -wu" version in order to hide spacing changes? Here

Re: [patch] fix bug 4128: branches cannot be renamed

2009-07-10 Thread Jürgen Spitzmüller
Jean-Marc Lasgouttes wrote: > Doing a recordUndo for > each inset (with cursor in the paragraph containing the inset) should > just work (the undo group is created in the LyXFunc::dispatch > machinery). How do I access the cursor from within Buffer::dispatch() and/or Buffer::renameBranches()? Jü

Re: hunspell or enchant support?

2009-07-10 Thread Helge Hafting
Abdelrazak Younes wrote: I hope the shared library is good enough, seems a better idea than including extra source code. On my system (ubuntu) I also have these these two packages but absolutely no program depends on them. So LyX has a chance to be first. We can always file complaints again

Re: Bug #5522

2009-07-10 Thread Sergiu Carpov
I hereby grant permission to license my contributions to LyX under the Gnu General Public Licence, version 2 or later. Thanks. 2009/7/9 rgheck > Jean-Marc Lasgouttes wrote: > >> rgheck writes: >> >> >>> Unfortunately, this does not work, because the operator== also compares > the > sav

Re: [patch] fix bug 4128: branches cannot be renamed

2009-07-10 Thread Jean-Marc Lasgouttes
Pavel Sanda writes: >> I'm not sure where the undo hooks should be placed. I've tried >> beginUndoGroup >> and endUndoGroup in the lfuns, to no avail. >> >> In the case of LFUN_BRANCHES_RENAME, it should be part of an undo group >> which >> is opened by the document dialog's params apply. > >

Re: hunspell or enchant support?

2009-07-10 Thread Jean-Marc Lasgouttes
Abdelrazak Younes writes: > I thought this was because some distribution likes and > others like Yes it is. However... > In any case, I think we should use and in > the code and adjust the include paths instead if need be. ... this is what the code already does, so the tests are useless. J

Re: Bugs / Trac

2009-07-10 Thread Jean-Marc Lasgouttes
Pavel Sanda writes: > JMarc, do you plan to update the components list? I was waiting to see whether you would first reaffect all those bugs to other components :) More seriously, I want to search a bit more whether there is a trac-approved way of getting rid of components. JMarc

Re: spellcheck

2009-07-10 Thread Pavel Sanda
Abdelrazak Younes wrote: > for holidays for two weeks starting tomorrow. enjoy! :) pavel

Re: Another problem with TRAC

2009-07-10 Thread Pavel Sanda
Christian Ridderström wrote: > On Wed, 8 Jul 2009, Vincent van Ravesteijn - TNW wrote: > >> Users can assign bugs to themselves (see bug 6058). I guess that, although >> we don't use the assign thingie very often, this is not wanted. > > Sorry for the stupid question, but why is it bad to assign i

Re: Bugs / Trac

2009-07-10 Thread Pavel Sanda
Christian Ridderström wrote: > On Tue, 7 Jul 2009, Pavel Sanda wrote: > >> and these are for discussion - i dont remember them to be much used: >> >> minibuffer >> website >> lyxtext >> lyxserver > > I've never used 'website' myself, but I think it'd be good to have if I > ever do get around to us

Re: Keytest: Screenshots of Crashes, Samples and Patch.

2009-07-10 Thread Pavel Sanda
Abdelrazak Younes wrote: > For example we can test that a given sequence of LFUNs produces a lyx file > that is identical to an archived lyx file on svn. So in my idea a test case > would contain: > * an optional lyx file input in case the test is about a mutating sequence > (eg: LFUN_BRANCHES_

Re: [patch] fix bug 4128: branches cannot be renamed

2009-07-10 Thread Pavel Sanda
Jürgen Spitzmüller wrote: > Pavel Sanda wrote: > > > Pavel, please tell me if this interferes with your branch-add-insert > > > plans, then I wait until that one is in. > > > > not at all. i like this feature very much. > > OK, it's in. > > There is one remaining problem, which is not restricted

Re: [patch] fix longtable bug 6057

2009-07-10 Thread Jürgen Spitzmüller
Jürgen Spitzmüller wrote: > In any case, I'd like to understand the actual problem first. As far as I can see, the real fix would be to assure that the caption row is terminated by an \endfirsthead, not by a \tabularnewline, if no first header is used. However, what if the user wants, for whate

Re: spellcheck

2009-07-10 Thread Abdelrazak Younes
Pavel Sanda wrote: Abdelrazak Younes wrote: if it's easy to add "replace all" to the spellcheck dialog you would make at least 1 person very happy ;-) Turned out to be quite easy so I just added the button. Please test. btw we might want new toolbar icon for c

Re: Keytest: Screenshots of Crashes, Samples and Patch.

2009-07-10 Thread Abdelrazak Younes
Pavel Sanda wrote: Abdelrazak Younes wrote: Thinking more about it, this lyxserver and the work John has been doing can be re-used to define automatic test cases for all our features. i'm interested how you imagine such kind of _useful_ script. to test that we don't crash on ctrl+n is