Jürgen Spitzmüller wrote:
> Pavel Sanda wrote:
> > > Pavel, please tell me if this interferes with your branch-add-insert
> > > plans, then I wait until that one is in.
> >
> > not at all. i like this feature very much.
> 
> OK, it's in.
> 
> There is one remaining problem, which is not restricted to my change, though:
> 
> The LFUN_BRANCHES_RENAME is not undo-recorded. The same applies to other 
> buffer lfuns such as LFUN_BRANCH_ACTIVATE.
> 
> I'm not sure where the undo hooks should be placed. I've tried beginUndoGroup 
> and endUndoGroup in the lfuns, to no avail.
> 
> In the case of LFUN_BRANCHES_RENAME, it should be part of an undo group which 
> is opened by the document dialog's params apply.

i guess that recordfulldocumentundo or how is that function exactly called 
could be just
called in those lfun handlers?
pavel

Reply via email to