Abdelrazak Younes wrote:
> Both looks good to me. Somebody please commit them (or wait until you have
> commit privilege).
i did this on your request.
pavel
Currently any change on existing documents you make with LyX 1.6svn will delete table alignment
informations:
http://bugzilla.lyx.org/show_bug.cgi?id=5250
So please don't commit anything to documentation files until this is fixed.
(I'm now off again for a week.)
regards Uwe
Uwe Stöhr wrote:
> Uwe Stöhr schrieb:
>
>> I just made an SVN update and compiled LyX 1.6. But in contrary to Monday
>> evening, no toolbar is shown. I can set up in the UI-files and the View
>> menu settings what I want, but they won't be shown.
>> -> a release blocker
>
> This bug is more worse
>>mutable bool margin_beg_sel;
>>mutable bool margin_end_sel;
>
>if these bools indicate whether you want to draw some selection to
>either the left or right, why not simply call >them:
>
>leftmargin_sel
>rightmargin_sel
>
>(just ignore me if it shows that i didn't study your patch)
Yes,
>mutable bool margin_beg_sel;
>mutable bool margin_end_sel;
if these bools indicate whether you want to draw some selection to either the
left or right, why not simply call them:
leftmargin_sel
rightmargin_sel
(just ignore me if it shows that i didn't study your patch)
Uwe Stöhr schrieb:
I just made an SVN update and compiled LyX 1.6. But in contrary to
Monday evening, no toolbar is shown. I can set up in the UI-files and
the View menu settings what I want, but they won't be shown.
-> a release blocker
This bug is more worse: The whole toolbar handling is
Abdelrazak Younes schrieb:
Upgrading boost would be the best thing to do...
Who can do this?
regards Uwe
Abdelrazak Younes wrote:
Yes, that sounds a better and cleaner solution. We basically only keep
rows that are shown on screen in memory so adding two move variable is
not a big problem.
Abdel.
Hi,
I sort of cut the new code in four. It is no longer computed for and
after the checksum and th
On Sat, Sep 13, 2008 at 05:21:27PM +0200, Abdelrazak Younes wrote:
> Vincent van Ravesteijn - TNW wrote:
>>
>>
>>> Vincent van Ravesteijn - TNW wrote:
>>>
In the following piece of code, the tmpInset was deleted if
insetAllowed was false. After the change, tmpInset is deleted wh
Uwe Stöhr wrote:
One of todays changesets makes LyX uncompilable:
I fixed that, an unfinished svn commit apparently, don't understand what
happened.
I'm btw. annoyed by this message:
Unknown compiler version - please run the configure tests and report
the results, LyX-TODO: update boost!
One of todays changesets makes LyX uncompilable:
Text2.cpp
Unknown compiler version - please run the configure tests and report the results, LyX-TODO: update
boost!
D:\LyXSVN\lyx-devel\src\Text2.cpp(93) : error C2440: 'initializing' : cannot convert from 'const
lyx::Inset' to 'const lyx::Inset
Abdelrazak Younes wrote:
Vincent van Ravesteijn - TNW wrote:
As a general comment on the patch, I didn't review it in detail but
I feel that this is a lot of additional code.
The only new code is in the logic whether to draw the margins or not.
And this was just the problem that I had with h
Vincent van Ravesteijn - TNW wrote:
As a general comment on the patch, I didn't review it in detail but
I feel that this is a lot of additional code.
The only new code is in the logic whether to draw the margins or not.
And this was just the problem that I had with how LyX drawn the
Vincent van Ravesteijn - TNW wrote:
Vincent van Ravesteijn - TNW wrote:
In the following piece of code, the tmpInset was deleted if
insetAllowed was false. After the change, tmpInset is deleted when
insetAllowed is true.
This leads to disappearing Insets and crashes. I'd suggest add
>Vincent van Ravesteijn - TNW wrote:
>> In the following piece of code, the tmpInset was deleted if
>> insetAllowed was false. After the change, tmpInset is deleted when
>> insetAllowed is true.
>>
>> This leads to disappearing Insets and crashes. I'd suggest adding a
!.
>>
>
>Oups, sorry.
> As a general comment on the patch, I didn't review it in detail but
> I feel that this is a lot of additional code.
The only new code is in the logic whether to draw the margins or not.
And this was just the problem that I had with how LyX drawn the margins.
Sometimes it does, sometimes with
Vincent van Ravesteijn wrote:
Abdel,
I took the liberty to change the drawParagraph function in
TextMetrics.cpp a bit. This because, after you asked me to use
meaningfull names for the variables, I tried to understand the other
names in the function and I didn't succeed. I felt that variables
Vincent van Ravesteijn wrote:
Vincent van Ravesteijn - TNW wrote:
First, when only selecting the end_margin between 'after i-1' and
'before i', the anchor is incorrectly set to be equal to the cur. This
is because comparing two CursorSlices does not take into account the
boundary property (beca
Uwe Stöhr schrieb:
You need to have an opened Internet connection while installing LyX or
while reconfiguring it. Then all packages needed by LyX are
automatically installed. The alternative Windows installer provides
the best possible support for this:
http://wiki.lyx.org/Windows/LyXWinInstal
Vincent van Ravesteijn wrote:
Abdel,
I took the liberty to change the drawParagraph function in
TextMetrics.cpp a bit. This because, after you asked me to use
meaningfull names for the variables, I tried to understand the other
names in the function and I didn't succeed. I felt that variables
Uwe Stöhr wrote:
> is that repaired when you unset
> tools->preferences->Allow saving/restoring of windows geometry
> save & restart lyx.
Yes. But this option has always been by default turned on. And until
Monday evening, this workaround wasn't needed. It cannot be that users
first have to mo
Vincent van Ravesteijn - TNW wrote:
In the following piece of code, the tmpInset was deleted if insetAllowed
was false. After the change, tmpInset is deleted when insetAllowed is
true.
- if (!toPar.insetAllowed(tmpInset->lyxCode())) {
+ Inset * inset = toPar.inInset();
+ if (inset&& inset->
22 matches
Mail list logo
