Re: [PATCH2] Re: LFUN for global change of note-insets type

Pavel Sanda wrote: > > //view()->cursor().recordUndoFullDocument(); let > > inset-apply do that job > > graphics::unifyGraphicsGroups(*lyx_view_->buffer(), > > argument); > > lyx_view_->buffer()->markDirty(); > > > > This is not needed

Re: [PATCH2] Re: LFUN for global change of note-insets type

Jean-Marc Lasgouttes wrote: > >> dispatch wants it, what made me wonder why lyxfunc dispatch wants cursor. > > > > actually inset dispatch, not lyxfunc dispatch. > > Do not use inset::dispach, but lyx::dispatch. this is typo or you mean it? lyx::dispatch is not in header and looks like only some

Re: [PATCH2] Re: LFUN for global change of note-insets type

Jean-Marc Lasgouttes wrote: > Let's see... > > case LFUN_GRAPHICS_GROUPS_UNIFY: { > LASSERT(lyx_view_, /**/); > if (argument.empty() || !lyx_view_->buffer()) > break; > > I do not see why you test against an e

Re: www-site source is not completly in svn

On Wed, 18 Jun 2008, Alex wrote: Hi! I would like to update my localised site (http::/lyx.hu) to the new design, therefore I made an "svn update" to www-original. Unfortunately, not all the files required for the new design are in under revision control. It would wise to have them all together

Re: [PATCH2] Re: LFUN for global change of note-insets type

Pavel Sanda <[EMAIL PROTECTED]> writes: > this issue is related to LFUN_GRAPHICS_GROUPS_UNIFY case, which is in a sense > similar lfun. Let's see... case LFUN_GRAPHICS_GROUPS_UNIFY: { LASSERT(lyx_view_, /**/); if (argument.empty() |

Re: [PATCH2] Re: LFUN for global change of note-insets type

Pavel Sanda <[EMAIL PROTECTED]> writes: > Pavel Sanda wrote: >> dispatch wants it, what made me wonder why lyxfunc dispatch wants cursor. > > actually inset dispatch, not lyxfunc dispatch. Do not use inset::dispach, but lyx::dispatch. JMarc

www-site source is not completly in svn

Hi! I would like to update my localised site (http::/lyx.hu) to the new design, therefore I made an "svn update" to www-original. Unfortunately, not all the files required for the new design are in under revision control. It would wise to have them all together also for archiving purposes. Pleas

Re: [PATCH2] Re: LFUN for global change of note-insets type

Abdelrazak Younes wrote: > index ad802c7..91b06e6 100644 > --- a/src/LyXFunc.cpp > +++ b/src/LyXFunc.cpp > @@ -583,6 +583,7 @@ FuncStatus LyXFunc::getStatus(FuncRequest const & cmd) > const > case LFUN_INSET_EDIT: > case LFUN_ALL_INSETS_TOGGLE: > case LFUN_GRAPHICS_GROUPS_UNIFY:

Re: [PATCH2] Re: LFUN for global change of note-insets type

Pavel Sanda wrote: > dispatch wants it, what made me wonder why lyxfunc dispatch wants cursor. actually inset dispatch, not lyxfunc dispatch. pavel

RE: Scrolling and painting is incredibly slow these days

and another profile, from linux this time: http://ecodip.net/scroll.zip

Re: [PATCH2] Re: LFUN for global change of note-insets type

Abdelrazak Younes wrote: > Pavel Sanda wrote: >> Abdelrazak Younes wrote: >> >>> * You don't need BufferView, passing 'Inset &' is good enough. >>> >> >> how i get view->cursor() from an inset? >> > Ah, I didn't see that you needed it. This is bad... i don't need it :) dispatch wants it

Re: [PATCH2] Re: LFUN for global change of note-insets type

Pavel Sanda <[EMAIL PROTECTED]> writes: > i hoped you finish http://wiki.lyx.org/Devel/NotesOnDispatchMechanism Yes, I should :) JMarc

Re: [PATCH2] Re: LFUN for global change of note-insets type

Pavel Sanda wrote: Abdelrazak Younes wrote: * You don't need BufferView, passing 'Inset &' is good enough. how i get view->cursor() from an inset? Ah, I didn't see that you needed it. This is bad... Abdel.

Re: [PATCH2] Re: LFUN for global change of note-insets type

Abdelrazak Younes wrote: > * You don't need BufferView, passing 'Inset &' is good enough. how i get view->cursor() from an inset? pavel

Re: [PATCH2] Re: LFUN for global change of note-insets type

Jean-Marc Lasgouttes wrote: > Abdelrazak Younes <[EMAIL PROTECTED]> writes: > > > This LFUN should go to Text or Buffer, not to LyXFunc. > > Yes, buffer is a better choice. LFUN_GRAPHICS_GROUPS_UNIFY should go into buffer too ? i hoped you finish http://wiki.lyx.org/Devel/NotesOnDispatchMechanis

Re: [PATCH2] Re: LFUN for global change of note-insets type

rgheck wrote: And then we have the insets as they're written in the LyX file, which isn't \begin_inset Note:Comment but: \begin_inset Note Comment So here's another thing that should be standardized, it seems to me, preferably as something like: \begin_inset Note Type Comment

Re: [PATCH2] Re: LFUN for global change of note-insets type

rgheck <[EMAIL PROTECTED]> writes: > in this case, you can't actually do this right now, because "Note" > won't hit anything. You'd need something like "Note:Comment", or > whatever. There's reason to want what name() does here, but this > should really be another function, and name() should just

Re: [PATCH2] Re: LFUN for global change of note-insets type

Abdelrazak Younes wrote: Jean-Marc Lasgouttes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: However, this kind of code makes me wonder whether we should have a new command forall Good idea. What we have to check is whether our insets have proper/usable names these da

Re: [PATCH2] Re: LFUN for global change of note-insets type

Jean-Marc Lasgouttes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: However, this kind of code makes me wonder whether we should have a new command forall Good idea. What we have to check is whether our insets have proper/usable names these days. Richard has been work

Re: Scrolling and painting is incredibly slow these days

On Wed, Jun 18, 2008 at 10:44 AM, Abdelrazak Younes <[EMAIL PROTECTED]> wrote: > Bennett Helm wrote: > >> >> OK ... did I do something different (I tried not to), or is this the >> effect >> of your revision? -- The profile this time is ~300x shorter when >> compressed. >> >> > > That's because yo

Re: Scrolling and painting is incredibly slow these days

Bennett Helm wrote: OK ... did I do something different (I tried not to), or is this the effect of your revision? -- The profile this time is ~300x shorter when compressed. That's because you had the TocWidget opened for the first profile and closed for the second one. Abdel.

Re: Scrolling and painting is incredibly slow these days

Bennett Helm wrote: On Wed, Jun 18, 2008 at 10:21 AM, Abdelrazak Younes <[EMAIL PROTECTED]> wrote: Thanks but sorry, I just made a change that should impact performance at rev 25305. Could you generate a new report with that revision? The comparison will be interesting. OK ... did I d

Re: Scrolling and painting is incredibly slow these days

On Wed, Jun 18, 2008 at 10:21 AM, Abdelrazak Younes <[EMAIL PROTECTED]> wrote: > Bennett Helm wrote: > >> On Wed, Jun 18, 2008 at 9:58 AM, Abdelrazak Younes <[EMAIL PROTECTED]> [EMAIL PROTECTED]>> wrote: >> >>Yes -- it works without it. Here's the profile, though it >>looks like I

Re: Scrolling and painting is incredibly slow these days

Bennett Helm wrote: On Wed, Jun 18, 2008 at 9:58 AM, Abdelrazak Younes <[EMAIL PROTECTED]> wrote: Yes -- it works without it. Here's the profile, though it looks like I must be doing something wrong since it's not as detailed as ones I'm used to getting. Indeed. But could you

Re: Scrolling and painting is incredibly slow these days

Bennett Helm wrote: On Wed, Jun 18, 2008 at 9:58 AM, Abdelrazak Younes <[EMAIL PROTECTED] > wrote: Yes -- it works without it. Here's the profile, though it looks like I must be doing something wrong since it's not as detailed as ones I'm used t

Re: Scrolling and painting is incredibly slow these days

On Wed, Jun 18, 2008 at 9:58 AM, Abdelrazak Younes <[EMAIL PROTECTED]> wrote: > Yes -- it works without it. Here's the profile, though it looks like I must >> be doing something wrong since it's not as detailed as ones I'm used to >> getting. >> > > Indeed. But could you try to expand the redrawAl

Re: Scrolling and painting is incredibly slow these days

Bennett Helm wrote: On Wed, Jun 18, 2008 at 9:10 AM, Abdelrazak Younes <[EMAIL PROTECTED] > wrote: Bennett Helm wrote: On Wed, Jun 18, 2008 at 7:58 AM, Abdelrazak Younes <[EMAIL PROTECTED]

Re: Scrolling and painting is incredibly slow these days

On Wed, Jun 18, 2008 at 9:10 AM, Abdelrazak Younes <[EMAIL PROTECTED]> wrote: > Bennett Helm wrote: > >> On Wed, Jun 18, 2008 at 7:58 AM, Abdelrazak Younes <[EMAIL PROTECTED]> [EMAIL PROTECTED]>> wrote: >> >>Could someone produce a profile with the UserGuide test* please? >> >> >>Abdel. >>

Re: Scrolling and painting is incredibly slow these days

Abdelrazak Younes wrote: Bennett Helm wrote: On Wed, Jun 18, 2008 at 7:58 AM, Abdelrazak Younes <[EMAIL PROTECTED] > wrote: Could someone produce a profile with the UserGuide test* please? Abdel. * Hold the PageDown key pressed to scroll the UserGuide

Re: Scrolling and painting is incredibly slow these days

Bennett Helm wrote: On Wed, Jun 18, 2008 at 7:58 AM, Abdelrazak Younes <[EMAIL PROTECTED] > wrote: Could someone produce a profile with the UserGuide test* please? Abdel. * Hold the PageDown key pressed to scroll the UserGuide I tried, but running the

Re: Scrolling and painting is incredibly slow these days

On Wed, Jun 18, 2008 at 7:58 AM, Abdelrazak Younes <[EMAIL PROTECTED]> wrote: > Could someone produce a profile with the UserGuide test* please? > > > Abdel. > > * Hold the PageDown key pressed to scroll the UserGuide I tried, but running the test produces a crash. Here's the backtrace: pplatex

Scrolling and painting is incredibly slow these days

Could someone produce a profile with the UserGuide test* please? Abdel. * Hold the PageDown key pressed to scroll the UserGuide

1.6svn userguide bugs

> Is anyone working on the userguide right now, or should I submit a patch > for this? As you can see in the lyx-docs list, me and others are working on the docs to update it for LyX 1.6. I'll have a look at your bug reports. regards Uwe

Re: 1.6svn Bug: view->TOC too disabled for read-only documents

Abdelrazak Younes wrote: Helge Hafting wrote: Open the read-only userguide, view->TOC Notice that the TOC is gray because it is disabled. I am doing a general fixing of the TOC, hopefully I'll fix that one too if I can reproduce. This is fixed by the way. Abdel.

Re: 1.6svn Bug: view->TOC too disabled for read-only documents

N. B. wrote: I can compile svn25293 only if I add #include in TocModel.h. (MSVC 9, winxp, qt4.4) André fixed that in the mean time. Thanks for the report anyway :-) By the way Nusret, when do you intent to more actively participate in the development? Abdel.

Re: 'make install' failed for lyx-1.6svn today. Python problem?

Jürgen Spitzmüller wrote: Helge Hafting wrote: Wanted to try today's lyx 1.6, did the svn update, autogen.sh, configure and make. All well so far, but 'make install' failed: Should be fixed as of rev. 25259. Confirmed ok. Helge Hafting

Re: [PATCH2] Re: LFUN for global change of note-insets type

Jean-Marc Lasgouttes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: However, this kind of code makes me wonder whether we should have a new command forall Good idea. What we have to check is whether our insets have proper/usable names these days. Richard has been work

Re: [PATCH2] Re: LFUN for global change of note-insets type

Abdelrazak Younes <[EMAIL PROTECTED]> writes: >> However, this kind of code makes me wonder whether we should have a >> new command >> forall > Good idea. What we have to check is whether our insets have proper/usable names these days. Richard has been working towards this goal, but I do not k

Re: [PATCH2] Re: LFUN for global change of note-insets type

Jean-Marc Lasgouttes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: This LFUN should go to Text or Buffer, not to LyXFunc. Yes, buffer is a better choice. However, this kind of code makes me wonder whether we should have a new command forall This would allow to write for

Re: [PATCH2] Re: LFUN for global change of note-insets type

Abdelrazak Younes <[EMAIL PROTECTED]> writes: > This LFUN should go to Text or Buffer, not to LyXFunc. Yes, buffer is a better choice. However, this kind of code makes me wonder whether we should have a new command forall This would allow to write forall Note note-mutate greyedout and wou

Re: [PATCH2] Re: LFUN for global change of note-insets type

Pavel Sanda wrote: Pavel Sanda wrote: Jürgen Spitzmüller wrote: see attached. better one. diff --git a/src/insets/InsetNote.cpp b/src/insets/InsetNote.cpp index 92c44ee..9b5b107 100644 --- a/src/insets/InsetNote.cpp +++ b/src/insets/InsetNote.cpp @@ -32,6 +32,7 @@ #include "ParIte