RE: Embedding feature, final remarks and farewell.

2008-04-19 Thread Bo Peng
> In any event, the "nail in the coffin" for Bo's approach ended up being > security issues that were first raised by Andre. These can be hard to > foresee. It wasn't that these issues couldn't be addressed within Bo's > approach. It was, rather, that once you'd addressed them, you couldn't > have

Re: [patch] fix tex2lyx's paragraph settings import

2008-04-19 Thread rgheck
Uwe Stöhr wrote: The attached patch fixes the import of paragraph settings like indentation and skipping. It furthermore adds support for line spacings. I don't have time to look at this tonight, but I'll try to do so on Sunday. Let me have a peek, please, before this gets committed. I find t

better [patch] to fix bug 2457

2008-04-19 Thread Uwe Stöhr
This patch adds support for \textcolor to tex2lyx. It takes also care of self-defined colors. Attached is also the file I'll add as testcase to SVN. regards Uwe \documentclass[a4paper,12pt]{article} \usepackage[T1]{fontenc} \usepackage[latin9]{inputenc} \usepackage{amsmath} \usepackage{color}

[patch] fix tex2lyx's paragraph settings import

2008-04-19 Thread Uwe Stöhr
The attached patch fixes the import of paragraph settings like indentation and skipping. It furthermore adds support for line spacings. regards Uwe Index: preamble.cpp === --- preamble.cpp (revision 24371) +++ preamble.cpp (working

Re: [Cvslog] r24371 - /lyx-devel/trunk/lib/lyx2lyx/lyx_1_6.py

2008-04-19 Thread rgheck
[EMAIL PROTECTED] wrote: Author: jamatos Date: Sat Apr 19 23:29:44 2008 New Revision: 24371 URL: http://www.lyx.org/trac/changeset/24371 Log: Fix calls to find_default_layout (guarentee arguments consistency) It's this kind of point you yearn for C++'s type safety. Anyway, thanks. My mista

Re: [Cvslog] r24344 - /lyx-devel/trunk/src/frontends/qt4/GuiClipboard.cpp

2008-04-19 Thread Andre Poenitz
On Sat, Apr 19, 2008 at 10:38:24PM +0200, Peter Kümmel wrote: > Andre Poenitz wrote: >>> >>> if (!metafileWindowsMime.get()) >>> metafileWindowsMime.reset(new QWindowsMimeMetafile()); >> Hm? > > - Done: changed the code to use auto_ptr Good. > - Fact: if (!metafileWindowsMime.get(

Re: [Cvslog] r24344 - /lyx-devel/trunk/src/frontends/qt4/GuiClipboard.cpp

2008-04-19 Thread Peter Kümmel
Andre Poenitz wrote: if (!metafileWindowsMime.get()) metafileWindowsMime.reset(new QWindowsMimeMetafile()); Hm? - Done: changed the code to use auto_ptr - Fact: if (!metafileWindowsMime.get()) has no value semantic. - Fact: metafileWindowsMime.reset(new QWindowsMimeM

Re: [Cvslog] r24344 - /lyx-devel/trunk/src/frontends/qt4/GuiClipboard.cpp

2008-04-19 Thread Peter Kümmel
Andre Poenitz wrote: On Sat, Apr 19, 2008 at 01:39:57PM +0200, Peter Kümmel wrote: By the way, shouldn't we use tr1 instead of boost, then boost must only be used on systems not supporting tr1. In theory not bad, in practice probably more trouble than what we have now (extra checks at configur

cvslog in private branches

2008-04-19 Thread Andre Poenitz
Do we really need to see the cvslog messages for private branches, especially when it is just syncronization with trunk? Andre'

Re: compiling LyX

2008-04-19 Thread Andre Poenitz
On Sat, Apr 19, 2008 at 06:25:05PM +0200, Abdelrazak Younes wrote: > Andre Poenitz wrote: >> Just as a side note: For the first time we have a ratio of less then >> 100 when comparing "total compiled lines of code" vs "our code": >> >> Total: compiled: 16378361 real: 164656 ratio: 99 >> >> We ha

Re: compiling LyX

2008-04-19 Thread Andre Poenitz
On Sat, Apr 19, 2008 at 04:22:23PM +0300, Martin Vermeer wrote: > On Sat, Apr 19, 2008 at 09:27:31AM +0200, Andre Poenitz wrote: > > > > Just as a side note: For the first time we have a ratio of less then > > 100 when comparing "total compiled lines of code" vs "our code": > > > > Total: compil

Re: [Cvslog] r24344 - /lyx-devel/trunk/src/frontends/qt4/GuiClipboard.cpp

2008-04-19 Thread Andre Poenitz
On Sat, Apr 19, 2008 at 01:39:57PM +0200, Peter Kümmel wrote: > Andre Poenitz wrote: >> >> It's overkill in this situation, and you misspelled 'std::tr1::' as >> 'boost::'... ;-} > > By the way, shouldn't we use tr1 instead of boost, then > boost must only be used on systems not supporting tr1. I

Re: [Cvslog] r24344 - /lyx-devel/trunk/src/frontends/qt4/GuiClipboard.cpp

2008-04-19 Thread Andre Poenitz
On Sat, Apr 19, 2008 at 12:37:35PM +0200, Peter Kümmel wrote: > Andre Poenitz wrote: >> On Sat, Apr 19, 2008 at 09:36:21AM -, [EMAIL PROTECTED] wrote: >>> Author: kuemmel >>> Date: Sat Apr 19 11:36:19 2008 >>> New Revision: 24344 >>> >>> URL: http://www.lyx.org/trac/changeset/24344 >>> Log: >>>

Re: opening the UserGuide crashes LyX

2008-04-19 Thread rgheck
Uwe Stöhr wrote: > This has to do with the removal of the embedding code, I expect. Yes, thanks to your recent trunk changes to remove this code, the UserGuie can be opened again. But there is more to be removed. What about the attached patch, is this removal correct? There's another issue

Re: opening the UserGuide crashes LyX

2008-04-19 Thread Uwe Stöhr
> This has to do with the removal of the embedding code, I expect. Yes, thanks to your recent trunk changes to remove this code, the UserGuie can be opened again. But there is more to be removed. What about the attached patch, is this removal correct? There's another issue: When opening a LyX

Re: compiling LyX

2008-04-19 Thread Abdelrazak Younes
Andre Poenitz wrote: Just as a side note: For the first time we have a ratio of less then 100 when comparing "total compiled lines of code" vs "our code": Total: compiled: 16378361 real: 164656 ratio: 99 We had about 24630737 lines half a year ago What was the ratio half a year ago?

Re: Embedding feature, final remarks and farewell.

2008-04-19 Thread rgheck
Luis Rivera wrote: rgheck <[EMAIL PROTECTED]> writes: It would help, actually, if you would explain why embedding of figures matters to you. This may help us figure out some of the details of how embedding should work. Is it a matter of being able easily to exchange LyX files with co-autho

Re: Opening files with embed lines

2008-04-19 Thread rgheck
Bo Peng wrote: Something like what follows? Done. Almost, though, because Insetbibtex will not work. Richard, I do not know what else you have done to InsetBibtex, but I suppose you can copy InsetBibtex from 1.5.x to 1.6.x. I don't think I've done anything, really. We re-wrote a coup

Re: opening the UserGuide crashes LyX

2008-04-19 Thread rgheck
Uwe Stöhr wrote: Opening the UserGuide crashes LyX: D:\LyXSVN\lyx-devel\src\support\assert.cpp(21): ASSERTION info_.hasParam(name) V IOLATED IN D:\LyXSVN\lyx-devel\src\insets\InsetCommandParams.cpp:406 Assertion triggered in void __cdecl lyx::doAssert(const char *,const char *,long ) by faili

Re: Status of the GTK+ frontend and KDE integration

2008-04-19 Thread Jürgen Spitzmüller
Liviu Andronic wrote: > Having checked the internationalization page [1], I would venture on > either Russian and/or Romanian translation efforts. What would be the > right way to start? For the UI translation, check out the 1.5.x branch or the development trunk (which will become 1.6.0) as descr

Re: [patch] fix bug 2457

2008-04-19 Thread Uwe Stöhr
Andre Poenitz schrieb: What is the benefit of having test files for such very special cases? To build a decent test suite one day. But all cases are also in the manuals. The Math, EmbeddedObjects, and UserGuide manual are excellent test cases. I'll nevertheless add testcases. regards Uwe

opening the UserGuide crashes LyX

2008-04-19 Thread Uwe Stöhr
Opening the UserGuide crashes LyX: D:\LyXSVN\lyx-devel\src\support\assert.cpp(21): ASSERTION info_.hasParam(name) V IOLATED IN D:\LyXSVN\lyx-devel\src\insets\InsetCommandParams.cpp:406 Assertion triggered in void __cdecl lyx::doAssert(const char *,const char *,long ) by failing check "false" in f

Re: compiling LyX

2008-04-19 Thread Martin Vermeer
On Sat, Apr 19, 2008 at 09:27:31AM +0200, Andre Poenitz wrote: > > Just as a side note: For the first time we have a ratio of less then > 100 when comparing "total compiled lines of code" vs "our code": > > Total: compiled: 16378361 real: 164656 ratio: 99 > > We had about 24630737 lines half

Re: [Cvslog] r24344 - /lyx-devel/trunk/src/frontends/qt4/GuiClipboard.cpp

2008-04-19 Thread Peter Kümmel
Andre Poenitz wrote: It's overkill in this situation, and you misspelled 'std::tr1::' as 'boost::'... ;-} By the way, shouldn't we use tr1 instead of boost, then boost must only be used on systems not supporting tr1. -- Peter Kümmel

Re: [Cvslog] r24344 - /lyx-devel/trunk/src/frontends/qt4/GuiClipboard.cpp

2008-04-19 Thread Andre Poenitz
On Sat, Apr 19, 2008 at 12:31:06PM +0200, Peter Kümmel wrote: > Andre Poenitz wrote: >> What's wrong with >> std::auto_ptr graphicsPasteboardMime; >> ... >> graphicsPasteboardMime.reset(new QMacPasteboardMimeGraphics); >> ? > > OK, you are right. But shared_ptr is also C++: std::tr1::shared_

Re: [Cvslog] r24344 - /lyx-devel/trunk/src/frontends/qt4/GuiClipboard.cpp

2008-04-19 Thread Peter Kümmel
Andre Poenitz wrote: On Sat, Apr 19, 2008 at 09:36:21AM -, [EMAIL PROTECTED] wrote: Author: kuemmel Date: Sat Apr 19 11:36:19 2008 New Revision: 24344 URL: http://www.lyx.org/trac/changeset/24344 Log: fix memory leak, using boost::shared_ptr because std::auto_ptr as no value semantic I s

Re: [Cvslog] r24344 - /lyx-devel/trunk/src/frontends/qt4/GuiClipboard.cpp

2008-04-19 Thread Peter Kümmel
Andre Poenitz wrote: What's wrong with std::auto_ptr graphicsPasteboardMime; ... graphicsPasteboardMime.reset(new QMacPasteboardMimeGraphics); ? OK, you are right. But shared_ptr is also C++: std::tr1::shared_ptr Andre' -- Peter Kümmel

Re: [Cvslog] r24344 - /lyx-devel/trunk/src/frontends/qt4/GuiClipboard.cpp

2008-04-19 Thread Andre Poenitz
On Sat, Apr 19, 2008 at 09:36:21AM -, [EMAIL PROTECTED] wrote: > Author: kuemmel > Date: Sat Apr 19 11:36:19 2008 > New Revision: 24344 > > URL: http://www.lyx.org/trac/changeset/24344 > Log: > fix memory leak, using boost::shared_ptr because std::auto_ptr as no value > semantic I still don'

compiling LyX

2008-04-19 Thread Andre Poenitz
Just as a side note: For the first time we have a ratio of less then 100 when comparing "total compiled lines of code" vs "our code": Total: compiled: 16378361 real: 164656 ratio: 99 We had about 24630737 lines half a year ago Andre'