Re: bug 1937, 1986: call for testers

2005-09-06 Thread Michael Gerz
Juergen Spitzmueller wrote: http://bugzilla.lyx.org/show_bug.cgi?id=1937 http://bugzilla.lyx.org/show_bug.cgi?id=1986 The attached patch is supposed to fix them both. Can someone please test? I will be able to do some testing at the weekend (but unfortunately not earlier). Michael

bug 1937, 1986: call for testers

2005-09-06 Thread Juergen Spitzmueller
http://bugzilla.lyx.org/show_bug.cgi?id=1937 http://bugzilla.lyx.org/show_bug.cgi?id=1986 The attached patch is supposed to fix them both. Can someone please test? Thanks, Jürgen Index: insettabular.C === RCS file: /usr/local/lyx/cvs

Re: [patch] bug 2002

2005-09-06 Thread Juergen Spitzmueller
Juergen Spitzmueller wrote: > The attached patch fixes bug 2002 (citation "find backwards" skips one > entry). What about this? Jürgen

Re: Cut & Paste in tables is broken!

2005-09-06 Thread Juergen Spitzmueller
Juergen Spitzmueller wrote: > > Yes, I guess os. > > Thanks. I'll add bold FIXME's. I've just applied the attached patch. Jürgen Index: ChangeLog === RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/ChangeLog,v retrieving revision 1.22

Re: [PATCH] Binding for paste-primary-selection

2005-09-06 Thread Michael Gerz
Michael Gerz wrote: So you propose \bind "C-M-v""primary-selection-paste" \bind "C-S-v""primary-selection-paste paragraph" Yes, why not. Lars? Can I commit the (modified) patch? The 1.4 patch is in the repository. So you wouldn't mind removing/replacing the following

Re: [PATCH] Fix crash when toggling off change tracking

2005-09-06 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | I cannot remember whether I posted this patch, so here it comes again. | This patch fixes two things: > | - a crash when toggling off change tracking and the cursor is inside | an inset > | - the first change is always skipped when merge changes

Re: support/lstrings.C subst() stuck in a loop

2005-09-06 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: >> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: > | Lars> Georg Baum <[EMAIL PROTECTED]> writes: | | I'd prefer 2/, since it does not make sense to subtitute an empty part of a | | string with something else. > | Lars> agree > | So

Re: Bugzilla email notification broken?

2005-09-06 Thread Lars Gullik Bjønnes
Michael Gerz <[EMAIL PROTECTED]> writes: | Lars, > | I added two bugzilla entries but received no corresponding email | reports. Could you please check whether the bugzilla server is | configured correctly? I have no idea how bugzilla works... and the mails sould be sent as usual hmmda hmm... it

[PATCH] Fix crash when toggling off change tracking

2005-09-06 Thread Jean-Marc Lasgouttes
I cannot remember whether I posted this patch, so here it comes again. This patch fixes two things: - a crash when toggling off change tracking and the cursor is inside an inset - the first change is always skipped when merge changes is automatically invoked by this function. The patch is r

Re: [PATCH] Computation of char style inset width does not consider inset name

2005-09-06 Thread Lars Gullik Bjønnes
Michael Gerz <[EMAIL PROTECTED]> writes: | Angus Leeming wrote: > >>I suspect that you mean to pass "s" to rectText, no? >> >> +string const s = undefined() ? +_("Undef: ") + >> params_.type : params_.type; >>+font_metrics::rectText(s, font, w, a, d); >> > | Oops, you are right! Wh

Re: support/lstrings.C subst() stuck in a loop

2005-09-06 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> Georg Baum <[EMAIL PROTECTED]> writes: | I'd prefer 2/, since it does not make sense to subtitute an empty part of a | string with something else. Lars> agree So the following patches are OK? JMarc Index: src/support/Change

Bugzilla email notification broken?

2005-09-06 Thread Michael Gerz
Lars, I added two bugzilla entries but received no corresponding email reports. Could you please check whether the bugzilla server is configured correctly? Thanks! Michael

Re: [PATCH] Computation of char style inset width does not consider inset name

2005-09-06 Thread Michael Gerz
Angus Leeming wrote: I suspect that you mean to pass "s" to rectText, no? +string const s = undefined() ? +_("Undef: ") + params_.type : params_.type; +font_metrics::rectText(s, font, w, a, d); Oops, you are right! Which means that there was another bug in the code, sinc

Re: Cut & Paste in tables is broken!

2005-09-06 Thread Juergen Spitzmueller
Lars Gullik Bjønnes wrote: > | Lars, can Jürgen's patch go in? > > Yes, I guess os. Thanks. I'll add bold FIXME's. Jürgen

Re: Cut & Paste in tables is broken!

2005-09-06 Thread Lars Gullik Bjønnes
Martin Vermeer <[EMAIL PROTECTED]> writes: | On Tue, 2005-09-06 at 11:23 +0200, Juergen Spitzmueller wrote: >> Martin Vermeer wrote: >> > This explanation crossed my mind too, but can it be true? You only need >> > access to paste_tabular, which is a pointer. And isn't it global anyway? >> > You h

Re: Cut & Paste in tables is broken!

2005-09-06 Thread Martin Vermeer
On Tue, 2005-09-06 at 11:23 +0200, Juergen Spitzmueller wrote: > Martin Vermeer wrote: > > This explanation crossed my mind too, but can it be true? You only need > > access to paste_tabular, which is a pointer. And isn't it global anyway? > > You have only one tabular paste buffer for all of LyX.

Re: Cut & Paste in tables is broken!

2005-09-06 Thread Juergen Spitzmueller
Martin Vermeer wrote: > This explanation crossed my mind too, but can it be true? You only need > access to paste_tabular, which is a pointer. And isn't it global anyway? > You have only one tabular paste buffer for all of LyX. What about moving > this over to CutAndPaste? > > Wondering. Please co

Re: Cut & Paste in tables is broken!

2005-09-06 Thread Martin Vermeer
On Tue, 2005-09-06 at 09:45 +0200, Juergen Spitzmueller wrote: > Martin Vermeer wrote: > > I may be missing something, but wouldn't it be simpler to just > > empty/invalidate the tabular paste buffer whenever the text paste buffer > > is being filled by a cut/copy (and thus becomes fresher)? That w

Re: Tabular fixed-/non-fixed-width switch (bugs 1296, 1840)

2005-09-06 Thread Juergen Spitzmueller
Lars Gullik Bjønnes wrote: > please keep the alignment change out of this. OK. Modified patch is attached. Jürgen Index: src/insets/insettabular.C === RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/insets/insettabular.C,v retrieving

Re: Cut & Paste in tables is broken!

2005-09-06 Thread Juergen Spitzmueller
Martin Vermeer wrote: > I may be missing something, but wouldn't it be simpler to just > empty/invalidate the tabular paste buffer whenever the text paste buffer > is being filled by a cut/copy (and thus becomes fresher)? That way you > don't have to introduce an extra state tracking boolean. I th