Re: [Patch] Make vector a member of doiterator

2005-02-06 Thread Asger Alstrup
Lars Gullik Bjønnes wrote: This patch changes dociterator to not inherit from vector, the vector is now a private member instead. I agree, this is a step forward. Regards, Asger

BOOST_POSIX for Cygwin?

2005-02-06 Thread Kayvan A. Sylvan
I have now installed a fresh cygwin install on a new Win32 computer, and ran into the same "cannot find binary" issue upon a fresh checkout and compile of lyx. The following patch fixes this by ensuring that BOOST_POSIX is set for Cygwin in the src/config.h file. I see no reason why we just shoul

[Patch] Make vector a member of doiterator

2005-02-06 Thread Lars Gullik Bjønnes
This patch changes dociterator to not inherit from vector, the vector is now a private member instead. IMHO this actually cleans up things a tiny bit: - can ovoid operator[](i) syntax in several places - same function always used to quesry the cursor depth: depth() - is LCursor a

Re: [Patch] Make sure double space is fixed on cursor movement

2005-02-06 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Sun, Feb 06, 2005 at 09:05:44PM +0100, Lars Gullik Bjønnes wrote: >> I'll be happy for suggestions on how to do this cleaner, but unless I >> get real objections this is going in. > | I don't think the bool returns all over the place add to the | read

Re: LCursor::resize - what is the intention of this?

2005-02-06 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Sun, Feb 06, 2005 at 12:05:01PM +0100, Lars Gullik Bjønnes wrote: >> | It sort of is, but the criterion how many items are erased is given by >> | the inset argument. >> >> But would be much clearer to use something like >> >> cur.erase(cur.begin()

Re: cursors does not change on "up" from inset

2005-02-06 Thread Lars Gullik Bjønnes
Andreas Vox <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: > >> | < LCursor old = cur; >> | < editXY(cur, x, y - par.rows()[row].ascent() - 1); >> | < if (cur == old) | ... >> >> I have a feeling that the cursor used

Re: cursors does not change on "up" from inset

2005-02-06 Thread Andreas Vox
Lars Gullik BjÃnnes <[EMAIL PROTECTED]> writes: > | < LCursor old = cur; > | < editXY(cur, x, y - par.rows()[row].ascent() - 1); > | < if (cur == old) ... > > I have a feeling that the cursor used afterwards is a different > cursor. ??? editXY() i

Re: LCursor::resize - what is the intention of this?

2005-02-06 Thread Andre Poenitz
On Sun, Feb 06, 2005 at 12:05:01PM +0100, Lars Gullik Bjønnes wrote: > | It sort of is, but the criterion how many items are erased is given by > | the inset argument. > > But would be much clearer to use something like > > cur.erase(cur.begin() + i, cur.end()); *shrug* If this makes the code mo

Re: [Patch] Make sure double space is fixed on cursor movement

2005-02-06 Thread Andre Poenitz
On Sun, Feb 06, 2005 at 09:05:44PM +0100, Lars Gullik Bjønnes wrote: > I'll be happy for suggestions on how to do this cleaner, but unless I > get real objections this is going in. I don't think the bool returns all over the place add to the readibility. I'd probably even prefer some 'semi-global'

Re: cursors does not change on "up" from inset

2005-02-06 Thread Andre Poenitz
On Sun, Feb 06, 2005 at 07:21:58PM +0100, Lars Gullik Bjønnes wrote: > > This is making life hard for me. > > I just don't understand why the cursor does not change, or am I just > looking at the wrong cursors. That is indeed possible. I don't have the sources handy... Some of the dispatch fun

Re: passing down buffer

2005-02-06 Thread Andre Poenitz
On Sun, Feb 06, 2005 at 12:08:37PM +0100, Lars Gullik Bjønnes wrote: > Why are we increasing an int that is not used? Probably some dead code? Andre'

Re: Problem writing a converter

2005-02-06 Thread Georg Baum
Am Sonntag, 6. Februar 2005 01:42 schrieb Bernard Hurley: > score I am working on. It beats having to export to a latex file and > call lilypond-book by hand, but it would be much neater if the directory > of the lyx document could be passed as a parameter to the converter. Sorry, I forgot that su

Re: [Patch] Make sure double space is fixed on cursor movement

2005-02-06 Thread Lars Gullik Bjønnes
[EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: | This patch tries to fix deletion of double space upon cursor movement. > | There also was a problem where a updateNeeded was not handled if you | moved out of a inset (or into) since updateNeeded was reset on each | call to dispatch. (LFUN_FINISHED

Re: cursors does not change on "up" from inset

2005-02-06 Thread Lars Gullik Bjønnes
[EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: | Andreas Vox <[EMAIL PROTECTED]> writes: > | | Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: >> >>> >>> This is making life hard for me. >> | | < bool LyXText::cursorUp(LCursor & cur) | | < { | | < Paragraph const & par = cur.paragraph()

Re: cursors does not change on "up" from inset

2005-02-06 Thread Lars Gullik Bjønnes
Andreas Vox <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: > >> >> This is making life hard for me. > | < bool LyXText::cursorUp(LCursor & cur) | < { | < Paragraph const & par = cur.paragraph(); | < int const row = par.pos2row(cur.pos()); | <

Re: cursors does not change on "up" from inset

2005-02-06 Thread Andreas Vox
Lars Gullik BjÃnnes <[EMAIL PROTECTED]> writes: > > This is making life hard for me. < bool LyXText::cursorUp(LCursor & cur) < { < Paragraph const & par = cur.paragraph(); < int const row = par.pos2row(cur.pos()); < int const x = cur.targetX(); < < if (!cur.selec

cursors does not change on "up" from inset

2005-02-06 Thread Lars Gullik Bjønnes
This is making life hard for me. I just don't understand why the cursor does not change, or am I just looking at the wrong cursors. This is the problematic code: bool LyXText::cursorUp(LCursor & cur) { Paragraph const & par = cur.paragraph(); int const row = par.pos2row(cur.pos(

Re: [Patch] gimmick: show word frequencies in new buffer

2005-02-06 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Sun, Feb 06, 2005 at 04:29:06AM +0100, Andreas Vox wrote: >> At least now we know that the english UserGuide.lyx does not only >> contain 31640 words but that there are only 3501 distinct ones. > | So why not remove the duplicates? Yeah. Just refere

Re: passing down buffer

2005-02-06 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Sat, Feb 05, 2005 at 09:47:33PM +0100, Lars Gullik Bjønnes wrote: >> Andre Poenitz <[EMAIL PROTECTED]> writes: >> >> | @@ -1132,7 +1132,7 @@ >> |bv().buffer()->params(), >> |sl.pos(), >> |outerFont(sl.pit(), text.p

Re: LCursor::resize - what is the intention of this?

2005-02-06 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Sun, Feb 06, 2005 at 03:55:16AM +0100, Lars Gullik Bjønnes wrote: >> >> void leaveInset(LCursor & cur, InsetBase const & in) >> { >> for (size_t i = 0; i != cur.depth(); ++i) { >> if (&cur[i].inset() == &in) { >>

Partitioning lines in matrices

2005-02-06 Thread Martin Vermeer
Something I was very happy discovering, as I was already mentally prepared to install the 'pmat' package and engage in ERT :-/ In the matrix set-up dialogue on the math panel, you can add pipe characters to the "c" alignment string, and they will come out as vertical lines in the displayed AND

Fax support in LyX

2005-02-06 Thread Martin Vermeer
What is the current status of fax support in LyX? It seems to be there (some supporting infrastructure), but you have to set up your own converter, at least if using efax. It appears to be looking for GUI fax applications to interface with (true?) I got it done (1.3.5) using Dekel's old script (be

[patch] new fileformat for tex2lyx

2005-02-06 Thread Georg Baum
This patch fixes wrong output of paperfontsize and updates the file format to 241 in tex2lyx. Committing now. Georg diff -p -r -U 3 -X excl.tmp lyx-1.4-clean/src/tex2lyx/ChangeLog lyx-1.4-cvs/src/tex2lyx/ChangeLog --- lyx-1.4-clean/src/tex2lyx/ChangeLog 2005-02-03 20:13:24.0 +0100 +++ lyx

Re: LCursor::resize - what is the intention of this?

2005-02-06 Thread Andre Poenitz
On Sun, Feb 06, 2005 at 03:55:16AM +0100, Lars Gullik Bjønnes wrote: > > void leaveInset(LCursor & cur, InsetBase const & in) > { > for (size_t i = 0; i != cur.depth(); ++i) { > if (&cur[i].inset() == &in) { > cur.resize(i); >

Re: [Patch] Make sure double space is fixed on cursor movement

2005-02-06 Thread Andre Poenitz
On Sun, Feb 06, 2005 at 02:38:13AM +0100, Lars Gullik Bjønnes wrote: > Just some comments on the real changes. > [...] > These were missing. but really, all lfuns need to be part of this > struct. > [..] > | + NoUpdate = 8 //< Does not (usually) require update > > "Usually" as in "always

Re: [Patch] Make sure double space is fixed on cursor movement

2005-02-06 Thread Andre Poenitz
On Sun, Feb 06, 2005 at 02:06:02AM +0100, Lars Gullik Bjønnes wrote: > I also removed a assert from depm (commented out), I'd like to know > why that was there. Looks as if DEPM should not change the cursor size, i.e. he nesting depth. Looks sensible to me. Andre'

Re: passing down buffer

2005-02-06 Thread Andre Poenitz
On Sat, Feb 05, 2005 at 09:47:33PM +0100, Lars Gullik Bjønnes wrote: > Andre Poenitz <[EMAIL PROTECTED]> writes: > > | @@ -1132,7 +1132,7 @@ > | bv().buffer()->params(), > | sl.pos(), > | outerFont(sl.pit(), text.paragraphs())); > | - for (; s < size(); ++s) >

Re: [Patch] gimmick: show word frequencies in new buffer

2005-02-06 Thread Andre Poenitz
On Sun, Feb 06, 2005 at 04:29:06AM +0100, Andreas Vox wrote: > At least now we know that the english UserGuide.lyx does not only > contain 31640 words but that there are only 3501 distinct ones. So why not remove the duplicates? Andre'