Andre Poenitz <[EMAIL PROTECTED]> writes:

| On Sat, Feb 05, 2005 at 09:47:33PM +0100, Lars Gullik Bjønnes wrote:
>> Andre Poenitz <[EMAIL PROTECTED]> writes:
>> 
>> | @@ -1132,7 +1132,7 @@
>> |            bv().buffer()->params(),
>> |            sl.pos(),
>> |            outerFont(sl.pit(), text.paragraphs()));
>> | -  for (; s < size(); ++s)
>> | +  for (; s < int(size()); ++s)
>> |            ;
>> 
>> Are you sure that 's' has the correct type?
>> Better to fix that than adding casts/temps. (if possible)
>
| It's an 'int' further up and counts there from size - 1 down to 0.

I know that s is an int, but is int the correct type for it.

besides what is the next line after, this construct?

Why are we increasing an int that is not used?

        // And the point of this empty construct is what? (Lgb)
        //for (; s < depth(); ++s)
        //    ;
        return font;

-- 
        Lgb

Reply via email to