Angus Leeming <[EMAIL PROTECTED]> writes:
>
> Here's my take on Asger's patch.
>
One typo left.
/Andreas
Index: src/lyxlex_pimpl.h
=
RCS file: /cvs/lyx/lyx-devel/src/lyxlex_pimpl.h,v
retrieving revision 1.21
diff -u -p -r1.21 lyxlex_pimpl.h
--- src/lyxlex_pimpl.h 2005
Andreas Vox wrote:
> Angus Leeming <[EMAIL PROTECTED]> writes:
>
>
>> Ha! Mine were easier still. I just cut and pasted them from Asger's
>> patch
>>
>> Committing these now.
>>
>
> Your Windows compilers are definitely more lenient than gcc3.3
> on Mac. ;-)
I was compiling on Linux. I don't
Angus Leeming <[EMAIL PROTECTED]> writes:
> Ha! Mine were easier still. I just cut and pasted them from Asger's
> patch
>
> Committing these now.
>
Your Windows compilers are definitely more lenient than gcc3.3
on Mac. ;-)
I had to add an extra "()" in the following line, too,
to get it to c
Jean-Marc,
attached are two patches for the 1.3.x tree which are already in HEAD.
string_lit_13x.diff changes the comparison of the addresses of string
literals to the comparison of std::strings. As flagged by MSVC.
I'd imagine that this patch was a no-brainer.
placeholder_13x.diff backports t
Asger Ottar Alstrup wrote:
> The result of today's work is this: Everything compiles with the
> attached patch
Ok, Asger. I applied the bits that were obviously the right thing to do.
Here is your patch back again. I believe that this is all you'll need to
make LyX compile for you --- down to 1136
As flagged by MSVC. Committing now.
--
AngusIndex: src/ChangeLog
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/ChangeLog,v
retrieving revision 1.2096
diff -u -p -r1.2096 ChangeLog
--- src/ChangeLog 20 Jan 2005 21:34:22 - 1.20
Here's my take on Asger's patch.
--
AngusIndex: src/ChangeLog
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/ChangeLog,v
retrieving revision 1.2095
diff -u -p -r1.2095 ChangeLog
--- src/ChangeLog 20 Jan 2005 16:17:34 - 1.2095
Georg Baum wrote:
> Angus Leeming wrote:
>
>> MSVC produces these warnings, all reasonable IMO. The attached patch
>> should silence it.
>
> Indeed reasonable. I always thought that gcc was pretty good with
> warnings, but this shows that it can be done better. Or do we need to
> enable more -W
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes:
Georg> Jean-Marc Lasgouttes wrote:
>> Are you looking for USE_COMRESSION or USE_COMPRESSION?
Georg> Good point. And I copy/pasted this several times without
Georg> noticing the typo :-(
Yes, this was fascinating to read :)
JMarc
Angus Leeming wrote:
> MSVC produces these warnings, all reasonable IMO. The attached patch
> should silence it.
Indeed reasonable. I always thought that gcc was pretty good with warnings,
but this shows that it can be done better. Or do we need to enable more -W
switches?
Georg
Jean-Marc Lasgouttes wrote:
> Are you looking for USE_COMRESSION or USE_COMPRESSION?
Good point. And I copy/pasted this several times without noticing the
typo :-(
Georg
MSVC produces these warnings, all reasonable IMO. The attached patch should
silence it.
OK?
Angus
support\path.C(33) : warning C4390: ';' :
empty controlled statement found; is this the intent?
mathed\math_spaceinset.C(122) : warning C4130: '==' :
logical operation on address of string cons
Jean-Marc Lasgouttes wrote:
> Angus> There's no corresponding /* #undef USE_COMRESSION */ in
> Angus> config.h.in or #define USE_COMPRESSION in config.h
>
> Are you looking for USE_COMRESSION or USE_COMPRESSION?
Gr. I'm going to make you all rebuild your entire trees unless you
cheat by using
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes:
Angus> Part of Asger's patch wraps bits of code up inside #ifdef
Angus> USE_COMPRESSION ... #endif
Angus> blocks. Looks entirely reasonable to me. However, before I can
Angus> apply it, I'd need to have a USE_COMPRESSION macro defined in
Angus Leeming wrote:
> Part of Asger's patch wraps bits of code up inside
>
> #ifdef USE_COMPRESSION
> ...
> #endif
>
> blocks. Looks entirely reasonable to me. However, before I can apply it,
> I'd need to have a USE_COMPRESSION macro defined in config.h.
>
> Unfortuanetly, whilst there's
Part of Asger's patch wraps bits of code up inside
#ifdef USE_COMPRESSION
...
#endif
blocks. Looks entirely reasonable to me. However, before I can apply it,
I'd need to have a USE_COMPRESSION macro defined in config.h.
Unfortuanetly, whilst there's this bit of code in configure.ac:
if
Also sprach Hartmut Haase:
> I was not aware of this.
>
> With filled math-bullet I mean \bullet in contrast to \circ
I see. But I cannot reproduce the problem neither in 1.3.6cvs nor in 1.4cvs.
Regards,
Jürgen
Asger needed a part of this (IGNORE -> IGNORED_WORD) to compile with MSVC.
The rest is just needless fiddling.
--
AngusIndex: src/ChangeLog
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/ChangeLog,v
retrieving revision 1.2094
diff
>From Asger's patch. Committing...
--
AngusIndex: src/client/ChangeLog
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/client/ChangeLog,v
retrieving revision 1.11
diff -u -p -r1.11 ChangeLog
--- src/client/ChangeLog 19 Jan 2005 15
Jean-Marc Lasgouttes wrote:
> Angus> Correct. And it's committed to the 1.3.x tree too because it's
> Angus> completely orthogonal to anything that might be breaking
> Angus> Kayvan's build.
>
> And you got the changelog entry wrong.
;-)
Fixed.
--
Angus
Jean-Marc Lasgouttes wrote:
> Angus> The $$s placeholder is currently taken to mean Angus> dir>/scripts. This patch moves that back one directory to Angus> support dir>. In turn, this will make it easy to define
> Angus> converters that are in other directories, eg noweb2lyx, reLyX.
> Angus> Ok?
Jean-Marc Lasgouttes wrote:
> Jean-Marc> And concerning the warnings, they seem indeed very
> Jean-Marc> interesting. At least the one in qt2/floatplacement.C is a
> Jean-Marc> bug.
>
> The following micropatch fixes two real bugs and silences a warning.
> Of course, I went after the easiest ones
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes:
Angus> Correct. And it's committed to the 1.3.x tree too because it's
Angus> completely orthogonal to anything that might be breaking
Angus> Kayvan's build.
And you got the changelog entry wrong.
JMarc
Jean-Marc Lasgouttes wrote:
> Angus> Sure, Jean-Marc, I understand that you're busy at the moment. I
> Angus> don't want you to feel that I'm throwing stuff at you too fast
> Angus> for careful consideration.
>
> It is not a problem as long as you remember what you have in stock and
> pester me un
Jean-Marc Lasgouttes wrote:
> Angus> There is a third solution which you proposed a few days ago.
> Angus> Install into a directory path with no spaces and then move the
> Angus> entire bundle to its final destination.
>
> How would we 'move' it in a portable way?
'We' wouldn't. We'd do enough fo
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes:
Angus> There is a third solution which you proposed a few days ago.
Angus> Install into a directory path with no spaces and then move the
Angus> entire bundle to its final destination.
How would we 'move' it in a portable way?
Angus> In
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes:
Angus> Sure, Jean-Marc, I understand that you're busy at the moment. I
Angus> don't want you to feel that I'm throwing stuff at you too fast
Angus> for careful consideration.
It is not a problem as long as you remember what you have in s
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes:
Lars> I wonder why I never tried that...
Lars> probably because I though the variable was already expanded.
Lars> if it works it works...
I committed it.
JMarc
> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes:
Jean-Marc> And concerning the warnings, they seem indeed very
Jean-Marc> interesting. At least the one in qt2/floatplacement.C is a
Jean-Marc> bug.
The following micropatch fixes two real bugs and silences a warning.
Of course,
Both lines are marked by #ES#
1. The line that invokes sed:
sed -f chkconfig.sed ${srcdir}/doc/LaTeXConfig.lyx.in >doc/LaTeXConfig.lyx
2. the command that deletes chkconfig.sed (because this file is used
later by my
config.bat and then deleted:
rm -f chkconfig.sed
E
Jean-Marc Lasgouttes wrote:
"E
Jean-Marc Lasgouttes wrote:
> Angus> Ok, see it at http://www.devel.lyx.org/~leeming/www-user/LGT
>
> Angus> If you're happy, then I'll just commit it.
>
> Some pictures show xdvi, but I guess its the best you can do, provided
> what we have.
>
> Please commit.
Done.
--
Angus
> "Asger" == Asger Ottar Alstrup <[EMAIL PROTECTED]> writes:
Asger> Hi, The result of today's work is this: Everything compiles
Asger> with the attached patch and new files placed as usual. I did a
Asger> bunch of gross hacks here and there, but there are some good
Asger> bits in there, which
Asger Ottar Alstrup wrote:
> Hi,
>
> The result of today's work is this: Everything compiles with the
> attached patch and new files placed as usual. I did a bunch of gross
> hacks here and there, but there are some good bits in there, which Angus
> might steal.
Well done, Asger. I'll have a loo
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes:
Angus> The $$s placeholder is currently taken to mean dir>/scripts. This patch moves that back one directory to support dir>. In turn, this will make it easy to define
Angus> converters that are in other directories, eg noweb2lyx, reLyX.
The $$s placeholder is currently taken to mean /scripts.
This patch moves that back one directory to . In turn,
this will make it easy to define converters that are in other directories,
eg noweb2lyx, reLyX.
We don't have to worry about compatibility because the $$s placeholder is
present only in
Hi,
The result of today's work is this: Everything compiles with the
attached patch and new files placed as usual. I did a bunch of gross
hacks here and there, but there are some good bits in there, which Angus
might steal.
Next step is to resolve linker errors, of which there are 24 right now.
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes:
Angus> Ok, see it at http://www.devel.lyx.org/~leeming/www-user/LGT
Angus> If you're happy, then I'll just commit it.
Some pictures show xdvi, but I guess its the best you can do, provided
what we have.
Please commit.
JMarc
Lars Gullik Bjønnes wrote:
So its you that are the joy-killer now.
> | | The phrase is "kill-joy".
> | Not in my vocab.
> | so no we have a kill-sport as well...
> but I guess you want "spoil-sport" here.
Attaboy!
--
Angus
[EMAIL PROTECTED] (Lars Gullik Bjønnes) writes:
| Angus Leeming <[EMAIL PROTECTED]> writes:
>
| | Lars Gullik Bjønnes wrote:
>>> | If any of you twits had bothered to look, you would see that the
>>> | second patch actually changed the definitions, rather than the forward
>>> | declarations.
>>>
Angus Leeming wrote:
> Open up the User Guide and press View->DVI leads to this crash:
Here's the fix. LyX is crashing when printing some diagnostic data!
I'll check the other output_foo.C for this too.
Angus
Index: src/output_latex.C
Jean-Marc Lasgouttes wrote:
> Angus> The following files are not included in any web page. Shall I
> Angus> consign them to the attic?
>
> Angus> 39.png 43.png 53.png 61.png 64.png 72.png 75.png 79.png
> Angus> 83.png 87.png 89.png
>
> Hmm, actually, looking at these pictures, I think that they
Angus Leeming <[EMAIL PROTECTED]> writes:
| Lars Gullik Bjønnes wrote:
>> | If any of you twits had bothered to look, you would see that the
>> | second patch actually changed the definitions, rather than the forward
>> | declarations.
>>
>> :-)
>>
>> So its you that are the joy-killer now.
>
|
Lars Gullik Bjønnes wrote:
> | If any of you twits had bothered to look, you would see that the
> | second patch actually changed the definitions, rather than the forward
> | declarations.
>
> :-)
>
> So its you that are the joy-killer now.
The phrase is "kill-joy".
--
Angus
Asger Ottar Alstrup <[EMAIL PROTECTED]> writes:
| If any of you twits had bothered to look, you would see that the
| second patch actually changed the definitions, rather than the forward
| declarations.
:-)
So its you that are the joy-killer now.
--
Lgb
Angus Leeming <[EMAIL PROTECTED]> writes:
| Lars Gullik Bjønnes wrote:
>> | Asger's exchanging of the class and struct keywords.
>>
>> I wonder who gets to clean this up...
>>
>> From what I saw in Asgers patch several places it was not the forward
>> declaration that should change, but the decl
Lars Gullik Bjønnes wrote:
> | The information on this page has been superceeded by that at
> | www.lyx.org/donations.php, no?
>>
> | Shall I just remove the page?
>
> Didn't I just change it?
>
> In my three I have the old "code" commetned out, and put in a pointer
> to the donations page instea
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes:
>> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes:
>
| Angus> The information on this page has been superceeded by that at
| Angus> www.lyx.org/donations.php, no?
>
| Angus> Shall I just remove the page? -- Angus
>
| Well, the page points t
Lars Gullik Bjønnes wrote:
> | $ grep mkinstalldirs *
> | config.log:MKINSTALLDIRS='../config/mkinstalldirs'
> | config.status:s,@MKINSTALLDIRS@,../config/mkinstalldirs,;t t
> | Makefile:mkinstalldirs = $(SHELL) $(top_srcdir)/config/mkinstalldirs
> | Makefile:MKINSTALLDIRS = ../config/mkinstalldirs
Asger Ottar Alstrup wrote:
> If any of you twits had bothered to look, you would see that the second
> patch actually changed the definitions, rather than the forward
> declarations.
Oh, I did look. And this is what I committed. But the stuff about the
semantic equivalence is still true, so eithe
Angus Leeming <[EMAIL PROTECTED]> writes:
| The information on this page has been superceeded by that at
| www.lyx.org/donations.php, no?
>
| Shall I just remove the page?
Didn't I just change it?
In my three I have the old "code" commetned out, and put in a pointer
to the donations page instead
Angus Leeming <[EMAIL PROTECTED]> writes:
| $ grep mkinstalldirs *
| config.log:MKINSTALLDIRS='../config/mkinstalldirs'
| config.status:s,@MKINSTALLDIRS@,../config/mkinstalldirs,;t t
| Makefile:mkinstalldirs = $(SHELL) $(top_srcdir)/config/mkinstalldirs
| Makefile:MKINSTALLDIRS = ../config/mkinsta
The license is granted for use with LyX. People who prefer
the other fonts may continue to do so. This is just a
replacement. It is, from my point view, o.k. that those
who would like to use LyX commercially should either
ask for permission themselves or stick with the inferior
fonts.
Anyway, an
If any of you twits had bothered to look, you would see that the second
patch actually changed the definitions, rather than the forward
declarations.
Regards,
Asger
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes:
Angus> The following files are not included in any web page. Shall I
Angus> consign them to the attic?
Angus> 39.png 43.png 53.png 61.png 64.png 72.png 75.png 79.png
Angus> 83.png 87.png 89.png
Hmm, actually, looking at these pictures,
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes:
Georg> The key sentence is "This fonts cannot be sold or distributed
Georg> with any commercial product or used in any commercial
Georg> organization without additional agreement with author." I don't
Georg> see a phrase in the additional inf
55 matches
Mail list logo
