Re: [patch] float -> string #1 (was: Re: [patch] validators for the rest)

John Spray wrote: > I think that two decimal places should be enough > for most people, so I'll change it to that. Yes, that's what the other frontends declare "valid" in most cases. Jürgen

[patch] remove getSelectionSpan

This was a helper function useful with the old selection code, not needed anymore. Alfredo Index: text2.C === RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/text2.C,v retrieving revision 1.589 diff -u -p -r1.589 text2.C --- text2.C 30

Re: [patch] float -> string #1 (was: Re: [patch] validators for the rest)

On Sun, 2004-12-05 at 19:22 +0100, Juergen Spitzmueller wrote: > BTW: John S., in the gtk graphics dialog, you cannot enter double values for > rotation, width/height and scale. This is possible in the other frontends and > might cause compatibility problems. Actually, you can enter double value

Re: [Patch] Clean up some gtk makefiles

John Spray <[EMAIL PROTECTED]> writes: | On Sun, 2004-12-05 at 22:02 +0100, Lars Gullik Bjønnes wrote: >> Would be nice if someone that compiles gtk regularly could try this >> out. (If not I will commit it anyway, and you will find out the hard >> was if it works or not :-) ) > | Works fine here.

Re: [Patch] Clean up some gtk makefiles

On Sun, 2004-12-05 at 22:02 +0100, Lars Gullik Bjønnes wrote: > Would be nice if someone that compiles gtk regularly could try this > out. (If not I will commit it anyway, and you will find out the hard > was if it works or not :-) ) Works fine here. John

[Patch] Clean up some gtk makefiles

Would be nice if someone that compiles gtk regularly could try this out. (If not I will commit it anyway, and you will find out the hard was if it works or not :-) ) ? gtk-1.diff Index: gimages/Makefile.am === RCS file: /usr/local/ly

[patch] undo

This patch solves two crashes with undo, and simplifies a bit undo.cursor handling in textUndoOrRedo. One of the crashes is due to copying paragraphs without setting their inset_owner to the correct inset. This backpointerage should surely die, but until then setting it is certainly needed. The s

Re: [patch] selection_possible

Alfredo Braunstein wrote: [...] And this is the actual patch ;-) Alfredo Index: text3.C === RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/text3.C,v retrieving revision 1.273 diff -u -p -r1.273 text3.C --- text3.C 2 Dec 2004 11:32:

[patch] float -> string #1 (was: Re: [patch] validators for the rest)

Lars Gullik Bjønnes wrote: > Do we have to use floats for this, or can we just use a string all the > time? I think it will be possible to switch to string in all these cases. However, I'd like to proceed in small steps. The attached patch uses strings instead of floats for graphics. We have to

Re: Spurious recompilation of pch.h

Angus Leeming <[EMAIL PROTECTED]> writes: | make[1]: Entering directory `/home/angus/lyx/devel/build/src' | TMPCMD=` echo g++ -DHAVE_CONFIG_H -I. -I../../src -I. -Winvalid-pch | --include=../../src/pch.h -I../../boost -Wextra -Wall | -I/usr/X11R6/include -g -O -fno-exceptions | sed -e s,\",\',`

Spurious recompilation of pch.h

make[1]: Entering directory `/home/angus/lyx/devel/build/src' TMPCMD=` echo g++ -DHAVE_CONFIG_H -I. -I../../src -I. -Winvalid-pch --include=../../src/pch.h -I../../boost -Wextra -Wall -I/usr/X11R6/include -g -O -fno-exceptions | sed -e s,\",\',` ; \ PATTERN=`echo -Winvalid-pch --include=../../sr

Re: [Patch] Make --without-included-boost work properly

[EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: | Also rename the boost convenience libs to the same names used on the | external lib. > | Will commit rs. With this patch I can use the boost packages for FC3 without problems. -- Lgb

[Patch] Make --without-included-boost work properly

Also rename the boost convenience libs to the same names used on the external lib. Will commit rs. ? Config ? boost-1.diff Index: boost/libs/filesystem/src/.cvsignore === RCS file: /usr/local/lyx/cvsroot/lyx-devel/boost/libs/filesys

Re: [Patch] PCH patch for Angus.

Angus Leeming <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: > >> Can you try this one out? >> >> With some magic (sed and brace expansion) we might be able to use >> AM_CPPFLAGS for PCH_FLAGS. >> >> All-in-all the result is nicer than what we have now, but the >> implementaion is a bi

Re: [Patch] PCH patch for Angus.

Lars Gullik Bjønnes wrote: > Can you try this one out? > > With some magic (sed and brace expansion) we might be able to use > AM_CPPFLAGS for PCH_FLAGS. > > All-in-all the result is nicer than what we have now, but the > implementaion is a bit hairy. Here's a one line patch that's still needed

Re: [Patch] PCH patch for Angus.

Angus Leeming <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: > >> Angus Leeming <[EMAIL PROTECTED]> writes: >> >> | Lars Gullik Bjønnes wrote: | In your other mail you say | I am not sure that the brace expansion stuff | is really portable. (I am sure angus can help me

Re: [Patch] PCH patch for Angus.

Lars Gullik Bjønnes wrote: > Angus Leeming <[EMAIL PROTECTED]> writes: > > | Lars Gullik Bjønnes wrote: >>> | In your other mail you say >>> | I am not sure that the brace expansion stuff >>> | is really portable. (I am sure angus can help me >>> | with that :-) ) >>> | What are you talki

Re: [Patch] PCH patch for Angus.

Angus Leeming <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: >> | In your other mail you say >> | I am not sure that the brace expansion stuff >> | is really portable. (I am sure angus can help me >> | with that :-) ) >>> >> | What are you talking about? I see no braces... >> >> One

Re: [Patch] gtk Include dialog

John Spray wrote: > > One part that may benefit from suggestions: > > In GInclude::onOpenClicked, in order to apply changes ready for loading > the document (which closes the dialog), I do > + apply(); > + controller().dispatchParams(); Yuck! > where other frontends trigger their "ok" button

Re: [Patch] PCH patch for Angus.

Lars Gullik Bjønnes wrote: > | In your other mail you say > | I am not sure that the brace expansion stuff > | is really portable. (I am sure angus can help me > | with that :-) ) >> > | What are you talking about? I see no braces... > > One line below...: > > $${TMPCMD/$$PATTERN} > > I am no

Re: [Patch] Use AM_CPPFLAGS for PCH_FLAGS wereever possible.

Lars Gullik Bjønnes wrote: > Have a look. This works fine for me. Looks nice. I'll try too soon... -- Angus

Re: [Patch] PCH patch for Angus.

Angus Leeming <[EMAIL PROTECTED]> writes: | Some comments: | Index: common.am | +$(PCH_FILE): $(PCH_SOURCE) | # Ok, here you need to escape the regexes with backslashes | # because the sed expression is not inside single quotes. | # The backslashes prevent the shell from messing up. | + TMPCMD=

Re: [Patch] PCH patch for Angus.

Lars Gullik Bjønnes wrote: > Can you try this one out? > > With some magic (sed and brace expansion) we might be able to use > AM_CPPFLAGS for PCH_FLAGS. > > All-in-all the result is nicer than what we have now, but the > implementaion is a bit hairy. I see that you've committed this already. I'

Re: undo.C

Andre Poenitz wrote: > On Tue, Nov 30, 2004 at 05:37:34PM +0100, Alfredo Braunstein wrote: >> >> There are some things of that patch I don't understand. >> >> >> >> In textUndoOrRedo 1) what does the bv.cursor has to do with anything? >> > >> > It should be needed to e.g. give the target for the