Lars Gullik Bjønnes wrote: > Can you try this one out? > > With some magic (sed and brace expansion) we might be able to use > AM_CPPFLAGS for PCH_FLAGS. > > All-in-all the result is nicer than what we have now, but the > implementaion is a bit hairy.
I see that you've committed this already. I've only just had a look at the patch, not used it yet. Some comments: Index: common.am +$(PCH_FILE): $(PCH_SOURCE) # Ok, here you need to escape the regexes with backslashes # because the sed expression is not inside single quotes. # The backslashes prevent the shell from messing up. + TMPCMD=` echo $(CXXCOMPILE) | sed -e s,\",\',` ; \ # But here? Why not: # sed -e 's,/,\\/,' + PATTERN=`echo $(PCH_FLAGS) | sed -e 's,\/,\\\/,'` ; \ In your other mail you say I am not sure that the brace expansion stuff is really portable. (I am sure angus can help me with that :-) ) What are you talking about? I see no braces... I'll 'cvs up' and try it out after I've finished reading the mails. -- Angus
