John Levon wrote:
> Cool stuff...
BTW I'm gonna rename the set all borders button in the qt tabular dialog from
"default" to "set", because it does not actually restore the default, but
sets all borders (which looks rather weird).
Jürgen
John Levon wrote:
> Aha, you're the table maintainer now ? :)
No, that's Georg
> Cool stuff...
Just preparing my Christmas gift.
Jürgen
On Thu, 2004-11-25 at 14:44 +, Angus Leeming wrote:
> I asked because I wanted to know what functionality gtk would really
> need from FileFilterList. It seems that you're saying that we should
> really have:
>
> struct FileFilterList {
> struct Filter {
> std::vector
Lars Gullik BjÃnnes wrote:
> | Hrm... here it is ;-)
>
> Ok, thanks.
>
> Please wait at least until next week with the merge.
Sure, no problem. I'll probably out for the weekend anyways.
> I have some comments (mostly nit-picking), and I also want to
> understand the patch a bit better. I am s
Alfredo Braunstein <[EMAIL PROTECTED]> writes:
| Lars Gullik Bjønnes wrote:
>
>> Alfredo Braunstein <[EMAIL PROTECTED]> writes:
>>
>> | This is the CoordBranch merge patch.
>>
>> The actual patch seems to be missing.
>
| Hrm... here it is ;-)
Ok, thanks.
Please wait at least until next week w
Lars Gullik BjÃnnes wrote:
> Alfredo Braunstein <[EMAIL PROTECTED]> writes:
>
> | This is the CoordBranch merge patch.
>
> The actual patch seems to be missing.
Hrm... here it is ;-)
Regards, Alfredo
allcoord.diff.gz
Description: GNU Zip compressed data
Alfredo Braunstein <[EMAIL PROTECTED]> writes:
| This is the CoordBranch merge patch.
The actual patch seems to be missing.
but thanks for sending such a nice overview (and a bit more) or what
this patch is doing.
--
Lgb
Jean-Marc Lasgouttes wrote:
> Angus> Shouldn't README.Win32 be renamed as README.Cygwin? If we
> Angus> want a README.Win32 then how about something like:
>
> Jean-Marc> Why not, but we should get our facts right.
> Or maybe merge the two file in one.
I think we should keep them separate. How abo
please ignore
This is the CoordBranch merge patch. I attach below a summarized ChangeLog;
I've tried to put there the most important changes but I could have missed
something. The Changelog is in the same order of the patch, so put both
side by side, take a deep breath and start reading. I think I understand
all
Jean-Marc Lasgouttes wrote:
> I guess you are right. Does this mean that all references to 'int' in
> the tabular code should be changed to idx_type?
idx_type or size_t?
Jürgen
The attached patch implements the discussed status messages in
MathHullInset::getStatus(). Is the wording ok?
I have one general question: What is the difference between the return value
of a getStatus() method and flag.enabled()? I noticed that e.g.
MathGridInset::getStatus() handles both, but
On Thu, Nov 25, 2004 at 04:07:03PM +0100, Juergen Spitzmueller wrote:
> OK?
> Jürgen
Aha, you're the table maintainer now ? :)
Cool stuff...
regards
john
Angus Leeming wrote:
> > I guess you are right. Does this mean that all references to 'int'
> > in the tabular code should be changed to idx_type?
>
> Looks like. All these lazy 32-bit coders...
I'll have a look.
Jürgen
Georg Baum wrote:
> BTW, you don't happen to know what all these lines
>
> //if (hasSelection())
> // cur.selection() = false;
>
> where supposed to do? because we use cur.selection() as a replacement for
> hasSelection() now...
I guess this should reset the se
Jean-Marc Lasgouttes wrote:
> Angus> Shouldn't README.Win32 be renamed as README.Cygwin?
> Angus> If we want a README.Win32 then how about something like:
>
> Why, not, but we should get our facts right.
Sure. Thanks for the corrections, but see below.
> Angus> Ruurd Reitsma has created a native
Juergen Spitzmueller wrote:
> OK?
According to what Alfredo told about cursor positions lately it looks fine.
BTW, you don't happen to know what all these lines
//if (hasSelection())
// cur.selection() = false;
where supposed to do? because we use cur.select
> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes:
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes:
Angus> Shouldn't README.Win32 be renamed as README.Cygwin? If we want
Angus> a README.Win32 then how about something like:
Jean-Marc> Why not, but we should get our fac
Jean-Marc Lasgouttes wrote:
>> "Angus" == Angus Leeming <[EMAIL PROTECTED]>
>> writes:
>
> Angus> As the code stands there's going to be a compilation warning
> Angus> about the conversion on 64-bit machines from size_t (8 bytes)
> Angus> to int (4 bytes).
>
> Angus> It looks to me like
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes:
Angus> Shouldn't README.Win32 be renamed as README.Cygwin? If we want
Angus> a README.Win32 then how about something like:
Why, not, but we should get our facts right.
Angus> Ruurd Reitsma has created a native port of LyX on Win32, using
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes:
Angus> As the code stands there's going to be a compilation warning
Angus> about the conversion on 64-bit machines from size_t (8 bytes)
Angus> to int (4 bytes).
Angus> It looks to me like all these Tabular::setXYZ functions should
Angus>
Shouldn't README.Win32 be renamed as README.Cygwin?
If we want a README.Win32 then how about something like:
Ruurd Reitsma has created a native port of LyX on Win32, using the
old but GPL-ed Qt/Win32 2.3.0 library. Find it, together with lots of
useful info at http://www.home.zonnet.nl/rareitsma
Juergen Spitzmueller wrote:
> OK?
> Jürgen
I'm not sure.
CursorSlice::idx_type is defined as:
typedef size_t idx_type;
But Tabular::setAllLines has the signature:
void setAllLines(int cell, bool line);
As the code stands there's going to be a compilation warning about
the conv
Juergen Spitzmueller wrote:
> Erm, actually, this is just what I am doing right now (look at the
> patch; I have also added a glue length validator to
> lengthvalidator).
Cool. (I was simply replying to your question.)
--
Angus
OK?
Jürgen
Index: insettabular.C
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/insets/insettabular.C,v
retrieving revision 1.444
diff -p -u -r1.444 insettabular.C
--- insettabular.C 24 Nov 2004 21:58:39 - 1.444
+++ insettabula
Angus Leeming wrote:
> Incidentally, Juergen, have you seen what the XForms frontend does?
> If a user inputs an invalid length, then it is highlighted in red and
> the Ok,Accept buttons are disabled. See xforms/checkedwidgets.[Ch]. I
> did something similar for the Qt External dialog. See the buil
John Spray wrote:
> On Thu, 2004-11-25 at 12:06 +, Angus Leeming wrote:
>> John, the GTK file dialog currently ignores the list of filters. Is
>> there any plan to change that?
> The plan is to rewrite the file dialog stuff to use GtkFileChooser
> instead of GtkFileSelection. I'd been plannin
Juergen Spitzmueller wrote:
> P.S.: Angus, why did you initialize the validator in
> QExternal->widthED to double? Shouldn't a user be able to enter
> "3.5cm" into the line edit widget even *if* "Scale" is still
> selected in the combo?
Sheesh! I dunno. I guess.
Incidentally, Juergen, have you se
On Thu, 2004-11-25 at 12:06 +, Angus Leeming wrote:
> John, the GTK file dialog currently ignores the list of filters. Is there
> any plan to change that?
The plan is to rewrite the file dialog stuff to use GtkFileChooser
instead of GtkFileSelection. I'd been planning to leave that until the
d
The attached patch adds length validators to the graphics and box dialogs. The
graphics dialog was the only one who didn't use widgetsToLength (so it was
not possible to enter lengths directly, like in the other dialogs). I have
intergrated this (with a new helper function that can handle QCombo
Lars Gullik Bjønnes wrote:
> | template
> | Controller const & GViewCB::controller() const
> | {
> | - return static_cast(getController());
> | + return static_cast | &>(Dialog::View::getController());
> | }
>
> I don't like the use of Dialog::View here, can you please try with
> just "th
John, the GTK file dialog currently ignores the list of filters. Is there
any plan to change that?
FileDialog::Private::open(string const & path,
lyx::support::FileFilterList const & /*filters*/,
string const & /*suggested*/)
The idea is to popu
John Spray <[EMAIL PROTECTED]> writes:
| Lars Gullik Bjønnes wrote:
>
>> | Okay, I'll switch to gcc 3.4 and work on this during my computer algebra
>>
>>| class this morning :-)
>>
>>Note that the gtk errors was in the gtkmm/libsigc libraries. If the
>>problem was only in frontends/gtk I would hav
[EMAIL PROTECTED] writes:
| CVSROOT: /usr/local/lyx/cvsroot
| Module name: lyx-devel
| Repository: lyx-devel/src/frontends/gtk/
| Changes by: [EMAIL PROTECTED] 04/11/25 12:33:01
>
| Modified files:
| lyx-devel/src/frontends/gtk/: GViewBase.h
| Added files:
| lyx-devel/
Lars Gullik Bjønnes wrote:
| Okay, I'll switch to gcc 3.4 and work on this during my computer algebra
| class this morning :-)
Note that the gtk errors was in the gtkmm/libsigc libraries. If the
problem was only in frontends/gtk I would have fixed in right away.
Just added barebones pch.h as sug
This patch just moves FileFilterList out of support/globbing.[Ch] and into
its own support/filefilterlist.[Ch] files. The idea is to eventually kill
globbing.[Ch] entirely.
Committing now...
--
Angus
filefilterlist.diff.gz
Description: GNU Zip compressed data
Lars Gullik Bjønnes wrote:
> Angus Leeming <[EMAIL PROTECTED]> writes:
> | I think that you forgot boost/spirit/core...
>
> I can even tell you why...
>
> cvs ignores "core"
You are not the first one bitten by this ;-)
Georg
John Spray <[EMAIL PROTECTED]> writes:
| On Thu, 2004-11-25 at 10:21 +0100, Lars Gullik Bjønnes wrote:
>> | Ah, I've only just found out what pch is. Perhaps someone who knows
>> | about it could take a look at bug 1745 [1], where "pch.h" is not found
>> | in frontends/gtk.
>>
>> The reason why
On Thu, 2004-11-25 at 10:21 +0100, Lars Gullik Bjønnes wrote:
> | Ah, I've only just found out what pch is. Perhaps someone who knows
> | about it could take a look at bug 1745 [1], where "pch.h" is not found
> | in frontends/gtk.
>
> The reason why I have not added that already is that gtk did n
Lars Gullik Bjønnes wrote:
> Angus Leeming writes:
> | I think that you forgot boost/spirit/core...
> I can even tell you why...
> cvs ignores "core"
A. Good detective work.
> I'll add it.
Thanks.
--
Angus
Angus Leeming <[EMAIL PROTECTED]> writes:
| [EMAIL PROTECTED] wrote:
>
>> CVSROOT: /usr/local/lyx/cvsroot
>> Module name: lyx-devel
>> Repository: lyx-devel/boost/boost/spirit/utility/impl/chset/
>> Changes by: [EMAIL PROTECTED] 04/11/24 22:11:03
>>
>> Modified files:
>
>> Log message:
[EMAIL PROTECTED] wrote:
> CVSROOT: /usr/local/lyx/cvsroot
> Module name: lyx-devel
> Repository: lyx-devel/boost/boost/spirit/utility/impl/chset/
> Changes by: [EMAIL PROTECTED] 04/11/24 22:11:03
>
> Modified files:
> Log message:
> add spirit
I think that you forgot boost/spirit/cor
John Spray <[EMAIL PROTECTED]> writes:
| On Thu, 2004-11-25 at 10:09 +0100, Lars Gullik Bjønnes wrote:
>> pch only on gcc 3.4 and 4.0
>
| Ah, I've only just found out what pch is. Perhaps someone who knows
| about it could take a look at bug 1745 [1], where "pch.h" is not found
| in frontends/gtk
On Thu, 2004-11-25 at 10:09 +0100, Lars Gullik Bjønnes wrote:
> pch only on gcc 3.4 and 4.0
Ah, I've only just found out what pch is. Perhaps someone who knows
about it could take a look at bug 1745 [1], where "pch.h" is not found
in frontends/gtk.
John
1. http://bugzilla.lyx.org/show_bug.cgi?i
Angus Leeming <[EMAIL PROTECTED]> writes:
>> | why do you use spirit/phoenix.hpp f.ex? aren't there smaller headers
>> | to use?
>
| I don't use spirit.hpp.
I didn't commit it either...
| I do use phoenix.hpp. Joel de Guzman makes repeated claims that Phoenix is
| a small library and that one sh
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes:
Angus> The built in copy constructor and assignment operator of a
Angus> class will use the copy constructor and assignment operator of
Angus> any member variables.
That makes sense.
Angus> So, no. FuncStatus does not need you to write
Lars Gullik Bjønnes wrote:
> [EMAIL PROTECTED] (Lars Gullik Bjønnes)
> writes:
>
> | Angus Leeming <[EMAIL PROTECTED]> writes:
>>
> | | g++ -DHAVE_CONFIG_H -I. -I../../../src/support -I../../src
> | | -I../../../src/support/../ -I../../../boost -I/usr/X11R6/include -g
> | | -O -fno-exceptions -W
47 matches
Mail list logo
