coord branch - looks good

2004-11-22 Thread Lars Gullik Bjønnes
I just had a look at the coord branch, I it feels pretty good. But i test of over a 11Mbit 802.11b X-forwarded link so it is hard to get a real feeling. But it feels a bit snappier than head, and several display bugs seems to be gone. What is the status of undo and paste? Are they fully function

Re: explicit destruction and placement new

2004-11-22 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | To be even more blunt: This kind of work does not help us to get 1.4.0 | out of the door. The small good it does is outweighed by distracting | people as seen e.g. in the XML discussion. Just to out-blunt you: I am not allowing you to command what _I_ d

Re: explicit destruction and placement new

2004-11-22 Thread Andre Poenitz
On Mon, Nov 22, 2004 at 09:34:32PM +0100, Lars Gullik Bjønnes wrote: > >>this->~SomeClass(); > >>new (this) SomeClass(foo); > >> > >> Does this work as intended? Or am I just way off? > > > | Maybe. > > I just had a look in my books and Mr. Sutter calls this the > "anti-idom" and says to

Re: explicit destruction and placement new

2004-11-22 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Mon, Nov 22, 2004 at 12:33:23PM +0100, Lars Gullik Bjønnes wrote: >> >> I am trying to make the inset hierarchy more immune to splicing and >> wrong usage. >> >> In mathed this construct is used >> >>*this = SomeClass(foo); > | Where? In fact,

Re: [patch] fix crash in mathhullinset

2004-11-22 Thread Georg Baum
Andre Poenitz wrote: > On Mon, Nov 22, 2004 at 05:12:03PM +0100, Georg Baum wrote: >> - I assume that we can never enter e.g. addCol() if getStatus returns >> false for "append-column". Therefore I removed the error messages in >> addCol() and delCol(). Is this assumption true? > > In theory, yes

Re: explicit destruction and placement new

2004-11-22 Thread Kuba Ober
On poniedziaÅek 22 listopad 2004 01:26 pm, Andre Poenitz wrote: > On Mon, Nov 22, 2004 at 12:33:23PM +0100, Lars Gullik BjÃnnes wrote: > > I am trying to make the inset hierarchy more immune to splicing and > > wrong usage. > > > > In mathed this construct is used > > > >*this = SomeClass(foo);

Re: [patch] gbox

2004-11-22 Thread Andre Poenitz
On Mon, Nov 22, 2004 at 10:56:57AM +0100, Jean-Marc Lasgouttes wrote: > I am not sure about that. It seems to me that the types eventually > resolve to unsigned int: > http://www.gtkmm.org/gtkmm2/docs/reference/html/classGtk_1_1TreeModel.html > http://www.gtkmm.org/gtkmm2/docs/reference/html/classG

Re: [patch] fix crash in mathhullinset

2004-11-22 Thread Andre Poenitz
On Mon, Nov 22, 2004 at 05:12:03PM +0100, Georg Baum wrote: > I recently discovered that one gets crashes or endless loops if one tries > to delete the only column of a formula. > This made me look at mathhullinset, and I came up with the attached patch > which fixes getStatus() and addCol()/delCo

Re: explicit destruction and placement new

2004-11-22 Thread Andre Poenitz
On Mon, Nov 22, 2004 at 12:33:23PM +0100, Lars Gullik Bjønnes wrote: > > I am trying to make the inset hierarchy more immune to splicing and > wrong usage. > > In mathed this construct is used > >*this = SomeClass(foo); Where? In fact, if this is Cursor/DocIterator code which retains anchor

Re: [patch] qt gluelength validator

2004-11-22 Thread Andre Poenitz
On Mon, Nov 22, 2004 at 10:12:05AM +0100, Lars Gullik Bjønnes wrote: > >> | +v->setBottom(glen); > >> | +return v; > >> | +} > >> > >> I really dont' like these returning pointers. > > > | This is 'best Qt practice'. The pointees life time is taken care of by > | its parent, and th

Re: [patch] qt gluelength validator

2004-11-22 Thread Andre Poenitz
On Mon, Nov 22, 2004 at 10:32:18AM +0100, Juergen Spitzmueller wrote: > > LyXLength len; > > Shouldn't len be (explicitely) initialized? It's default constructed. If the result is different from LyXLength len = LyXLength() the copy constructor has extremely unusual behaviour. Andre'

Re: [patch] qt gluelength validator

2004-11-22 Thread Juergen Spitzmueller
Lars Gullik Bjønnes wrote: > I can live with this. committed. Jürgen

Re: [PATCH] Bug 1739: The optional argument inset does not propagate the NeedProtect flag

2004-11-22 Thread Juergen Spitzmueller
Jean-Marc Lasgouttes wrote: > Sure, it does not make much sense... And memoir does not use two optional arguments with captions AFAICS. Jürgen

Re: [PATCH] Correct update in spellcheck and change merge

2004-11-22 Thread Jean-Marc Lasgouttes
> "Alfredo" == Alfredo Braunstein <[EMAIL PROTECTED]> writes: >> There is also a CoordBranch version, since they are a bit >> different. Shall I apply it, or do you prefer to merge by your self >> from time to time? Alfredo> Please apply it if you have done it already, and I'll reject Alfredo

Re: [PATCH] Correct update in spellcheck and change merge

2004-11-22 Thread Alfredo Braunstein
Jean-Marc Lasgouttes wrote: > Like that? Seems fine. > There is also a CoordBranch version, since they are a bit different. > Shall I apply it, or do you prefer to merge by your self from time to > time? Please apply it if you have done it already, and I'll reject the changes when I merge. Tha

[PATCH] Correct update in spellcheck and change merge

2004-11-22 Thread Jean-Marc Lasgouttes
> "Alfredo" == Alfredo Braunstein <[EMAIL PROTECTED]> writes: >> The problem is that this code does not use the dispatch mechanism, >> but direct calls to the kernel. Alfredo> Aha! That's the problem ;-) Well then just calling update (I Alfredo> think that fullRebreak + update in head) direct

Re: [Patch] gtk Sendto dialog

2004-11-22 Thread Lars Gullik Bjønnes
Georg Baum <[EMAIL PROTECTED]> writes: | John Spray wrote: > >> As in subject line. > | It does not compile with concept checks turned on. I'll apply the attached | patch shortly. We should probably report this to the gtkmm people somehow. and then they can decide if any changes are warranted.

Re: [Patch] gtk Sendto dialog

2004-11-22 Thread Georg Baum
John Spray wrote: > As in subject line. It does not compile with concept checks turned on. I'll apply the attached patch shortly. GeorgIndex: src/frontends/gtk/ChangeLog === RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/frontends/

Re: [PATCH] Bug 1739: The optional argument inset does not propagate the NeedProtect flag

2004-11-22 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> Jean-Marc Lasgouttes wrote: >> Didn't you forget captions? Juergen> Don't think so. What sense should a second optional argument Juergen> make in captions? Sure, it does not make much sense... JMarc

Re: [PATCH] Bug 1739: The optional argument inset does not propagate the NeedProtect flag

2004-11-22 Thread Juergen Spitzmueller
Jean-Marc Lasgouttes wrote: > Didn't you forget captions? Don't think so. What sense should a second optional argument make in captions? > Also, do not forget to update Extended.lyx. Done. Jürgen

Re: [patch] qt gluelength validator

2004-11-22 Thread Lars Gullik Bjønnes
Juergen Spitzmueller <[EMAIL PROTECTED]> writes: | Partially changed patch attached. I can live with this. -- Lgb

Re: [patch] qt gluelength validator

2004-11-22 Thread Juergen Spitzmueller
Lars Gullik Bjønnes wrote: > | Index: QExternalDialog.C > | === > | RCS file: > | /usr/local/lyx/cvsroot/lyx-devel/src/frontends/qt2/QExternalDialog.C,v > | retrieving revision 1.22 > | diff -p -u -r1.22 QExternalDialog.C > | --- QExte

Re: help debugging CoordBranch

2004-11-22 Thread Alfredo Braunstein
Jean-Marc Lasgouttes wrote: > Where is the relevant code? I guess that real_current_font, which is > just a cache is not updated at this point (you get the size of Author > paragraph). LCursor::getDim > So you may have to make sure it is updated. Ah, ok. So we have to add a call to setCurrentFo

Re: help debugging CoordBranch

2004-11-22 Thread Jean-Marc Lasgouttes
> "Alfredo" == Alfredo Braunstein <[EMAIL PROTECTED]> writes: >> Also, if you put the cursor in the middle of the first line and use >> cursor down, just after jumping above the note inset the cursor >> does not have the right size. Alfredo> What should I put as cursor size? IMO it should be

Re: help debugging CoordBranch

2004-11-22 Thread Alfredo Braunstein
Jean-Marc Lasgouttes wrote: > Now that I test the right build %-] here is a small difference: > when using cursor down, the cursor does not seem to enter float insets > (see for example the first note of the user guide). > > In head, the behaviour is slightly better, since the cursor enters the >

Re: [PATCH] Bug 1739: The optional argument inset does not propagate the NeedProtect flag

2004-11-22 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> Jean-Marc Lasgouttes wrote: >> I applied it, along with a small Customization.lyx update. Juergen> Good. I have applied the corresponding memoir code. Also, do not forget to update Extended.lyx. JMarc

Re: [PATCH] Bug 1739: The optional argument inset does not propagate the NeedProtect flag

2004-11-22 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> Jean-Marc Lasgouttes wrote: >> I applied it, along with a small Customization.lyx update. Juergen> Good. I have applied the corresponding memoir code. Didn't you forget captions? JMarc

explicit destruction and placement new

2004-11-22 Thread Lars Gullik Bjønnes
I am trying to make the inset hierarchy more immune to splicing and wrong usage. In mathed this construct is used *this = SomeClass(foo); (or the variant this->operator(SomeClass(foo)) ) My method of avoiding splicing and wrong usage does not like this very much... so I have replaced this w

Re: [LyX/Mac] Setting PATH in property file.

2004-11-22 Thread Jean-Marc Lasgouttes
> "Ronald" == Ronald Florence <[EMAIL PROTECTED]> writes: Ronald> This is a very good idea, with only one "gotcha" that I could Ronald> see: Ronald> "These environment variables are set only for applications Ronald> launched through Launch Services. If you run your executable Ronald> directly

Re: help debugging CoordBranch

2004-11-22 Thread Jean-Marc Lasgouttes
> "Alfredo" == Alfredo Braunstein <[EMAIL PROTECTED]> writes: Alfredo> Anyways, I think that this may be one of the last regressions Alfredo> of CoordBranch wrt HEAD, so I need testers to ascertain this Alfredo> please... Alfredo> Please report every other change wrt to HEAD Now that I test

Re: help debugging CoordBranch

2004-11-22 Thread Alfredo Braunstein
Andre Poenitz wrote: > So lets think a bit about it. > > My stomach says "Full repaint is just fine". Most of the other time > consuming stuff can be done in the metrics phase and cached (e.g. in > MetricsBase or the position cache) if necessary. So metrics() is the > part that hurts. Are your s

Re: [patch] gbox

2004-11-22 Thread Jean-Marc Lasgouttes
> "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes: Andre> On Fri, Nov 19, 2004 at 02:28:25PM +0100, Juergen Spitzmueller Andre> wrote: >> The attached patch shuts up a few compiler warnings. John, please >> have a look. I didn't test this very much. Andre> Please use 'size_t' instead of '

Re: help debugging CoordBranch

2004-11-22 Thread Jean-Marc Lasgouttes
> "Alfredo" == Alfredo Braunstein <[EMAIL PROTECTED]> writes: Alfredo> Hummpff Jean-Marc. Check line numbers in rowpainter.C: this Alfredo> backtrace is from HEAD, not CoordBranch. Erm, sorry about that. I do not know how I managed this :) I'll try to do a real test now... JMarc

Re: [patch] qt gluelength validator

2004-11-22 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Mon, Nov 22, 2004 at 09:24:41AM +0100, Lars Gullik Bjønnes wrote: >> | - v->setBottom(LyXLength()); >> | + LyXLength len = LyXLength(); >> >> LyXLength len; > | v->setBottom(LyXLength()) is just fine. > >> | + v->setBottom(glen); >> | + return v;

Re: [patch] qt gluelength validator

2004-11-22 Thread Andre Poenitz
On Mon, Nov 22, 2004 at 08:50:52AM +0100, Juergen Spitzmueller wrote: > Andre Poenitz wrote: > > I think I saw some code similar to > > > >    void foo(LyXLength len); > > > > This should be > > > >    void foo(LyXLength const & len); > > Corrected in the attached patch. I will commit this if I he

Re: [patch] qt gluelength validator

2004-11-22 Thread Lars Gullik Bjønnes
Juergen Spitzmueller <[EMAIL PROTECTED]> writes: | Andre Poenitz wrote: >> I think I saw some code similar to >> >>    void foo(LyXLength len); >> >> This should be >> >>    void foo(LyXLength const & len); > | Corrected in the attached patch. I will commit this if I hear no more | objections. >

Re: [patch] qt gluelength validator

2004-11-22 Thread Juergen Spitzmueller
Andre Poenitz wrote: > I think I saw some code similar to > >    void foo(LyXLength len); > > This should be > >    void foo(LyXLength const & len); Corrected in the attached patch. I will commit this if I hear no more objections. Jürgen Index: QExternalDialog.C =