Re: undo.C

2004-11-21 Thread Andre Poenitz
On Sun, Nov 21, 2004 at 03:37:35PM +0100, [EMAIL PROTECTED] wrote: > Andre, undo continues to have problems despite your last patch. That's bad news, especially since my next free slot on a private 'development' machine will be in two weeks' time. I don't even have a working LyX here to check. >

Re: help debugging CoordBranch

2004-11-21 Thread Andre Poenitz
On Sun, Nov 21, 2004 at 08:07:58PM +0100, Alfredo Braunstein wrote: > Andre Poenitz wrote: > > > We could e.g. have a 'metrics dirty flag' which is set to true > > by default and in cases we know that we haven't changed anything (i.e. > > just selecting and the creen hasn't moved) we set it to fal

Re: [patch] CoordBranch

2004-11-21 Thread Alfredo Braunstein
Andreas Vox wrote: > Today's CVS version doesn't crash any more, but cursor positioning in > maths isn't finished: > > - I can't reach some positions in inner insets, instead the cursor goes to > the > edge of some outer inset (Mouse _and_ Keyboard) I'll have a look. > - Sometimes the cursor

Re: [patch] CoordBranch

2004-11-21 Thread Andreas Vox
Alfredo Braunstein <[EMAIL PROTECTED]> writes: > > but look what happend when I just tried that: (see bugreport at the end) > > I was just scrolling to the math section of de_Userguide and > > clicking randomly ... > > Please try again with current CoordBranch. Anything else? Today's CVS version

Re: [patch] qt gluelength validator

2004-11-21 Thread Andre Poenitz
On Sun, Nov 21, 2004 at 01:23:54PM +0100, Juergen Spitzmueller wrote: > Andre Poenitz wrote: > > > Comments? > > > > LyX[Glue]Length arguments should be passed by reference. > > I don't understand. I think I saw some code similar to void foo(LyXLength len); This should be void foo(LyXLen

Re: help debugging CoordBranch

2004-11-21 Thread Andre Poenitz
On Sun, Nov 21, 2004 at 02:46:53PM +0100, Lars Gullik Bjønnes wrote: > | Third time you repeat this nonsense. Who's rushing anything? > > Andre seems pretty eager. Because ifrst of all, I think it's the right sthink to do technically, and secondly, I see messages on lyx-cvs telling me that Alfred

Re: help debugging CoordBranch

2004-11-21 Thread Alfredo Braunstein
Andre Poenitz wrote: > We could e.g. have a 'metrics dirty flag' which is set to true > by default and in cases we know that we haven't changed anything (i.e. > just selecting and the creen hasn't moved) we set it to false. Sure, but metrics is only one thing. When selecting, the bottleneck is

Re: help debugging CoordBranch

2004-11-21 Thread Andre Poenitz
On Sun, Nov 21, 2004 at 03:03:06AM +0100, Lars Gullik Bjønnes wrote: > Just because it is better than head does not mean that we should rush > to get it into head. I disagree especially since needlessly maintaining the branch bites into the most valuable resources we currently have: Alfredo's time

Re: help debugging CoordBranch

2004-11-21 Thread Andre Poenitz
On Sun, Nov 21, 2004 at 12:48:52AM +0100, Alfredo Braunstein wrote: > Mmm... I'm not 100% sure. The point is how to make these optimizations in a > way that keeps the code clean ;-) We could e.g. have a 'metrics dirty flag' which is set to true by default and in cases we know that we haven't chang

Re: [patch] qt gluelength validator

2004-11-21 Thread Juergen Spitzmueller
Alfredo Braunstein wrote: > I think that he means just to replace > boolÂLengthValidator::setBottom(LyXGlueLengthÂg) > by > boolÂLengthValidator::setBottom(LyXGlueLengthÂconst & g) > and so on, whenever possible. I see. OK, I'll change this. Regards, JÃrgen > Regards, Alfredo

Re: [patch] qt gluelength validator

2004-11-21 Thread Alfredo Braunstein
Juergen Spitzmueller wrote: >> LyX[Glue]Length arguments should be passed by reference. > > I don't understand. Hi Juergen, I think that he means just to replace boolÂLengthValidator::setBottom(LyXGlueLengthÂg) by boolÂLengthValidator::setBottom(LyXGlueLengthÂconst & g) and so on, whenever

Re: help debugging CoordBranch

2004-11-21 Thread Alfredo Braunstein
Lars Gullik BjÃnnes wrote: > coord might be better than what the head was lately, but it is not > better than what head used to be. I surely agree. (maybe we disagree with the dates: I think it is slow from about when we changed the drawing scheme -- i.e soon after 1.3.) I'm not as sure as Andre

Re: help debugging CoordBranch

2004-11-21 Thread Alfredo Braunstein
Lars Gullik BjÃnnes wrote: > PS. It is not friday today. ;-) I got confused with the timezone change and all... Alfredo

Re: help debugging CoordBranch

2004-11-21 Thread Lars Gullik Bjønnes
Alfredo Braunstein <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: > >> Alfredo Braunstein <[EMAIL PROTECTED]> writes: >> >> | Andre Poenitz wrote: >>> Hm... you could just merge CoordBranch back to HEAD. From wht I can tell >>> >> | Not all people here seem to agree. >> >> Just b

Re: help debugging CoordBranch

2004-11-21 Thread Alfredo Braunstein
Lars Gullik BjÃnnes wrote: > Alfredo Braunstein <[EMAIL PROTECTED]> writes: > > | Andre Poenitz wrote: >> >>> Hm... you could just merge CoordBranch back to HEAD. From wht I can tell >> > | Not all people here seem to agree. > > Just because it is better than head does not mean that we should ru

Re: help debugging CoordBranch

2004-11-21 Thread Lars Gullik Bjønnes
Alfredo Braunstein <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: > >> Loading times is not the crux of everything. > | Of course not. | >> I think we must look at how much we redraw on update as well. > | I think that speed is mostly irrelevant at this stage (plenty of | regressions)

Re: help debugging CoordBranch

2004-11-21 Thread Alfredo Braunstein
Lars Gullik BjÃnnes wrote: > Loading times is not the crux of everything. Of course not. > I think we must look at how much we redraw on update as well. I think that speed is mostly irrelevant at this stage (plenty of regressions). What I really cannot understand is this sudden rush to address

Re: [patch] qt gluelength validator

2004-11-21 Thread Juergen Spitzmueller
Andre Poenitz wrote: > > Comments? > > LyX[Glue]Length arguments should be passed by reference. I don't understand. Jürgen