Re: lyx-1.3.x/src/lyxlength.C

2004-11-04 Thread Georg Baum
Allan Rae wrote: > Actually if someone wanted to be extra helpful they could fix the > external inset problem mentioned in ANNOUNCE: > > - Partly fix the handling of included files. External insets are still > not working correctly [bug #605]. > > I've found a few threads in the archive about

Re: lyx-1.3.x/src/frontends/xforms/forms/Makefile.am

2004-11-04 Thread Allan Rae
Try this patch instead if you really want to stick to obsoleted rule types. How nobody else has had a problem is a mystery. Allan. (ARRae) Index: Makefile.am === RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/frontends/xforms/forms

Re: lyx-1.3.x/src/frontends/xforms/forms/Makefile.am

2004-11-04 Thread Allan Rae
Angus wrote: > This is a gnu make-ism, isn't it? At the moment the XForms frontend > builds with non-gnu makes. I don't think that we should change that. Automake generates plenty of entries with the "%.a: %.b" format. Take a look at your Makefiles. They appear to be libtool related mostly but t

Re: lyx-1.3.x/src/lyxlength.C

2004-11-04 Thread Allan Rae
On Thu, 4 Nov 2004, Jean-Marc Lasgouttes wrote: > > "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: > > Jean-Marc> Thanks for the tip. I'd rather use #include > Jean-Marc> "support/snprintf.h" since this uses our own implementation > Jean-Marc> if needed. Can you confirm that i

Re: [Patch] GWorkArea buttonpress handling

2004-11-04 Thread John Spray
On Thu, 2004-11-04 at 21:37 +0100, Lars Gullik Bjønnes wrote: > Why not a freestanding function? Should be no need to have this in > GWorkArea? > until used in other places as well, just put it in anon namespace in > GWorkArea.C. Done and committed. John

Re: [Patch] GWorkArea buttonpress handling

2004-11-04 Thread Lars Gullik Bjønnes
John Spray <[EMAIL PROTECTED]> writes: | Hi, > | When writing the box dialog, I noticed that all mouse clicks were having | the button-1 effect. This was because the gdk mouse button integer was | being cast straight to a mouse_button::state, so 1 converted correctly | but other values didn't. P

[Patch] GWorkArea buttonpress handling

2004-11-04 Thread John Spray
Hi, When writing the box dialog, I noticed that all mouse clicks were having the button-1 effect. This was because the gdk mouse button integer was being cast straight to a mouse_button::state, so 1 converted correctly but other values didn't. Patch attached. John Index: GWorkArea.C ===

Re: [patch] fix installation of lib/scripts/* and lib/lyx2lyx/lyx2lyx

2004-11-04 Thread Georg Baum
Lars Gullik Bjønnes wrote: > Georg Baum <[EMAIL PROTECTED]> > writes: > | No, I did not notice that until now, but I will do it. BTW, what should > | we do with configure.cmd? It is really outdated. Should we install it at > | all? Probably only for OS/2, but I don't know how to do that. > > Igno

Re: Someone apply this?

2004-11-04 Thread Jean-Marc Lasgouttes
> "chr" == chr <[EMAIL PROTECTED]> writes: chr> I modified it according to JMarcs statement. Thanks Christian. I applied the patch and adapted it to 1.3.x too. Both have been committed. JMarc

Re: lyx-1.3.x/src/lyxlength.C

2004-11-04 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> I thought I already did this for 1.4.0, but obviously not... Here is the corresponding patch against HEAD. I'll apply it shortly. JMarc Index: ChangeLog === RCS

Re: [patch] coordbranch

2004-11-04 Thread Jean-Marc Lasgouttes
> "Alfredo" == Alfredo Braunstein <[EMAIL PROTECTED]> writes: Alfredo> - It's simpler code (much more separation between data/view) Alfredo> - it's much near to multiple bvs of the same buffer - It is Alfredo> faster, and has the potential of being much faster (no need Alfredo> to keep updated

Re: lyx-1.3.x/src/lyxlength.C

2004-11-04 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: >> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: > | Angus> Looks good enough to me. Why not get rid of snprintf.[Ch] at | Angus> the same time? > | What I propose is to remove all traces of it in 1.4.0, and keep it as | it is in 1.3.x. I

Re: [patch] coordbranch

2004-11-04 Thread Alfredo Braunstein
Jean-Marc Lasgouttes wrote: >> "Alfredo" == Alfredo Braunstein >> <[EMAIL PROTECTED]> writes: > > Alfredo> I've implemented the "decoupling" between cursor and screen > Alfredo> in CoordBranch, similar as described in another thread. > > Alfredo> current most obvious problems: > > And h

Re: [patch] coordbranch

2004-11-04 Thread Jean-Marc Lasgouttes
> "Alfredo" == Alfredo Braunstein <[EMAIL PROTECTED]> writes: Alfredo> I've implemented the "decoupling" between cursor and screen Alfredo> in CoordBranch, similar as described in another thread. Alfredo> current most obvious problems: And how would you describe the advantages wrt HEAD?

Re: [patch] charstyle getStatus & draw

2004-11-04 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> Is the attached better? Yes, much better. Juergen> BTW: I have stolen the old code (in priv_dispatch) from Juergen> insetert. Should I implement there a getStatus method, too? Yes. This will disable the font-changing i

Re: lyx-1.3.x/src/lyxlength.C

2004-11-04 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> Looks good enough to me. Why not get rid of snprintf.[Ch] at Angus> the same time? What I propose is to remove all traces of it in 1.4.0, and keep it as it is in 1.3.x. I prefer to have a minimal impact on the sources. JMarc

Re: lyx-1.3.x/src/lyxlength.C

2004-11-04 Thread José Abílio Oliveira Matos
On Thu, Nov 04, 2004 at 11:27:04AM +, Angus Leeming wrote: > > Looks good enough to me. Why not get rid of snprintf.[Ch] at the same > time? I agree on both issues. > -- > Angus -- José Abílio Matos LyX and docbook a perfect match. :-)

Re: [patch] charstyle getStatus & draw

2004-11-04 Thread Juergen Spitzmueller
Angus Leeming wrote: > What's a 'curosor'? ;-) someone who's too curious. Jürgen

Re: [patch] charstyle getStatus & draw

2004-11-04 Thread Angus Leeming
Juergen Spitzmueller wrote: > Jean-Marc Lasgouttes wrote: >> I am not sure the getStatus code is really right. You should return >> true when you did something (meaning: OK, I know what to do about >> that lfun), and return the result of InsetText::getStatus >> otherwise. >> >> Actually, you shoul

Re: lyx-1.3.x/src/lyxlength.C

2004-11-04 Thread Angus Leeming
Jean-Marc Lasgouttes wrote: > Jean-Marc> Thanks for the tip. I'd rather use #include > Jean-Marc> "support/snprintf.h" since this uses our own > implementation Jean-Marc> if needed. Can you confirm that it works? > > Actually it does not work here. Since snprintf is not used anywhere > else in 1.

Re: [patch] charstyle getStatus & draw

2004-11-04 Thread Juergen Spitzmueller
Jean-Marc Lasgouttes wrote: > I am not sure the getStatus code is really right. You should return > true when you did something (meaning: OK, I know what to do about that > lfun), and return the result of InsetText::getStatus otherwise. > > Actually, you should rather call InsetCollapsable::getStat

[patch] coordbranch

2004-11-04 Thread Alfredo Braunstein
I've implemented the "decoupling" between cursor and screen in CoordBranch, similar as described in another thread. current most obvious problems: - missing fitCursor - scrolling not so smooth "one par at a time" - some visual problems in math with super/subscripts (no idea why) - some undo crash

Re: lyx-1.3.x/src/lyxlength.C

2004-11-04 Thread Jean-Marc Lasgouttes
> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: Jean-Marc> Thanks for the tip. I'd rather use #include Jean-Marc> "support/snprintf.h" since this uses our own implementation Jean-Marc> if needed. Can you confirm that it works? Actually it does not work here. Since snprintf i

Re: lyx-1.3.x/src/frontends/xforms/forms/Makefile.am

2004-11-04 Thread Angus Leeming
Allan Rae wrote: > > I'm trying to compile lyx-1.3.x cvs and found I need the following > change in order to avoid errors from make-3.79.1 which say it > doesn't know how to make .C files. This is a gnu make-ism, isn't it? At the moment the XForms frontend builds with non-gnu makes. I don't thi

Re: [patch] charstyle getStatus & draw

2004-11-04 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> This patch implements InsetCharStyle::getStatus as suggested Juergen> by Jean-Marc. Furthermore, it draws a visual clue when the Juergen> cursor is inside the inset (see attached screenshot). I am not sure the getStatus

Re: [patch] charstyle getStatus & draw

2004-11-04 Thread Martin Vermeer
On Thu, 2004-11-04 at 11:56, Juergen Spitzmueller wrote: > This patch implements InsetCharStyle::getStatus as suggested by Jean-Marc. > Furthermore, it draws a visual clue when the cursor is inside the inset (see > attached screenshot). > > Regards, > JÃrgen Flott! - Martin signature.asc Des

[patch] charstyle getStatus & draw

2004-11-04 Thread Juergen Spitzmueller
This patch implements InsetCharStyle::getStatus as suggested by Jean-Marc. Furthermore, it draws a visual clue when the cursor is inside the inset (see attached screenshot). Regards, Jürgen Index: insets/insetcharstyle.C === RCS fil

Re: coord cache

2004-11-04 Thread Alfredo Braunstein
Jean-Marc Lasgouttes wrote: > Alfredo> Not in main trunk ;-) > > Isee. > > Alfredo> In CoordBranch paragraphs have a cached dim_. It replaces > Alfredo> what it is height+width+... in main trunk. > > So it should go in a second coord cache, I guess (one for insets, one > for paragraphs). That'

Re: coord cache

2004-11-04 Thread Jean-Marc Lasgouttes
> "Alfredo" == Alfredo Braunstein <[EMAIL PROTECTED]> writes: Alfredo> Not in main trunk ;-) Isee. Alfredo> In CoordBranch paragraphs have a cached dim_. It replaces Alfredo> what it is height+width+... in main trunk. So it should go in a second coord cache, I guess (one for insets, one fo

Re: coord cache

2004-11-04 Thread Alfredo Braunstein
Jean-Marc Lasgouttes wrote: > Alfredo> Am I right in that every view-related data should go to the > Alfredo> coord cache? for instance, par.ascent(), par.descent() etc. > > What methods are you talking about? I cannot find a > Paragraph::ascent(). Not in main trunk ;-) In CoordBranch paragraph

Re: lyx-1.3.x/src/lyxlength.C

2004-11-04 Thread Jean-Marc Lasgouttes
> "Allan" == Allan Rae <[EMAIL PROTECTED]> writes: Hello Allan, Nice to see you around again! Allan> The recent backported bug fix for bug 1523 breaks compilation Allan> because snprintf() is unknown. Note this is lyx-1.3.x cvs I'm Allan> talking about. Thanks for the tip. I'd rather use #