Re: [patch] getRowNearY (was: anchor_row_)

2003-08-15 Thread Alfredo Braunstein
Alfredo Braunstein wrote: > John Levon wrote: > >> On Sat, Aug 16, 2003 at 12:51:20AM +0200, Alfredo Braunstein wrote: >> >>> RowList::iterator LyXText::getRowNearY(int & y, >>> - ParagraphList::iterator & pit) const >>> + ParagraphList::iterator & pit

Re: [patch] getRowNearY (was: anchor_row_)

2003-08-15 Thread Alfredo Braunstein
John Levon wrote: > On Sat, Aug 16, 2003 at 12:51:20AM +0200, Alfredo Braunstein wrote: > >> RowList::iterator LyXText::getRowNearY(int & y, >> - ParagraphList::iterator & pit) const >> + ParagraphList::iterator & pit) >> const > > You're uglifying the

Re: [patch] getRowNearY (was: anchor_row_)

2003-08-15 Thread John Levon
On Sat, Aug 16, 2003 at 12:51:20AM +0200, Alfredo Braunstein wrote: > RowList::iterator LyXText::getRowNearY(int & y, > - ParagraphList::iterator & pit) const > + ParagraphList::iterator & pit) const You're uglifying the source. I guess you use a small

Re: [patch] getRowNearY (was: anchor_row_)

2003-08-15 Thread Alfredo Braunstein
Alfredo Braunstein wrote: Here's a patch with both changes + some minor cosmetic stuff Index: text.C === RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/text.C,v retrieving revision 1.421 diff -u -p -u -r1.421 text.C --- text.C 1

[patch] getRowNearY (was: anchor_row_)

2003-08-15 Thread Alfredo Braunstein
On Friday 15 August 2003 17:19, André wrote: > > > Ok. What about paragraph count from beginning plus position within? > > > > Fine... and you can even drop the position I guess. > > > > I wonder if this anchor_par_ shouldn't be stored on the bufferview > > instead of the lyxtext. > > Good idea a

strace on lyx2lyx

2003-08-15 Thread Garst R. Reese
Here is where it seems go get stuck: mmap2(NULL, 212992, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x4054 munmap(0x40574000, 212992) = 0 mmap2(NULL, 212992, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x40574000 munmap(0x4054, 212992)

Re: [patch] row list split

2003-08-15 Thread Garst R. Reese
"Garst R. Reese" wrote: > > Andre Poenitz wrote: > > > What's the performance status ? > > > > Performance is really good and I haven't had a crash today... > Relative to July 1, it still sucks(1). Your machine is too fast. > > Garst > > (1) Still Unusable 'Cause Keyboard is Slow. OK, with toda

Re: weekend project

2003-08-15 Thread Martin Vermeer
On Thu, Aug 14, 2003 at 03:46:28PM +0200, Andre Poenitz spake thusly: > > the four > y-related arguments to paintRows() and tell me about his findings. > > *sigh* > > Andre' Suggesting a transformation: replace the two args y2 and yf by a single dy. Doesn't help understanding much, but makes th

Re: [patch] row list split

2003-08-15 Thread Andre Poenitz
On Fri, Aug 15, 2003 at 09:56:54AM +0200, Lars Gullik Bjønnes wrote: > Andre Poenitz <[EMAIL PROTECTED]> writes: > > | Not to mention 110 lost lines of not-so-obvious code and much simpler > | interface for the lyxrow_func.h stuff (the temporary > | LyXText::getPar(RowList::iterator) hack is alr

Compile fix

2003-08-15 Thread Kayvan A. Sylvan
gcc does not like the unterminated single quote: Index: src/BufferView_pimpl.C === RCS file: /cvs/lyx/lyx-devel/src/BufferView_pimpl.C,v retrieving revision 1.414 diff -u -r1.414 BufferView_pimpl.C --- src/BufferView_pimpl.C 2003

Re: [patch] row list split

2003-08-15 Thread Garst R. Reese
Andre Poenitz wrote: > > What's the performance status ? > > Performance is really good and I haven't had a crash today... Relative to July 1, it still sucks(1). Your machine is too fast. Garst (1) Still Unusable 'Cause Keyboard is Slow.

Re: [patch] waste cycles

2003-08-15 Thread Alfredo Braunstein
John Levon wrote: > On Fri, Aug 15, 2003 at 05:48:43PM +0200, Andre Poenitz wrote: > >> There is always a difference between John's expectations and the real >> world. >> >> [And to be honest, the same holds for mine...] > > Surely neither is "always" ... can we not agree on "most of the time"

Re: [patch] waste cycles

2003-08-15 Thread John Levon
On Fri, Aug 15, 2003 at 05:48:43PM +0200, Andre Poenitz wrote: > There is always a difference between John's expectations and the real > world. > > [And to be honest, the same holds for mine...] Surely neither is "always" ... can we not agree on "most of the time" ? :) john -- Khendon's Law:

Re: [patch] waste cycles

2003-08-15 Thread Andre Poenitz
On Fri, Aug 15, 2003 at 05:42:57PM +0200, Helge Hafting wrote: > On Fri, Aug 15, 2003 at 02:00:18PM +0100, John Levon wrote: > > On Fri, Aug 15, 2003 at 12:56:33PM +0200, Andre Poenitz wrote: > > > > > I'd like to apply this. > > > > Ooff, are you kidding ? I suspect this will make the whole scr

Re: Hello again!

2003-08-15 Thread John Levon
On Fri, Aug 15, 2003 at 06:57:22PM +0300, Martin Vermeer wrote: > > 2) when closing a branch and a cursor is inside, the cursor is not > > reset. > > I do not understand what you mean. > > If you mean: > - place cursor in inset > - close inset > - visible cursor lands on top of button Yes, but

Re: Hello again!

2003-08-15 Thread Martin Vermeer
On Wed, Aug 13, 2003 at 12:28:25AM +0100, John Levon spake thusly: > > On Mon, Aug 11, 2003 at 08:12:36PM +0300, Martin Vermeer wrote: > > > Here's an update. Two bugs squashed, an off-by-one in ColorHandler > > Generally seems OK. Problems : > > 1) the default color is black. This "should" giv

Re: [patch] waste cycles

2003-08-15 Thread Helge Hafting
On Fri, Aug 15, 2003 at 02:00:18PM +0100, John Levon wrote: > On Fri, Aug 15, 2003 at 12:56:33PM +0200, Andre Poenitz wrote: > > > I'd like to apply this. > > Ooff, are you kidding ? I suspect this will make the whole screen > flicker in Qt constantly. (It would be nice if you checked out the qt

Re: [patch] row list split

2003-08-15 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | Not to mention 110 lost lines of not-so-obvious code and much simpler | interface for the lyxrow_func.h stuff (the temporary | LyXText::getPar(RowList::iterator) hack is already gone btw) To me the patch looks pretty good. -- Lgb

[patch] row list split

2003-08-15 Thread Andre Poenitz
Only known issue is funny behaviour for 'cursor down' on the last line of a text (jumps to first line...). Reason is more or less known (the 'correction' in getRowNearY). In any case, looks like all crashes are gone (especially the multiline cut), so this is an improvement. Not to mention 110 l

Re: UI tuning

2003-08-15 Thread Andre Poenitz
On Thu, Aug 14, 2003 at 06:00:01PM +0100, John Levon wrote: > On Thu, Aug 14, 2003 at 06:46:14PM +0200, Andre Poenitz wrote: > > > (b) send it to someone who's able to compile it... > > It didn't have change logs. I'm not writing them. That's what I use to create ChangeLog entry skeletons from

[patch] waste cycles

2003-08-15 Thread Andre Poenitz
I'd like to apply this. It wastes a few cycles but reduces the number of places drawFromTo from 4 to 2, with identical arguments. So I'd fold this into redraw() and might be able to figure out which of the four y coordinates to paintRows are unneeded... I can't see any slowdown btw. Andre' --

Re: UI tuning

2003-08-15 Thread Lars Gullik Bjønnes
"Garst R. Reese" <[EMAIL PROTECTED]> writes: | Maybe if there was an almost working port there would be more people | interested in fixing and maintaining it. As things now stand you | (collective) have been pretty effective at stifling all attempts to get | a gtk/gnome port working, or even start

Re: UI tuning

2003-08-15 Thread Garst R. Reese
Lars Gullik Bjønnes wrote: > > And what if he is indeed scared off? Why should we have frontend that > no-one is willing to support? > > -- > Lgb Maybe if there was an almost working port there would be more people interested in fixing and maintaining it. As things now stand you (collec

Requested report

2003-08-15 Thread Michael Schmitt
Hi, create new doc, enter "a", undo -> text not available! no text in cache! BufferView::update() BufferView::update() dont like 1 please report <== BufferView::update() Michael

regression

2003-08-15 Thread Andre Poenitz
Hm.. there _are_ regressions. Go into a tall minipage, try to go down... Just commited a fix for some aspect of it but that's not yet sufficient. Andre' -- Those who desire to give up Freedom in order to gain Security, will not have, nor do they deserve, either one. (T. Jefferson or B. Fra

Re: toggleSelection

2003-08-15 Thread Andre Poenitz
On Sat, Aug 09, 2003 at 01:19:52PM +0200, Juergen Spitzmueller wrote: > Andre Poenitz wrote: > > > it toggles the selection ;-) > > > > Under what circumstances would I notice it? > > I have noticed it when playing with text3.C before replaceSelection() > has been introduced. Imagine the old do-no

Re: regression

2003-08-15 Thread John Levon
On Fri, Aug 15, 2003 at 03:21:21PM +0200, Andre Poenitz wrote: > > change tracking, > > I think it's safe now to start to fix it. OK, I'll start looking into it. We have a couple of mildly tough issues. regards john -- Khendon's Law: If the same point is made twice by the same person, the thr

Re: anchor_row

2003-08-15 Thread Andre Poenitz
On Fri, Aug 15, 2003 at 03:16:50PM +0100, John Levon wrote: > On Fri, Aug 15, 2003 at 04:12:43PM +0200, Alfredo Braunstein wrote: > > > Needless to say, I don't agree with > > > > - RowList::iterator anchor_row_; > > You have to evangelise/explain to Andre. Lest it gets lost: The part of

Re: toggleSelection

2003-08-15 Thread Juergen Spitzmueller
Andre Poenitz wrote: > > it toggles the selection ;-) > > Under what circumstances would I notice it? I have noticed it when playing with text3.C before replaceSelection() has been introduced. Imagine the old do-not-replace-selection policy (which is still in 1.3.x). When you have selected a few

Re: regression

2003-08-15 Thread Andre Poenitz
On Fri, Aug 15, 2003 at 02:15:22PM +0100, John Levon wrote: > On Fri, Aug 15, 2003 at 03:10:32PM +0200, Andre Poenitz wrote: > > > > Now is the difficult part :) > > > > I don't agree. > > It took me more than an hour to just *analyse* the two bugs I posted > about. We already have 40 or so know

Re: regression

2003-08-15 Thread John Levon
On Fri, Aug 15, 2003 at 03:10:32PM +0200, Andre Poenitz wrote: > > Now is the difficult part :) > > I don't agree. It took me more than an hour to just *analyse* the two bugs I posted about. We already have 40 or so known regressions; the true number is nearer 100 I reckon. Never mind the total

Re: anchor_row

2003-08-15 Thread Andre Poenitz
On Fri, Aug 15, 2003 at 03:16:50PM +0100, John Levon wrote: > On Fri, Aug 15, 2003 at 04:12:43PM +0200, Alfredo Braunstein wrote: > > > Needless to say, I don't agree with > > > > - RowList::iterator anchor_row_; > > You have to evangelise/explain to Andre. I am happy to learn about it.

Re: [patch] row list split

2003-08-15 Thread Andre Poenitz
On Fri, Aug 15, 2003 at 10:29:49AM +0200, Lars Gullik Bjønnes wrote: > Andre Poenitz <[EMAIL PROTECTED]> writes: > > | Maybe we should start thinking of a freeze policy for the 1.4 release > | which does not lead to deadlocks and half-year-long slumber. > > Suggestions? Not yet. But when it com

Dead code

2003-08-15 Thread Michael Schmitt
Hello, I have prepared a new list of dead code, just in case anybody is interested in it... Ah... btw, I used the QT frontend. Michael > (anonymous namespace)::Correction* std::__copy_backward<(anonymous > namespace)::Correction*, (anonymous namespace)::Correction*>((anonymous > namespace)::

Re: mini-patch for "make dist"

2003-08-15 Thread Lars Gullik Bjønnes
"Kayvan A. Sylvan" <[EMAIL PROTECTED]> writes: | On Fri, Aug 15, 2003 at 08:55:10AM +0200, Lars Gullik Bjønnes wrote: >> >> MOve the EXTRA_DIST back where it used to be and add the gz files >> explicit to the var. >> >> -- >> Lgb > | Done. A lot better :-) Ok for commit. -- Lgb

Re: toggleSelection

2003-08-15 Thread Andre Poenitz
On Sat, Aug 09, 2003 at 01:00:57PM +0200, Juergen Spitzmueller wrote: > Andre Poenitz wrote: > > What is it good for? > > it toggles the selection ;-) Under what circumstances would I notice it? > > Everything still seems to work if I simply remove it? > > It has been used in text3.C before I h

Re: anchor_row

2003-08-15 Thread John Levon
On Fri, Aug 15, 2003 at 04:12:43PM +0200, Alfredo Braunstein wrote: > Needless to say, I don't agree with > > - RowList::iterator anchor_row_; You have to evangelise/explain to Andre. john -- Khendon's Law: If the same point is made twice by the same person, the thread is over.

Problem with CVS lyx and graphics

2003-08-15 Thread Pascal Francq
Hi, I have just compile the lastest cvs version of LyX, and I have problems with graphics: when I insert several graphics in a LyX document, it is always the same graphic which is shown in the output file. In fact, in the LaTeX source generated by LyX (/tmp/lyx), it is always the same filena

Re: anchor_row

2003-08-15 Thread Andre Poenitz
On Fri, Aug 15, 2003 at 04:12:43PM +0200, Alfredo Braunstein wrote: > Needless to say, I don't agree with > > - RowList::iterator anchor_row_; If you tell me what it was supposed to do I'll happily re-implement it on top of the now split rowlist. Andre' -- Those who desire to give up Fr

Re: regression

2003-08-15 Thread Andre Poenitz
On Fri, Aug 15, 2003 at 02:02:32PM +0100, John Levon wrote: > On Fri, Aug 15, 2003 at 02:56:33PM +0200, Andre Poenitz wrote: > > > Hm.. there _are_ regressions. Go into a tall minipage, try to go down... > > Just commited a fix for some aspect of it but that's not yet sufficient. > > I think we n

anchor_row

2003-08-15 Thread Alfredo Braunstein
Needless to say, I don't agree with - RowList::iterator anchor_row_; Alfredo

Re: [patch] waste cycles

2003-08-15 Thread Andre Poenitz
On Fri, Aug 15, 2003 at 02:00:18PM +0100, John Levon wrote: > On Fri, Aug 15, 2003 at 12:56:33PM +0200, Andre Poenitz wrote: > > > I'd like to apply this. > > Ooff, are you kidding ? Goes away if the draw there is removed entirely... Andre' -- Those who desire to give up Freedom in order to g

Re: [patch] row list split

2003-08-15 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | Maybe we should start thinking of a freeze policy for the 1.4 release | which does not lead to deadlocks and half-year-long slumber. Suggestions? -- Lgb

Re: [patch] row list split

2003-08-15 Thread John Levon
On Fri, Aug 15, 2003 at 02:58:31PM +0200, Andre Poenitz wrote: > Pessimist. Sure am ! john -- Khendon's Law: If the same point is made twice by the same person, the thread is over.

Re: toggleSelection

2003-08-15 Thread Juergen Spitzmueller
Andre Poenitz wrote: > What is it good for? it toggles the selection ;-) > Everything still seems to work if I simply remove it? It has been used in text3.C before I have introduced my replaceSelection method (to replace selected text with pasted or typed text). In the old days, the text would

Re: regression

2003-08-15 Thread John Levon
On Fri, Aug 15, 2003 at 02:56:33PM +0200, Andre Poenitz wrote: > Hm.. there _are_ regressions. Go into a tall minipage, try to go down... > Just commited a fix for some aspect of it but that's not yet sufficient. I think we need to know when things have "stopped" so we can get Michael, me, etc. t

Re: Problem with CVS lyx and graphics

2003-08-15 Thread John Levon
On Fri, Aug 15, 2003 at 03:46:06PM +0200, Pascal Francq wrote: > I have just compile the lastest cvs version of LyX, and I have > problems with graphics: when I insert several graphics in a LyX > document, it is always the same graphic which is shown in the output > file. In fact, in the LaTeX sou

Re: mini-patch for "make dist"

2003-08-15 Thread Kayvan A. Sylvan
On Fri, Aug 15, 2003 at 08:55:10AM +0200, Lars Gullik Bjønnes wrote: > > MOve the EXTRA_DIST back where it used to be and add the gz files > explicit to the var. > > -- > Lgb Done. -- Kayvan A. Sylvan | Proud husband of | Father to my kids: Sylvan Associates, Inc. | Lau

Re: [patch] waste cycles

2003-08-15 Thread John Levon
On Fri, Aug 15, 2003 at 12:56:33PM +0200, Andre Poenitz wrote: > I'd like to apply this. Ooff, are you kidding ? I suspect this will make the whole screen flicker in Qt constantly. (It would be nice if you checked out the qt frontend from time to time ...) I dread to think of the X traffic this

Re: [Patch] Modernization & cleanup in ColorHandler

2003-08-15 Thread Martin Vermeer
On Wed, Aug 13, 2003 at 09:47:38AM +0100, Angus Leeming spake thusly: > Martin Vermeer wrote: > > > OK to commit? > > I wasn't paying too much attention to your earlier explanation. Thw > code below looks entirely reasonable. Why do you want to get rid of > the 'XAllocColor(... &ccol)' step?

anchor_row

2003-08-15 Thread Andre Poenitz
Why is this needed at all? Wouldn't a 'y offset from document start' suffice? I'd even guess scrolling would be much smoother ... Andre' -- Those who desire to give up Freedom in order to gain Security, will not have, nor do they deserve, either one. (T. Jefferson or B. Franklin or both.

Re: [patch] row list split

2003-08-15 Thread Andre Poenitz
On Fri, Aug 15, 2003 at 01:54:33PM +0100, John Levon wrote: > On Fri, Aug 15, 2003 at 10:13:26AM +0200, Andre Poenitz wrote: > > > There are lots of small things, though. The two phase drawing is still a > > bit hackish for the main text etc but generally spoken I am more or less > > happy now. >

toggleSelection

2003-08-15 Thread Andre Poenitz
What is it good for? Everything still seems to work if I simply remove it? Andre' -- Those who desire to give up Freedom in order to gain Security, will not have, nor do they deserve, either one. (T. Jefferson or B. Franklin or both...)

Re: [patch] row list split

2003-08-15 Thread John Levon
On Fri, Aug 15, 2003 at 10:13:26AM +0200, Andre Poenitz wrote: > There are lots of small things, though. The two phase drawing is still a > bit hackish for the main text etc but generally spoken I am more or less > happy now. Really ? So you're basically "done" ? What's the performance status ?