[patch] Store Buffer in shared_ptr.

2003-07-17 Thread Lars Gullik Bjønnes
I like this patch... and I am sure that several of you won't... Anyway, please have a look. ? src/less ? src/frontends/xforms/FormPreferences.o.lock ? src/frontends/xforms/lyx_forms.h ? src/frontends/xforms/lyx_xpm.h Index: src/BufferView.C ===

[patch] Fix Gcc 3.4 compilation.

2003-07-17 Thread Lars Gullik Bjønnes
Please have a quick look. ? src/frontends/xforms/lyx_forms.h ? src/frontends/xforms/lyx_xpm.h Index: boost/boost/config/compiler/gcc.hpp === RCS file: /usr/local/lyx/cvsroot/lyx-devel/boost/boost/config/compiler/gcc.hpp,v retrieving

Re: Enchant spellchecker

2003-07-17 Thread Garst R. Reese
Lars Gullik Bjønnes wrote: > What is glib? > part of gnome -- short for gnome-lib I guess. Dumb name.

Re: [patch] textwidth

2003-07-17 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | Angus Leeming wrote: | | > Lars Gullik Bjønnes wrote: | > | >> Andre Poenitz <[EMAIL PROTECTED]> writes: | >> | >> | + lyxerr << "InsetTabular::draw: " << x << " " << y << "\n"; | >> | >> Please, please do not use '\n' to end a lyxerr sequence, us

Re: lyx --export with wrong argument crashes

2003-07-17 Thread Alfredo Braunstein
Kayvan A. Sylvan wrote: > Latest CVS: > > $ lyx --export foo Ah yes... correct behaviour, but somewhat harsh wording ;-) Anyway, It's entirely my fault (two different bugs actually). Can I apply this fix? Index: src/lyx_main.C =

Re: [patch] textwidth

2003-07-17 Thread Angus Leeming
Angus Leeming wrote: > Lars Gullik Bjønnes wrote: > >> Andre Poenitz <[EMAIL PROTECTED]> writes: >> >> | + lyxerr << "InsetTabular::draw: " << x << " " << y << "\n"; >> >> Please, please do not use '\n' to end a lyxerr sequence, use >> std::endl, since that also flush the buffer. >> >> I hav

Re: [patch] textwidth

2003-07-17 Thread Angus Leeming
Lars Gullik Bjønnes wrote: > Andre Poenitz <[EMAIL PROTECTED]> writes: > > | + lyxerr << "InsetTabular::draw: " << x << " " << y << "\n"; > > Please, please do not use '\n' to end a lyxerr sequence, use > std::endl, since that also flush the buffer. > > I have a patch somewhere that fixes thi

Re: [patch] textwidth

2003-07-17 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | + lyxerr << "InsetTabular::draw: " << x << " " << y << "\n"; Please, please do not use '\n' to end a lyxerr sequence, use std::endl, since that also flush the buffer. I have a patch somewhere that fixes this other places in the code. (OTOH a patch

Re: Enchant spellchecker

2003-07-17 Thread Lars Gullik Bjønnes
John Levon <[EMAIL PROTECTED]> writes: | | http://www.abisource.com/enchant/ | | I've been talking with Dom, and it sounds like this might be promising | for LyX. One problem is that it only takes UTF8 apparently though (and | currently there is a requirement on glib - I'm not sure whether that

lyx --export with wrong argument crashes

2003-07-17 Thread Kayvan A. Sylvan
Latest CVS: $ lyx --export foo lyx: SIGSEGV signal caught Sorry, you have found a bug in LyX. Please read the bug-reporting instructions in Help->Introduction and send us a bug report, if necessary. Thanks ! Bye. Abort (core dumped) ---Kayvan -- Kayvan A. Sylvan

Re: Cleaning up the spellchecker controller

2003-07-17 Thread Angus Leeming
John Levon wrote: > On Thu, Jul 17, 2003 at 06:44:35PM +, Angus Leeming wrote: > >> Can you help fill in the gaps here. > > I added the FIXMEs. I have no idea what they do, how they work, or how > they're supposed to be used. Sorry. Then I'll try and dig. Thanks anyway. -- Angus

Re: Cleaning up the spellchecker controller

2003-07-17 Thread John Levon
On Thu, Jul 17, 2003 at 06:44:35PM +, Angus Leeming wrote: > Can you help fill in the gaps here. I added the FIXMEs. I have no idea what they do, how they work, or how they're supposed to be used. Sorry. regards john

Re: Cleaning up the spellchecker controller

2003-07-17 Thread Angus Leeming
John Levon wrote: > Thu, Jul 17, 2003 at 06:20:08PM +, Angus Leeming wrote: > >> What exactly is >> word_ = bufferview()->nextWord(newval_); >> doing. What is newval_ and why is it being updated? > > It is allgedly the position of the word in the whole document (for the > progress bar). It

Re: Cleaning up the spellchecker controller

2003-07-17 Thread John Levon
Thu, Jul 17, 2003 at 06:20:08PM +, Angus Leeming wrote: > What exactly is > word_ = bufferview()->nextWord(newval_); > doing. What is newval_ and why is it being updated? It is allgedly the position of the word in the whole document (for the progress bar). It doesn't work very well.

Re: Cleaning up the spellchecker controller

2003-07-17 Thread Angus Leeming
[Taking this to lyx-devel rather than lyx-users...] On Thursday 17 July 2003 5:11 pm, John Levon wrote: > On Thu, Jul 17, 2003 at 06:07:19PM +, Angus Leeming wrote: > > John, I think that you know this code well. Am I on the right track? > > Why all in LFUN_SPELLCHECK ? Most of these seem fair

Re: New note inset

2003-07-17 Thread Juergen Spitzmueller
Garst R. Reese wrote: > Why use a long word when a short one does the job? > But maybe "Post-it Note" in place of just "Note" would be the best > description. We have to somehow distinguish between 1. The "Note" (Meta-)Inset which currently contains a.) the (old) Note Inset b.) the comment environ

Re: Enchant spellchecker

2003-07-17 Thread John Levon
On Thu, Jul 17, 2003 at 05:03:35PM +, Angus Leeming wrote: > For the record, Enchant is already in use by Conglomerate, Lyx, and AbiWord. I got him to fix it already. The big issue for us is UTF8 regards john

Re: New note inset

2003-07-17 Thread John Levon
On Thu, Jul 17, 2003 at 01:06:11PM -0300, Garst R. Reese wrote: > I think of annotations as something pedantically added to a document, as > in an annotated bibliography or "The annotated version of ..." Note OTOH > is familar to me from lots of old software as something that will not > get printe

Re: New note inset

2003-07-17 Thread Garst R. Reese
John Levon wrote: > > On Thu, Jul 17, 2003 at 05:16:42PM +0200, Lars Gullik Bj?nnes wrote: > > > | > Can we rename "note" to "annotation" in the "insert" menu? There's a > > | > > | Possibly. What do others think ? > > > > Is a note the same as an annotation? > > In this context I would say so y

Re: Enchant spellchecker

2003-07-17 Thread Angus Leeming
John Levon wrote: > > http://www.abisource.com/enchant/ > > I've been talking with Dom, and it sounds like this might be promising > for LyX. One problem is that it only takes UTF8 apparently though (and > currently there is a requirement on glib - I'm not sure whether that's a > serious proble

[patch] textwidth

2003-07-17 Thread Andre Poenitz
This prepares some infrastructure to break text at the proper width right from the beginning instead of relying on the remains of 'update' to get it rigth after a while.. [And yes, I keep the table row creation bug in mind] Andre' -- Those who desire to give up Freedom in order to gain Securit

Re: The new gtk+ patch

2003-07-17 Thread Juergen Spitzmueller
Andre Poenitz wrote: > > You'll need a gtk 2 installation. libgtkmm is the C++ API. > > I think I have a gtk2 installation now, but there seem to be no > libgtkmm-2 rpms for SuSE.. Indeed. And gtkmm-2 does not compile from source with gcc-3.3 due to a compiler bug :-( No way at least for SuSE 8.2

Re: Enchant spellchecker

2003-07-17 Thread Jose' Matos
On Thursday 17 July 2003 16:42, John Levon wrote: > http://www.abisource.com/enchant/ > > I've been talking with Dom, and it sounds like this might be promising > for LyX. One problem is that it only takes UTF8 apparently though (and > currently there is a requirement on glib - I'm not sure whether

Re: regression

2003-07-17 Thread Angus Leeming
Andre Poenitz wrote: > Remove the 'if...' line entirely and re-indent the second. Done. > Or even better: remove the case altogether. default return > UNDISPATCHED. I started, but stopped again having got confused ;-) -- Angus

Enchant spellchecker

2003-07-17 Thread John Levon
http://www.abisource.com/enchant/ I've been talking with Dom, and it sounds like this might be promising for LyX. One problem is that it only takes UTF8 apparently though (and currently there is a requirement on glib - I'm not sure whether that's a serious problem) regards john

Re: regression

2003-07-17 Thread Angus Leeming
Andre Poenitz wrote: > On Thu, Jul 17, 2003 at 02:36:32PM +0200, Alfredo Braunstein wrote: >> Alfredo Braunstein wrote: >> >> >> I don't feel guilty right now... >> > >> > I didn't suggest that you should... >> >> Are you developing a pavlovian reaction to the word 'regression'? > > Well, both

Re: regression

2003-07-17 Thread Andre Poenitz
On Thu, Jul 17, 2003 at 04:23:53PM +, Angus Leeming wrote: > case LFUN_DIALOG_SHOW: > - if (argument == "mathpanel") > +// if (argument == "mathpanel") > result = UNDISPATCHED; > break; > ... > } > > I think tha

Re: regression

2003-07-17 Thread John Levon
On Thu, Jul 17, 2003 at 04:23:53PM +, Angus Leeming wrote: > - if (argument == "mathpanel") > +// if (argument == "mathpanel") I guess this is bug 1268 as well as bug 1273. > Actually, one could argue that things like the "mathmatrix" dialog are an > implementation

Re: regression

2003-07-17 Thread Angus Leeming
Andre Poenitz wrote: > On Thu, Jul 17, 2003 at 02:36:32PM +0200, Alfredo Braunstein wrote: >> Alfredo Braunstein wrote: >> >> >> I don't feel guilty right now... >> > >> > I didn't suggest that you should... >> >> Are you developing a pavlovian reaction to the word 'regression'? > > Well, both

Re: New note inset

2003-07-17 Thread John Levon
On Thu, Jul 17, 2003 at 05:16:42PM +0200, Lars Gullik Bj?nnes wrote: > | > Can we rename "note" to "annotation" in the "insert" menu? There's a > | > | Possibly. What do others think ? > > Is a note the same as an annotation? In this context I would say so yes. > (and is the same dialog/menu-

Re: New note inset

2003-07-17 Thread Lars Gullik Bjønnes
John Levon <[EMAIL PROTECTED]> writes: | On Thu, Jul 17, 2003 at 02:17:05PM +0200, Michael Schmitt wrote: | | > Can we rename "note" to "annotation" in the "insert" menu? There's a | | Possibly. What do others think ? Is a note the same as an annotation? (and is the same dialog/menu-entry used

Re: New note inset

2003-07-17 Thread Juergen Spitzmueller
Am Donnerstag, 17. Juli 2003 17:05 schrieb John Levon: > > Can we rename "note" to "annotation" in the "insert" menu? There's a > > Possibly. What do others think ? Yes. "Note" is just a member of the new meta-inset. And it indicates to the user that this is something different (but still familia

Re: New note inset

2003-07-17 Thread John Levon
On Thu, Jul 17, 2003 at 02:17:05PM +0200, Michael Schmitt wrote: > Can we rename "note" to "annotation" in the "insert" menu? There's a Possibly. What do others think ? regards john

Re: The new gtk+ patch

2003-07-17 Thread Andre Poenitz
On Thu, Jul 17, 2003 at 03:16:38PM +0100, John Levon wrote: > On Thu, Jul 17, 2003 at 04:15:41PM +0200, Andre Poenitz wrote: > > > > the needed trivial cleanups. > > > > We could apply it anyway and avoid sending around more incarnations of > > that big patch... > > This might not encourage said

A definite table bug

2003-07-17 Thread Michael Schmitt
Hello, create a new doc, insert a table, append a row in the top/leftmost cell -> Crash! ==11874== ==11874== Conditional jump or move depends on uninitialised value(s) ==11874==at 0x8204B7A: InsetText::saveLyXTextState() const (insettext.C:90) ==11874==by 0x820BDE5: InsetText::reinitLyX

A bug?

2003-07-17 Thread Michael Schmitt
Create a new document, insert a table: ==11853== Conditional jump or move depends on uninitialised value(s) ==11853==at 0x8204B7A: InsetText::saveLyXTextState() const (insettext.C:90) ==11853==by 0x820BDE5: InsetText::reinitLyXText() const (insettext.C:2004) ==11853==by 0x81FAC59

Re: The new gtk+ patch

2003-07-17 Thread John Levon
On Thu, Jul 17, 2003 at 04:15:41PM +0200, Andre Poenitz wrote: > > the needed trivial cleanups. > > We could apply it anyway and avoid sending around more incarnations of > that big patch... This might not encourage said cleanups ;) > > Good work ! > > How do you compile that? I didn't. > I.

Re: The new gtk+ patch

2003-07-17 Thread Andre Poenitz
On Thu, Jul 17, 2003 at 03:11:29PM +0100, John Levon wrote: > These are all minor points. I'm in favour of this patch being applied after > the needed trivial cleanups. We could apply it anyway and avoid sending around more incarnations of that big patch... > Good work ! How do you compile that?

Re: The new gtk+ patch

2003-07-17 Thread John Levon
On Thu, Jul 17, 2003 at 09:49:05PM +0800, Huang Ying wrote: > Sorry, I forget the attachment! + FRONTEND_INFO="libgtkmm version: ${GTKMM_VERSION}\n\ +libglademm version: ${LIBGLADEMM_VERSION}\n" + ;; Whitespace damage and in configure.ac (spaces instead of a tab) +

Re: The new gtk+ patch

2003-07-17 Thread Andre Poenitz
On Thu, Jul 17, 2003 at 09:49:05PM +0800, Huang Ying wrote: > Sorry, I forget the attachment! Don't worry. Can you tell me what packages is needed (preferably SuSE 8.1) to get the 'pgk-config' that seems to be needed? Andre' -- Those who desire to give up Freedom in order to gain Security, w

new gtk patch

2003-07-17 Thread Huang Ying
After last gtk patch, many people propose good advice, so I can make some change of my patch. Something worth saying: 1. after erase 2 or 3 inline functions, there are also many inline functions, but almost every inline function is less than 3 lines, so I think reserve these inline functions do not

Re: regression

2003-07-17 Thread Andre Poenitz
On Thu, Jul 17, 2003 at 02:36:32PM +0200, Alfredo Braunstein wrote: > Alfredo Braunstein wrote: > > >> I don't feel guilty right now... > > > > I didn't suggest that you should... > > Are you developing a pavlovian reaction to the word 'regression'? Well, both the 'math' and the 'regression' la

Re: regression

2003-07-17 Thread Alfredo Braunstein
Alfredo Braunstein wrote: >> I don't feel guilty right now... > > I didn't suggest that you should... Are you developing a pavlovian reaction to the word 'regression'? SCNR Hiper-double-mega-:^) Alfredo

Re: regression

2003-07-17 Thread Alfredo Braunstein
Andre Poenitz wrote: > On Thu, Jul 17, 2003 at 02:17:32PM +0200, Alfredo Braunstein wrote: >> inserting a matrix (or other symbol) from the math-panel inside an >> equation doesn't work. (it works if starting outside any equation). > > Mainly because the sub-panels do not appear? Exactly > I d

Re: regression

2003-07-17 Thread Andre Poenitz
On Thu, Jul 17, 2003 at 02:17:32PM +0200, Alfredo Braunstein wrote: > inserting a matrix (or other symbol) from the math-panel inside an equation > doesn't work. (it works if starting outside any equation). Mainly because the sub-panels do not appear? I don't feel guilty right now... Andre' --

Re: New note inset

2003-07-17 Thread Juergen Spitzmueller
Am Donnerstag, 17. Juli 2003 14:17 schrieb Michael Schmitt: > Hello, Hi, > what is the difference between a "note" and a "comment"? I can see no > difference in the latex output and on screen only the label changes. Note is LyX internal only (does not appear in LaTeX output) Comment is a LaTeX e

Re: New note inset

2003-07-17 Thread Angus Leeming
Michael Schmitt wrote: > Hello, > > what is the difference between a "note" and a "comment"? I can see no > difference in the latex output and on screen only the label changes. Look at the latex file itself, not at the dvi. Nothing at all is output from the note, but the comment's contents are

regression

2003-07-17 Thread Alfredo Braunstein
inserting a matrix (or other symbol) from the math-panel inside an equation doesn't work. (it works if starting outside any equation). Regards, Alfredo

New note inset

2003-07-17 Thread Michael Schmitt
Hello, what is the difference between a "note" and a "comment"? I can see no difference in the latex output and on screen only the label changes. Can we rename "note" to "annotation" in the "insert" menu? There's a small inconsistency in the sense that the note dialog is called "Annotation Set

[patch]

2003-07-17 Thread Andre Poenitz
This needs a bit of testing. Idea is obviously to call partialRebreak less often and remove stuff from updateLocal() Andre' -- Those who desire to give up Freedom in order to gain Security, will not have, nor do they deserve, either one. (T. Jefferson or B. Franklin or both...) Index: inse

Re: [patch]

2003-07-17 Thread Andre Poenitz
On Thu, Jul 17, 2003 at 10:36:29AM +, Angus Leeming wrote: > Andre Poenitz wrote: > > > +MetricsBase::MetricsBase(BufferView * b, LyXFont const & f) > > +: bv(b), font(f), style(LM_ST_TEXT), fontname("mathnormal"), > > + restrictwidth(false), textwidth(0) > > +{} > > Can you

Re: [patch]

2003-07-17 Thread Angus Leeming
Andre Poenitz wrote: > +MetricsBase::MetricsBase(BufferView * b, LyXFont const & f) > +: bv(b), font(f), style(LM_ST_TEXT), fontname("mathnormal"), > + restrictwidth(false), textwidth(0) > +{} Can you explain why the fontname defaults to "mathnormal"? -- Angus

Re: [patch] update (3)

2003-07-17 Thread Angus Leeming
Andre Poenitz wrote: > Oh, the 'test this now' requests usually contain more or less explicit > words towards John or Lars or someone unsuspecting like Angus to stop > fiddling with unimportant pet projects ;-) ;-) -- Angus

[patch] remove unneeded InsetText::old_max_width member

2003-07-17 Thread Andre Poenitz
Index: insets/insettext.C === RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/insets/insettext.C,v retrieving revision 1.434 diff -u -p -r1.434 insettext.C --- insets/insettext.C 17 Jul 2003 07:43:55 - 1.434 +++ insets/insette

[patch] simplify InsetTabular::calculate_dimensions_of_cells a bit

2003-07-17 Thread Andre Poenitz
Index: insets/insettabular.C === RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/insets/insettabular.C,v retrieving revision 1.301 diff -u -p -r1.301 insettabular.C --- insets/insettabular.C 17 Jul 2003 09:10:16 - 1.301 +

Re: Chemnitz

2003-07-17 Thread Andre Poenitz
On Thu, Jul 17, 2003 at 02:03:57AM -0300, Garst R. Reese wrote: > This is just a note to wish all attendees the best of beer. Since > Chemnitz seems to be as difficult to get to as Prince Edward Island, No, it's pretty easy actually. You get born 25km away and move there when you're 14. > I might

Re: [patch] update (3)

2003-07-17 Thread Andre Poenitz
On Thu, Jul 17, 2003 at 10:39:00AM +0200, Alfredo Braunstein wrote: > Andre Poenitz wrote: > > > From time to time I'll explicitly shout 'test this now' (like yesterday > > for update 2 - which was crucial...). This is the critical stuff that > > needs real testing (and the nod...) > > Your word

Re: [patch] update (3)

2003-07-17 Thread Alfredo Braunstein
Andre Poenitz wrote: > From time to time I'll explicitly shout 'test this now' (like yesterday > for update 2 - which was crucial...). This is the critical stuff that > needs real testing (and the nod...) Your wording made me though that this was one of these times. Sorry for the noise. Regards

Re: [patch] update (3)

2003-07-17 Thread Andre Poenitz
On Thu, Jul 17, 2003 at 10:25:52AM +0200, Alfredo Braunstein wrote: > Can you repost this? It doesn't apply cleanly (have you already commited > part of it?). It's already in. When doing simple things I try to keep patches small and self-contained and post them here for information. Would be nice

Re: [patch] update (3)

2003-07-17 Thread Alfredo Braunstein
Andre Poenitz wrote: > > This (1.diff) rips out Inset::update(). Can you repost this? It doesn't apply cleanly (have you already commited part of it?). Regards, Alfredo

[patch]

2003-07-17 Thread Andre Poenitz
Reduce number of calls to TabularInset::metrics Index: metricsinfo.C === RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/metricsinfo.C,v retrieving revision 1.2 diff -u -p -r1.2 metricsinfo.C --- metricsinfo.C 28 May 2003 13:22:

Re: [patch] move some functions out of converter/format

2003-07-17 Thread Andre Poenitz
On Thu, Jul 17, 2003 at 10:10:57AM +0200, Alfredo Braunstein wrote: > How about this? > [...] > } > + > + > + > + > +string const BufferParams::paperSizeName() const Four empty lines look a bit excessive ;-) Rest looks ok. Andre' -- Those who desire to give up Freedom in order to gain Securi

Re: [patch] move some functions out of converter/format

2003-07-17 Thread Alfredo Braunstein
Andre Poenitz wrote: >> Yes, but don't kill the messenger ;^) > > I won't. That's what the 'I'd think so' was good for... I want to remark that I was joking, and I really apreciate your comments (I think that we are in a state that, if someone reads and understand a piece of code, it's a pitty i

[patch] update (4)

2003-07-17 Thread Andre Poenitz
in_update is unneeded. -- Those who desire to give up Freedom in order to gain Security, will not have, nor do they deserve, either one. (T. Jefferson or B. Franklin or both...) Index: rowpainter.C === RCS file: /usr/local/lyx/c

[patch] update (3)

2003-07-17 Thread Andre Poenitz
This (1.diff) rips out Inset::update(). I guess it is killing time now - everybody invited... There should be a few parameters, variables and lines of code that were only there to make Inset::update() happy. These could go... For starters I attach the relevant parts of the last two patches (3.di

Re: [patch] move some functions out of converter/format

2003-07-17 Thread Andre Poenitz
On Thu, Jul 17, 2003 at 09:16:28AM +0200, Alfredo Braunstein wrote: > Andre Poenitz wrote: > > >> +string const papersize(Buffer const * buffer) > >> +{ > > > > Shouldn't a BufferParams const & suffice? > > Yes, but don't kill the messenger ;^) I won't. That's what the 'I'd think so' was good f

Re: [patch] move some functions out of converter/format

2003-07-17 Thread Alfredo Braunstein
Andre Poenitz wrote: >> +string const papersize(Buffer const * buffer) >> +{ > > Shouldn't a BufferParams const & suffice? Yes, but don't kill the messenger ;^) >> +string const dvips_options(Buffer const * buffer) >> +{ > > Same here. > > Hm.. and as bufferparams.h uses string anyway, this

Re: [patch] move some functions out of converter/format

2003-07-17 Thread Andre Poenitz
On Thu, Jul 17, 2003 at 09:02:50AM +0200, Alfredo Braunstein wrote: > These are not related to converter/format and are reused. > > Ok to apply? I'd think so. > +string const papersize(Buffer const * buffer) > +{ Shouldn't a BufferParams const & suffice? > +string const dvips_options(Buffer co

[patch] move some functions out of converter/format

2003-07-17 Thread Alfredo Braunstein
These are not related to converter/format and are reused. Ok to apply? Index: ChangeLog === RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/ChangeLog,v retrieving revision 1.1421 diff -u -p -u -r1.1421 ChangeLog --- ChangeLog 17 Ju