On Thu, Jul 17, 2003 at 04:23:53PM +0000, Angus Leeming wrote:
>         case LFUN_DIALOG_SHOW:
> -               if (argument == "mathpanel")
> +//             if (argument == "mathpanel")
>                         result = UNDISPATCHED;
>                 break;
>         ...
>  }
> 
> I think that the original intention was to prevent things like the citation 
> dialog from being opened when the cursor was in the math inset, but...
> 
> Actually, one could argue that things like the "mathmatrix" dialog are an 
> implementation detail of the frontend and a request to open them shouldn't 
> be dispatched through the kernel at all.
> 
> Shall I just commit the fix above?

Remove the 'if...' line entirely and re-indent the second.

Or even better: remove the  case  altogether. default return
UNDISPATCHED.

Andre'

-- 
Those who desire to give up Freedom in order to gain Security, will not have,
nor do they deserve, either one.     (T. Jefferson or B. Franklin or both...)

Reply via email to