Re: [lxc-devel] [Lxc-users] regular lxc development call?

2010-12-13 Thread Stéphane Graber
the office around 10am central (9am eastern). I'm usually around from 9am eastern to 11:30am and 12:30pm to 5:30pm. Monday being usually quite busy so would like to avoid if possible :) I guess it might be useful to have a list somewhere (wiki ?) of people who'd like to attend with availab

Re: [lxc-devel] Any ETA on the next release?

2011-02-03 Thread Stéphane Graber
side of SF to avoid the issue. -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: This is a digitally signed message part -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value

Re: [lxc-devel] Status of usability of lxc

2011-04-11 Thread Stéphane Graber
eboot your host :) There are some tricks that can be used to limit that issue but LXC will need proper isolation of /proc /sys (and others) before we can even think of giving root access to containers. -- Stéphane Graber Ubuntu developer http://www.ubuntu.com -

[lxc-devel] [PATCH 0/2] Template update for Oneiric and armel

2011-05-24 Thread Stéphane Graber
Some small template changes to add Oneiric and fix armel support. Stéphane Graber (2): Convert all Debian (and derivative) templates from using 'arch' to using 'dpkg --print-architecture' as debootstrap does Add initial oneiric template .gitignore|

[lxc-devel] [PATCH 1/2] Convert all Debian (and derivative) templates from using 'arch' to using 'dpkg --print-architecture' as debootstrap does

2011-05-24 Thread Stéphane Graber
--- templates/lxc-debian.in |9 + templates/lxc-lenny.in|9 + templates/lxc-lucid.in|9 + templates/lxc-maverick.in |9 + templates/lxc-natty.in|9 + 5 files changed, 5 insertions(+), 40 deletions(-) diff --git a/templates/

[lxc-devel] [PATCH 2/2] Add initial oneiric template

2011-05-24 Thread Stéphane Graber
--- .gitignore |1 + configure.ac |1 + templates/Makefile.am|1 + templates/lxc-oneiric.in | 285 ++ 4 files changed, 288 insertions(+), 0 deletions(-) create mode 100644 templates/lxc-oneiric.in diff --git a

[lxc-devel] [PATCH] Ubuntu template: Allow mknod (fixing udev upgrades) and drop mac_override and mac_admin from lxc.cap.drop as apparmor has/will have support for namespaces

2011-11-02 Thread Stéphane Graber
--- templates/lxc-ubuntu.in |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/templates/lxc-ubuntu.in b/templates/lxc-ubuntu.in index 4f44b03..2be8680 100644 --- a/templates/lxc-ubuntu.in +++ b/templates/lxc-ubuntu.in @@ -179,9 +179,12 @@ lxc.pts = 1024 lxc.rootfs = $ro

[lxc-devel] [PATCH] Ubuntu template: Add precise to the list of Ubuntu releases.

2011-11-10 Thread Stéphane Graber
--- templates/lxc-ubuntu.in |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/templates/lxc-ubuntu.in b/templates/lxc-ubuntu.in index 2be8680..d116f4c 100644 --- a/templates/lxc-ubuntu.in +++ b/templates/lxc-ubuntu.in @@ -382,7 +382,7 @@ usage() { cat < --clean [-a|

Re: [lxc-devel] security of mounting sysfs in LXC container?

2012-05-15 Thread Stéphane Graber
ns /proc/sysrq-trigger which lets a container reboot or shutdown the host and for this one you don't quite have the option not to mount it. The real solution to the problem, as stated by Serge is to use the user namespaces which we hope will land in the upstream kernel very soon. Unt

Re: [lxc-devel] [PATCH] Add lxc-net tool

2012-05-17 Thread Stéphane Graber
if (ret) + return > ret; > + + execvp(my_args.argv[0], my_args.argv); +SYSERROR("failed to > exec '%s'", my_args.argv[0]); + return -1; +} We recently discussed during a session at the Ubuntu Developer Summit that we should instead update lx

Re: [lxc-devel] [PATCH] Add lxc-net tool

2012-05-17 Thread Stéphane Graber
/ > > Thanks, I didn't know that current versions of iproute2's ip could do > that (the version I have installed actually can't, I'll have to > upgrade). > > Regards, > Christian Thanks for your work. -- Stéphane Graber

[lxc-devel] [PATCH] Always close all inherited fds and drop --close-all-fds

2012-05-24 Thread Stéphane Graber
an fd, so I think it makes sense to do away with that option and just make it the default. Stéphane Graber (1): Remove --close-all-fds (-C) from lxc-start and always close any inherited fd. doc/lxc-start.sgml.in | 15 --- src/lxc/arguments.h |3 --- src/lxc/conf.h

[lxc-devel] [PATCH] Remove --close-all-fds (-C) from lxc-start and always close any inherited fd.

2012-05-24 Thread Stéphane Graber
This changes the default behaviour from complaining about it but not closing the inherited fds to logging an INFO entry and closing them automatically. That's the same as always calling lxc-start with --close-all-fds. Signed-off-by: Stéphane Graber Cc: Daniel Lezcano Cc: Serge Hallyn ---

Re: [lxc-devel] [PATCH 1/1] lxc-ubuntu.in: drop duplicate code

2012-05-24 Thread Stéphane Graber
good. Acked-by: Stéphane Graber > --- > templates/lxc-ubuntu.in | 28 > 1 file changed, 28 deletions(-) > > diff --git a/templates/lxc-ubuntu.in b/templates/lxc-ubuntu.in > index 3e84e74..822554f 100644 > --- a/templates/lxc-ubuntu.in > +++

[lxc-devel] Getting some hooks into the container configuration

2012-05-24 Thread Stéphane Graber
ght know (where they wouldn't work as "mount" hooks). These would be configurable in the container as: lxc.hook. = Does that sound good to everyone? Are there other hooks we should make sure we implement? Anything else I missed? Thanks -- Stéphane Graber Ubuntu developer htt

Re: [lxc-devel] Getting some hooks into the container configuration

2012-05-25 Thread Stéphane Graber
nal hook. For example, a failure in the "start" hook will cause the container to be shutdown and unmounted but without calling the stop, umount or post-stop hooks. (I'm mostly looking at http://download.openvz.org/doc/OpenVZ-Users-Guide.pdf in the "OpenVZ Action Scripts"

Re: [lxc-devel] Shutting down containers properly

2012-05-25 Thread Stéphane Graber
Christian I only very quickly read through your e-mail, apologize if what I'm saying below is already covered in your e-mail. Have you looked at the lxc-shutdown script we have in Ubuntu and the integration we have with upstart? lxc-shutdown sends two different signals: reboot => SIGIN

Re: [lxc-devel] Shutting down containers properly

2012-05-25 Thread Stéphane Graber
plemented > in lxc-stop and that it should be a bit more generic with the > possibility that the user can configure different methods in the config > file. I remember Serge and I discussed that at some point and ended up making it a separate tool. I can't remember the exact ratio

Re: [lxc-devel] Please make "-f" mandatory in lxc-create

2012-05-28 Thread Stéphane Graber
uot;lxc-create -n foo > foo.cfg" instead of "lxc-create -n foo -f foo.cfg". At least in Ubuntu -f isn't mandatory because calling lxc-create without it will simply default to a system wide configuration in /etc/lxc/lxc.conf. -- Stéphane Graber Ubuntu developer http://www.

Re: [lxc-devel] Please make "-f" mandatory in lxc-create

2012-05-28 Thread Stéphane Graber
On 05/28/2012 06:29 PM, richard -rw- weinberger wrote: > On Tue, May 29, 2012 at 12:06 AM, Stéphane Graber wrote: >> At least in Ubuntu -f isn't mandatory because calling lxc-create without >> it will simply default to a system wide configuration in /etc/lxc/lxc.conf. >

Re: [lxc-devel] Does lxc support unionfs ?

2012-06-05 Thread Stéphane Graber
th all changes stored on tmpfs using overlayfs/aufs. -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature -- Live Security Virtual Conference Exclusive live event will

Re: [lxc-devel] liblxc api

2012-06-09 Thread Stéphane Graber
nd will have proper ABI versioning (as should be expected from any public library). I'm currently testing it using Serge's branch and I'm already working on the python binding using the not yet stable liblxc but I'm expecting both the python module API and liblxc ABI to be stab

Re: [lxc-devel] lxc-unshare default behavior

2012-06-11 Thread Stéphane Graber
n error if (argv[optind]==NULL) > before > > args = &argv[optind]; > > Objections? > > -serge Sounds good to me. +1 -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature

Re: [lxc-devel] Closing all fds by default

2012-06-12 Thread Stéphane Graber
stablish a communication channel between the host and a > container. Thoughts? > > V/r, > Daniel Well, the easiest way to achieve that with LXC is simply to bind mount a socket into the container. Just create a socket outside of the container, add it to the container's fstab and mak

[lxc-devel] Test packages of liblxc and python3-lxc for Ubuntu 12.04 and 12.10

2012-06-19 Thread Stéphane Graber
it over the next few days ;) Bugs, feedback and suggestion of missing features/calls is most welcome. -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature -- L

Re: [lxc-devel] liblxc api

2012-06-21 Thread Stéphane Graber
On 06/21/2012 11:37 AM, Diego Elio Pettenò wrote: > Il 09/06/2012 19:36, Stéphane Graber ha scritto: >> Yes, the new version of liblxc will be public and will have proper ABI >> versioning (as should be expected from any public library). > > Since you're working on the

Re: [lxc-devel] Usability: lxc-ls

2012-06-29 Thread Stéphane Graber
ll be expected to provide the library and python module. From that point on, there won't be any reason that the tools provided in that same git tree can't use either the new C api or the python binding. -- Stéph

Re: [lxc-devel] [PATCH 1/1] Fix lxc's handling of CAP_LAST_CAP

2012-06-29 Thread Stéphane Graber
TIVE, 1, &cap, flag); > if (ret) { > The idea of the change looks good, though you're defining a new lastcap variable that you then set but never actually seem to use as you're instead using cap-1 in the INFO() call. Am I just missing some context or is that indee

Re: [lxc-devel] [PATCH 1/1] Fix lxc's handling of CAP_LAST_CAP (v2)

2012-06-29 Thread Stéphane Graber
+ goto out; > + } > } > > ret = cap_set_flag(caps, CAP_EFFECTIVE, 1, &cap, flag); > Acked-by: Stéphane Graber -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description

Re: [lxc-devel] set shmmax for container in lxc-execute

2012-07-05 Thread Stéphane Graber
eny @{PROC}/sys/kernel/** wklx, + deny @{PROC}/sys/kernel/[^s][^h][^m]* wklx, + deny @{PROC}/sys/kernel/*/** wklx, # deny writes in /sys except for /sys/fs/cgroup, also allow # fusectl, securityfs and debugfs to be mounted there (read-only) I'm expecting this fix to land within the

Re: [lxc-devel] set shmmax for container in lxc-execute

2012-07-05 Thread Stéphane Graber
ners. RedHat uses SELinux but lxc currently doesn't have any support for it, so it's unlikely to be the problem. Maybe something is dropping some capabilities that are preventing you from changing these limits? -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc D

[lxc-devel] lxc staging branch on github

2012-09-07 Thread Stéphane Graber
github account so I can add you to the project admins. -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature -- Live Security Virtual Conference Exclusive live ev

Re: [lxc-devel] [PATCH 3/3] lxc-rpm-build

2012-09-10 Thread Stéphane Graber
Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/5012226

Re: [lxc-devel] [PATCH 2/3] lxc-pkgconfig-dir

2012-09-10 Thread Stéphane Graber
> pcdata_DATA = lxc.pc > > ChangeLog:: What's the reason for that change? I believe both locations are allowed in pkg-config and at least on Debian systems, /usr/share/pkgconfig is more popular, so unless there's a very good reason for that change, I'm against it.

Re: [lxc-devel] [PATCH 2/3] lxc-pkgconfig-dir

2012-09-10 Thread Stéphane Graber
On 12-09-10 10:46 AM, Daniel P. Berrange wrote: > On Mon, Sep 10, 2012 at 10:39:39AM -0400, Stéphane Graber wrote: >> On 12-09-10 10:28 AM, Dwight Engen wrote: >>> Put pkg-config .pc file in libdir. >>> >>> Signed-off-by: Dwight Engen >>> --- >&

Re: [lxc-devel] [PATCH 2/3] lxc-pkgconfig-dir

2012-09-10 Thread Stéphane Graber
On 12-09-10 10:59 AM, Stéphane Graber wrote: > On 12-09-10 10:46 AM, Daniel P. Berrange wrote: >> On Mon, Sep 10, 2012 at 10:39:39AM -0400, Stéphane Graber wrote: >>> On 12-09-10 10:28 AM, Dwight Engen wrote: >>>> Put pkg-config .pc file in libdir. >>

Re: [lxc-devel] [PATCH 1/3] lxc-doc-synopsis-args

2012-09-10 Thread Stéphane Graber
nc., 59 Temple Place, Suite 330, Boston, MA > 02111-1307 USA > > > > - lxc-stop -n name > - > + lxc-stop > + -n name > > > > diff --git a/doc/lxc-unfreeze.sgml.in b/doc/lxc-unfreeze.sgml.in > index bb00d85..c4c545e 10

Re: [lxc-devel] [PATCH 3/3] lxc-rpm-build

2012-09-10 Thread Stéphane Graber
On 12-09-10 01:26 PM, Dwight Engen wrote: > On Mon, 10 Sep 2012 10:36:17 -0400 > Stéphane Graber wrote: > >> On 12-09-10 10:28 AM, Dwight Engen wrote: >>> Expand variables to get correct paths in man pages and fix building >>> of rpm by non-root user. Include

Re: [lxc-devel] [PATCH 2/2] fix compile without apparmor (against git staging)

2012-09-10 Thread Stéphane Graber
*fout, struct lxc_conf *c) > case PER_LINUX: fprintf(fout, "lxc.arch = x86_64\n"); break; > default: break; > } > +#if HAVE_APPARMOR > if (c->aa_profile) > fprintf(fout, "lxc.aa_profile = %s\n", c->aa_profile); > +#endif

Re: [lxc-devel] [PATCH 1/2] fix gcc error: typedef redefinition (against git staging)

2012-09-10 Thread Stéphane Graber
config_personality }, Reviewed by Serge and pushed to staging branch. Thanks. -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature -- L

Re: [lxc-devel] [PATCH 1/3] lxc-doc-synopsis-args

2012-09-10 Thread Stéphane Graber
On 12-09-10 04:49 PM, Dwight Engen wrote: > On Mon, 10 Sep 2012 11:10:24 -0400 > Stéphane Graber wrote: > > [...] >> >> I briefly tried applying this to the staging branch but it's failing >> because of some of the other changes we have in there (lxc-att

Re: [lxc-devel] lxc staging branch on github

2012-09-10 Thread Stéphane Graber
On 12-09-07 04:47 PM, Stéphane Graber wrote: > Hello everyone, > > As you probably noticed Serge and I have been trying to keep up with all > the changes going to the lxc-users and lxc-devel mailing lists with some > varying success. > > For quite a while now Serge h

Re: [lxc-devel] [PATCH 3/3] lxc-rpm-build

2012-09-11 Thread Stéphane Graber
On 12-09-11 02:30 PM, Dwight Engen wrote: > On Mon, 10 Sep 2012 13:53:50 -0400 > Stéphane Graber wrote: > > [...] >>> The reason I changed them to expand was so the docs would be right >>> (they had SUBST paths with ${var} still in them) but obviously I >>>

Re: [lxc-devel] [PATCH 3/3] lxc-rpm-build

2012-09-11 Thread Stéphane Graber
On 12-09-11 05:06 PM, Dwight Engen wrote: > On Tue, 11 Sep 2012 14:30:22 -0400 > Dwight Engen wrote: > >> On Mon, 10 Sep 2012 13:53:50 -0400 >> Stéphane Graber wrote: >> >> [...] >>>> The reason I changed them to expand was so the docs would be right

Re: [lxc-devel] [PATCH] busybox: for all lib dirs create mounts only if directories exist

2012-09-12 Thread Stéphane Graber
in a minute with a minor change. The current implementation seems to use absolute paths as the target (/var/lib/lxc//rootfs/) which isn't recommended as it's making cloning a container much harder. Instead, lxc now supports relative mounts, for example: lxc.mount.entry=/usr/lib usr/li

Re: [lxc-devel] [PATCH] Add mechanism for container to notify host about end of boot

2012-09-13 Thread Stéphane Graber
b/src/lxc/start.c >> @@ -128,6 +128,7 @@ int signalfd(int fd, const sigset_t *mask, int flags) >> #include "namespace.h" >> #include "apparmor.h" >> #include "lxcseccomp.h" >> +#include "notification.h" >> >> lxc_log_define(l

Re: [lxc-devel] [PATCH] Add mechanism for container to notify host about end of boot

2012-09-13 Thread Stéphane Graber
gt; extensible (binary?) protocol, which currently also only allows one to > change the status. But because it's extensible, the interface would > already be there. > > Christian -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital

Re: [lxc-devel] [PATCH] Add mechanism for container to notify host about end of boot

2012-09-19 Thread Stéphane Graber
sible but very simple protocol, line-based, currently, only > 'status NEWSTATUS' is supported, where NEWSTATUS may be either > RUNNING or STOPPING > - now returns either 'OK' or 'ERR message' to the caller > > Regards, > Christian --

Re: [lxc-devel] [PATCH] Add mechanism for container to notify host about end of boot

2012-09-19 Thread Stéphane Graber
s not an actual device node, but it's the only directory that lxc already requires all distros not to mess with (or we wouldn't have working console, tty, ...). -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature

Re: [lxc-devel] [PATCH 2/2] allow short -h and -n options to lxc-ps

2012-09-19 Thread Stéphane Graber
help; exit 1;; > - --name) > + -n|--name) > containers=$2; list_container_processes=1; shift 2;; > --lxc) > list_container_processes=1; shift;; > -- Stéphane Graber Ubuntu developer http:/

Re: [lxc-devel] [PATCH] [trivial] lxc-ls: Scan cgroup mount points from fstype and not device

2012-09-24 Thread Stéphane Graber
mountpoint=$(grep -E "^[^ ]+ [^ ]+ cgroup ([^ > ]+,)?$subsystems(,[^ ]+)? " /proc/self/mounts | cut -d ' ' -f 2) > if [ -z "$mountpoint" ]; then continue; fi > > # Return the absolute path to the containers' parent

Re: [lxc-devel] [PATCH] [trivial] lxc-ls: Scan cgroup mount points from fstype and not device

2012-09-24 Thread Stéphane Graber
On 12-09-24 09:25 AM, Stéphane Graber wrote: > On 12-09-24 05:21 AM, Christian Seiler wrote: >> lxc-ls --active now scans mount points that have the 'cgroup' filesystem >> type and not the 'cgroup' device name (which is ignored anyway and may be >> anythin

Re: [lxc-devel] [PATCH] fix minor spelling error

2012-09-26 Thread Stéphane Graber
Specify the namespaces to attach to, as a pipe-separated list, > e.g. NETWORK|IPC. Allowed values are > MOUNT, PID, > UTSNAME, IPC, > Looks good, applied to staging. Thanks -- Stéphane Graber Ubuntu developer http://www.ubu

Re: [lxc-devel] [PATCH] if the rootfs is a btrfs subvolume, delete it instead of rm -rf

2012-09-26 Thread Stéphane Graber
+btrfs subvolume list "$rootdev" >/dev/null 2>&1; then > + btrfs subvolume delete "$rootdev" > + else > + # In case rootfs is not under $lxc_path/$lxc_name, > remove it > +

Re: [lxc-devel] [PATCH] handle clone of btrfs snapshots

2012-09-26 Thread Stéphane Graber
fs" >> "$lxc_path/$lxc_new/config" > - > else > if [ $snapshot = "yes" ]; then > echo "$(basename $0): cannot snapshot a directory" >&2 > @@ -252,8 +251,8 @@ else > lxc-freeze -n $lxc_orig > frozen=1 >

Re: [lxc-devel] [PATCH] handle clone of btrfs snapshots

2012-09-26 Thread Stéphane Graber
reeze -n $lxc_orig >> frozen=1 >> fi >> -mkdir -p $lxc_path/$lxc_new/rootfs/ >> -rsync -ax $lxc_path/$lxc_orig/rootfs/ $lxc_path/$lxc_new/rootfs/ >> +mkdir -p $rootfs/ >> +rsync -ax $oldroot/ $rootfs/ >> echo "lxc.rootfs = $rootfs&

Re: [lxc-devel] [PATCH] Add Oracle Linux template

2012-10-01 Thread Stéphane Graber
-o hp:n:t:r: -l help,path:,name:,template:,rootfs: -- "$@") > +if [ $? -ne 0 ]; then > +usage $(basename $0) > +exit 1 > +fi > + > +eval set -- "$options" > +while true > +do > +case "$1" in > + -p|--path) cfg_dir=$

Re: [lxc-devel] [PATCH] display warning when yum missing in fedora template

2012-10-05 Thread Stéphane Graber
d_pkgs="yum $needed_pkgs" > -exit 1 > fi > > type curl >/dev/null 2>&1 Looks good, applied to staging. -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature -

[lxc-devel] Pull request bugfix branch

2012-10-31 Thread Stéphane Graber
ntu: fix printing of default user templates: mount devtmpfs in ubuntu containers revert devtmpfs in ubuntu templates replace HOOK define with proper code. Stuart Yoder (1): busybox: for all lib dirs create mounts only if directories exist Stéphane Graber (17): Fix lxc-u

Re: [lxc-devel] [PATCH] Reinstate README file in rootfs directory

2012-11-06 Thread Stéphane Graber
XCROOTFSMOUNT@ >>> >>> -README_DATA= >>> +README_DATA=README >> >> I did not applied it because it has already been fixed by Stephan. > > Hi, indeed this is not an issue in the sourceforge.net git, but is still > a problem on the github stag

Re: [lxc-devel] [PATCH 3/3] lxc: include sched.h to have a declaration of clone().

2012-11-11 Thread Stéphane Graber
c3a..1f7684e 100644 > --- a/src/lxc/namespace.c > +++ b/src/lxc/namespace.c > @@ -30,6 +30,7 @@ > #include > #include > #include > +#include > > #include "namespace.h" > #include "log.h" This was proposed and discarded already a few week

[lxc-devel] staging branch has been rebased

2012-11-12 Thread Stéphane Graber
ter branch. I'm expecting automated builds for Ubuntu to start again a bit later today. -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature -- Monito

Re: [lxc-devel] [PATCH 2/3] build: make sure to expand all variables that are substituted.

2012-11-12 Thread Stéphane Graber
']) > > -AC_SUBST(LXCINITDIR, ['${libexecdir}']) > +AS_AC_EXPAND(LXCINITDIR, ['${libexecdir}']) > > AC_CHECK_HEADERS([linux/unistd.h linux/netlink.h linux/genetlink.h], > [], > Applied to s

Re: [lxc-devel] [PATCH] Reinstate README file in rootfs directory

2012-11-12 Thread Stéphane Graber
Makefile.am > @@ -1,3 +1,3 @@ > READMEdir=@LXCROOTFSMOUNT@ > > -README_DATA= > +README_DATA=README > Applied to staging. -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature

Re: [lxc-devel] [GIT] lxc branch, master, updated. 4aa7ac35696b87867b1e85410a80527696ff4d64

2012-11-13 Thread Stéphane Graber
0 > > Signed-off-by: Daniel Lezcano Hi Daniel, Frederic Crozat on IRC pointed out that there's no tag for the 0.8.0 release in the master git branch. Can you add it? -- Stéphane Graber Ubuntu developer

Re: [lxc-devel] [PATCH] Fix package name needed for building docs with RPM

2012-11-14 Thread Stéphane Graber
On 11/14/2012 10:44 AM, Dwight Engen wrote: > Tested on Oracle Linux 6 and Fedora 17 > > Signed-off-by: Dwight Engen Acked-by: Stéphane Graber And applied to staging branch. > --- > lxc.spec.in |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > di

Re: [lxc-devel] [PATCH] ensure btrfs subvolume is removed when container creating fails

2012-11-14 Thread Stéphane Graber
eason. >> >> Attached patch fixes this issue. > > Acked-by: Serge E. Hallyn Acked-by: Stéphane Graber And applied to staging branch. >> -- >> Frederic Crozat >> SUSE > >> >From 028d1b3eb110229113dc99f3587fac1f9fca9b0e Mon Sep 17 00:00:00 2001

Re: [lxc-devel] using posix shell instead of bash

2012-11-14 Thread Stéphane Graber
t into apps, servers, databases, vmware, > SAP, cloud infrastructure, etc. Download 30-day Free Trial. > Pricing starts from $795 for 25 servers or applications! > http://p.sf.net/sfu/zoho_dev2dev_nov > > > > ___ > Lxc-devel mailing

Re: [lxc-devel] [PATCH v2] lxc-start: add option -p, --pidfile=FILE

2012-11-15 Thread Stéphane Graber
Acked-by: Serge E. Hallyn Acked-by: Stéphane Graber Applied to staging with an extra commit changing the error message to Serge's suggested one. > Only one comment below > >> --- >> Changes v1 -> v2: >> - allow use --pidfile without --daemon >> - up

Re: [lxc-devel] [PATCH] lxc-create: use posix shell instead of bash

2012-11-21 Thread Stéphane Graber
t;> - make sure condition expands to empty string if variable is empty >> > > looks good to me, thanks. > > Acked-by: Serge E. Hallyn Acked-by: Stéphane Graber And pushed to staging. Thanks! > >> Signed-off-by: Natanael Copa >> --- >> I have teste

[lxc-devel] [PATCH] Rewrite lxc-ls in python

2012-11-21 Thread Stéphane Graber
interface with the following fields: - name - state - ipv4 - ipv6 - pid of init Signed-off-by: Stéphane Graber --- .gitignore | 1 - configure.ac| 1 - doc/lxc-ls.sgml.in | 150 ++--- src/lxc/Makefile.am | 2 +- src/lxc/lxc-ls

Re: [lxc-devel] [PATCH] Rewrite lxc-ls in python

2012-11-21 Thread Stéphane Graber
On 11/21/2012 06:04 PM, Stéphane Graber wrote: > This rewrite is mostly compatible with the shell version. > --active and -1 still work and behave as they used to. > > This adds --running, --stopped and --frozen as state filters. > > A new "fancy" view is also i

Re: [lxc-devel] [PATCH] lxc-create: fix passing over first argument to template script

2012-11-22 Thread Stéphane Graber
er# lxc-create -t ubuntu -n p1 -- --arch i386 /usr/bin/lxc-create: 87: local: not in a function It looks like "local" isn't posix shell according to a bit of googling. That's when running under Ubuntu and Debian's default shel

Re: [lxc-devel] [PATCH] Rewrite lxc-ls in python

2012-11-22 Thread Stéphane Graber
On 11/22/2012 08:39 AM, Natanael Copa wrote: > On Wed, 21 Nov 2012 18:04:03 -0500 > Stéphane Graber wrote: > >> This rewrite is mostly compatible with the shell version. >> --active and -1 still work and behave as they used to. > > Does this mean that python will

[lxc-devel] [PATCH 0/2] Adding devices to a running container

2012-11-22 Thread Stéphane Graber
t and will add the required entry in the cgroup whitelist. Stéphane Graber (2): python: Add add_device() function python: Add new lxc-device tool src/lxc/Makefile.am| 1 + src/lxc/lxc-device | 59 src/python-lxc/lxc/__init__.py

[lxc-devel] [PATCH 2/2] python: Add new lxc-device tool

2012-11-22 Thread Stéphane Graber
Add a new lxc-device tool which uses the new add_device() function of the python API and lets you add a new device node to a running container. Signed-off-by: Stéphane Graber --- src/lxc/Makefile.am | 1 + src/lxc/lxc-device | 59 + 2 files

[lxc-devel] [PATCH 1/2] python: Add add_device() function

2012-11-22 Thread Stéphane Graber
create the entry in the container. Signed-off-by: Stéphane Graber --- src/python-lxc/lxc/__init__.py | 61 ++ 1 file changed, 61 insertions(+) diff --git a/src/python-lxc/lxc/__init__.py b/src/python-lxc/lxc/__init__.py index 4da3d41..c572e10 100644 --- a/src

Re: [lxc-devel] [PATCH 1/2] python: Add add_device() function

2012-11-23 Thread Stéphane Graber
On 11/23/2012 10:39 AM, Serge Hallyn wrote: > Quoting Stéphane Graber (stgra...@ubuntu.com): >> This introduces a new add_devices() call to the python API. >> >> Parameters: >> - path => Mandatory, path to a character or block device on the host >> - destpath

Re: [lxc-devel] [PATCH] lxc-create: do not use 'local'

2012-11-26 Thread Stéphane Graber
On 11/26/2012 06:00 AM, Natanael Copa wrote: > Apparently 'local' is not POSIX. Don't use it. > > Signed-off-by: Natanael Copa Acked-by: Stéphane Graber Applied to staging branch. Thanks. > --- > src/lxc/lxc-create.in | 7 +++ > 1 file changed, 3 insert

Re: [lxc-devel] [PATCH] lxc-create: fix passing over first argument to template script

2012-11-26 Thread Stéphane Graber
;; > --) > - shift > break;; > -?) > usage_err "unknown option '$opt'" > Acked-by: Stéphane Graber Applied to staging branch. Thanks. -- Stéphane Graber Ubunt

Re: [lxc-devel] [PATCH 1/2] python: Add add_device() function

2012-11-26 Thread Stéphane Graber
On 11/23/2012 03:19 PM, Serge Hallyn wrote: > Quoting Stéphane Graber (stgra...@ubuntu.com): >>> The cgroup tweaking should be done using generic code. Maybe it's >>> time to add those to the c api... >> >> Totally agreed, I was actually going to nag y

Re: [lxc-devel] [PATCH] Add lxc.autodev (v2)

2012-11-26 Thread Stéphane Graber
ink of a better name than autodev. > > Changelog: Don't error out if we couldn't mknod a /dev/ttyN. > Changelog: Describe the option in lxc.conf manpage. > > Signed-off-by: Serge Hallyn Acked-by: Stéphane Graber I'll push the fix I highlighted below too. This

[lxc-devel] [PATCH 2/3] python: Use builtin len() function for network interfaces

2012-11-26 Thread Stéphane Graber
Use our own len() function for network interfaces as doing len(container.get_config_item("lxc.network")) will fail when the list is empty. Signed-off-by: Stéphane Graber --- src/python-lxc/lxc/__init__.py | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff -

[lxc-devel] [PATCH 1/3] python: PEP8 compatibility

2012-11-26 Thread Stéphane Graber
The new version of the pep8 command is detecting more indentation mistakes than it used to, this fixes them. Signed-off-by: Stéphane Graber --- src/lxc/lxc-start-ephemeral.in | 81 +++-- src/python-lxc/examples/api_test.py | 20 - src/python-lxc/lxc

[lxc-devel] [PATCH 0/3] Various python fixes

2012-11-26 Thread Stéphane Graber
PEP-8 and other bugfixes for the python code. Stéphane Graber (3): python: PEP8 compatibility python: Use builtin len() function for network interfaces gitignore: Ignore python cache .gitignore | 2 + src/lxc/lxc-start-ephemeral.in | 81

[lxc-devel] [PATCH 3/3] gitignore: Ignore python cache

2012-11-26 Thread Stéphane Graber
Signed-off-by: Stéphane Graber --- .gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore index 398e4fc..76c9533 100644 --- a/.gitignore +++ b/.gitignore @@ -65,6 +65,8 @@ src/lxc/lxc-unshare src/lxc/lxc-version src/lxc/lxc-wait +src/python-lxc/lxc

Re: [lxc-devel] [PATCH] Fix checkconfig to handle kernel memory cgroup name change

2012-11-26 Thread Stéphane Graber
On 11/14/2012 12:03 PM, Dwight Engen wrote: > The kernel config option for the memory cgroup was changed in 3.6 > from CONFIG_CGROUP_MEM_RES_CTLR to CONFIG_MEMCG with commit c255a458. > > Signed-off-by: Dwight Engen Sorry for the delay, I somehow missed that one. Acked-by: Sté

Re: [lxc-devel] [PATCH] Fix fd leak in lxc log

2012-11-26 Thread Stéphane Graber
- > Monitor your physical, virtual and cloud infrastructure from a single > web console. Get in-depth insight into apps, servers, databases, vmware, > SAP, cloud infrastructure, etc. Download 30-day Free Trial. > Pricing starts from $795 for 25 servers or applicatio

Re: [lxc-devel] [PATCH] Fix use of list item memory after free

2012-11-26 Thread Stéphane Graber
= __iterator->next) >> >> +#define lxc_list_for_each_safe(__iterator, __list, __next) \ >> +for (__iterator = (__list)->next, __next = __iterator->next;\ >> + __iterator != __list; \ >>

Re: [lxc-devel] [PATCH] Free allocated configuration memory

2012-11-26 Thread Stéphane Graber
src/lxc/lxccontainer.c b/src/lxc/lxccontainer.c >> index 37f5ed7..ac995a6 100644 >> --- a/src/lxc/lxccontainer.c >> +++ b/src/lxc/lxccontainer.c >> @@ -65,6 +65,10 @@ static void lxc_container_free(struct lxc_container *c) >> free(c->error_string); >>

Re: [lxc-devel] [PATCH] Ensure argv passed by createl to create is NULL terminated

2012-11-26 Thread Stéphane Graber
oud infrastructure, etc. Download 30-day Free Trial. > Pricing starts from $795 for 25 servers or applications! > http://p.sf.net/sfu/zoho_dev2dev_nov > ___ > Lxc-devel mailing list > Lxc-devel@lists.sourceforge.net > https://lists.sourceforge.net/l

Re: [lxc-devel] [PATCH] lxc-info: add option -t, --state-is=STATE to test for a given test

2012-11-26 Thread Stéphane Graber
>> Lxc-devel mailing list >> Lxc-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/lxc-devel > > -

Re: [lxc-devel] [PATCH 1/1] fix lxc-ubuntu-cloud option parsing bugs

2012-11-26 Thread Stéphane Graber
On 11/26/2012 03:08 PM, Serge Hallyn wrote: > The -u shortopt matching --userdata was not specified, and when -L > is found shift should have been by 1 not 2 since there is no optarg. > > Signed-off-by: Serge Hallyn Acked-by: Stéphane Graber Pushed to staging. Thanks > --- &

Re: [lxc-devel] [PATCH v2] lxc-version: use POSIX shell instead of bash

2012-11-27 Thread Stéphane Graber
1bd055a..b6875da 100644 > --- a/src/lxc/lxc-version.in > +++ b/src/lxc/lxc-version.in > @@ -1,3 +1,3 @@ > -#!/bin/bash > +#!/bin/sh > > echo "lxc version: @PACKAGE_VERSION@" > -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: Open

Re: [lxc-devel] [PATCH v2] lxc-checkconfig: use POSIX shell instead of bash

2012-11-27 Thread Stéphane Graber
Misc ---" > echo -n "Veth pair device: " && is_enabled CONFIG_VETH > echo -n "Macvlan: " && is_enabled CONFIG_MACVLAN > echo -n "Vlan: " && is_enabled CONFIG_VLAN_8021Q > -echo -n "File capabilities: " &&a

Re: [lxc-devel] [PATCH] Use autoconf LXCPATH instead of hardcoded LXCDIR

2012-11-27 Thread Stéphane Graber
DIR "/var/lib/lxc" > bool (*is_defined)(struct lxc_container *c); // did > /var/lib/lxc/$name/config exist > const char *(*state)(struct lxc_container *c); > bool (*is_running)(struct lxc_container *c); // true so long as > defined and not stopped &g

Re: [lxc-devel] [PATCH] lxc-setcap: use POSIX shell instead of bash

2012-11-27 Thread Stéphane Graber
On 11/26/2012 04:37 PM, Natanael Copa wrote: > Avoid getopt --longoptions > > Signed-off-by: Natanael Copa Looks reasonable, though I'm not usually using that script so didn't actually test the change. Acked-by: Stéphane Graber And pushed to staging. Thanks. > --- &g

Re: [lxc-devel] [PATCH] lxc-setuid: use POSIX shell instead of bash

2012-11-27 Thread Stéphane Graber
On 11/26/2012 04:39 PM, Natanael Copa wrote: > Avoid getop --longoptions. > > Signed-off-by: Natanael Copa Looks reasonable, though I'm not usually using that script so didn't actually test the change. Acked-by: Stéphane Graber And pushed to staging. Thanks. > --- &g

Re: [lxc-devel] [PATCH] Make config api items const

2012-11-27 Thread Stéphane Graber
e in lxcapi_start and lxcapi_create to match >> that of execv(3). >> >> Signed-off-by: Dwight Engen > > Thanks. > > Acked-by: Serge E. Hallyn And applied to staging. -- Stéphane Graber Ubuntu developer http://www.ubuntu.com s

Re: [lxc-devel] [PATCH] Oracle template: make container also boot under libvirt

2012-11-27 Thread Stéphane Graber
On 11/27/2012 11:07 AM, Dwight Engen wrote: > This allows containers created with lxc-create to also boot under > libvirt/Virtual Machine Monitor > > Signed-off-by: Dwight Engen Acked-by: Stéphane Graber Applied to staging. Thanks! > --- > templates/lx

  1   2   3   4   5   6   7   8   >