On 12-09-13 05:26 PM, Christian Seiler wrote: >> I like the idea but haven't looked at the implementation yet as the >> patch is really quite large. Quickly scanning through I briefly noticed >> that the copyright headers for the new files are wrong (refer to IBM and >> Daniel instead of Christian). > > I just copy&pasted them from the other files, most header files I saw > contained the same copyright. Just tell me what exactly to put there and > then I'll do that for the next version of the patch.
The license is fine (LGPL v2.1+), just drop the IBM part and replace Daniel Lezcano by your name. >> I'm also wondering if we shouldn't try to keep the "protocol" a bit more >> generic to eventually allow the container to send/receive more than just >> its status? > > If we want to have a back-channel, we'd need a socket, which makes just > doing echo RUNNING > /dev/lxc-notify impossible, you'd need a special > program for that. Having the template scripts dump an additional script > or upstart job or systemd unit file or whatever in the container when > creating it seems a lot easier than having to use a special program. Well, talking to a socket is really easy from the command line too: echo status STARTING | nc -U /dev/lxc_socket It's depending on netcat but netcat is part of all distros and even exists in busybox (in a stripped down version). > On the other hand, it wouldn't be too complicated to have two special > files lying around: One for simple status updates using the current text > interface (easily scriptable, not much hassle to get basic status > notification functionality right) and a socket that supports an > extensible (binary?) protocol, which currently also only allows one to > change the status. But because it's extensible, the interface would > already be there. > > Christian -- Stéphane Graber Ubuntu developer http://www.ubuntu.com
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________ Lxc-devel mailing list Lxc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/lxc-devel
